Re: [edk2-devel] [PATCH V2 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-09-01 Thread Gerd Hoffmann
Hi, > So the agreement in first stage is that: > 1. Accept all memory below 4G. Yes. > 2. The PcdLazyAcceptPartialMemorySize is not needed in current stage. Question is whenever we ever need PcdLazyAcceptPartialMemorySize. When accepting all memory below 4G works fast enough (which I think

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 09/01/2022 #cal-reminder

2022-09-01 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* 09/01/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [PATCH v3 2/2] CloudHv/arm: switch PeiMemLib to its own

2022-09-01 Thread Jianyong Wu
As Cloud Hypervisor has its own PeiMemLib, change it in dsc file accordingly. Reviewed-by: Sami Mujawar Signed-off-by: Jianyong Wu --- ArmVirtPkg/ArmVirtCloudHv.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc

[edk2-devel] [PATCH v3 1/2] CloudHv/arm: add PeiMemInfoLib

2022-09-01 Thread Jianyong Wu
Memory layout in CLoud Hypervisor for arm is changed and is different with Qemu, thus we should build its own PeiMemInfoLib. The main change in the memory layout is that normal ram may not contiguous. The top 64M under 4G is reserved for 32bit device. What this patch does: 1. get all of the

[edk2-devel] [PATCH v3 0/2] CloudHv/arm: Add specific mem info lib

2022-09-01 Thread Jianyong Wu
Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory layout for cloud hypervisor is changed, it needs a new meminfo lib. Signed-off-by: Jianyong Wu Jianyong Wu (2): CloudHv/arm: add PeiMemInfoLib CloudHv/arm: switch PeiMemLib to its own ArmVirtPkg/ArmVirtCloudHv.dsc

Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Chiu, Chasel
Patch pushed: https://github.com/tianocore/edk2-platforms/commit/07bcc0be8c1bcfbd88eb254ebd4f674217013dca Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Thursday, September 1, 2022 4:55 PM > To: devel@edk2.groups.io > Cc: Chiu,

Re: [edk2-devel] [PATCH v2 1/2] CloudHv/arm: add PeiMemInfoLib

2022-09-01 Thread Jianyong Wu
Thanks Sami, I will address all the comments in this patch in next version. > -Original Message- > From: Sami Mujawar > Sent: Thursday, September 1, 2022 11:43 PM > To: Jianyong Wu ; devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; Justin He ; nd > > Subject: Re: [PATCH v2 1/2]

Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, September 1, 2022 4:55 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric > Subject: [edk2-platforms: PATCH v2] MinPlatformPkg:

[edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Chiu, Chasel
FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Rename PlatformMultiPhaseLibSample.

2022-09-01 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/ec87181192f013f4f7ff916b2a39ff2c87b079f3 Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, August 31, 2022 11:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star

Re: [edk2-devel] [PATCH V2 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-09-01 Thread Min Xu
On September 1, 2022 11:56 PM, Gerd Hoffmann wrote: > > > Lazy accept page can be controlled in build time like below: > > -D LAZY_ACCEPT_PARTIAL_MEM=512 > > > > The unit is MB. If it is 0 then it means Lazy-accept is turned off. > > > > Lazy-accept is turned off by default in OvmfPkgX64. > >

Re: [edk2-devel] [PATCH V2 01/14] MdeModulePkg: Add PrePiHob.h

2022-09-01 Thread Min Xu
On September 1, 2022 11:48 PM, Gerd Hoffmann wrote: > > > EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > > But this defitinion has not been officially in the PI spec. > > I think this has just changed with uefi spec 2.10 released in August. > Thanks for reminder. I will

Re: [edk2-devel] [PATCH 11/24] IntelFsp2WrapperPkg: Remove duplicated words

2022-09-01 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2/commit/6edd2578 > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Tuesday, August 23, 2022 9:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject:

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Rename PlatformMultiPhaseLibSample.

2022-09-01 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, August 31, 2022 11:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2WrapperPkg: Rename > PlatformMultiPhaseLibSample. > > REF:

Re: [edk2-devel] [PATCH 11/24] IntelFsp2WrapperPkg: Remove duplicated words

2022-09-01 Thread Nate DeSimone
Good catch! Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Tuesday, August 23, 2022 9:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH 1/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Rebecca Cran
On 9/1/22 16:21, Andrew Fish via groups.io wrote: I think this feature flag is going to control the output of edk2 DEBUG. In an abstract sense DEBUG is not Terminal or ConOut. It could be mapped to the same device, but it does not have to be. So maybe PcdDebugAnsiSeqSupport or

Re: [edk2-devel] [PATCH 1/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Andrew Fish via groups.io
> On Sep 1, 2022, at 4:52 PM, Rebecca Cran wrote: > > Thanks. I've just sent out a v2 that introduces a > > PcdTerminalSupportsAnsiSequences FeatureFlag. > > Let me know if you'd prefer a different name: I wondered about something like > PcdConOutAnsiSeqSupport for example. > Rebecca, I

Re: [edk2-devel] [PATCH 1/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Rebecca Cran
Thanks. I've just sent out a v2 that introduces a PcdTerminalSupportsAnsiSequences FeatureFlag. Let me know if you'd prefer a different name: I wondered about something like PcdConOutAnsiSeqSupport for example. -- Rebecca Cran On 8/29/22 17:29, Kinney, Michael D wrote: Hi Rebecca, I think

[edk2-devel] [PATCH v2 1/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Rebecca Cran
There currently isn't a way to differentiate the different levels of DEBUG output: DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO etc. To improve this, wrap DEBUG_ERROR and DEBUG_WARN level messages in ANSI color code escape sequences. DEBUG_ERROR messages will be displayed in red text, and DEBUG_WARN in

[edk2-devel] [PATCH v2 0/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Rebecca Cran
Changes in v2: Introduced a new FeatureFlag gEfiMdePkgTokenSpaceGuid.PcdTerminalSupportsAnsiSequences which defaults to FALSE, and which controls whether to use ANSI color sequences. Rebecca Cran (1): MdePkg: Use ANSI colors to indicate debug message severity MdePkg/MdePkg.dec

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Tim Lewis via groups.io
Is the FSP 2.4 specification available publicly? It is hard to understand the impact of this without referencing the specification. From the FSP page on https://www.intel.com/content/www/us/en/intelligent-systems/intel-firmware-support-package/intel-fsp-overview.html, only 2.3 is available.

[edk2-devel] Building ShellBinPkg for stable tags/releases

2022-09-01 Thread Rebecca Cran
Has there been any progress on fixing the following Bugzilla tickets? Enhance CI process to generate the release contents for each stable tag https://bugzilla.tianocore.org/show_bug.cgi?id=3176 UEFI shell rebuild for edk2-stable202102 https://bugzilla.tianocore.org/show_bug.cgi?id=3178

Re: [edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules

2022-09-01 Thread Kun Qin
Hi Sami, Thank you so much the test and help! Regards, Kun On 9/1/2022 3:17 AM, Sami Mujawar wrote: Dropped last patch in this series as discussed at https://edk2.groups.io/g/devel/topic/92947269#92984 and tested using guest firmware for Kvmtool. For this series. Tested-by: Sami Mujawar

Re: [edk2-devel] [PATCH v6 2/2] UefiPayloadPkg: Allow DxeMain.inf to consume the new SerialPortLib

2022-09-01 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Sravanthi, K KavyaX Sent: Thursday, September 1, 2022 3:13 AM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH v6 2/2] UefiPayloadPkg: Allow DxeMain.inf to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Add BUILD_SHELL flag for IA32, IA32X64, X64

2022-09-01 Thread Gerd Hoffmann
On Tue, Aug 30, 2022 at 06:13:54PM +0200, Oliver Steffen wrote: > Add BUILD_SHELL flag, similar to the one in OvmfPkg/AmdSev, > to enable/disable building of the UefiShell as part of > the firmware image. The UefiShell should not be included for > secure production systems (e.g. SecureBoot)

Re: [edk2-devel] [PATCH V2 13/14] OvmfPkg: Call gEdkiiMemoryAcceptProtocolGuid to accept pages

2022-09-01 Thread Gerd Hoffmann
On Sat, Aug 27, 2022 at 02:21:20PM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > After EdkiiMemoryAcceptProtocol is implemented in TdxDxe driver, we can > call it to accept pages in DXE phase. > > Cc: Erdem Aktas > Cc: James Bottomley

Re: [edk2-devel] [PATCH V2 12/14] OvmfPkg: Realize EdkiiMemoryAcceptProtocol in TdxDxe

2022-09-01 Thread Gerd Hoffmann
On Sat, Aug 27, 2022 at 02:21:19PM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > Memory usage may exceed the amount accepted at the begining (SEC), TDVF > needs to accept memory dynamically when OUT_OF_RESOURCE occurs. > >

Re: [edk2-devel] [PATCH V2 11/14] MdePkg: The prototype definition of EdkiiMemoryAcceptProtocol

2022-09-01 Thread Gerd Hoffmann
On Sat, Aug 27, 2022 at 02:21:18PM +0800, Min Xu wrote: > From: Jiaqi Gao > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > EdkiiMemoryAcceptProtocol is defined in MdePkg, the method AcceptMemory() > can be called when memory needs to be accepted. > > EdkiiMemoryAcceptProtocol

Re: [edk2-devel] [PATCH V2 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-09-01 Thread Gerd Hoffmann
> Lazy accept page can be controlled in build time like below: > -D LAZY_ACCEPT_PARTIAL_MEM=512 > > The unit is MB. If it is 0 then it means Lazy-accept is turned off. > > Lazy-accept is turned off by default in OvmfPkgX64. > Lazy-accept is turned on with 512MB by default in IntelTdxX64. > +

[edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo

2022-09-01 Thread Konstantin Aladyshev
Fix typo in the set default value action define name: DEFAUTL -> DEFAULT Signed-off-by: Konstantin Aladyshev --- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c

Re: [edk2-devel] [PATCH V2 06/14] ShellPkg: Update shell command memmap to show unaccepted memory

2022-09-01 Thread Gerd Hoffmann
On Sat, Aug 27, 2022 at 02:21:13PM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > ShellCommandRunMemMap() is updated to handle the case of unaccepted > memory type. Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH V2 01/14] MdeModulePkg: Add PrePiHob.h

2022-09-01 Thread Gerd Hoffmann
Hi, > EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > But this defitinion has not been officially in the PI spec. I think this has just changed with uefi spec 2.10 released in August. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH 2/2] CloudHv/arm: switch PeiMemLib to its own

2022-09-01 Thread Sami Mujawar
Hi Jianyong, Please prefix the patch series version for this patch. Regards, Sami Mujawar On 19/08/2022 09:09 am, Jianyong Wu wrote: As Cloud Hypervisor has its own PeiMemLib, change it in dsc file accordingly. Signed-off-by: Jianyong Wu Reviewed-by: Sami Mujawar ---

Re: [edk2-devel] [PATCH v2 1/2] CloudHv/arm: add PeiMemInfoLib

2022-09-01 Thread Sami Mujawar
Hi Jianyong, Thank you for the updated patch. I have one comment marked inline as [SAMI]. Other than that this patch looks good to me. With that fixed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/08/2022 09:09 am, Jianyong Wu wrote: Memory layout in CLoud Hypervisor for arm

Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: Fix typo in AmlCodeGenRdMemory32Fixed doxygen comment

2022-09-01 Thread Sami Mujawar
Merged as 7719bc3f716e..ac55fcb051e4 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93051): https://edk2.groups.io/g/devel/message/93051 Mute This Topic: https://groups.io/mt/93374776/21656 Group Owner:

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: Fix nested processor containers

2022-09-01 Thread Sami Mujawar
Merged as 0a4079ad86f5..7719bc3f716e Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93050): https://edk2.groups.io/g/devel/message/93050 Mute This Topic: https://groups.io/mt/93107401/21656 Group Owner:

Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: Fix typo in AmlCodeGenRdMemory32Fixed doxygen comment

2022-09-01 Thread Sami Mujawar
Hi Rebecca, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 31/08/2022 05:20 pm, Rebecca Cran wrote: Fix typo of "Address". Signed-off-by: Rebecca Cran --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- 1 file changed, 1

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation

2022-09-01 Thread Sami Mujawar
Merged as  b9bb27e1ff40..0a4079ad86f5 Thanks. Regards, Sami Mujawar On 24/08/2022 05:35 am, Jeff Brasen wrote: Expose the UID value to GeneratePciSlots(). This is needed for some cases for example:

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation

2022-09-01 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93047): https://edk2.groups.io/g/devel/message/93047 Mute This Topic:

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - 09/01/2022 #cal-notice

2022-09-01 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* 09/01/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com (

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - 09/01/2022 #cal-reminder

2022-09-01 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* 09/01/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com (

Re: [edk2-devel] [PATCH v3] DynamicTablesPkg: Add support to build _DSD

2022-09-01 Thread Sami Mujawar
Merged as 033ba8bb2976..b9bb27e1ff40 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93044): https://edk2.groups.io/g/devel/message/93044 Mute This Topic: https://groups.io/mt/93085812/21656 Group Owner:

Re: [edk2-devel] [PATCH V2] RedfishPkg/RedfishDiscoverDxe: Install EFI_DISCOVER_PROTOCOL on each network interface

2022-09-01 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Thank you, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, September 01, 2022 12:02 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V2] RedfishPkg/RedfishDiscoverDxe: Install

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-01 Thread Rebecca Cran
You don't need a TianoCore account: if you have a personal GitHub account you could push to a fork there. For example, I have https://github.com/bcran/edk2 which I forked from https://github.com/tianocore/edk2 . -- Rebecca Cran On 8/31/22 20:51, RichardHo [何明忠] wrote: Hi Rebecca, All files

Re: [edk2-devel] [PATCH v3] DynamicTablesPkg: Add support to build _DSD

2022-09-01 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. There are some minor documentation changes that I will fix before pushing. Other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules

2022-09-01 Thread Sami Mujawar
Merged as 9ca7ece8b3b1..033ba8bb2976 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93040): https://edk2.groups.io/g/devel/message/93040 Mute This Topic: https://groups.io/mt/92947263/21656 Group Owner:

Re: [edk2-devel] [PATCH] [edk2-basetools]GenCrc32:Convert the C tool of calculating the crc32 into a python tool

2022-09-01 Thread Michael Brown
On 01/09/2022 07:57, liwenzha wrote: This patch converts the C tool of calculating the crc32 value of file into a python file. To realize this,after reading the data into the file in binary form from an original file,a lookup table is listed to do XOR and shifting calculation for each bit in the

Re: [edk2-devel] [PATCH v2 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib

2022-09-01 Thread Sami Mujawar
Hi Nhi, Thank you for the updated patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93038): https://edk2.groups.io/g/devel/message/93038 Mute This

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-01 Thread RichardHo [何明忠] via groups . io
Hi Abner, OK, I will using "--transfer-encoding=8bit " to resend it next. Thanks, Richard -Original Message- From: Chang, Abner Sent: 2022年9月1日 5:06 PM To: devel@edk2.groups.io; RichardHo [何明忠] ; Rebecca Cran Cc: Andrew Fish ; Leif Lindholm ; Michael D Kinney ; Michael Kubacki ;

Re: [edk2-devel] [PATCH v2 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments

2022-09-01 Thread Sami Mujawar
Hi Michael, Thank you for this fix. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 25/08/2022 04:48 am, mikub...@linux.microsoft.com wrote: From: Michael Kubacki Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Michael Kubacki ---

Re: [edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules

2022-09-01 Thread Sami Mujawar
Dropped last patch in this series as discussed at https://edk2.groups.io/g/devel/topic/92947269#92984 and tested using guest firmware for Kvmtool. For this series. Tested-by: Sami Mujawar Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/08/2022 11:28 pm, Kun Qin wrote: REF:

[edk2-devel] [PATCH v6 2/2] UefiPayloadPkg: Allow DxeMain.inf to consume the new SerialPortLib

2022-09-01 Thread Kavya
Let DxeMain.inf consume new SerialPortLib to support multiple channel debug message on early DXE if the macro MULTIPLE_DEBUG_PORT_SUPPORT is TRUE. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++ 1 file

[edk2-devel] [PATCH v6 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-09-01 Thread Kavya
Add new Serial port library instance that consumes the HOB defined in MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h to support multiple UART's. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Kavya ---

[edk2-devel] [PATCH] [edk2-basetools]GenCrc32:Convert the C tool of calculating the crc32 into a python tool

2022-09-01 Thread liwenzha
description This patch converts the C tool of calculating the crc32 value of file into a python file. To realize this,after reading the data into the file in binary form from an original file,a lookup table is listed to do XOR and shifting calculation for each bit in the file.The 32-bit result

Re: [edk2-devel] [PATCH V2] RedfishPkg/RedfishDiscoverDxe: Install EFI_DISCOVER_PROTOCOL on each network interface

2022-09-01 Thread NickleLa
Reviewed-by: Nickle Wang Thanks, Nickle 於 2022年9月1日 週四 中午12:02寫道: > From: Abner Chang > > BZ 4037: > Install EFI_DISCOVER_PROTOCOL on each network interface. > > This fixes the issue that causes the high-level Redfish driver > on the network interface is stopped when: > 1.

[edk2-devel] [PATCH] [edk2-basetools]GenCrc32:Convert the C tool of calculating the crc32 into a python tool

2022-09-01 Thread liwenzha
description This patch converts the C tool of calculating the crc32 value of file into a python file. To realize this,after reading the data into the file in binary form from an original file,a lookup table is listed to do XOR and shifting calculation for each bit in the file.The 32-bit result

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: Install EFI_DISCOVER_PROTOCOL on each network interface

2022-09-01 Thread NickleLa
Hi Abner, I see that the comment is in the middle of function parameters. I suggest that we can move the comment to the position before function call. +Status = CloseProtocolService ( + // Close protocol and destroy service. +

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Richard, Not sure if you can fix the extra lines using "--transfer-encoding=8bit" option to git send-email. Would you like to resend it? Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of > RichardHo [???] via groups.io >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: To replace the libraries for the capsule driver.

2022-09-01 Thread Lu, James
Reviewed-by: James Lu Thanks, James -Original Message- From: Liu, KasimX Sent: Thursday, August 25, 2022 11:22 AM To: devel@edk2.groups.io Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: To replace the libraries for the capsule driver.

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Chiu, Chasel
Agree. I'm sending patch to rename this lib from edk2 and will send patch to rename this lib from MinPlatformPkg dsc too. Thanks, Chasel > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, August 31, 2022 4:10 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone,