Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Set default Pci PCDs in Tdx guest

2022-09-05 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3291 > -Original Message- > From: Xu, Min M > Sent: Friday, August 26, 2022 8:41 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Gerd Hoffmann ; > Tom Lendacky > S

Re: [edk2-devel] [PATCH V5 0/2] Re-design CcProbeLib

2022-09-05 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3290 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Min Xu > Sent: Tuesday, August 30, 2022 9:04 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Gerd Hoffmann > ; Aktas, Erdem ; James > Bottomley ; Y

Re: [edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version from 0.1.24 to 0.1.28

2022-09-05 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: Feng, Bob C > Sent: Friday, September 2, 2022 2:18 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Chen, Christine ; > Kinney, Michael D > Subject: [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version > fro

[edk2-devel] [PATCH V5 8/8] OvmfPkg: Add build-flag SECURE_BOOT_FEATURE_ENABLED

2022-09-05 Thread Min Xu
From: Min M Xu SECURE_BOOT_FEATURE_ENABLED is the build-flag defined when secure boot is enabled. Currently this flag is used in below lib: - OvmfPkg/PlatformPei - PeilessStartupLib So it is defined in below 5 .dsc - OvmfPkg/CloudHv/CloudHvX64.dsc - OvmfPkg/IntelTdx/IntelTdxX64.dsc - OvmfPk

[edk2-devel] [PATCH V5 7/8] OvmfPkg/TdxDxe: Set PcdEmuVariableNvStoreReserved

2022-09-05 Thread Min Xu
From: Min M Xu Set PcdEmuVariableNvStoreReserved with the value in PlatformInfoHob. It is the address of the EmuVariableNvStore reserved in Pei-less startup. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Min Xu

[edk2-devel] [PATCH V5 6/8] OvmfPkg/NvVarsFileLib: Shortcut ConnectNvVarsToFileSystem in secure-boot

2022-09-05 Thread Min Xu
From: Min M Xu OvmfPkg/Library/NvVarsFileLib allows loading variables into emulated varstore from a on-disk NvVars file. We can't allow that when secure boot is active. So check secure-boot feature and shortcut the ConnectNvVarsToFileSystem() function when sb is enabled. Cc: Erdem Aktas Cc: J

[edk2-devel] [PATCH V5 5/8] OvmfPkg: Reserve and init EmuVariableNvStore in Pei-less Startup

2022-09-05 Thread Min Xu
From: Min M Xu EmuVariableNvStore is reserved and init with below 2 functions defined in PlatformInitLib: - PlatformReserveEmuVariableNvStore - PlatformInitEmuVariableNvStore PlatformInitEmuVariableNvStore works when secure boot feature is enabled. This is because secure boot needs the EFI var

[edk2-devel] [PATCH V5 4/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore

2022-09-05 Thread Min Xu
From: Min M Xu ReserveEmuVariableNvStore is updated with below 2 functions defined in PlatformInitLib: - PlatformReserveEmuVariableNvStore - PlatformInitEmuVariableNvStore PlatformInitEmuVariableNvStore works when secure boot feature is enabled. This is because secure boot needs the EFI variab

[edk2-devel] [PATCH V5 3/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore

2022-09-05 Thread Min Xu
From: Min M Xu There are 3 functions added for EmuVariableNvStore: - PlatformReserveEmuVariableNvStore - PlatformInitEmuVariableNvStore - PlatformValidateNvVarStore PlatformReserveEmuVariableNvStore allocate storage for NV variables early on so it will be at a consistent address. PlatformIni

[edk2-devel] [PATCH V5 2/8] OvmfPkg/PeilessStartupLib: Delete TdxValidateCfv

2022-09-05 Thread Min Xu
From: Min M Xu TdxValidateCfv is used to validate the integrity of FlashNvVarStore (PcdOvmfFlashNvStorageVariableBase) and it is not Tdx specific. So it will be moved to PlatformInitLib and be renamed to PlatformValidateNvVarStore in the following patch. And it will be called before EmuVaribleNvS

[edk2-devel] [PATCH V5 1/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib

2022-09-05 Thread Min Xu
From: Min M Xu AllocateRuntimePages is used to allocate one or more 4KB pages of type EfiRuntimeServicesData. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Gerd Hoffmann Reviewed-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Signed-off-by: Min Xu --- Embedded

[edk2-devel] [PATCH V5 0/8] Enable secure-boot when lauch OVMF with -bios parameter

2022-09-05 Thread Min Xu
Secure-Boot related variables include the PK/KEK/DB/DBX and they are stored in NvVarStore (OVMF_VARS.fd). When lauching with -pflash, QEMU/OVMF will use emulated flash, and fully support UEFI variables. But when launching with -bios parameter, UEFI variables will be partially emulated, and non-vola

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/06/2022 #cal-reminder

2022-09-05 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 09/06/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 09/05/2022 #cal-notice

2022-09-05 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* 09/05/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1608789 ) *Description:* TianoCore community, Micros

Re: [edk2-devel] [PATCH 1/1] Ext4Pkg: Fix bug in EXT4_HAS_GDT_CSUM

2022-09-05 Thread Pedro Falcato
Pushed as bcad50b On Mon, Sep 5, 2022 at 7:19 AM Marvin Häuser wrote: > > > > On 5. Sep 2022, at 03:58, Pedro Falcato wrote: > > > > Catched when running clang-tidy on this code. Also tidies up some l

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 09/05/2022 #cal-reminder

2022-09-05 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* 09/05/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1608789 ) *Description:* TianoCore communit

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-05 Thread Ard Biesheuvel
On Mon, 5 Sept 2022 at 17:52, Rebecca Cran wrote: > > On 9/5/22 04:57, Ard Biesheuvel wrote: > > > > IIRC, there were some issues with this code on bare metal. Which > > hardware did you use to test it? Any chance you could try it on a > > RPi4? > > Yes, there were. I've run this code on an Arm Ju

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-05 Thread Rebecca Cran
On 9/5/22 04:57, Ard Biesheuvel wrote: IIRC, there were some issues with this code on bare metal. Which hardware did you use to test it? Any chance you could try it on a RPi4? Yes, there were. I've run this code on an Arm Juno R2, Synquacer Developer Box and SolidRun HoneyComb. I do have an R

Re: [edk2-devel] Event: Tools, CI, Code base construction meeting series - 09/05/2022 #cal-reminder

2022-09-05 Thread Sean
Just a reminder. US holiday today. Tools and ci meeting canceled for the week. https://github.com/tianocore/edk2/discussions/2614#discussioncomment-3529140 From: devel@edk2.groups.io on behalf of Group Notification Sent: Sunday, September 4, 2022 4:30:03 PM T

[edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file

2022-09-05 Thread Vijayenthiran Subramaniam
The base address of NV storage are different on reference design platforms after the introduction of the RD-N2 platform. So the comment for the NV storage sizes for variables is corrected as it is now inaccurate. The base address of NV storage is correctly listed in the SgiMemoryMap.dsc.inc and Sgi

Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning

2022-09-05 Thread Ard Biesheuvel
On Wed, 3 Aug 2022 at 11:27, Wenyi Xie wrote: > > The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this > PCD is UINT32. So change the declaratrion of gTimeOut to UINT32 > to fix compile warning. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > S

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512

2022-09-05 Thread Ard Biesheuvel
On Mon, 15 Aug 2022 at 16:47, Gerd Hoffmann wrote: > > On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote: > > From: Laszlo Ersek > > > > Increase the maximum line length for debug messages. > > While log messages should be short, they can still > > get quite long, for example when pr

Re: [edk2-devel] [PATCH 04/24] ArmVirtPkg: Remove duplicated words

2022-09-05 Thread Ard Biesheuvel
On Tue, 23 Aug 2022 at 19:12, Sami Mujawar wrote: > > Hi Pierre, > > Thank you for this patch. > > Reviewed-by: Sami Mujawar > Merged as #3287 > Regards, > > Sami Mujawar > > On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote: > > From: Pierre Gondois > > > > In an effort to clean the d

Re: [edk2-devel] [PATCH 15/24] OvmfPkg: Remove duplicated words

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 01:00, Yao, Jiewen wrote: > > Reviewed-by: Jiewen Yao > Merged as #3287 > > -Original Message- > > From: pierre.gond...@arm.com > > Sent: Wednesday, August 24, 2022 12:00 AM > > To: devel@edk2.groups.io > > Cc: Pierre Gondois ; Ard Biesheuvel > > ; Yao, Jiewen >

Re: [edk2-devel] [PATCH 21/24] StandaloneMmPkg: Remove duplicated words

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 01:00, Yao, Jiewen wrote: > > Reviewed-by: Jiewen Yao > Merged as #3287 > > -Original Message- > > From: pierre.gond...@arm.com > > Sent: Wednesday, August 24, 2022 12:00 AM > > To: devel@edk2.groups.io > > Cc: Pierre Gondois ; Ard Biesheuvel > > ; Sami Mujawar ;

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/PlatformDxe: Check RouteConfig arguments for spec compliance

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 04:31, Yuan Yu wrote: > > Per UEFI Spec 2.9, EFI_HII_CONFIG_ROUTING_PROTOCOL.RouteConfig() > should return EFI_INVALID_PARAMETERS if caller passes in a NULL for > the Configuration parameter (see 35.4 EFI HII Configuration Routing > Protocol). > > Add a check to return EFI_I

Re: [edk2-devel] [PATCH 03/24] ArmPlatformPkg: Remove duplicated words

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 15:27, Leif Lindholm wrote: > > On Tue, Aug 23, 2022 at 18:00:10 +0200, pierre.gond...@arm.com wrote: > > From: Pierre Gondois > > > > In an effort to clean the documentation of the above > > package, remove duplicated words. > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuve

Re: [edk2-devel] [PATCH 02/24] ArmPkg: Remove duplicated words

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 15:28, Leif Lindholm wrote: > > On Tue, Aug 23, 2022 at 18:00:09 +0200, pierre.gond...@arm.com wrote: > > From: Pierre Gondois > > > > In an effort to clean the documentation of the above > > package, remove duplicated words. > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuve

Re: [edk2-devel] [PATCH 08/24] EmbeddedPkg: Remove duplicated words

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 15:31, Chang, Abner wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Abner Chang > Merged as #3287 > > -Original Message- > > From: pierre.gond...@arm.com > > Sent: Wednesday, August 24, 2022 12:00 AM > > To: devel@edk2.groups.io > > Cc: Pierre Gondo

Re: [edk2-devel] [edk2][PATCH V4 1/1] ArmPkg: Handle warm reboot request correctly

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 18:44, Pranav Madhu wrote: > > The warm reboot requests from OSPM are mapped to cold reboot. To handle > the warm reboot separately from a cold reboot, update > ArmSmcPsciResetSystemLib and to invoke the PSCI call with parameters > for warm reboot. > > Signed-off-by: Pranav

Re: [edk2-devel] [edk2][PATCH V4 1/1] ArmPlatformPkg/PrePeiCore: Invoke constructors for SEC phase

2022-09-05 Thread Ard Biesheuvel
On Tue, 30 Aug 2022 at 00:18, Rebecca Cran wrote: > > It would be good if we could get this committed now the stable tag has > been created. > Merged as #3287 > > On 8/9/22 03:39, Rohit Mathew wrote: > > Hi, > > > > Could anyone please let me know if there are any more comments on this > > pat

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Add BUILD_SHELL flag for IA32, IA32X64, X64

2022-09-05 Thread Ard Biesheuvel
On Thu, 1 Sept 2022 at 18:08, Gerd Hoffmann wrote: > > On Tue, Aug 30, 2022 at 06:13:54PM +0200, Oliver Steffen wrote: > > Add BUILD_SHELL flag, similar to the one in OvmfPkg/AmdSev, > > to enable/disable building of the UefiShell as part of > > the firmware image. The UefiShell should not be incl

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/PlatformDxe: Handle all requests in ExtractConfig and RouteConfig

2022-09-05 Thread Ard Biesheuvel
On Mon, 5 Sept 2022 at 14:11, Samer El-Haj-Mahmoud wrote: > > Hi Ard, > > Yes, this was found during SCT testing: > > HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig- ExtractConfig() returns EFI_SUCCESS > or EFI_NOT_FOUND with Request been NULL . -- FAILURE > 603E52F0-2CE3-4E7A-A72E-DF8CA3FDB20D > /home

Re: [edk2-devel] [PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

2022-09-05 Thread Ard Biesheuvel
On Mon, 5 Sept 2022 at 15:19, Corvin Köhne wrote: > > Hi, > > I've created a PR for the merge: https://github.com/tianocore/edk2/pull/3288 > Can you accept it/cherry pick the patch? > > OK -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#

Re: [edk2-devel] [PATCH v3 0/2] CloudHv/arm: Add specific mem info lib

2022-09-05 Thread Ard Biesheuvel
On Fri, 2 Sept 2022 at 04:12, Jianyong Wu wrote: > > Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory > layout for cloud hypervisor is changed, it needs a new meminfo lib. > > Signed-off-by: Jianyong Wu > > Jianyong Wu (2): > CloudHv/arm: add PeiMemInfoLib > CloudHv

Re: [edk2-devel] [PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

2022-09-05 Thread Ard Biesheuvel
On Fri, 2 Sept 2022 at 12:41, Corvin Köhne wrote: > > There's no bhyve specific PlatformSecureLib any more. Use the default > one of OvmfPkg which works too. > > Signed-off-by: Corvin Köhne > CC: Ard Biesheuvel > CC: Jiewen Yao > CC: Jordan Justen > CC: Gerd Hoffmann > CC: Rebecca Cran > CC:

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/PlatformDxe: Handle all requests in ExtractConfig and RouteConfig

2022-09-05 Thread Samer El-Haj-Mahmoud
Hi Ard, Yes, this was found during SCT testing: HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig- ExtractConfig() returns EFI_SUCCESS or EFI_NOT_FOUND with Request been NULL . -- FAILURE 603E52F0-2CE3-4E7A-A72E-DF8CA3FDB20D /home/dpavlov/qemu-cert/custom-testing/arm-systemready/SR/scripts/edk2-test/uefi

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/PlatformDxe: Handle all requests in ExtractConfig and RouteConfig

2022-09-05 Thread Ard Biesheuvel
On Thu, 18 Aug 2022 at 21:58, Dimitrije Pavlov wrote: > > Per the UEFI specification, if the Request argument in > EFI_HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig() is NULL or does not contain > any request elements, the implementation should return all of the settings > being abstracted for the part

Re: [[edk2-devel] PATH v1 2/3] OvmfPkg: take PcdResizeXterm from the QEMU command line

2022-09-05 Thread Ard Biesheuvel
On Tue, 23 Aug 2022 at 03:03, Paweł Poławski wrote: > > From: Laszlo Ersek > <--- insert explanatory text here ---> > Signed-off-by: Laszlo Ersek > > Pawel: Updated commit message for re-submission > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > > Signed-

Re: [edk2-devel] [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements

2022-09-05 Thread Ard Biesheuvel
On Wed, 24 Aug 2022 at 18:51, Nhi Pham wrote: > > This patchset is to update the ArmPkg/SMBIOS for fixes and improvements. > > Changes since v1: > + Change PartNumber to ProcessorVersion [Sami] > > Minh Nguyen (5): > ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib > ArmP

Re: [edk2-devel] [PATCH V4 1/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib

2022-09-05 Thread Ard Biesheuvel
On Fri, 1 Jul 2022 at 01:29, Min Xu wrote: > > From: Min M Xu > > AllocateRuntimePages is used to allocate one or more 4KB pages of > type EfiRuntimeServicesData. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Cc: Gerd Hoffmann > Signed-off-by: Min Xu

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-05 Thread Ard Biesheuvel
On Mon, 29 Aug 2022 at 18:00, Rebecca Cran wrote: > > This is the rework of the patches I sent out in late 2021, > building on fixes done by Ard at > https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor. > > The most significant changes are the addition of code to enable > the

Re: [edk2-devel] [PATCH V3 06/12] ShellPkg: Update shell command memmap to show unaccepted memory

2022-09-05 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Min Xu > Sent: Monday, September 5, 2022 4:35 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Ni, Ray ; Gao, > Zhichao ; Aktas, Erdem > ; Gerd Hoffmann ; James > Bottomley ; Yao, Jiew

[edk2-devel] [PATCH] BaseTools: Correct BPDG tool error prints

2022-09-05 Thread Konstantin Aladyshev
Popen communication returns bytestrings. It is necessary to perform decode on these strings before passing them to the EdkLogger that works with ordinary strings. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/Python/Common/VpdInfoFile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Enable ADM when change TTM

2022-09-05 Thread Sheng Wei
In Abort DMA Mode(ADM), hardware will abort all DMA operations without the need to set up a roottable. Enable Abort DMA Mode, when change Translation Table Mode(TTM) Change-Id: I74207fe96ef7a57d89a355d40dfbdd36186f06c3 Signed-off-by: Sheng Wei Cc: Jenny Huang Cc: Ray Ni Cc: Rangasai V Chaganty

[edk2-devel] [PATCH V3 12/12] OvmfPkg: Call gEdkiiMemoryAcceptProtocolGuid to accept pages

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 After EdkiiMemoryAcceptProtocol is implemented in TdxDxe driver, we can call it to accept pages in DXE phase. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Acked-by: Gerd Hoffman

[edk2-devel] [PATCH V3 11/12] OvmfPkg: Realize EdkiiMemoryAcceptProtocol in TdxDxe

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 Memory usage may exceed the amount accepted at the begining (SEC), TDVF needs to accept memory dynamically when OUT_OF_RESOURCE occurs. Another usage is in SetOrClearSharedBit. If a memory region is changed from shared to p

[edk2-devel] [PATCH V3 10/12] MdePkg: The prototype definition of EdkiiMemoryAcceptProtocol

2022-09-05 Thread Min Xu
From: Jiaqi Gao RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 EdkiiMemoryAcceptProtocol is defined in MdePkg, the method AcceptMemory() can be called when memory needs to be accepted. EdkiiMemoryAcceptProtocol can be installed by architecture-specific drivers such as TdxDxe. This all

[edk2-devel] [PATCH V3 09/12] OvmfPkg: Update ConstructFwHobList for lazy accept

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 In TDVF the hob list is constructed at the memory region which is the largest one below 4GB. After lazy accept is introduced, the MaxAcceptedMemoryAddress (which is tha max accpeted memory address in lazy accept) should be c

[edk2-devel] [PATCH V3 08/12] OvmfPkg: Introduce lazy accept in PlatformInitLib and PlatformPei

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 There are below major changes in PlatformInitLib/PlatformPei 1. ProcessHobList The unaccepted memory is accepted if it is under 4G address.If an EFI_RESOURCE_MEMORY_UNACCEPTED memory region is cross the 4G address, it

[edk2-devel] [PATCH V3 07/12] OvmfPkg: Add MaxAcceptedMemoryAddress in TDX work area

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 In lazy-accept the MaxAcceptedMemoryAddress is needed in TransferTdxHobList and ContructFwHobList(at PeilessStartupLib). But in SEC phase we cannot use a global variable to pass this value. So we add a new field (MaxAccepted

[edk2-devel] [PATCH V3 06/12] ShellPkg: Update shell command memmap to show unaccepted memory

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 ShellCommandRunMemMap() is updated to handle the case of unaccepted memory type. Cc: Ray Ni Cc: Zhichao Gao Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Acked-by: Gerd Hoffman

[edk2-devel] [PATCH V3 05/12] MdeModulePkg: Update Dxe to handle unaccepted memory type

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 Unaccepted memory is a kind of new memory type, CoreInitializeGcdServices() and CoreGetMemoryMap() are updated to handle the unaccepted memory type. Ref: microsoft/mu_basecore@97e9c31 Cc: Jian J Wang Cc: Liming Gao Cc: R

[edk2-devel] [PATCH V3 03/12] OvmfPkg: Use EFI_RESOURCE_MEMORY_UNACCEPTED which defined in MdeModulePkg

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 EFI_RESOURCE_MEMORY_UNACCEPTED is defined in MdeModulePkg. The files which use the definition are updated as well. Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off-by: Mi

[edk2-devel] [PATCH V3 04/12] MdePkg: Add UEFI Unaccepted memory definition

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 Plase refer to: UEFI Spec v2.9 Table 7-5 Memory Type Usage before ExitBootServices() Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom

[edk2-devel] [PATCH V3 02/12] MdePkg: Increase EFI_RESOURCE_MAX_MEMORY_TYPE

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. But this defitinion has not been officially in the PI spec. Base on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at MdeModulePkg/Include/Pi/PrePiHob

[edk2-devel] [PATCH V3 00/12] Introduce Lazy-accept for Tdx guest

2022-09-05 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 UnacceptedMemory is one of the four defined types of TD memory in Intel TDX guest. TDVF must invoke TDCALL [TDG.MEM.PAGE.ACCEPT] the unaccepted memory before use it. See [TDVF] Section 7.1. TDVF: https://www.intel.com/content/dam/develop/ext

[edk2-devel] [PATCH V3 01/12] MdeModulePkg: Add PrePiHob.h

2022-09-05 Thread Min Xu
From: Min M Xu RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. But this defitinion has not been officially in the PI spec. Base on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at MdeModulePkg/Include/Pi/PrePiHob

Re: [edk2-devel] [PATCH v3 8/8] OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments

2022-09-05 Thread Ard Biesheuvel
On Sat, 3 Sept 2022 at 00:23, wrote: > > From: Michael Kubacki > > The DEBUG macro updated in this patch previously contained 11 print > specifiers in the debug string but passeed 13 arguments. This change > attempts to update the macro to the author's intention so the number > of specifiers matc

Re: [edk2-devel] [PATCH v2 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib

2022-09-05 Thread Sami Mujawar
Hi Nhi, This patch series is fine for me. But we need permission from Ard or Leif for proceeding further. Regards, Sami Mujawar On 05/09/2022, 05:47, "Nhi Pham" wrote: Hi Sami, Thanks a lot for your review. Please help merge this series to edk2. -Nhi On 9/1/2022 5:48