[STILL CRASHING] Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

2022-11-18 Thread Jeremy Linton
Hi, Dead thread poke, but, its been > 2 years since this problem was pointed out. Multiple patches have been proposed, including one by me: https://edk2.groups.io/g/devel/message/58193 and the USB/XHCI reset logic continues to be broken enough that a wide range of USB issues can result in

Re: [edk2-devel] [edk2-platforms: PATCH] BIOS needs to present cores in order of relative performance in MADT

2022-11-18 Thread Pedro Falcato
On Fri, Nov 18, 2022 at 8:35 AM Lin, JackX wrote: > Hi Pedro, > > > > Yes, it is for some specific test tools. > > > > There are different performance between CPU cores, and the big cores are > better than small cores. > > Some legacy tools are executing with the highest performance CPU cores,

Re: [edk2-devel] [PATCH 2/3] ArmVirtPkg/ArmVirtQemu: Expose TRNG hypercall via RngDxe if implemented

2022-11-18 Thread PierreGondois
Hello Ard, On 11/10/22 14:47, Ard Biesheuvel wrote: Currently, we only expose the EFI_RNG_PROTOCOL in ArmVirtQemu if QEMU provides a virtio-rng device, and it doesn't do so by default. Given that KVM exposes the ARM architected TRNG service (and has done so for a while now), let's incorporate

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Remove AP support from PrePi/PrePeiCore

2022-11-18 Thread Rebecca Cran
Hi Sami, I was wondering if you could answer Leif's question? Thanks. Rebecca Cran On 10/28/22 03:17, Leif Lindholm wrote: On Thu, Oct 27, 2022 at 20:10:33 +0200, Ard Biesheuvel wrote: On Thu, 27 Oct 2022 at 19:31, Rebecca Cran wrote: Modern platforms use TF-A, so there's no need for

[edk2-devel][PATCH V1 1/1] Platform/Sgi: Add memory map entry for debug uart controller

2022-11-18 Thread Tony K Nadackal
The UART0 controller connected in the AXI expansion space is used as the debug UART controller. Add platform memory map descriptor for this UART controller. Signed-off-by: Tony K Nadackal --- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/RngDxe: Fix Rng algo selection for Arm

2022-11-18 Thread PierreGondois
On 11/18/22 11:35, Ard Biesheuvel wrote: On Fri, 18 Nov 2022 at 11:32, PierreGondois wrote: On 11/18/22 11:14, Ard Biesheuvel wrote: On Fri, 18 Nov 2022 at 11:10, Sami Mujawar wrote: Hi Ard, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 18/11/2022,

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/RngDxe: Fix Rng algo selection for Arm

2022-11-18 Thread Ard Biesheuvel
On Fri, 18 Nov 2022 at 11:32, PierreGondois wrote: > > > > On 11/18/22 11:14, Ard Biesheuvel wrote: > > On Fri, 18 Nov 2022 at 11:10, Sami Mujawar wrote: > >> > >> Hi Ard, > >> > >> Please find my response inline marked [SAMI]. > >> > >> Regards, > >> > >> Sami Mujawar > >> > >> On 18/11/2022,

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/RngDxe: Fix Rng algo selection for Arm

2022-11-18 Thread PierreGondois
On 11/18/22 11:14, Ard Biesheuvel wrote: On Fri, 18 Nov 2022 at 11:10, Sami Mujawar wrote: Hi Ard, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 18/11/2022, 09:56, "Ard Biesheuvel" wrote: On Wed, 16 Nov 2022 at 16:02, PierreGondois wrote: > >

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/RngDxe: Fix Rng algo selection for Arm

2022-11-18 Thread Ard Biesheuvel
On Fri, 18 Nov 2022 at 11:10, Sami Mujawar wrote: > > Hi Ard, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 18/11/2022, 09:56, "Ard Biesheuvel" wrote: > > On Wed, 16 Nov 2022 at 16:02, PierreGondois > wrote: > > > > From: Pierre Gondois >

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/RngDxe: Fix Rng algo selection for Arm

2022-11-18 Thread Sami Mujawar
Hi Ard, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 18/11/2022, 09:56, "Ard Biesheuvel" wrote: On Wed, 16 Nov 2022 at 16:02, PierreGondois wrote: > > From: Pierre Gondois > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151 > >

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/RngDxe: Fix Rng algo selection for Arm

2022-11-18 Thread Ard Biesheuvel
On Wed, 16 Nov 2022 at 16:02, PierreGondois wrote: > > From: Pierre Gondois > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151 > > The EFI_RNG_PROTOCOL can advertise multiple algorithms through > Guids. The PcdCpuRngSupportedAlgorithm contains a Guid that > can be configured. It

Re: [edk2-devel] [edk2-platforms: PATCH] BIOS needs to present cores in order of relative performance in MADT

2022-11-18 Thread JackX Lin
Hi Pedro, Yes, it is for some specific test tools. There are different performance between CPU cores, and the big cores are better than small cores. Some legacy tools are executing with the highest performance CPU cores, In early CPU design, it is usually the first one. We have to put them

Re: [edk2-devel] [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect

2022-11-18 Thread PierreGondois
Hello Jeff, The Lpi version should effectively be 0: Reviewed-by: Pierre Gondois Regards, Pierre On 11/15/22 19:01, Jeff Brasen wrote: _LPI Revision should be 0 per the ACPI 6.5 specification. "The revision number of the _LPI object. Current revision is 0." Signed-off-by: Jeff Brasen ---

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s

2022-11-18 Thread Yao, Jiewen
Sounds good. No size different is good news. Reviewed-by: Jiewen Yao We are in hard-freeze now. This will be merged after freeze. Thank you Yao Jiewen > -Original Message- > From: Chen, Gang C > Sent: Friday, November 18, 2022 4:08 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s

2022-11-18 Thread Chen, Gang C
Hi Jiewen, Thanks for your review. Yes, I did finish the tiano CI: https://github.com/tianocore/edk2/pull/3648. Regarding the size, I'm not sure which lib you'd like to know. So I list the 3 CryptLib size here(compiler: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0): PeiCryptLib.lib