[edk2-devel] [PATCH 1/1] SecurityPkg/AuthVariableLib: Check SHA-256 OID with ContentInfo present

2022-12-02 Thread Jan Bobek via groups.io
Based on whether the DER-encoded ContentInfo structure is present in authenticated SetVariable payload or not, the SHA-256 OID can be located at different places. UEFI specification explicitly states the driver shall support both cases, but the old code assumed ContentInfo was not present and

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2022-12-02 Thread Rebecca Cran
The SendRndisSetMsg function never appears to be called: never directly, or as a callback. I noticed this because qemu's rndis receive function always fails because the media status is 'uninitialized': it uses the RNDIS SET MSG to change the status to initialized. -- Rebecca Cran On

Re: [edk2-devel] [PATCH v10 07/17] CI: Use Fedora 35 container (Linux only)

2022-12-02 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 12/1/2022 3:28 PM, Oliver Steffen wrote: Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 7/7] NetworkPkg/HttpBootDxe: Add Proxy URI input in setup menu

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Allows users to input the Proxy Server URI in the HTTP setup menu Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- NetworkPkg/HttpBootDxe/HttpBootConfig.c | 99 ++-

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 5/7] NetworkPkg: Add support for HTTP CONNECT Method

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add support for the HTTP CONNECT method to request the Proxy Server to open a tunnel to the EndPoint Server Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- NetworkPkg/HttpBootDxe/HttpBootClient.c|

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 6/7] NetworkPkg/HttpDxe: Support HTTPS EndPoint server with Proxy

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add support for Proxy server to connect to a HTTPS EndPoint server. TLS Connection to be created during GET/HEAD after CONNECT method. Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 4/7] NetworkPkg: Add Proxy Support to HTTP_PROTOCOL

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Update HTTP Protocol with variables to support Proxy Use state machine to call HttpBootGetBootFile() Add switch/case for EfiHttpRequest request method Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 3/7] NetworkPkg/HttpBootDxe: Update HTTP Boot Driver with parsed Proxy URL

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add ProxyUri to HTTP_BOOT_PRIVATE_DATA Parse HTTP Boot Device path to process Proxy and EndPoint URLs Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- NetworkPkg/HttpBootDxe/HttpBootClient.c | 30

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 2/7] MdePkg/Include: Add Proxy Server URL in EFI_HTTP_REQUEST_DATA

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add Proxy Server URL to EFI_HTTP_REQUEST_DATA. This will be used when a Proxy Server URL is a part of the HTTP Boot device path. Cc: Zhiguang Liu Cc: Michael D Kinney Cc: Liming Gao Cc: Maciej Rabeda Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 1/7] MdeModulePkg/Library: Support multi-URI HTTP Boot device path

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Process device path with proxy server and endpoint server included. Update comment for sample HTTP Boot device path. Cc: Jian J Wang Cc: Liming Gao Cc: Maciej Rabeda Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [edk2-staging/HttpProxy PATCH v3 0/7] Support HTTPS Proxy Server for HTTP Boot

2022-12-02 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4052 - Add CONNECT HTTP Method to create a tunnel through the Proxy Server - TLS adjustments to establish handshake with the Endpoint Server - Use multi-URI device path to support Proxy

Re: [edk2-devel] [PATCH 1/4] MdeModulePkg/XhciDxe/XhciReg: Handle incorrect PSIV indices

2022-12-02 Thread Sean Rhodes
Hi Hao They are now resolved Thanks Sean On Fri, 2 Dec 2022 at 06:25, Wu, Hao A wrote: > Hello, > > I saw there are several CI check failures for this 4 patches: > https://github.com/tianocore/edk2/pull/3702 > > Could you help to resolve them? Thanks. > > Best Regards, > Hao Wu > > >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE

2022-12-02 Thread Rebecca Cran
On 12/1/22 18:26, Wu, Hao A wrote: Sorry for a question. For the changes in EhcBulkTransfer() and XhcBulkTransfer(), is it feasible to distinguish timeout cases with other error cases and only adjust timeout related messages to VERBOSE level? No problem! Something like this? if (EFI_ERROR

[edk2-devel] [PATCH 14/14] OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported + mQemuFwCfgDmaSupported

2022-12-02 Thread Gerd Hoffmann
Remove global variables, store the state in PlatformInfoHob instead. Probing for fw_cfg happens on first use, at library initialization time the Hob might not be present yet. Signed-off-by: Gerd Hoffmann --- .../Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 4 ++

[edk2-devel] [PATCH 13/14] OvmfPkg/QemuFwCfgLib: rewrite fw_cfg probe

2022-12-02 Thread Gerd Hoffmann
Move the code to a new QemuFwCfgProbe() function. Use direct Io*() calls instead of indirect QemuFwCfg*() calls to make sure we don't get recursive calls. Also simplify CC guest detection. Signed-off-by: Gerd Hoffmann --- .../Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 1 -

[edk2-devel] [PATCH 12/14] OvmfPkg/DebugLibIoPort: use Rom version for PEI

2022-12-02 Thread Gerd Hoffmann
This variant does not use global variables. Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.dsc | 4 ++-- OvmfPkg/Bhyve/BhyveX64.dsc| 4 ++-- OvmfPkg/Microvm/MicrovmX64.dsc| 4 ++--

[edk2-devel] [PATCH 11/14] OvmfPkg/PlatformPei: remove mFeatureControlValue

2022-12-02 Thread Gerd Hoffmann
Use PlatformInfoHob->FeatureControlValue instead. OnMpServicesAvailable() will find PlatformInfoHob using GetFirstGuidHob() and pass a pointer to the WriteFeatureControl callback. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Include/Library/PlatformInitLib.h | 2 ++ OvmfPkg/PlatformPei/Platform.h

[edk2-devel] [PATCH 10/14] OvmfPkg/PlatformPei: remove mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable. Let BuildPlatformInfoHob() allocate and return PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.h | 4 +- OvmfPkg/PlatformPei/Platform.c | 71 ++ 2 files changed, 39

[edk2-devel] [PATCH 07/14] OvmfPkg/PlatformPei: MemTypeInfo: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in MemTypeInfoInitialization() function. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.h| 2 +- OvmfPkg/PlatformPei/MemTypeInfo.c | 4 ++-- OvmfPkg/PlatformPei/Platform.c| 2

[edk2-devel] [PATCH 09/14] OvmfPkg/PlatformPei: Verification: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in S3Verification() and Q35BoardVerification() functions. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff

[edk2-devel] [PATCH 08/14] OvmfPkg/PlatformPei: NoExec: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in NoexecDxeInitialization() function. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [PATCH 05/14] OvmfPkg/PlatformPei Q35 SMM helpers: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in Q35TsegMbytesInitialization() and Q35SmramAtDefaultSmbaseInitialization() ) functions. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.h | 4 ++-- OvmfPkg/PlatformPei/MemDetect.c |

[edk2-devel] [PATCH 06/14] OvmfPkg/PlatformPei: PeiMemory: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in PublishPeiMemory() and GetPeiMemoryCap() functions. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.h | 2 +- OvmfPkg/PlatformPei/MemDetect.c | 36 -

[edk2-devel] [PATCH 02/14] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

2022-12-02 Thread Gerd Hoffmann
Fixes problems due to code assuming it runs with frame pointers and thus updates rbp / ebp registers when switching stacks. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH 04/14] OvmfPkg/PlatformPei: PeiFv: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in PeiFvInitialization() function. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.h | 2 +- OvmfPkg/PlatformPei/Fv.c | 6 +++--- OvmfPkg/PlatformPei/Platform.c | 2 +- 3 files

[edk2-devel] [PATCH 03/14] OvmfPkg/PlatformPei: AmdSev: stop using mPlatformInfoHob

2022-12-02 Thread Gerd Hoffmann
Stop using the mPlatformInfoHob global variable in AmdSevInitialize() and AmdSevEsInitialize() functions. Pass a pointer to the PlatformInfoHob instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.h | 2 +- OvmfPkg/PlatformPei/AmdSev.c | 14 +++---

[edk2-devel] [PATCH 01/14] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS

2022-12-02 Thread Gerd Hoffmann
They are not used anywhere. Remove them. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 2 -- 1 file changed, 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index c4e4c7ded0af..73f95b2a3a9f 100755 ---

[edk2-devel] [PATCH 00/14] OvmfPkg: avoid global variables in PEI

2022-12-02 Thread Gerd Hoffmann
Writing to global variables changes the PEI firmware volume which in turn screws up firmware volume measurements. Fix OvmfPkg to avoid that, for the most part by using the PlatformInfoHob instead. Gerd Hoffmann (14): tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS tools_def: add

[edk2-devel] [PATCH 2/3] OvmfPkg: move dsc include snippet for Network support to inc subdir

2022-12-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- OvmfPkg/{ => inc}/NetworkComponents.dsc.inc | 0 OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-

[edk2-devel] [PATCH 0/3] OvmfPkg: move include files to inc subdir

2022-12-02 Thread Gerd Hoffmann
We have a number of include files for *.dsc and *.fdf in OvmfPkg/, lets unclutter the directory a bit by moving them all to a subdirectory. Gerd Hoffmann (3): OvmfPkg: move dsc and fdf include snippets for TPM support to inc subdir OvmfPkg: move dsc include snippet for Network support to

[edk2-devel] [PATCH 3/3] OvmfPkg: move fdf include snippets to inc subdirectory

2022-12-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.fdf | 6 +++--- OvmfPkg/Bhyve/BhyveX64.fdf| 6 +++--- OvmfPkg/CloudHv/CloudHvX64.fdf| 2 +- OvmfPkg/IntelTdx/IntelTdxX64.fdf | 8

[edk2-devel] [PATCH 1/3] OvmfPkg: move dsc and fdf include snippets for TPM support to inc subdir

2022-12-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- OvmfPkg/{ => inc}/OvmfTpmComponentsDxe.dsc.inc | 0 OvmfPkg/{ => inc}/OvmfTpmComponentsPei.dsc.inc | 0 OvmfPkg/{ => inc}/OvmfTpmDefines.dsc.inc | 0 OvmfPkg/{ => inc}/OvmfTpmLibs.dsc.inc | 0 OvmfPkg/{ => inc}/OvmfTpmPcds.dsc.inc | 0

Re: [edk2-devel] Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr

2022-12-02 Thread Gerd Hoffmann
On Fri, Dec 02, 2022 at 11:26:56PM +1100, Alexey Kardashevskiy wrote: > > > On 2/12/22 01:47, Tom Lendacky wrote: > > Added the subject as somehow it didn't get set. > > > > On 11/30/22 20:35, Alexey Kardashevskiy wrote: > > > Date: Tue, 22 Nov 2022 16:12:55 +1100 > > > Subject: [PATCH ovmf

Re: [edk2-devel] Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr

2022-12-02 Thread Alexey Kardashevskiy via groups.io
On 2/12/22 01:47, Tom Lendacky wrote: Added the subject as somehow it didn't get set. On 11/30/22 20:35, Alexey Kardashevskiy wrote: Date: Tue, 22 Nov 2022 16:12:55 +1100 Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to   PcdConfidentialComputingGuestAttr

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2022-12-02 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Richard, Attach the changes for GCC build for your reference. Regards, Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Brown via groups.io > Sent: Friday, December 2, 2022 6:09 PM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2022-12-02 Thread RichardHo [何明忠] via groups . io
Hi Michael, Thanks for your response. I will fixed it next. Thanks, Richard -Original Message- From: Michael Brown Sent: 2022年12月2日 6:09 PM To: devel@edk2.groups.io; Richard Ho (何明忠) Cc: Andrew Fish ; Leif Lindholm ; Michael D Kinney ; Michael Kubacki ; Zhiguang Liu ; Liming Gao ;

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2022-12-02 Thread RichardHo [何明忠] via groups . io
Hi Rebecca, Thanks for your response. I will fixed it next. Thanks, Richard -Original Message- From: Rebecca Cran Sent: 2022年12月1日 11:47 PM To: devel@edk2.groups.io; Richard Ho (何明忠) Cc: Andrew Fish ; Leif Lindholm ; Michael D Kinney ; Michael Kubacki ; Zhiguang Liu ; Liming Gao ;

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2022-12-02 Thread Michael Brown
On 03/10/2022 10:26, RichardHo [何明忠] via groups.io wrote: diff --git a/UsbNetworkPkg/NetworkCommon/DriverBinding.h b/UsbNetworkPkg/NetworkCommon/DriverBinding.h new file mode 100644 index 00..29f1f967f5 --- /dev/null +++ b/UsbNetworkPkg/NetworkCommon/DriverBinding.h +VOID

回复: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-02 Thread gaoliming via groups.io
Zhiguang: Can you explain more about the emulator usage model for this library? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Zhiguang Liu > 发送时间: 2022年12月2日 14:25 > 收件人: devel@edk2.groups.io > 抄送: Zhiguang Liu ; Michael D Kinney > ; Liming Gao ; > Ray Ni > 主题: [edk2-devel]