Thank you Jiewen.
On 15/12/2022 4:42, Yao, Jiewen wrote:
> Hey
> CI failed - https://github.com/tianocore/edk2/pull/3772
> Have you run CI before submit patch? Please take a look.
I haven't -- last time I contributed to edk2 was a long time ago; I'll
look for the instructions on triggering the CI
From: Min M Xu
https://bugzilla.tianocore.org/show_bug.cgi?id=4171
AmdSevIoMmu.* is renamed as CcIoMmu*. The related section in
Maintainers.txt should be updated as well.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lenda
From: Tom Lendacky
Add support to use the reserved shared memory within the IoMmu library.
This improves boot times for all SEV guests, with SEV-SNP benefiting the
most as it avoids the page state change call to the hypervisor.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Min Xu
Cc
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171
IoMmuDxe once was designed to support DMA operation when SEV is enabled.
After TDX is enabled in IoMmuDxe, some files' name in IoMmuDxe need to
be more general. So this patch rename:
AmdSevIoMmu.h -> CcIoMmu.h
AmdSevIoMmu
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171
A typical QEMU fw_cfg read bytes with IOMMU for td guest is that:
(QemuFwCfgReadBytes@QemuFwCfgLib.c is the example)
1) Allocate DMA Access buffer
2) Map actual data buffer
3) start the transfer and wait for the transfer to c
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171
This patch-set introduces the feature of reserving shared memory
for DMA operation. Its intention is to reduce the allocation and
conversion of private/shared memory, so that boot performance
can be improved significantly. Detailed informatio
During the finalization of Mp initialization before booting into the OS,
depending on whether Mwait is supported or not, AsmRelocateApLoop
places Aps in MWAIT-loop or HLT-loop.
Since paging is necessary for long mode, the original implementation of
moving APs to 32-bit was to disable paging to e
AsmRelocateApLoop is replicated for future Intel Logic Extraction,
further brings AP into 64-bit, and enables paging.
Signed-off-by: Yuanhao Xie
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 52
UefiCpuPkg/Library/MpInitLib/MpEqu.inc
Yuanhao Xie (2):
UefiCpuPkg: Duplicated AsmRelocateApLoop as AsmRelocateApLoopAmd
UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS.
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 170
+++
Hi, Leif/Ard/Abner/Daniel
Since you're the maintainer/reviewer of EmbeddedPkg, would you please help to
review this patch? Any comments is welcome.
Thanks
Min
> -Original Message-
> From: Xu, Min M
> Sent: Tuesday, December 13, 2022 2:24 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; L
Merged https://github.com/tianocore/edk2/pull/3773
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Thursday, December 15, 2022 12:25 AM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Aktas, Erdem ; James Bottomley
> ; Tom Lendacky ; Arti
> Gupta
> Subje
Agree.
Reviewed-by: Jiewen Yao
I will wait for 1 work week to see if there is any objection.
If anyone has concern, please let us know as soon as possible.
Thank you
Yao, Jiewen
> -Original Message-
> From: Wang, Jian J
> Sent: Thursday, December 15, 2022 11:02 AM
> To: devel@edk2.grou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
There's no real usage of these two libraries. They're deprecated.
Cc: Jiewen Yao
Cc: Michael D Kinney
Cc: Nishant C Mistry
Cc: Judah Vang
Signed-off-by: Jian J Wang
---
SecurityPkg/Include/Library/RpmcLib.h | 42
Hey
CI failed - https://github.com/tianocore/edk2/pull/3772
Have you run CI before submit patch? Please take a look.
Thank you
Yao, Jiewen
> -Original Message-
> From: Tom Lendacky
> Sent: Monday, December 12, 2022 11:01 PM
> To: Dov Murik ; devel@edk2.groups.io
> Cc: Tobin Feldman-Fitzt
[AMD Official Use Only - General]
Hi Jiangang,
Could you please provide the context of this patch?
Thanks
Abner
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, December 12, 2022 11:27 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray
> ; Zeng,
Hi Sebastien
CI failed, https://github.com/tianocore/edk2/pull/3769
Have you run CI before submission? Please take a look.
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, December 15, 2022 12:20 AM
> To: Boeuf, Sebastien ; devel@edk2.groups.io
> Cc: Xu, Min M ; kra...@redhat.co
Sorry,
Could you help to:
1. Update the function description comment for XhcCheckUsbPortSpeedUsedPsic()
in .C/.H files for adding the new input parameter 'PortNumber'
2. Add additional checks in XhciPsivGetPsid() to not allow:
* PortId.Data.CompPortOffset having a value of 0
* Por
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Sean Rhodes
> Sent: Saturday, December 10, 2022 4:46 AM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier ; Wu, Hao A
> ; Ni, Ray ; Rhodes, Sean
>
> Subject: [PATCH 2/3] MdeModulePkg/XhciDxe/Xhci: Don't check for inv
Merged
PR: https://github.com/tianocore/edk2/pull/3771
Commit:
https://github.com/tianocore/edk2/commit/44fc90eb0ea7299abc79577db55aa6257b46b7ae
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, December 14, 2022 3:10 PM
> To: devel@edk2.groups.io; jesh...@nvidia.c
On Thu, 15 Dec 2022 at 00:21, Michael Kubacki
wrote:
>
> Yes. It will also reduce frequency of incoming patches that must be
> reviewed and merged due to people continuously fixing trivial spelling
> errors.
>
In that case, NAK to this patch (and the ArmVirtPkg one). Unless we
add a button to the
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeshua Smith
> via groups.io
> Sent: Wednesday, November 30, 2022 3:02 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> mikub...@linux.microsoft.com; sean.bro...@microsoft.com; Jeshua
On Wed, 14 Dec 2022 at 23:53, wrote:
>
> From: Michael Kubacki
>
> Audit mode was enabled for the spellcheck CI plugin. It is no longer
> needed with recent changes. Spelling errors can be checked in the
> package moving forward.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
One comment below
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Wednesday, December 14, 2022 2:53 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: [edk2-devel] [PATCH v3 05/14] FatPkg: Fix new typos reported
>
> From: Michael Kubacki
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Wednesday, December 14, 2022 2:53 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Kinney, Michael D
> ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH v3 12/14] .azurepi
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, December 14, 2022 2:53 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; Jiang, Guomin
> ; Xu, Wei6
> Subject: [PATCH v3 06/14] FmpDevicePkg: Fix new typos
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, December 14, 2022 2:53 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Sean Brogan
>
> Subject: [PATCH v3 04/14] UnitTestFrameworkPkg: Fix new typos reported
>
> From: M
From: Michael Kubacki
Audit mode was enabled for the spellcheck CI plugin. It is no longer
needed with recent changes. Spelling errors can be checked in the
package moving forward.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Michael Kubacki
---
Ar
From: Michael Kubacki
Audit mode was enabled for the spellcheck CI plugin. It is no longer
needed with recent changes. Spelling errors can be checked in the
package moving forward.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Michael Kubacki
---
ArmPkg/ArmPkg.ci.yaml
From: Michael Kubacki
- Updates node from 14.x to 19.x to keep current.
- Updates the cspell module used in CI from 5.20.0 to 5.21.0.
Cc: Sean Brogan
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
.azurepipelines/templates/spell-check-prereq-steps.yml | 4 ++--
1 fil
From: Dongdong Zhang
Fix some typos in ArmVirtPkg directory.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Dongdong Zhang
---
ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemI
From: Dongdong Zhang
Fix some typos in ArmPlatformPkg directory.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Dongdong Zhang
---
ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c| 2 +-
ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 6 +++---
ArmPlatformPkg/ArmPlatformPkg.dec
From: Dongdong Zhang
Fix some typos in ArmPkg directory.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Dongdong Zhang
---
ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change adds the new words reported to the extended
words list in ArmVirtPkg.ci.yaml.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Michael Kubacki
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929
The SpellCheck plugin began reporting new typos that were previously
missed. Due to the number of spelling errors in this package, no
errors are fixed in this change. They are ignored to unblock overall
edk2 CI.
The m
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Michael Kubacki
---
FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 2
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Ray Ni
Signed-off-by: Michael Kubacki
---
FatPkg/EnhancedFatDxe/FileSpace.c | 2 +-
FatPkg/EnhancedFatDxe/ReadWrite.c | 2 +-
FatPkg/EnhancedFatDxe/Fat.h
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Michael Kubacki
---
UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c
|
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Signed-off-by: Michael Kubacki
Reviewed-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLi
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Signed-off-by: Michael Kubacki
Reviewed-by: Sami Mujawar
---
StandaloneMmPkg/Core/Dep
Liming,
I can add that, but I was wondering if you have a preference of one of the
following:
1) add to the EfiSignalReadyToBoot Function and create, signal, and close the
AfterReadyToBoot Event
2) create a new function EfiSignalAfterReadyToBoot and call that from BmBoot.c
3) have all the code
On Mon, 12 Dec 2022 at 17:58, Tom Lendacky wrote:
>
> On 12/2/22 07:09, Gerd Hoffmann wrote:
> > Writing to global variables changes the PEI firmware volume which in
> > turn screws up firmware volume measurements. Fix OvmfPkg to avoid that,
> > for the most part by using the PlatformInfoHob inst
All Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Wednesday, December 14, 2022 3:14 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Tom Lendacky
> ; Arti Gupta
> Subject: [PATCH V1 0/3] Fix incorrect implementat
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Boeuf, Sebastien
> Sent: Monday, December 12, 2022 5:04 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Xu, Min M ;
> kra...@redhat.com; Boeuf, Sebastien
> Subject: [PATCH 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
>
>
Merged as d103840cfb55..916825b84f23
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97376): https://edk2.groups.io/g/devel/message/97376
Mute This Topic: https://groups.io/mt/95048993/21656
Group Owner: de
Is there anything holding this up from getting reviewed?
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jeshua Smith via
groups.io
Sent: Wednesday, November 30, 2022 11:31 AM
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Jeshua Smith
Subject: [edk2-de
Is there anything blocking this patch from being merged?
-Original Message-
From: Michael Kubacki
Sent: Wednesday, November 30, 2022 4:07 PM
To: devel@edk2.groups.io; Jeshua Smith
Cc: michael.d.kin...@intel.com; sean.bro...@microsoft.com
Subject: Re: [edk2-devel] [PATCH v3] UnitTestFram
On Wed, Dec 14, 2022 at 03:12:22PM +0100, Gerd Hoffmann wrote:
> > Sorry for I forgot to put my testing environment in patch description.
> > My testing is on qemu with OVMF:
> >
> > - edk2-master or edk2-stable202211
> > build --verbose --debug=1 -D SECURE_BOOT_ENABLE -D TPM_ENABLE -D
> > TP
Hi Jeff,
Apologies for the delay and thank you for this fix.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/11/2022 06:01 pm, Jeff Brasen wrote:
_LPI Revision should be 0 per the ACPI 6.5 specification.
"The revision number of the _LPI object. Current r
Hi Jiewen,
Thanks for your response!
On Wed, Dec 14, 2022 at 06:53:42AM +, Yao, Jiewen via groups.io wrote:
> Hey
> Good catch!
>
> I think we need handle below valid cases:
> 1. VAR_HEADER_VALID_ONLY (0x7F) <-- Header added (*)
> 2. VAR_ADDED (0x3F) <-- Header + data added
> 3. VAR_ADDED &
Hi,
On Wed, Dec 14, 2022 at 09:46:36PM +0800, joeyli wrote:
> Hi Gerd,
>
> Thanks for your response!
>
> On Wed, Dec 14, 2022 at 07:15:28AM +0100, Gerd Hoffmann via groups.io wrote:
> > Hi,
> >
> > > When the variable store has those variables, then system
> > > booting/rebooting will
> > >
On 12/13/22 18:02, Xu, Min M wrote:
On December 14, 2022 12:04 AM, Lendacky, Thomas wrote:
On 12/12/22 23:48, Min Xu wrote:
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171
This patch causes crashes for SEV guests and breaks bisect-ability of the
EDK2 tree. See below.
> Sorry for I forgot to put my testing environment in patch description.
> My testing is on qemu with OVMF:
>
> - edk2-master or edk2-stable202211
> build --verbose --debug=1 -D SECURE_BOOT_ENABLE -D TPM_ENABLE -D
> TPM_CONFIG_ENABLE \
> -D NETWORK_IP6_ENABLE -D NETWORK_HTTP_BOOT_ENAB
Hi Gerd,
Thanks for your response!
On Wed, Dec 14, 2022 at 07:15:28AM +0100, Gerd Hoffmann via groups.io wrote:
> Hi,
>
> > When the variable store has those variables, then system booting/rebooting
> > will
> > hangs in a ASSERT:
> >
> > NvVarStore Variable header State was invalid.
> > AS
> +
> + MapAttribute.Uint64 = mReservedTopOfApStack;
1. Above assignment is too early because mReservedTopOfApStack hasn't been
allocated.
> + MapAttribute.Bits.Present = 1;
> + MapAttribute.Bits.ReadWrite = 1;
> +
> + MapMask.Bits.PageTableBaseAddress = 1;
> + MapMask.Bits.Pre
1.
> + if (StandardSignatureIsAuthenticAMD ()) {
> +StackStart = CpuMpData->SevEsAPResetStackStart;
CpuMpData->SevEsAPResetStackStart is not always allocated when CPU is AMD.
How about to use the following code:
if (StandardSignatureIsAuthenticAMD ()) {
StackStart
No.
I agree that rename can avoid confusion in future but that will cause lots of
build break in all x86 platforms.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif Lindholm
> Sent: Wednesday, December 14, 2022 5:39 PM
> To: Ni, Ray
> Cc: Sunil V L ; devel@edk2.groups
Hi Ray,
Should we then consider renaming DxeCpuExceptionHandlerLib
DxeCpuExceptionHandlerLibIA32X64?
Best Regards,
Leif
On Thu, Dec 08, 2022 at 08:32:31 +, Ni, Ray wrote:
> Yes. I am not sure if the preference for modules in other packages.
> But for code in UefiCpuPkg, I don't prefer this
On 12/14/22 09:38, Ard Biesheuvel wrote:
On Wed, 14 Dec 2022 at 09:34, wrote:
From: Pierre Gondois
Building the RdV1 platform fails when only providing the
'-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
Signed-off-by: Pierre Gondois
---
Platform/ARM/SgiPkg/SgiPlatf
On Wed, 14 Dec 2022 at 09:34, wrote:
>
> From: Pierre Gondois
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
>
> Signed-off-by: Pierre Gondois
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> 1 file chan
Code referenced from Aarch64 and Risc-V. Added three test case for
LoongArch64.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4192
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Supreeth Venkatesh
Signed-off-by: Chao Li
---
.../Lib
LoongArch64 support was merged into edk2 and edk2-platforms, enable it
in edk2-test now.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4192
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Supreeth Venkatesh
Signed-off-by: Chao Li
Ch
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4192
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Supreeth Venkatesh
Signed-off-by: Chao Li
---
.../Application/InstallSct/InstallSctDef.h| 4 +
uefi-sct/SctPkg/Library/SctLib/Sc
From: Pierre Gondois
Building the RdV1 platform fails when only providing the
'-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
Signed-off-by: Pierre Gondois
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platfor
Hi Michael,
Thanks for your submission,
I just reviewed your edit and I think it looks good to me.
Thanks,
Dongdong
> -原始邮件-发件人:"Michael Kubacki"
> 发送时间:2022-12-14 11:13:27
> (星期三)收件人:devel@edk2.groups.io,
> zhangdongd...@eswincomputing.com抄送:zhuwen...@eswincomputing.com,
> zhen..
On Wed, 14 Dec 2022 at 07:00, Gerd Hoffmann wrote:
>
> On Mon, Dec 12, 2022 at 10:38:46PM -0500, Michael Kubacki wrote:
> > Hi all,
> >
> > I still need reviews on this series. It should only take a few minutes of
> > your time.
> >
> > The TianoCore wiki changes that these changes link to are ava
65 matches
Mail list logo
