Re: [edk2-devel] [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support

2023-01-05 Thread Laszlo Ersek
On 1/5/23 18:01, Ard Biesheuvel wrote: > Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test > app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested > on Raspberry Pi 4. Note that the test app is not added to the image - it > can be taken from the build director

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-05 Thread Laszlo Ersek
On 1/5/23 19:25, dann frazier wrote: > On Thu, Jan 05, 2023 at 12:46:19PM +0100, Ard Biesheuvel wrote: >> On Wed, 4 Jan 2023 at 18:23, Ard Biesheuvel wrote: >>> >>> The early ID map used by ArmVirtQemu uses ASID scoped non-global >>> mappings, as this allows us to switch to the permanent ID map se

Re: [edk2-devel] [Patch V2 2/2] UefiCpuPkg: Keep 4GB limitation of memory allocation

2023-01-05 Thread Laszlo Ersek
On 1/6/23 04:11, Yuanhao Xie wrote: > Keep 4GB limitation of memory allocation if APs need transferring to > 32bit mode before handoff to the OS. > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4234 > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Signed-off-by: Yuanhao Xie > ---

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB

2023-01-05 Thread Gerd Hoffmann
On Fri, Jan 06, 2023 at 12:49:21AM +, Xu, Min M wrote: > On January 5, 2023 7:32 PM, Gerd Hoffmann wrote: > > > > On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote: > > > From: Min M Xu > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236 > > > > > > Similarly to the "cade

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

2023-01-05 Thread Laszlo Ersek
On 1/6/23 05:12, Ni, Ray wrote: >>> @@ -555,19 +556,25 @@ InitMpGlobalData ( >>> ) >>> ); >>> >>> - mReservedTopOfApStack = (UINTN)AllocateReservedPages (EFI_SIZE_TO_PAGES >>> (ApSafeBufferSize)); >>> - ASSERT (mReservedTopOfApStack != 0); >>> -

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB

2023-01-05 Thread Gerd Hoffmann
> > Also we maybe should move the MEMFD section to a Include/Fdf snippet > > to reduce code duplication and make it easier to keep things in sync? > > The problem with centralized code is the same as the advantage of > centralized code. You modify it once and it affects everything. But for > examp

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-01-05 Thread sahil
NT_FW_CONFIG DTB contains platform information passed by Tf-A boot stage. This information is used for Virtual memory map generation during PEI phase and passed on to DXE phase as a HOB, where it is used in ConfigurationManagerDxe. Signed-off-by: sahil --- Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Modify IRQ ID of Debug UART and routing to IOFPGA UART1

2023-01-05 Thread sahil
From: Himanshu Sharma In DBG2 table, IRQ ID was set as 0 for the UART. This overwrote the IPI0 trigger method to "level", which prevented SGI0 to be enabled again after a CPU offline/online cycle. This patch fixes the above issue by assigning a reserved IRQ ID for the Debug UART, other than 0 an

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Fix RemoteDdrSize cast

2023-01-05 Thread sahil
RemoteDdrSize calculation wraps around when booting N1Sdp in multichip mode. Casting it to UINT64 to fix the issue. Signed-off-by: sahil --- Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibM

Re: [edk2-devel] [PATCH] ShellPkg/AcpiView: ERST Parser

2023-01-05 Thread Gao, Zhichao
Hi, Sorry, just back from personal affairs. I would review the patch in next week. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeshua > Smith via groups.io > Sent: Friday, January 6, 2023 12:48 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao

Re: [edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it

2023-01-05 Thread Kun Qin
Hi Ard/Rebecca, Thanks for bringing this to the mailing list. But somehow I cannot find the patches sent along with this v4 cover letter. Could you please point me to them? I have been running the previous version of this patch and noticed a minor issue when the wait event is specified but th

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-05 Thread Wu, Jiaxin
Hi Zachary, Insert all my comments as below. Besides: where defined this protocol (EFI_WIFI_PROFILE_SYNC_PROTOCOL)? I didn't find in the UEFI spec, in such a case, could we named it as EDKII_WIFI_PROFILE_SYNC_PROTOCOL? please add more description about the protocol usage. Thanks, Jiaxin > +

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

2023-01-05 Thread Ni, Ray
> > @@ -555,19 +556,25 @@ InitMpGlobalData ( > > ) > > ); > > > > - mReservedTopOfApStack = (UINTN)AllocateReservedPages (EFI_SIZE_TO_PAGES > > (ApSafeBufferSize)); > > - ASSERT (mReservedTopOfApStack != 0); > > - ASSERT ((mReservedTopOfApStack

Re: [edk2-devel] [PATCH] Readme: Fix invalid URL

2023-01-05 Thread Michael D Kinney
pushed as a57865b571 Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, January 5, 2023 7:42 AM > To: Dongdong Zhang ; devel@edk2.groups.io > Cc: zhuwen...@eswincomputing.com; zhen...@eswincomputing.com; > jinyanji...@eswincomputing.com; quic_llind...@quicinc.com; Kin

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, January 5, 2023 #cal-reminder

2023-01-05 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, January 5, 2023 7:30pm to 8:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-

[edk2-devel] [Patch V2 2/2] UefiCpuPkg: Keep 4GB limitation of memory allocation

2023-01-05 Thread Yuanhao Xie
Keep 4GB limitation of memory allocation if APs need transferring to 32bit mode before handoff to the OS. Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4234 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 21 +++

[edk2-devel] [Patch V2 1/2] UefiCpuPkg:Fix stack offset mismatch in 32bit AsmRelocateApLoopStart

2023-01-05 Thread Yuanhao Xie
Fix 32bit version of AsmRelocateApLoopStart to retrieve the parameters from correct stack offset. Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4234 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c| 2 +- UefiC

[edk2-devel] [PATCH V4 3/3] RedfishPkg/Include: Redfish USB Interface V2 update

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../IndustryStandard/RedfishHostInterface.h | 25 +

[edk2-devel] [PATCH V4 2/3] RedfishPkg/Include: Add Redfish IPMI definitions

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang Add the definitions of Redfish Host Interface credential bootstrapping IPMI commands. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Igor Kulchytskyy Reviewed-by: Isaac Oram --- .../RedfishHostInterfaceIpmi.h| 51 ++

[edk2-devel] [PATCH V4 1/3] MdePkg/IndustryStandard: Update IPMI definitions

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang This change updates IPMI header files to support build up SMBIOS 42 Redfish Host Interface record using the information retrieved via IPMI App/Net Function. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchytskyy

[edk2-devel] [PATCH V4 0/3] IPMI changes for Redfish

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang In V4: Updateed copyright to 2023 Addressd the comment from Isaac on V3 2/3 In V3: Addressd the comments on V1 2/3 In V2: Addressd the comments on V1 3/3 This patch updates IPMI related definitions for supporting Redfish Host interface Credential bootstrapping spec and b

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2023-01-05 Thread Michael Kubacki
Hi Ard, I believe you're referencing the points in this mail, right? https://edk2.groups.io/g/devel/message/97433 To be clear about why that was considered dismissive and passive aggressive, these sentences: "I would also like to point out that all this focus on code aesthetics that do not co

Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

2023-01-05 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Isaac, I am not quite understand, this patch set should be independent of edk2. What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg is good now? Abner > -Original Message- > From: Oram, Isaac W > Sent: Friday, January 6, 2023 1:4

Re: [edk2-devel] [PATCH] .azurepipelines: Skip CodeCoverage if coverage.xml not found

2023-01-05 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Guo, Gua > Sent: Thursday, January 5, 2023 4:44 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Sean Brogan ; > Michael Kubacki ; Kinney, > Michael D ; Gao, Liming > Subject: [PATCH] .azurepipelines: Skip CodeCoverage if covera

Re: [edk2-devel] [PATCH] .azurepipelines: Skip CodeCoverage if coverage.xml not found

2023-01-05 Thread Sean
Reviewed-by: Sean Brogan On 1/5/2023 4:44 PM, Guo, Gua wrote: From: Gua Guo Skip CodeCoverage if coverage.xml not found Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Gua Guo --- .azurepipelines/templates/pr-gate-build-job.yml | 8 1

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

2023-01-05 Thread Ni, Ray
Isaac, So, no public doc defines the SMBIOS entry: SMBIOS_TABLE_TYPE_OEM_INTEL_FVI? Then, I am ok with the new addition 0xDD. Reviewed-by: Ray Ni > -Original Message- > From: Oram, Isaac W > Sent: Friday, January 6, 2023 3:26 AM > To: Ni, Ray ; Chang, Hunter ; > devel@edk2.groups.io

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB

2023-01-05 Thread Min Xu
On January 5, 2023 7:32 PM, Gerd Hoffmann wrote: > > On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote: > > From: Min M Xu > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236 > > > > Similarly to the "cadence" mentioned in commit d272449 ("OvmfPkg: > > raise DXEFV size to 11 MB",

[edk2-devel] [PATCH] .azurepipelines: Skip CodeCoverage if coverage.xml not found

2023-01-05 Thread Guo, Gua
From: Gua Guo Skip CodeCoverage if coverage.xml not found Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Gua Guo --- .azurepipelines/templates/pr-gate-build-job.yml | 8 1 file changed, 8 insertions(+) diff --git a/.azurepipelines/templates

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

2023-01-05 Thread Théo Jehl
Hello, Could your qemu open board pkg be built using stuart and setup to run > tests? More details about the goals and plans for the qemu open board pkg. > I like the test idea, however I do not know what Stuart is. If the goal is getting QOBP to build and pass tests using github CI on edk2-plat

Re: [edk2-devel] PING [PATCH 1/1 v2] EmulatorPkg: fixes for NetBSD

2023-01-05 Thread Pedro Falcato
On Thu, Jan 5, 2023 at 11:50 AM wrote: > Hello, > > Ping'ing for this patch sent on November 2022. > > The patch is trivial. Can someone review it or eventually merge it if OK? > > TIA, > -- > Thierry Laronde > http://www.kergis.com/ > http://kert

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Alexander Graf
> Am 05.01.2023 um 12:44 schrieb Ard Biesheuvel : > > On Thu, 5 Jan 2023 at 12:19, Gerd Hoffmann wrote: >> >> Hi, >> What number would you expect? I'd hope that we get to <100 realistically. I'm happy to hear about alternatives to this approach. I'm very confident tha

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

2023-01-05 Thread Pedro Falcato
On Thu, Jan 5, 2023 at 1:52 AM Sean Brogan wrote: > Pedro, > > Thanks. Happy to get some feedback. I hope others also provide > feedback. :) > > > Regarding the Edk2 tools & CI meeting: If we scheduled the Jan 16th > meeting for Jan 17th at 8am Pacific (should be 5 pm your time) would that >

[edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

2023-01-05 Thread Moritz Fischer via groups.io
Linux' cpu DT bindings call out arm,armv8 while the code previously used arm,arm-v8. Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") Signed-off-by: Moritz Fischer --- DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +- 1 file changed, 1 insertion(+),

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Gerd Hoffmann
Hi, > Tried booting grub.efi directly and via shim.efi, on Fedora 37 GA. > > In both cases I get a pagefault on linux kernel boot (before any other > message is printed), which I guess happens because the loader places the > linux kernel efi stub in EfiLoaderData memory. When compiling ovmf wi

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

2023-01-05 Thread Isaac Oram
Ray, I think it is ok because this file is "Intel common definitions for an OEM defined SMBIOS table structure". We could say that the folder name is wrong or the whole file is in the wrong place. But this addition seems consistent with the rest of the file contents. Regards, Isaac -Ori

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-05 Thread dann frazier
On Thu, Jan 05, 2023 at 12:46:19PM +0100, Ard Biesheuvel wrote: > On Wed, 4 Jan 2023 at 18:23, Ard Biesheuvel wrote: > > > > The early ID map used by ArmVirtQemu uses ASID scoped non-global > > mappings, as this allows us to switch to the permanent ID map seamlessly > > without the need for explic

Re: [edk2-devel] [PATCH V3 2/3] RedfishPkg/Include: Add Redfish IPMI definitions

2023-01-05 Thread Isaac Oram
Reviewed-by: Isaac Oram < isaac.w.o...@intel.com > Nit comment, there is a typo in "lenght", line 21. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98032): https://edk2.groups.io/g/devel/message/98032 Mute This Topic: https://groups.io/

Re: [edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it

2023-01-05 Thread Ard Biesheuvel
On Thu, 5 Jan 2023 at 18:39, Ard Biesheuvel wrote: > > On Wed, 4 Jan 2023 at 16:37, Rebecca Cran wrote: > > > > Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64, and > > add an MpServicesTest application to exercise it. > > > > Changes from v3: > > > > Removed Ard's 'Reviewed-by

Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

2023-01-05 Thread Isaac Oram
Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. f5da8af6befbfc655fd3e4cb899eda158dd9ede5 My apologies, I was sloppy and didn't ensure the edk2 changes were pushed first, so IpmiFeaturePkg build is currently broken pending https://edk2.groups.io/g/devel/message/97789being being push

Re: [edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it

2023-01-05 Thread Ard Biesheuvel
On Wed, 4 Jan 2023 at 16:37, Rebecca Cran wrote: > > Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64, and > add an MpServicesTest application to exercise it. > > Changes from v3: > > Removed Ard's 'Reviewed-by' line from the commits since the code has changed > sufficiently that

Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

2023-01-05 Thread Isaac Oram
Series Reviewed-by: Isaac Oram -Original Message- From: abner.ch...@amd.com Sent: Thursday, January 5, 2023 8:01 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-p

[edk2-devel] [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support

2023-01-05 Thread Ard Biesheuvel
Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested on Raspberry Pi 4. Note that the test app is not added to the image - it can be taken from the build directory and executed from the UEFI shell. Signed-off

Re: [edk2-devel] [PATCH] ShellPkg/AcpiView: ERST Parser

2023-01-05 Thread Jeshua Smith via groups.io
Resending after the holidays. -Original Message- From: Jeshua Smith Sent: Wednesday, December 14, 2022 8:30 AM To: devel@edk2.groups.io; Jeshua Smith Cc: ray...@intel.com; zhichao@intel.com Subject: RE: [edk2-devel] [PATCH] ShellPkg/AcpiView: ERST Parser Is there anything holding th

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values

2023-01-05 Thread Sunny Wang
Looks good to me. Thanks, Sam. Just for others' reference. I also had an offline discussion with Samer and got some clarifications below: 1. The default strings (SMBIOS PCDs) in ArmPkg\ArmPkg.dec are L"", so the UNI files should be changed to match the PCD values. 2. As for the case wher

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB

2023-01-05 Thread Laszlo Ersek
On 1/5/23 12:31, Gerd Hoffmann wrote: > On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote: >> From: Min M Xu >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236 >> >> Similarly to the "cadence" mentioned in commit d272449 ("OvmfPkg: >> raise DXEFV size to 11 MB", 2018-05-29), it's b

[edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-05 Thread Ard Biesheuvel
The early ID map used by ArmVirtQemu uses ASID scoped non-global mappings, as this allows us to switch to the permanent ID map seamlessly without the need for explicit TLB maintenance. However, this triggers a known erratum on ThunderX, which does not tolerate non-global mappings that are executab

[edk2-devel] [PATCH v2 1/2] ArmVirtPkg/ArmPlatformLibQemu: Ensure that VFP is on before running C code

2023-01-05 Thread Ard Biesheuvel
Now that we build the early code without strict alignment and without suppressing the use of SIMD registers, ensure that the VFP unit is on before entering C code. While at it, simplyify the mov_i macro, which is only used for 32-bit quantities. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/Libr

Re: [edk2-devel] [PATCH 1/4] BaseTools/tools_def RISCV: Make OpenSBI references RISCV-only

2023-01-05 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang Add Sunil to review this. > -Original Message- > From: Ard Biesheuvel > Sent: Friday, January 6, 2023 12:05 AM > To: devel@edk2.groups.io > Cc: quic_llind...@quicinc.com; rebe...@quicinc.com; bob.c.f...@intel.com; > gaolim...@byos

[edk2-devel] [PATCH 3/4] BaseTools/tools_def ARM: Make choice for soft float ABI explicit

2023-01-05 Thread Ard Biesheuvel
Recent GCC for ARM will complain when selecting the hard float ABI without specifying the FPU implementation, even when just running the preprocessor. This all happens under the hood, and we never bothered in the past, given that we don't emit floating point code anyway. However, to placate newer

[edk2-devel] [PATCH 2/4] BaseTools/tools_def ARM AARCH64: Get rid of ARCHCC and ARCHASM flags

2023-01-05 Thread Ard Biesheuvel
ARCHCC_FLAGS and ARCHASM_FLAGS no longer serve a useful purpose so drop all the definitions and references. Signed-off-by: Ard Biesheuvel --- BaseTools/Conf/tools_def.template | 89 +--- 1 file changed, 41 insertions(+), 48 deletions(-) diff --git a/BaseTools/Conf/tools_def.temp

[edk2-devel] [PATCH 4/4] BaseTools/tools_def CLANG38: Suppress unaligned access warning

2023-01-05 Thread Ard Biesheuvel
Even though the presence of the 'packed' pragma should be a strong hint that the misaligned placement of a GUID in a struct is intentional, recent Clang versions will object nonetheless, and break the build due to the presence of such GUIDs in the FPDT ACPI tables. This is obviously not something

[edk2-devel] [PATCH 1/4] BaseTools/tools_def RISCV: Make OpenSBI references RISCV-only

2023-01-05 Thread Ard Biesheuvel
The global GCC_PP_FLAGS tools_def variable now contains a reference to OpenSBI specific C preprocessor variables, which means they are added to the command line on every architecture, not just RISC-V. This does not currently result in any issues, but it is a bit sloppy so let's clean this up. Give

[edk2-devel] [PATCH 0/4] BaseTools - various cleanups

2023-01-05 Thread Ard Biesheuvel
Some cleanups for the tools_def template, mostly related to ARM but with some CLANG38 and RISCV changes as well. Ard Biesheuvel (4): BaseTools/tools_def RISCV: Make OpenSBI references RISCV-only BaseTools/tools_def ARM AARCH64: Get rid of ARCHCC and ARCHASM flags BaseTools/tools_def ARM: Mak

Re: [edk2-devel] [edk2-platforms][PATCH 1/3] Features/IpmiFeaturePkg: Add IPMI functions

2023-01-05 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks Isaac, V2 was sent to address your comments on patch 1/3 and 2/3. Abner > -Original Message- > From: Oram, Isaac W > Sent: Thursday, January 5, 2023 8:10 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Desimone, Nathaniel L ; Gao, Liming > ; N

[edk2-devel] [PATCH edk2-platforms 1/2] Platform/ Silicon/: Drop remnants of RVCT toolchain support

2023-01-05 Thread Ard Biesheuvel
The RVCT toolchain family has been removed from EDK2 so let's get rid of the remaining references to it. This includes .asm versions of assembler source files that use a different idiom than GNU as. Signed-off-by: Ard Biesheuvel --- Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/, Platform/: Get rid of redundant toolchains flags

2023-01-05 Thread Ard Biesheuvel
The ARCHCC and ARCHASM flags are redundant, given that ARMv7-A with Thumb2 codegen has been the default for a long time, for all supported toolchains. So let's drop these definitions: this allows us to retire ARCHCC and ARCHASM entirely from EDK2. Signed-off-by: Ard Biesheuvel --- Platform/ARM/

[edk2-devel] [edk2-platforms][PATCH V2] IpmiFeaturePkg: Add reference of IpmiBaseLib

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang Add reference of IpmiBaseLib Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Isaac Oram --- .../OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec| 5 + 1 file changed, 5 insertions(

[edk2-devel] [PATCH edk2-platforms 0/2] toolchain cleanups

2023-01-05 Thread Ard Biesheuvel
This cleans up some obsolete toolchain configuration variables: - the RVCT ones, which are no longer supported by EDK2 - ARCHCC and ARCHASM, which serve no useful purpose and are better removed Ard Biesheuvel (2): Platform/ Silicon/: Drop remnants of RVCT toolchain support Silicon/, Platform

[edk2-devel] [edk2-platforms][PATCH V2] Features/IpmiFeaturePkg: Add IPMI functions

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang Add functions to get system UUID and LAN configuration parameter. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Include/Library/IpmiCommandLib.h | 62 +++ 1 file changed, 6

[edk2-devel] [edk2-platforms][PATCH V2] IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang Add functions to get system UUID and LAN configuration parameter. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Isaac Oram --- .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +

[edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

2023-01-05 Thread Chang, Abner via groups.io
From: Abner Chang In V2: Addressed the comments from Isaac. BZ# 4214 This patch adds IPMI functions for building up SMBIOS 42 record for the USB NIC host interface exposed by BMC. The corresponding updates on edk2 is in the separate pacth. This is the part I of upstream, the follow up patche se

[edk2-devel] Now: TianoCore Community Meeting EMEA/NAMO - Thursday, January 5, 2023 #cal-notice

2023-01-05 Thread Group Notification
*TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, January 5, 2023 8:00am to 9:00am (UTC-08:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join on th

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, January 5, 2023 #cal-reminder

2023-01-05 Thread Group Notification
*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, January 5, 2023 8:00am to 9:00am (UTC-08:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | J

Re: [edk2-devel] [PATCH] Readme: Fix invalid URL

2023-01-05 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Dongdong Zhang > Sent: Wednesday, January 4, 2023 9:50 PM > To: devel@edk2.groups.io > Cc: zhuwen...@eswincomputing.com; zhen...@eswincomputing.com; > jinyanji...@eswincomputing.com; quic_llind...@quicinc.com; Kinney, > Michael

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Oliver Steffen
Quoting Laszlo Ersek (2023-01-05 16:12:36) > On 1/5/23 14:52, Gerd Hoffmann wrote: > > On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote: > >> Quoting Gerd Hoffmann (2023-01-05 14:12:22) > >>> Not sure this is an option. Is nested virtualization supported in azure > >>> pipeline VMs?

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Laszlo Ersek
ugh, unless you meant the Build_VS2019_TARGET_CODE_COVERAGE and Build_GCC5_TARGET_CODE_COVERAGE test failures, which I mentioned in passing -- I agree that those don't look healthy. Thanks Laszlo On 1/5/23 16:15, Laszlo Ersek wrote: > Hi Mike, > > On 1/5/23 00:34, Kinney, Michael D wrote: >> Hi

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Laszlo Ersek
Hi Mike, On 1/5/23 00:34, Kinney, Michael D wrote: > Hi Laszlo, > > Unit test code coverage was enabled just a couple days ago in CI. Looks like > you uncovered a corner case that was missed that should not generate a CI > failure. > > I have asked Gua to investigate. the CI env is healthy,

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Laszlo Ersek
On 1/5/23 14:52, Gerd Hoffmann wrote: > On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote: >> Quoting Gerd Hoffmann (2023-01-05 14:12:22) >>> Not sure this is an option. Is nested virtualization supported in azure >>> pipeline VMs? If so, is /dev/kvm passed into containers? >> >> I d

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Gerd Hoffmann
Hi, > > That sounds neat, especially as we can print a big'n'fat warning in that > > case, so the problem gets attention without actually breaking users. > > > > That, and a sleep(5) > > > Looking at the efi calls it looks like edk2 doesn't track the owner of > > an allocation (say by image ha

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion

2023-01-05 Thread Laszlo Ersek
On 1/5/23 14:15, Gerd Hoffmann wrote: > On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote: >> From: Min M Xu >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 >> >> Commit 9fdc70af6ba8 breaks log analysis and code cohesion in >> AcpiPlatformDxe. See the detailed information in BZ#

[edk2-devel] Tianocore edk2-test Bug Triage Meeting

2023-01-05 Thread G Edhaya Chandran
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT E

[edk2-devel] Tianocore edk2-test Bug Triage Meeting

2023-01-05 Thread G Edhaya Chandran
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT E

[edk2-devel] Tianocore edk2-test Bug Triage Meeting

2023-01-05 Thread G Edhaya Chandran
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT E

[edk2-devel] Canceled: Tianocore edk2-test Bug Triage Meeting

2023-01-05 Thread G Edhaya Chandran
BEGIN:VCALENDAR METHOD:CANCEL PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT EN

[edk2-devel] Canceled: Tianocore edk2-test Bug Triage Meeting

2023-01-05 Thread G Edhaya Chandran
BEGIN:VCALENDAR METHOD:CANCEL PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT EN

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - Thursday, January 5, 2023 #cal-notice

2023-01-05 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, January 5, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?su

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Gerd Hoffmann
On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote: > Quoting Gerd Hoffmann (2023-01-05 14:12:22) > > Not sure this is an option. Is nested virtualization supported in azure > > pipeline VMs? If so, is /dev/kvm passed into containers? > > I doubt it, but need to check. > > That requ

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, January 5, 2023 #cal-reminder

2023-01-05 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, January 5, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Oliver Steffen
Quoting Gerd Hoffmann (2023-01-05 14:12:22) > Hi, > > > So I'm not proposing to merge this immediately; something must be fixed > > first: > > > > - use KVM in the CI env, or > > Not sure this is an option. Is nested virtualization supported in azure > pipeline VMs? If so, is /dev/kvm passed in

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion

2023-01-05 Thread Gerd Hoffmann
On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > Commit 9fdc70af6ba8 breaks log analysis and code cohesion in > AcpiPlatformDxe. See the detailed information in BZ#4237. > > There are below changes in this p

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Gerd Hoffmann
On Wed, Jan 04, 2023 at 04:12:34PM +0100, Laszlo Ersek wrote: > In QEMU v5.1.0, the CPU hotplug register block misbehaves: the negotiation > protocol is (effectively) broken such that it suggests that switching from > the legacy interface to the modern interface works, but in reality the > switch n

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Gerd Hoffmann
Hi, > So I'm not proposing to merge this immediately; something must be fixed > first: > > - use KVM in the CI env, or Not sure this is an option. Is nested virtualization supported in azure pipeline VMs? If so, is /dev/kvm passed into containers? > - delay this patch until my QEMU fix is m

[edk2-devel] PING [PATCH 1/1 v2] EmulatorPkg: fixes for NetBSD

2023-01-05 Thread tlaronde
Hello, Ping'ing for this patch sent on November 2022. The patch is trivial. Can someone review it or eventually merge it if OK? TIA, -- Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint = 0FF7 E906 FBAF FE95 FD89

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-05 Thread Ard Biesheuvel
On Wed, 4 Jan 2023 at 18:23, Ard Biesheuvel wrote: > > The early ID map used by ArmVirtQemu uses ASID scoped non-global > mappings, as this allows us to switch to the permanent ID map seamlessly > without the need for explicit TLB maintenance. > > However, this triggers a known erratum on ThunderX

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Ard Biesheuvel
On Thu, 5 Jan 2023 at 12:19, Gerd Hoffmann wrote: > > Hi, > > > > What number would you expect? I'd hope that we get to <100 realistically. > > > > > > I'm happy to hear about alternatives to this approach. I'm very confident > > > that forcing NX on always is going to have the opposite effect

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB

2023-01-05 Thread Gerd Hoffmann
On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236 > > Similarly to the "cadence" mentioned in commit d272449 ("OvmfPkg: > raise DXEFV size to 11 MB", 2018-05-29), it's been ~1.75 years since > commit 5e75c4d ("Ovm

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Gerd Hoffmann
Hi, > > What number would you expect? I'd hope that we get to <100 realistically. > > > > I'm happy to hear about alternatives to this approach. I'm very confident > > that forcing NX on always is going to have the opposite effect of what we > > want: Everyone who ships AAVMF binaries will dis

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Ard Biesheuvel
On Thu, 5 Jan 2023 at 09:43, Alexander Graf wrote: > > > > > Am 05.01.2023 um 09:11 schrieb Gerd Hoffmann : > > > >  Hi, > > > >> To clarify, I mean something like the patch below, but with an additional > >> callback notification similar to the Emu one in LoadImage(), so that we can > >> make s

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

2023-01-05 Thread Ni, Ray
If it's not defined by any spec, it's probably not a good idea to put the definition in an industry header file. > -Original Message- > From: Chang, Hunter > Sent: Thursday, January 5, 2023 3:54 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac W > ; S, A

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

2023-01-05 Thread Ard Biesheuvel
On Thu, 5 Jan 2023 at 07:21, Yuanhao Xie wrote: > > Kept 4GB allocation limit for the case that APs are still transferred to > 32-bit protected mode on long mode DXE. > Fixed AsmRelocateApLoopStart stack offset in Ia32. > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4234 > > Cc: Eric

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion

2023-01-05 Thread Laszlo Ersek
On 1/4/23 15:13, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > Commit 9fdc70af6ba8 breaks log analysis and code cohesion in > AcpiPlatformDxe. See the detailed information in BZ#4237. > > There are below changes in this patch: > 1) Add back debug lo

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Alexander Graf
> Am 05.01.2023 um 09:11 schrieb Gerd Hoffmann : > >  Hi, > >> To clarify, I mean something like the patch below, but with an additional >> callback notification similar to the Emu one in LoadImage(), so that we can >> make sure we only enable the quirk when we load a known-bad grub binary.

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-05 Thread Gerd Hoffmann
Hi, > To clarify, I mean something like the patch below, but with an additional > callback notification similar to the Emu one in LoadImage(), so that we can > make sure we only enable the quirk when we load a known-bad grub binary. > That way we still force distros to ship fixed versions of the