On Thu, Jan 26, 2023 at 07:09:55AM +, Xu, Min M wrote:
> On January 25, 2023 8:22 PM, Gerd Hoffmann wrote:
> > > +#define FV_HANDOFF_TABLE_DESC "Fv(----
> > )"
> > > +typedef PLATFORM_FIRMWARE_BLOB2_STRUCT
> > CFV_HANDOFF_TABLE_POINTERS2;
> >
> > > -#define
On January 25, 2023 8:22 PM, Gerd Hoffmann wrote:
> > +#define FV_HANDOFF_TABLE_DESC "Fv(----
> )"
> > +typedef PLATFORM_FIRMWARE_BLOB2_STRUCT
> CFV_HANDOFF_TABLE_POINTERS2;
>
> > -#define FV_HANDOFF_TABLE_DESC "Fv(----
> )"
> >
Ah, yes. We can call Sha384HashAll(). Thanks for reminder!
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, January 26, 2023 10:02 AM
> To: Xu, Min M ; devel@edk2.groups.io;
> kra...@redhat.com
> Cc: Aktas, Erdem ; James Bottomley
> ; Tom Lendacky ;
> Michael Roth
> Subject:
Hey
I don't think it is a good idea to define a context size here, because that
will assume the openssl implementation. Please don't do that.
Could you please just use Sha384HashAll() API, if you don't like to allocate
memory?
Thank you
Yao, Jiewen
> -Original Message-
> From: Xu, Min
On January 25, 2023 8:22 PM, Gerd Hoffmann wrote:
> > +#define FV_HANDOFF_TABLE_DESC "Fv(----
> )"
> > +typedef PLATFORM_FIRMWARE_BLOB2_STRUCT
> CFV_HANDOFF_TABLE_POINTERS2;
>
> > -#define FV_HANDOFF_TABLE_DESC "Fv(----
> )"
> >
On January 25, 2023 8:16 PM, Gerd Hoffmann wrote:
> > +//
> > +// SHA512_CTX is defined in and its size is 216 bytes.
> > +// It can be built successfully with GCC5 compiler but failed with VS2019.
> > +// The error code showed in VS2019 is that "openssl/sha.h" cannot be found.
> > +// To
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Thursday, January 26, 2023 1:11 AM
> To: devel@edk2.groups.io
> Cc: Pawel Polawski ; Tom Lendacky
> ; Yao, Jiewen ; Oliver
> Steffen ; Gerd Hoffmann ; Ard
> Biesheuvel ;
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, January 26, 2023 3:44 AM
> To: Jake Garver ; devel@edk2.groups.io
> Cc: jbra...@nvidia.com; ashishsin...@nvidia.com; Yao, Jiewen
> ; Wang, Jian J ; Lu, Xiaoyu1
> ; Jiang, Guomin ; Kinney,
> Michael
I don’t think MdePkg is the right place. MdePkg only includes the approved
industry standard.
As Gerd and I discussed before, this protocol should be in OvmfPkg.
Please move to
https://github.com/tianocore/edk2/tree/master/OvmfPkg/Include/Protocol
Thank you
Yao, Jiewen
> -Original
Instead of eagerly accepting all memory in PEI, only accept memory under
the 4GB address. This allows a loaded image to use the
MEMORY_ACCEPTANCE_PROTOCOL to disable the accept behavior and indicate
that it can interpret the memory type accordingly.
This classification is safe since
This protocol implementation disables the accept-all-memory behavior
of the BeforeExitBootServices event this driver adds.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Ard Biesheuvel
Cc: "Min M. Xu"
Cc: Andrew Fish
Cc: "Michael D. Kinney"
Signed-off-by:
The default behavior for unaccepted memory in SEV-SNP is to accept all
memory when ExitBootServices is called. An OS loader can use this
protocol to disable this behavior to assume responsibility for memory
acceptance and to affirm that the OS can handle the unaccepted memory
type.
This is a
The added behavior is to accept all unaccepted memory at
ExitBootServices if the behavior is not disabled. This allows safe
upgrades for OS loaders to affirm their support for the unaccepted
memory type.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Ard Biesheuvel
We make eager memory acceptance the default behavior at
ExitBootServices for SEV-SNP machines by using the standard-enforced
behavior that if the call returns an error code, then the map key is
incorrect and the caller must re-call GetMemoryMap to ensure the
contents are correct.
Eager memory
From: Swatisri Kantamsetti
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https://developer.arm.com/documentation/den0049/ee)
added flags in SMMUv3 node for validity of ID mappings for MSIs
related to control interrupts.
Therefore, update the IORT header file to:
-
From: Swatisri Kantamsetti
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https://developer.arm.com/documentation/den0049/ee)
added flags in SMMUv3 node for validity of ID mappings for MSIs
related to control interrupts.
It makes one small addition to SMMUv3 nodes to
Hi Sean,
> From looking over the patch 1/4 email i have a concern.
>
> In AuthService.c on the conditional change you made. Aren't we losing
> a case where we are evaluating a nonPK payload signed by the PK?
> Given the system is in SetupMode that means there is no PK but is this
> the
Hi Sahil,
On 06/01/2023 06:11, sahil via groups.io wrote:
NT_FW_CONFIG DTB contains platform information passed by
Tf-A boot stage.
This information is used for Virtual memory map generation
during PEI phase and passed on to DXE phase as a HOB, where
it is used in ConfigurationManagerDxe.
On Wed, Jan 25, 2023 at 8:00 PM Kinney, Michael D <
michael.d.kin...@intel.com> wrote:
> Sounds like a reasonable feature request to disable install of all
> external tools. Pytools uses GitHub issues, so a feature request like
> this can be entered there.
>
There was a discussion about this
Hi Sahil,
On 06/01/2023 06:09, sahil via groups.io wrote:
From: Himanshu Sharma
In DBG2 table, IRQ ID was set as 0 for the UART. This overwrote the
IPI0 trigger method to "level", which prevented SGI0 to be enabled
again after a CPU offline/online cycle.
This patch fixes the above issue by
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jake Garver
> Sent: Wednesday, January 25, 2023 11:22 AM
> To: devel@edk2.groups.io
> Cc: jbra...@nvidia.com; ashishsin...@nvidia.com; Yao, Jiewen
> ; Wang, Jian J
> ; Lu, Xiaoyu1 ; Jiang, Guomin
> ; Kinney, Michael
> D
These sections were removed mistakenly. SmmCryptLib.inf supports these
architectures.
Signed-off-by: Jake Garver
---
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++
1 file changed, 6 insertions(+)
diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
Hi Sahil,
On 06/01/2023 06:07, sahil via groups.io wrote:
RemoteDdrSize calculation wraps around when booting N1Sdp in
multichip mode. Casting it to UINT64 to fix the issue.
The change looks okay but can the commit message be expanded to explain
how this issue surfaced. RemoteDdrSize was
Sounds like a reasonable feature request to disable install of all external
tools. Pytools uses GitHub issues, so a feature request like this can be
entered there.
One caution on this approach is that you make see passing conditions using your
local versions of dependent tools,
but when you
On Wed, Jan 25, 2023 at 5:56 PM Gerd Hoffmann wrote:
> Hi,
>
> > Given that nasm is x86 specific, we should be able to work around this
> > by moving the nasm_ext_dep.yaml file into the right place.
>
> Overall stuart feels kind of alien to linux. It just goes download
> stuff from the
On Wed, Jan 25, 2023 at 5:56 PM Gerd Hoffmann wrote:
> Hi,
>
> > Given that nasm is x86 specific, we should be able to work around this
> > by moving the nasm_ext_dep.yaml file into the right place.
>
> Overall stuart feels kind of alien to linux. It just goes download
> stuff from the
On 1/25/23 11:10, Gerd Hoffmann via groups.io wrote:
BuildResourceDescriptorHob() expects the third parameter be the Length,
not the End address.
Fixes: 328076cfdf45 ("OvmfPkg/PlatformInitLib: Add PlatformAddHobCB")
Thanks for the quick fix, Gerd!
Tested-by: Tom Lendacky
Reported-by: Tom
On 25/01/2023 16:55, Gerd Hoffmann wrote:
iasl is a different matter, as we need it to build for arm64 as well.
iasl is already available in the arm64 distros, so as I see it, there
are 3 options here:
- build iasl for Linux/arm64 and add it to the nuget repo
- allow a fallback to system-wide
BuildResourceDescriptorHob() expects the third parameter be the Length,
not the End address.
Fixes: 328076cfdf45 ("OvmfPkg/PlatformInitLib: Add PlatformAddHobCB")
Reported-by: Tom Lendacky
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +-
1 file changed, 1
On 1/24/23 14:42, Tom Lendacky wrote:
>> Fedora has near zero additional patches, so it pretty much depends on
>> how mainline merges stuff. If SEV-SNP or TDX or both will land in an
>> upstream release before support for unaccepted memory lands too you'll
>
> Sorry, just saw this...
>
>
>From 0541928e66eb01802a855bbbae125ef0b02259d6 Mon Sep 17 00:00:00 2001
From: houjingyi233
Date: Wed, 25 Jan 2023 22:11:31 +0800
Subject: [PATCH] RedfishPkg/RedfishLib: Avoid possible overflow in memcpy
It is possible that when the third argument of the memcpy is unequal
to the first argument of
>From 0541928e66eb01802a855bbbae125ef0b02259d6 Mon Sep 17 00:00:00 2001
From: houjingyi233
Date: Wed, 25 Jan 2023 22:11:31 +0800
Subject: [PATCH] RedfishPkg/RedfishLib: Avoid possible overflow in memcpy
It is possible that when the third argument of the memcpy is unequal
to the first argument of
hello
If this protocol is SEV specific, please also add prefix SEV_ or AMD_ for the
protocol name.
发件人: Ard Biesheuvel
发送时间: Wednesday, January 25, 2023 10:52:42 PM
收件人: Gerd Hoffmann
抄送: devel@edk2.groups.io ; thomas.lenda...@amd.com
; Hansen, Dave ;
Hi,
> Given that nasm is x86 specific, we should be able to work around this
> by moving the nasm_ext_dep.yaml file into the right place.
Overall stuart feels kind of alien to linux. It just goes download
stuff from the internet, even in case the tools are already available
locally. Oliver
On 1/25/23 09:35, Tom Lendacky wrote:
On 1/25/23 03:11, Gerd Hoffmann wrote:
On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote:
On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote:
Add PlatformAddHobCB() callback function for use with
PlatformScanE820(). It adds HOBs for high
On 1/25/23 03:11, Gerd Hoffmann wrote:
On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote:
On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote:
Add PlatformAddHobCB() callback function for use with
PlatformScanE820(). It adds HOBs for high memory and reservations (low
memory is
On Wed, 25 Jan 2023 at 13:10, Gerd Hoffmann wrote:
>
> On Wed, Jan 25, 2023 at 12:44:13PM +0100, Ard Biesheuvel wrote:
> > On Wed, 25 Jan 2023 at 10:18, Gerd Hoffmann wrote:
> > >
> > > On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote:
> > >
> > > > Exactly. And my Fedora kernel
Hello all,
Given some recent issues with OVMF and ArmVirtPkg, where regressions
were not caught, or resulted in different behavior between TCG
(emulation) and KVM (virtualized executon) when running under KVM.
So I have started with increasing the test coverage for ArmVIrtPkg,
even for
Also swap the ordering of 32bit PCI MMIO window on q35, i.e. use the
room between end of low memory and the start of the mmconfig bar.
With a typical configuration on modern qemu with gigabyte-aligned memory
the MMIO window start at 0x800, sized 1532 MB. In case there is
memory present above
With the new mmconfig location at 0xe000 above the 32-bit PCI MMIO
window we don't have to special-case the mmconfig xbar any more. We'll
just add a mtrr uncachable entry starting at MMIO window base and ending
at 4GB.
Update comments to match reality.
Signed-off-by: Gerd Hoffmann
---
Move the commment up so it is placed just before the address space
calculations start. Also add q35 memory layout.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformInitLib/Platform.c | 36 --
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git
Gerd Hoffmann (3):
OvmfPkg/PlatformInitLib: update address space layout comment
OvmfPkg/PlatformInitLib: move mmconfig to 0xe000
OvmfPkg/PlatformInitLib: simplify mtrr setup
OvmfPkg/AmdSev/AmdSevX64.dsc| 2 +-
OvmfPkg/IntelTdx/IntelTdxX64.dsc| 2 +-
On Wed, 25 Jan 2023 at 10:42, Gerd Hoffmann wrote:
>
> On Tue, Jan 24, 2023 at 05:34:11PM +0100, Ard Biesheuvel wrote:
> > We recently experienced some build breakage in one of the ArmVirtPkg
> > platforms that is not covered by PlatformCI, in the PrePi component
> > which replaces the entire PEI
On Wed, Jan 25, 2023 at 10:23:59AM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> The implementation of TdxHelperProcessTdHob is moved from
> PlatformInitLib/IntelTdx.c. Its counterpart in PlatformInitLib is
> ProcessTdxHobList. After it is
> +#define FV_HANDOFF_TABLE_DESC "Fv(----)"
> +typedef PLATFORM_FIRMWARE_BLOB2_STRUCT CFV_HANDOFF_TABLE_POINTERS2;
> -#define FV_HANDOFF_TABLE_DESC "Fv(----)"
> -typedef struct {
> - UINT8 BlobDescriptionSize;
>
> +//
> +// SHA512_CTX is defined in and its size is 216 bytes.
> +// It can be built successfully with GCC5 compiler but failed with VS2019.
> +// The error code showed in VS2019 is that "openssl/sha.h" cannot be found.
> +// To overcome this error SHA512_CTX_SIZE is defined.
> +//
> +#define
On Wed, Jan 25, 2023 at 12:44:13PM +0100, Ard Biesheuvel wrote:
> On Wed, 25 Jan 2023 at 10:18, Gerd Hoffmann wrote:
> >
> > On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote:
> >
> > > Exactly. And my Fedora kernel has those bits enabled by default.
> > >
> > > So I suppose the way
On Wed, 25 Jan 2023 at 10:18, Gerd Hoffmann wrote:
>
> On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote:
>
> > Exactly. And my Fedora kernel has those bits enabled by default.
> >
> > So I suppose the way forward here is to expose this protocol only on
> > OVMF builds that target
Had an offline discussion with Pierre. Apparently there are additional issues
that need to be fixed.
So, please ignore this patch series and instead use the patch series from
Pierre at https://edk2.groups.io/g/devel/message/99012
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
From: Pierre Gondois
Building the following images with the SECURE_STORAGE_ENABLE flag
fails due to VariableFlashInfoLib being missing:
- Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
- Platform/ARM/SgiPkg/PlatformStandaloneMm2.dsc
Add the missing library.
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
Building the following images with the SECURE_STORAGE_ENABLE flag
fails due to VariableFlashInfoLib being missing:
- Platform/Hisilicon/D03/D03.dsc
- Platform/Hisilicon/D06/D06.dsc
- Platform/Hisilicon/HiKey960/HiKey960.dsc
- Platform/Hisilicon/HiKey/HiKey.dsc
Add the
From: Pierre Gondois
commit d7b286ae5f53 ("Platform/ARM: clone NorFlashDxe from
ArmPlatformPkg")
recently moved the NorFlashDxe.
Update the TokenSpace of the PcdNorFlashCheckBlockLocked accordingly
and include ARM.dec for the module.
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc
was removed in the previous patch. The same flag was probably copied
from this first configuration in:
commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
image for OP-TEE")
As the flag is
From: Pierre Gondois
The '-march=armv8-a+nofp' flag abort the following build:
build -a AARCH64 -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
-t GCC5 -D SECURE_STORAGE_ENABLE
Error message:
CryptoPkg/Library/OpensslLib/openssl/crypto/rand/drbg_lib.c:1009:12:
error: ‘+nofp’ feature
From: Pierre Gondois
These patches were only compile tested:
- [1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag
- [2/5] Platform/StandaloneMm: Remove '-march=armv8-a+nofp' flag
but as described in the commit message of [1/5], I was told the
flag was not necessary anymore.
Building
On Tue, Jan 24, 2023 at 05:34:11PM +0100, Ard Biesheuvel wrote:
> We recently experienced some build breakage in one of the ArmVirtPkg
> platforms that is not covered by PlatformCI, in the PrePi component
> which replaces the entire PEI stage. This component is now also being
> used in TDVF, and
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2928
commit 17bd834eb5fd ("BaseTools: Factorize GCC flags")
makes GCC48_ALL_CC_FLAGS inherit from GCC_ALL_CC_FLAGS.
GCC_ALL_CC_FLAGS contains the '-Os' flag.
The latest flag in a command line overrides the previous
On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote:
> Exactly. And my Fedora kernel has those bits enabled by default.
>
> So I suppose the way forward here is to expose this protocol only on
> OVMF builds that target SEV-SNP, instead of introducing it as a
> generic CoCo feature.
On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote:
> On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote:
> > Add PlatformAddHobCB() callback function for use with
> > PlatformScanE820(). It adds HOBs for high memory and reservations (low
> > memory is handled elsewhere because there
On Tue, 24 Jan 2023 at 23:42, Lendacky, Thomas via groups.io
wrote:
>
> On 1/16/23 04:28, Gerd Hoffmann via groups.io wrote:
> > On Fri, Jan 13, 2023 at 10:34:15AM -0800, Dave Hansen wrote:
> >> On 1/13/23 10:23, Dionna Glaze via groups.io wrote:
> However, *NONE* of this points me in the
On Mon, Jan 23, 2023 at 12:08 AM, PierreGondois wrote:
>
> forms have the same library missing:
> - Platform/Hisilicon/D03/D03.dsc
> - Platform/Hisilicon/D06/D06.dsc
> - Platform/Hisilicon/HiKey960/HiKey960.dsc
> - Platform/Hisilicon/HiKey/HiKey.dsc
>
> If the library definition is done in
61 matches
Mail list logo
