[AMD Official Use Only - General]
Hi Nickle,
One comment to the new added function.
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 1, 2023 10:09 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject:
On Tue, Feb 21, 2023 at 09:29:06PM +0800, Chai, Evan wrote:
> From: "Chai, Evan"
>
> RiscVSetSupervisorAddressTranslationRegister() should be moved out from
> RiscVCpuLib since it had been merged to MdePkg/Include/Library/BaseLib.h,
> to avoid a multiple definition problem in building.
>
>
On Thu, Mar 02, 2023 at 09:26:49AM +0800, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4238
>
> Per SDM, DisplayFamily = Extended_Family_ID + Family_ID.
> Correct the related code.
Acked-by: Gerd Hoffmann
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Thank yo very much!, Liming.
On 01/03/23 20:17, gaoliming via groups.io wrote:
Sunil:
PR https://github.com/tianocore/edk2/pull/4084 has been created for this
patch.
Thanks
Liming
-邮件原件-
发件人: devel@edk2.groups.io 代表 Sunil V L
发送时间: 2023年2月28日 14:47
收件人: devel@edk2.groups.io;
Hi,
Thanks for your review.
In principle you’re right about exceptions/interrupts not being different… but
in practice their numerical values are disjoint, which makes handling them the
same way be awkward (not impossible, but let’s not do a linear search on
exception entry!).
Interrupts are
On Wed, Mar 1, 2023 at 8:59 PM Tuan Phan via groups.io wrote:
>
>
> On Thu, Feb 23, 2023 at 3:55 PM Andrei Warkentin <
> andrei.warken...@intel.com> wrote:
>
>> RegisterCpuInterruptHandler did not allow setting
>> exception handlers for anything beyond the timer IRQ.
>> Beyond that, it didn't
On Thu, Feb 23, 2023 at 3:55 PM Andrei Warkentin
wrote:
> RegisterCpuInterruptHandler did not allow setting
> exception handlers for anything beyond the timer IRQ.
> Beyond that, it didn't meet the spec around handling
> of inputs.
>
> RiscVSupervisorModeTrapHandler now will invoke
> set
*Reminder: TianoCore Community Meeting - APAC/NAMO*
*When:*
Thursday, March 2, 2023
7:30pm to 8:30pm
(UTC-08:00) America/Los Angeles
*Where:*
Reviewed-by: Ray Ni
> -Original Message-
> From: Liu, Zhiguang
> Sent: Thursday, March 2, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Dong, Eric
> ; Ni, Ray ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly
>
> REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4238
Per SDM, DisplayFamily = Extended_Family_ID + Family_ID.
Correct the related code.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Zhiguang Liu
---
UefiCpuPkg/Application/Cpuid/Cpuid.c
Hi Ben,
On the x86 side we developed the MinPlatformPkg to help mitigate this problem.
As Andrew points out the edk2 build system is extremely flexible… to the point
that it can become unwieldy and difficult to get started. For that reason, our
Minimum Platform
On Wed, 1 Mar 2023 at 19:19, Rebecca Cran wrote:
>
> Add a .editorconfig file which editors can use for basic formatting
> details of files, such as tabs/spaces, line endings etc.
>
> Signed-off-by: Rebecca Cran
Reviewed-by: Ard Biesheuvel
Thanks!
> ---
> .editorconfig | 31
On Wed, 1 Mar 2023 at 21:43, Taylor Beebe wrote:
>
>
>
> On 2/11/2023 2:05 AM, Ard Biesheuvel wrote:
> > On Sat, 11 Feb 2023 at 01:56, Taylor Beebe wrote:
> >>
> >> Hey Ard,
> >>
> >> Once the Memory Attribute Protocol is made available, Windows will have
> >> some expectations about its
On 2/11/2023 2:05 AM, Ard Biesheuvel wrote:
On Sat, 11 Feb 2023 at 01:56, Taylor Beebe wrote:
Hey Ard,
Once the Memory Attribute Protocol is made available, Windows will have
some expectations about its functionality. Can you run this test app
created by me and Jiewen to ensure it meets
Signed-off-by: Graeme Gregory
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index da1c98638ddc..747191366070 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -361,7 +361,7 @@ F: Platform/Qemu/SbsaQemu/
F:
Hello everyone,
Submitted for the community to evaluate and provide any feedback. We are
looking to move to GitHub Security Reporting and Security advisories. This
makes some minor changes to the Security reporting process and a big shift for
the Security advisories. Please take a moment to
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Rebecca Cran
> Sent: Wednesday, March 1, 2023 10:07 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Rebecca Cran
> Subject: [PATCH edk2-libc 1/1] Update my email address in Maintainers.txt
>
> My nuviainc.com email
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Graeme Gregory
> Sent: Wednesday, March 1, 2023 10:43 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> quic_llind...@quicinc.com; Graeme Gregory
> Subject: [PATCH edk2-platforms 1/1] Maintainers.txt : update email
Add a .editorconfig file which editors can use for basic formatting
details of files, such as tabs/spaces, line endings etc.
Signed-off-by: Rebecca Cran
---
.editorconfig | 31
1 file changed, 31 insertions(+)
diff --git a/.editorconfig b/.editorconfig
new file mode 100644
My nuviainc.com email address no longer works, so switch to my
bsdio.com address.
Signed-off-by: Rebecca Cran
---
Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index d0419be1a806..c262b2f17236 100644
---
Thanks... let me go a different route.
I'll have 1 more variant that can be used in classical SEC and PEI - only
capable of output (input doesn't matter) and rename the one I already shared.
I'll name these SecPeiSerialPortLibRiscVSbi and PrePiDxeSerialPortLibRiscVSbi,
respectively.
Does
If a dependency on MdePkg\Include\Library\ BaseRiscVSbiLib.h and SBI services
assumed memory is available
and code loaded is loaded into RAM and not XIP, then BASE is ok for this
component.
You may want to make sure the library class header file and INF file header for
BaseRiscVSbiLib
Hi Michael,
What module type should I use instead? The reason being this SerialPortLib
implementation specifically fits into the class of UEFI implementations, where
RAM is always available (initialized by something else prior to Tiano) and
non-const globals can be used (e.g. PrePi).
A
Using a global is not compatible with XIP code where only const globals are
supported.
A module of type BASE is considered compatible with XIP components.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
> Sent: Wednesday, March 1, 2023 1:07 AM
> To:
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Tuesday, February 28, 2023 10:37 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric
> Subject: [PATCH v1]
*Reminder: TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, March 2, 2023
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |
Sunil:
PR https://github.com/tianocore/edk2/pull/4084 has been created for this
patch.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sunil V L
> 发送时间: 2023年2月28日 14:47
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: 'Andrei Warkentin' ; 'Ard Biesheuvel'
> ; 'Jiewen
Add Computer System schema version 1.17.0
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../v1_17_0/Common/ComputerSystemCommon.c | 1636 +
.../v1_17_0/Common/ComputerSystemCommon.h | 29 +
.../v1_17_0/Dxe/ComputerSystemDxe.c
- Add latest BIOS schema version 1.2.0
- Follow early fix in Bios.V1_0_9.c and add fix to Bios.V1_2_0.c
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../src/Bios/Bios.V1_2_0/Bios.V1_2_0.c| 1341 +
- Add new interface GetPendingSettings() to check and see if
"Redfish.Settings" is in the JSON data or not. If "Redfish.Settings"
is found, return the URI and the context to Redfish pending settings.
- Fix missing FreePool() and uncrustify issues.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc:
Add BIOS feature driver version 1.2.0 and Computer System feature
driver version 1.17.0. Move the function of handling
"@Redfish.Settings" to RedfishFeatureUtilityLib because it is called
multiple times in different feature drivers. The missing of FreePool()
calls are fixed together.
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, March 2, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 1, 2023 9:16 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v2 1/1] RedfishClientPkg: Add
Thanks for your review, Abner. Version 2 patch is sent. I also fixed uncrustify
issue together.
Regards,
Nickle
-Original Message-
From: Chang, Abner
Sent: Thursday, February 16, 2023 8:56 PM
To: Nickle Wang ; devel@edk2.groups.io
Cc: Igor Kulchytskyy ; Nick Ramirez
Subject: RE:
When system configuration is updated from RESTful interface, we need a
system reboot so that the changes can be applied. Introduce PCD
"PcdSystemRebootRequired" to RedfishClientPkg. RedfishFeatureUtility
library will enable this flag when system config is updated.
RedfishFeatureCore driver will
On Wed, Mar 01, 2023 at 08:50:38AM +, Warkentin, Andrei wrote:
> The library caller could call Poll() first,
Ah, Poll is part of the library API, not just an internal helper.
Ok, makes sense then.
series:
Acked-by: Gerd Hoffmann
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
The library caller could call Poll() first, then call Read(), and the
expectation is the char won't be lost. SBI doesn't have a poll call itself, so
best you could do is read and stash. So you have to stash it globally. And read
must use the stashed char, if it exists, before requesting more
Hi,
> + while ((Index < NumberOfBytes) && SerialPortPoll ()) {
> +Buffer[Index++] = (UINT8)mLastGetChar;
> +mLastGetChar= -1;
> + }
Why do you use a global variable to pass the character? SerialPortPoll
could just return it directly ...
take care,
Gerd
38 matches
Mail list logo
