Abdul,
What prevents you implementing the OVMF version MmSaveStateLib?
Or I assume OVMF is emulating AMD CPU, why AMD version MmSaveStateLib cannot
support OVMF?
Thanks,
Ray
From: Attar, AbdulLateef (Abdul Lateef)
Sent: Tuesday, April 18, 2023 1:22 PM
To: Ni, Ray ; devel@edk2.groups.io;
Hi Ray,
Many thanks for your feedback.
Yes, but it is just for Boot Options that are automatically created by
BDS. If users/OS input 2, 3, 4 … boot options without option data
(mBmAutoCreateBootOptionGuid), the RefreshAllBootOptions() API should
not modify/delete them, right? Users will be
[AMD Official Use Only - General]
Hi Maintainers,
Please review this.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Sunday, April 2, 2023 9:52 AM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Liming Gao
> ;
[AMD Official Use Only - General]
Hi Maintainers,
Please review this.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Sunday, April 2, 2023 9:57 AM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Liming Gao
> ;
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, April 18, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
RefreshAllBootOptions() API internally can keep an ordering rule so that
platform-level-higher-priority boot options are before
those platform-level-lower-priority options.
So, that means, you could only change RefreshAllOptions() implementation to
control the order without adding a new API.
*Tools, CI, Code base construction meeting series*
*When:*
Monday, April 17, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1868164 )
*Description:*
TianoCore
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, April 17, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1868164 )
*Description:*
With the current ASM_FUNC() macro, there is no good way to declare an
alignment constraint for a function. As ASM_FUNC() switches sections,
declaring the constraint before the macro invocation applies it to the
current location in the previous section. Declaring the constraint after
the macro
As the ASM_FUNC() macro performs a section switch, the preceding
.balign directive applies the alignment constraint to the current
location in the previous section. As the linker may not merge the
sections in-order, ArmReplaceLiveTranslationEntry() may be left
unaligned.
Replace the explicit
On Mon, 17 Apr 2023 at 21:52, Leif Lindholm wrote:
>
> Hi Marvin,
>
> First of all - many thanks for tracking down the bug that creates the
> need for this.
>
> On Mon, Apr 17, 2023 at 18:09:15 +, Marvin Häuser wrote:
> > With the current ASM_FUNC() macro, there is no good way to declare an
On Mon, Apr 17, 2023 at 18:09:16 +, Marvin Häuser wrote:
> As the ASM_FUNC() macro performs a section switch, the preceding
> .balign directive applies the alignment constraint to the current
> location in the previous section. As the linker may not merge the
> sections in-order,
Hi Marvin,
First of all - many thanks for tracking down the bug that creates the
need for this.
On Mon, Apr 17, 2023 at 18:09:15 +, Marvin Häuser wrote:
> With the current ASM_FUNC() macro, there is no good way to declare an
> alignment constraint for a function. As ASM_FUNC() switches
As the ASM_FUNC() macro performs a section switch, the preceding
.balign directive applies the alignment constraint to the current
location in the previous section. As the linker may not merge the
sections in-order, ArmReplaceLiveTranslationEntry() may be left
unaligned.
Replace the explicit
With the current ASM_FUNC() macro, there is no good way to declare an
alignment constraint for a function. As ASM_FUNC() switches sections,
declaring the constraint before the macro invocation applies it to the
current location in the previous section. Declaring the constraint after
the macro
Hi Wang,
Thanks for this point, you're right. It's a redundant change and I will update
in v2 patches, but the second change is necessary. How do you think about that?
Thanks,
Minh Nguyen
-Original Message-
From: Nickle Wang
Sent: Friday, April 14, 2023 4:04 PM
To: Minh Nguyen OS ;
Hi Wang,
Thanks for this point, you're right. It's a redundant change and I will update
in v2 patches, but the second change is necessary. How do you think about that?
Thanks,
Minh Nguyen
-Original Message-
From: Nickle Wang
Sent: Friday, April 14, 2023 4:04 PM
To: Minh Nguyen OS ;
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Vu Nguyen
When a MAC address matching interface is found, a RestEx child will be
created to provide the Redfish communication on that interface.
Currently, It will try to locate all RestEx binding services and choose
the first satisfied instance without taking care about current selected
From: Vu Nguyen
This change also fix miscellaneous errors on condition checking and
debug argument missing.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
This patchset adds necessary changes for RedfishPkg to avoid
some unexpected cases and fix compilation.
Nhi Pham (1):
RedfishPkg: Add missing newline character
Vu Nguyen (4):
RedfishPkg: Correct variable type to prevent memory corruption
RedfishPkg: Prevent assertion of allocate zero
[AMD Official Use Only - General]
Hi @Ard Biesheuvel , @Leif Lindholm, @Michael D Kinney,
I had renamed the folder from MinBoardPkg to AmdMinBoardPkg, could you
please review it.
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via
[AMD Official Use Only - General]
Thanks for review comment, will update accordingly.
-Original Message-
From: Ni, Ray
Sent: 11 April 2023 13:21
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc: Grimes, Paul ; Kirkendall, Garrett
; Chang, Abner ; Dong, Eric
; Kumar,
[AMD Official Use Only - General]
Hi Abner,
I think EDK2 uses the below naming convention for variables which are
acronyms.
First letter is capitalized, and rest all are smaller.
Its better to rename below variables from I2C to
I2c.
-Original Message-
From: Chang, Abner
Sent:
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Saturday, April 15, 2023 5:27 PM
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Saturday, April 15, 2023 5:27 PM
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH
On Mon, 2023-04-17 at 14:14 +0200, Gerd Hoffmann wrote:
> On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin Köhne wrote:
> > It's much easier to create configuration dependend ACPI tables for
> > bhyve
> > than for OVMF. For this reason, don't use the statically created
> > ACPI
> > tables provided
It's much easier to create configuration dependend ACPI tables for bhyve
than for OVMF. For this reason, don't use the statically created ACPI
tables provided by OVMF. Instead prefer the dynamically created ACPI
tables of bhyve. If bhyve provides no ACPI tables or we are unable to
detect those,
|||Reviewed-by: Tinh Nguyen |
On 4/17/2023 7:55 PM, abner.ch...@amd.com wrote:
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +-
> Hi Gerd,
>
> thanks for your reply. It's mostly the same code. Only the start and
> end of the scanned range differ. So, it does make sense to share the
> same implementation.
> Where's the right place for this shared implementation? Is it
> "OvmfPkg/Library"?
Yes.
take care,
Gerd
On 4/17/23 5:03 AM, Gerd Hoffmann wrote:
Does it make sense to have a separate prefix for each gcc variant?
I guess it makes sense for the existing GCC5 and GCC4x configs for
backward compatibility reasons, but for the new GCC / GCCNOLTO variants
not so much.
I think I'd prefer to add the new
On 4/17/23 4:17 AM, Gerd Hoffmann wrote:
On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote:
Sorry for not commenting on this earlier.
Would it be better to have people use the build `--pcd` option instead? e.g.
build
For older FVPs (without support for RME extension) the top 16MB of
DRAM1 is reserved as Trusted DRAM. However, the latest FVP Base RevC
AEM Model [1] has support for RME extension. When RME extension is
present the top 64MB of DRAM1 (i.e. at the top of the 32bit address
space) is carved out for
[AMD Official Use Only - General]
Sure, I fixed it. Please check V2
Thanks
Abner
> -Original Message-
> From: Tinh Nguyen
> Sent: Monday, April 17, 2023 6:40 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Nickle Wang
> Subject:
From: Abner Chang
Add AARCH64 support in Manageability.dsc
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
Reviewed-by: Abdul Lateef Attar
Reviewed-by: Tinh Nguyen
---
.../ManageabilityPkg/Include/Dsc/Manageability.dsc| 11 +--
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +-
.../BaseManageabilityTransportHelper.inf | 2 +-
.../BaseManageabilityTransportHelper.c
From: Abner Chang
Remove duplicate library instance in [LibraryClass]
section.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
Reviewed-by: Abdul Lateef Attar
Reviewed-by: Tinh Nguyen
---
Hi Mike,
Have been thinking on this (and been on holiday last week).
On Thu, Apr 06, 2023 at 16:28:57 +, Michael D Kinney wrote:
> I am not sure. The current contributors agreement has support for code and
> documentation.
>
> The specific sections on documents are:
> *
>
On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin Köhne wrote:
> It's much easier to create configuration dependend ACPI tables for bhyve
> than for OVMF. For this reason, don't use the statically created ACPI
> tables provided by OVMF. Instead prefer the dynamically created ACPI
> tables of bhyve.
On 4/17/23 5:46 AM, Corvin Köhne wrote:
+
+/**
+ Get the address of bhyve's ACPI Root System Description Pointer (RSDP).
+
+ @param RsdpPtr Return pointer to RSDP.
+
+ @return EFI_SUCCESS Bhyve's RSDP successfully found.
+ @return EFI_NOT_FOUND Couldn't find
On Mon, Apr 17, 2023 at 05:56:37 +, Attar, AbdulLateef (Abdul Lateef) wrote:
> [AMD Official Use Only - General]
>
> Hi @Ard Biesheuvel , @Leif Lindholm, @Michael D Kinney,
> I had renamed the folder from MinBoardPkg to AmdMinBoardPkg, could
> you please review it.
Ah, sorry, didn't
Hello Nick,
CalculateCrc16 function has already defined in
edk2-platforms/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h
and edk2/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c.
This patch adds another CalculateCrc16 declaration.
There was an attempt to unify
On Sun, Apr 16, 2023 at 11:05:19AM -0600, Rebecca Cran wrote:
> Update the toolchain definitions:
>
> - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
> CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
> and IA32.
ARM not working for me in the cross
> +DEFINE GCCNOLTO_IA32_PREFIX= ENV(GCCNOLTO_BIN)
> +DEFINE GCCNOLTO_X64_PREFIX = ENV(GCCNOLTO_BIN)
> +
> DEFINE GCC5_IA32_PREFIX= ENV(GCC5_BIN)
> DEFINE GCC5_X64_PREFIX = ENV(GCC5_BIN)
> +DEFINE GCC_IA32_PREFIX = ENV(GCC_BIN)
> +DEFINE GCC_X64_PREFIX =
Reviewed-by: Tinh Nguyen
On 15/04/2023 18:57, abner.ch...@amd.com wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
From: Abner Chang
Add AARCH64 support in
Hi Abner,
Please assist me in changing the email address to
tinhngu...@os.amperecomputing.com.
Reviewed-by: Tinh Nguyen
On 15/04/2023 18:57, abner.ch...@amd.com wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and
On Thu, Apr 13, 2023 at 08:38:24AM +, Chai, Evan wrote:
> Hi Sunil,
>Sorry to remind, do we need one more reviewer for it? Or you can help to
> merge it now?
>
Merged.
Thanks,
Sunil
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote:
> Sorry for not commenting on this earlier.
>
> Would it be better to have people use the build `--pcd` option instead? e.g.
> build
> --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302".
Possible, but
On Fri, Apr 14, 2023 at 04:39:23PM -0500, Tom Lendacky wrote:
> On 4/14/23 15:23, Tom Lendacky wrote:
> > I've been trying to debug a problem I'm seeing when I moved to the GCC 12
> > compiler. Under SEV it results in the guest crashing.
>
> False alarm, I was on the wrong branch that does not
Add a driver for the virtio serial device.
The virtio serial device also known as virtio console device because
initially it had only support for a single tty, intended to be used as
console. Support for multiple streams and named data ports has been
added later on.
The driver supports tty
In case a virtio-serial device is present in the system register the
first serial port as console.
Signed-off-by: Gerd Hoffmann
---
.../PlatformBootManagerLib/BdsPlatform.c | 47 +++
1 file changed, 47 insertions(+)
diff --git
Add the driver to the ovmf builds.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Microvm/MicrovmX64.dsc | 1 +
OvmfPkg/OvmfPkgIa32.dsc| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
OvmfPkg/OvmfPkgX64.dsc | 1 +
OvmfPkg/Microvm/MicrovmX64.fdf | 1 +
OvmfPkg/OvmfPkgIa32.fdf| 1 +
Gerd Hoffmann (4):
OvmfPkg: add IndustryStandard/VirtioSerial.h
OvmfPkg/VirtioSerialDxe: add driver
OvmfPkg/VirtioSerialDxe: wire up in OvmfPkg*
OvmfPkg/PlatformBootManagerLib: setup virtio serial console
OvmfPkg/Microvm/MicrovmX64.dsc| 1 +
OvmfPkg/OvmfPkgIa32.dsc
Add header files with structs and defines for the virtio serial device.
The virtio serial device also known as virtio console device because
initially it had only support for a single tty, intended to be used as
console. Support for multiple streams and named data ports has been
added later on.
56 matches
Mail list logo
