Re: [edk2-devel] [edk2-platforms][PATCH V2 08/14] ManageabilityPkg: Add MCTP manageability header file

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 08/14] Manageabil

Re: [edk2-devel] [edk2-platforms][PATCH V2 07/14] ManageabilityPkg: Add definitions of MCTP

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 07/14] Manageabil

Re: [edk2-devel] [edk2-platforms][PATCH V2 06/14] ManageabilityPkg/KCS: KCS transport interface

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 06/14] Manageabil

Re: [edk2-devel] [edk2-platforms][PATCH V2 05/14] ManageabilityPkg: Add PldmSmbiosTransferDxe driver

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 05/14] Manageabil

Re: [edk2-devel] [edk2-platforms][PATCH V2 04/14] ManageabilityPkg: Add PldmProtocolLib

Please find my comment inline below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 04/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 03/14] ManageabilityPkg: Add HeaderSize and TrailerSize

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 03/14] Manageabil

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 02/14] Manageabil

Re: [edk2-devel] [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: Add more helper functions

Hi Abner, Please find my comments below. Thanks, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 01

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

Hi Abner, I have some inline comments below On 18/04/2023 14:15, Chang, Abner via groups.io wrote: From: Abner Chang Update GetTransportCapability to support Maximum Transfer Unit (MTU) of transport interface. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wan

Re: [edk2-devel] [edk2-platforms][PATCH V2 14/14] ManageabilityPkg: Add Manageability FDFs

Reviewed-by: Tinh Nguyen On 18/04/2023 14:15, abner.ch...@amd.com wrote: From: Abner Chang Add FDF include files for build in ManageabilityPkg modules to firmware device. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguye

Re: [edk2-devel] [edk2-platforms][PATCH V2 13/14] ManageabilityPkg: Relocate Manageability.dsc

Reviewed-by: Tinh Nguyen On 18/04/2023 14:15, abner.ch...@amd.com wrote: From: Abner Chang Relocate Manageability.dsc to just under \Include folder. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen --- Features/Mana

Re: [edk2-devel] [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add Manageability PCDs

Reviewed-by: Tinh Nguyen On 18/04/2023 14:15, abner.ch...@amd.com wrote: From: Abner Chang Add PCDs to control ManageabilityPkg modules. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen --- Features/ManageabilityP

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

>-Original Message- >From: Kinney, Michael D >Sent: Thursday, April 20, 2023 5:04 AM >To: Lin, Benny ; devel@edk2.groups.io >Cc: Gao, Liming ; Liu, Zhiguang >; Pedro Falcato ; Kinney, >Michael D >Subject: RE: [PATCH v3 2/3] MdePkg: Support FDT library. > >Responses below > >Mike > >>

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action

Hi Min, This SEI test passes: SecureBoot - TestImage2.bin in Image Execution Info Table with SIG_NOT_FOUND. -- PASS 00C3C2F2-39D5-4D35-B7E7-587CA0F3CB75 SctPkg/TestCase/UEFI/EFI/RuntimeServices/SecureBoot/BlackBoxTest/ImageLoadingBBTest.c:1103:Status - Success The test image binary is diffe

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM Base definitions

[AMD Official Use Only - General] Hi Mike and liming, Here are two PRs for PLDM related C header files, which are all passed CI. Please help to push it to master branch. https://github.com/tianocore/edk2/pull/4287 https://github.com/tianocore/edk2/pull/4288 Thanks Abner > -Original Message

Re: [edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

Hi Qi1 and Jiewen Could you help to review this patch ? Thanks. From: Linus Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4408 Change-Id: I3c4b466ef318766d6d70c9f73e36b94b5f10832c Cc: Jiewen Yao Cc: Maggie Chu Signed-off-by: Linus Liu --- SecurityPkg/HddPassword/HddPasswordDxe.c

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

Hi Rebecca, ECM and NCM will be enable when move the UsbNetworkPkg to MdeModulePkg\Bus\Usb\UsbNetwork. About rate limiting. We have test it X86 system. It will be slow to PXE boot. Do you think this PCD should be enabled by default? Thanks, Richard -Original Message- From: Rebecca Cran

Re: [edk2-devel] [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface

[AMD Official Use Only - General] Hi Minh, Is this the first time you send email to groups.io, if yes please also check it with Miki miki.deme...@intel.com to confirm is your mail passed through groups.io or not. Thanks Abner Get Outlook for Android ___

Re: [edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

[AMD Official Use Only - General] Hi Igor, I have no problem with this change, however some upstream practices here, - Please shorten the subject to <= 76 - Each line in the commit message should be <=76 You can run Patchcheck.py (here: BaseTools\Scripts) before you sending out the patches. Ple

Re: [edk2-devel] [PATCH v1 1/2] Add the volatile keyword to NvmExpressDxe's Passthru CQs and SQs.

If it's to copy from hw to sw memory, why do we need volatile? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oliver > Smith-Denny > Sent: Thursday, April 20, 2023 7:41 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Wang, > Jian J ; Gao, Liming ; >

Re: [edk2-devel] [PATCH v2 0/6] RISC-V MMU support

Hi Andrei, Here you go: https://github.com/pttuan/edk2/tree/tphan/riscv_mmu Will put the link in the cover letter next round. From: devel@edk2.groups.io on behalf of Andrei Warkentin Date: Tuesday, April 18, 2023 at 9:04 AM To: Tuan Phan , devel@edk2.groups.io Cc: Kinney, Michael D , Gao, Lim

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On Wed, Apr 19, 2023 at 10:55 PM Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 22:10, Marvin Häuser wrote: > > > > > > > On 19. Apr 2023, at 21:48, Ard Biesheuvel wrote: > > > > > > The issue is likely caused by > > > > > > -Wl,--defsym=PECOFF_HEADER_SIZE=0 > > > > > > Why are you setting tha

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On 19. Apr 2023, at 23:55, Ard Biesheuvel wrote:On Wed, 19 Apr 2023 at 22:10, Marvin Häuser wrote:On 19. Apr 2023, at 21:48, Ard Biesheuvel wrote:The issue is likely caused by-Wl,--defsym=PECOFF_HEADER_SIZE=0Why are you setting that? It breaks the ELF to PE conversion.Where?It would, but you on

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On Wed, 19 Apr 2023 at 22:10, Marvin Häuser wrote: > > > > On 19. Apr 2023, at 21:48, Ard Biesheuvel wrote: > > > > The issue is likely caused by > > > > -Wl,--defsym=PECOFF_HEADER_SIZE=0 > > > > Why are you setting that? It breaks the ELF to PE conversion. > > Where? It would, but you only appe

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

> On 19. Apr 2023, at 22:10, Marvin Häuser wrote: > >  >> On 19. Apr 2023, at 21:48, Ard Biesheuvel wrote: >> >> The issue is likely caused by >> >> -Wl,--defsym=PECOFF_HEADER_SIZE=0 >> >> Why are you setting that? It breaks the ELF to PE conversion. > > Where? AUDK doesn’t use that macr

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

Responses below Mike > -Original Message- > From: Lin, Benny > Sent: Wednesday, April 19, 2023 10:12 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Pedro Falcato > Subject: RE: [PATCH v3 2/3] MdePkg: Support FDT library. > > Please find my feed

Re: [edk2-devel] [PATCH v3 0/5] Introduce EDKII Redfish Platform Config Protocol

Full PATCH reviewed Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Wednesday, April 19, 2023 5:09 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v3 0/5] Introduce EDKII Redfish Platform Config Protocol

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

> On 19. Apr 2023, at 21:48, Ard Biesheuvel wrote: > > The issue is likely caused by > > -Wl,--defsym=PECOFF_HEADER_SIZE=0 > > Why are you setting that? It breaks the ELF to PE conversion. Where? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Rep

[edk2-devel] [PATCH v4 13/13] BaseTools/Conf/tools_def.template: Bump VERSION to 3.00

Bump VERSION to 3.00 and explain the changes made to the toolchains. Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index a2fb3fcd99

[edk2-devel] [PATCH v4 12/13] BaseTools/Conf/tools_def.template: Add section for deprecated toolchains

In order to make it clear for anyone reading tools_def.template, add a section for deprecated tool chains and move GCC48, GCC49 and GCC5 into it. Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(

[edk2-devel] [PATCH v4 11/13] BaseTools: Add a deprecation warning for GCC48,GCC49,GCC5 to build.py

The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming months. Inform users that they're deprecated and tell them what replaces them. Signed-off-by: Rebecca Cran --- BaseTools/Source/Python/build/build.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/BaseTools/S

[edk2-devel] [PATCH v4 10/13] BaseTools: Only call LoadConfiguration once in build.py

Avoid calling LoadConfiguration twice, in both InitPreBuild and InitBuild. Since InitPreBuild is called first, delete the second call from InitBuild. Signed-off-by: Rebecca Cran --- BaseTools/Source/Python/build/build.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Base

[edk2-devel] [PATCH v4 09/13] BaseTools/Conf/tools_def.template: Add GCC and GCCNOLTO toolchains

Add a 'GCC' toolchain that's a copy of the existing GCC5 definition. Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC48 toolchain. Signed-off-by: Rebecca Cran --- UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 ++ IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc |

[edk2-devel] [PATCH v4 08/13] BaseTools: Update VS toolchain descriptions in tools_def.txt.template

Update the Visual Studio toolchain descriptions in tools_def.txt.template: - The WinDDK is no longer needed. - Update 3 is required for VS 2015. - VS 2005 has been removed. Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 7 ++- 1 file changed, 2 insertions(+), 5 deletion

[edk2-devel] [PATCH v4 07/13] BaseTools: Remove EBC (EFI Byte Code) compiler definitions

The edk2-stable202302 release was the last to support building EFI Byte Code drivers. Since the Intel EFI Byte Code Compiler is no longer available, a decision has been made to remove support for EBC from edk2. Remove the definitions for Intel's EBC compiler from Conf/tools_def.template. Signed-o

[edk2-devel] [PATCH v4 06/13] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs

Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions from Conf/tools_def.template. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- BaseTools/Conf/tools_def.template | 4 1 file changed, 4 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTo

[edk2-devel] [PATCH v4 05/13] edksetup.bat: Remove VS2008-VS2013 remnants

Since Visual Studio versions older than VS2015 are no longer supported, remove mention of them from edksetup.bat. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- edksetup.bat | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/edksetup.bat b/edksetup.bat ind

[edk2-devel] [PATCH v4 04/13] MdePkg: Remove VS2008-VS2013 remnants

Since Visual Studio versions older than VS2015 are no longer supported, remove mention of them from MdePkg. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- MdePkg/Include/Ia32/ProcessorBind.h | 8 ++-- MdePkg/Include/X64/ProcessorBind.h | 8 ++-- 2 files changed, 4 inse

[edk2-devel] [PATCH v4 02/13] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions

With recent changes, Visual Studio versions older than VS2015 are unable to build EDK2 code. To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain definitions from Conf/tools_def.template, leaving only versions that can be used to successfully build firmware. Signed-off-by: Rebecca Cra

[edk2-devel] [PATCH v4 03/13] BaseTools: Remove VS2008-VS2013 remnants

Remove remnants of Visual Studio 2008-2013 support from Conf/tools_def.txt and various batch scripts. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- BaseTools/Conf/tools_def.template | 12 BaseTools/Scripts/SetVisualStudio.bat | 22 +- BaseT

[edk2-devel] [PATCH v4 01/13] BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38 toolchains

Update the CLANGDWARF toolchain definition in tools_def.template with the settings from CLANG38, and delete the CLANG35 and CLANG38 toolchains. The CLANG35 and CLANG38 toolchains were added for compatibility with ARM's proprietary clang-based toolchain. Things have since moved on, and with the lat

[edk2-devel] [PATCH v4 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF

Update the toolchain definitions: - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 and IA32. - Mark GCC48, GCC49 and GCC5 as deprecated. - Add GCC and GCCNOLTO toolchain definitions. - Remove VS2008, VS

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On Wed, 19 Apr 2023 at 20:32, Marvin Häuser wrote: > > > On 19. Apr 2023, at 20:26, Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 20:25, Marvin Häuser wrote: > > > > On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: > > Your branch seems to be missing 16e0969ef775b898ac700f3261d76030b8ab9ef0

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

> On 19. Apr 2023, at 20:26, Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 20:25, Marvin Häuser wrote: >> >> >> On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: >> >> Your branch seems to be missing 16e0969ef775b898ac700f3261d76030b8ab9ef0 >> >> "ArmVirtPkg/ArmVirtQemu: Use PEI flavor o

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On Wed, 19 Apr 2023 at 20:25, Marvin Häuser wrote: > > > On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: > > Your branch seems to be missing 16e0969ef775b898ac700f3261d76030b8ab9ef0 > > "ArmVirtPkg/ArmVirtQemu: Use PEI flavor of ArmMmuLib for all PEIMs" > > > That's correct (because that commit

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

> On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: > > Your branch seems to be missing 16e0969ef775b898ac700f3261d76030b8ab9ef0 > > "ArmVirtPkg/ArmVirtQemu: Use PEI flavor of ArmMmuLib for all PEIMs" That's correct (because that commit is after the last commit I managed to reproduce the issue

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On Wed, 19 Apr 2023 at 19:45, Marvin Häuser wrote: > > > On 19. Apr 2023, at 19:40, Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 19:14, Marvin Häuser wrote: > > > Hi all, > > While testing Ard's suggestion for V3, I noticed I got a broken FD where > ArmReplaceLiveTranslationEntry() is misal

Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Plugin: Clarify code coverage failure message

Reviewed-by: Rebecca Cran On 4/18/23 10:11 AM, mikub...@linux.microsoft.com wrote: From: Michael Kubacki HostBasedUnitTestRunner.py is a build plugin responsible for locating and executing host-based unit tests. Recently, commit 6bb00aa introduced support for the plugin to generate code cov

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

> On 19. Apr 2023, at 19:40, Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 19:14, Marvin Häuser > wrote: >> >> Hi all, >> >> While testing Ard's suggestion for V3, I noticed I got a broken FD where >> ArmReplaceLiveTranslationEntry() is misaligned, but does not

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

On Wed, 19 Apr 2023 at 19:14, Marvin Häuser wrote: > > Hi all, > > While testing Ard's suggestion for V3, I noticed I got a broken FD where > ArmReplaceLiveTranslationEntry() is misaligned, but does not cross a 4 KB > boundary. Which platform are you building? > To not just hide the issue via

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

Please find my feedback below. We can remove FDT_RESERVE_ENTRY but keep FDT_NODE_HEADER, what do you think? QQQ Benny >-Original Message- >From: Kinney, Michael D >Sent: Wednesday, April 19, 2023 11:54 PM >To: Lin, Benny ; devel@edk2.groups.io >Cc: Gao, Liming ; Liu, Zhiguang >; Pedro

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

Hi Richard, I was wondering if you'd seen my questions about ECM and NCM, and rate limiting? -- Rebecca Cran On 4/11/23 6:31 AM, Rebecca Cran wrote: Yes, you can add me as a reviewer. A couple more comments on the patches: why are ECM and NCM disabled by default? I've tested on my Jun

Re: [edk2-devel] [PATCH v3 3/3] .pytool: Support FDT library.

Reviewed-by: Michael D Kinney > -Original Message- > From: Lin, Benny > Sent: Sunday, April 16, 2023 10:35 PM > To: devel@edk2.groups.io > Cc: Lin, Benny ; Sean Brogan > ; Michael Kubacki > ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH v3 3/3] .pytool: Support FDT library. >

Re: [edk2-devel] [PATCH v3 1/3] Tianocore: Support FDT library.

Reviewed-by: Michael D Kinney > -Original Message- > From: Lin, Benny > Sent: Sunday, April 16, 2023 10:35 PM > To: devel@edk2.groups.io > Cc: Lin, Benny ; Andrew Fish ; Leif > Lindholm ; Kinney, > Michael D > Subject: [PATCH v3 1/3] Tianocore: Support FDT library. > > From: Benny Lin

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

A few comments below. Mike > -Original Message- > From: Lin, Benny > Sent: Sunday, April 16, 2023 10:35 PM > To: devel@edk2.groups.io > Cc: Lin, Benny ; Kinney, Michael D > ; Gao, Liming > ; Liu, Zhiguang ; Pedro > Falcato > Subject: [PATCH v3 2/3] MdePkg: Support FDT library. > > Fr

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM Base definitions

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, April 18, 2023 7:14 PM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Gao, Liming ; Liu, Zhiguang > ; Nickle Wang ; Igor > Kulchytskyy ; Oram

Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming via > groups.io > Sent: Tuesday, April 18, 2023 10:58 PM > To: devel@edk2.groups.io; abner.ch...@amd.com > Cc: Kinney, Michael D ; Liu, Zhiguang > ; 'Nickle Wang' > ; 'Igor Kulchytsk

[edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

gRedfishDiscoveredToken may be allocated several times, if multiple NIC installed on the system. To avoid this issue Discover Token related global variables replaced with the local variables. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishConfigHandler/Re

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

Ray, I am suggesting that only the lib class be defined in MdePkg. Lib instance can remain in UefiCpuPkg. Mike From: Ni, Ray Sent: Tuesday, April 18, 2023 11:01 PM To: Kinney, Michael D ; devel@edk2.groups.io; Wang, Jian J ; Tan, Dun Cc: Gao, Liming ; Ard Biesheuvel Subject: RE: [edk2-deve

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

On 4/19/23 00:39, duntan via groups.io wrote: Hi Tom, This PF happened because that CR0.WP is set and DxeMemEncryptSevLib sets a part of smm page table as RO before ReadyToLock while CpuSmm driver assumes the smm page table is not marked as RO before ReadyToLock. The code flow to set smm page

Re: 回复: [ ** SPAMMAIL ** ]Re: [edk2-devel] [edk2][PATCH v2 1/1] MdeModulePkg: Add EDKII Platform Boot Manager Protocol v2

+ Leif, as the maintainer of ARM Platforms Hi Liming, I think about it, too. But like I said with Ray (in private mail) "I did not put it in PlatformBootManagerLib because this library is being generalized by Arm and not every Arm platform needs to change the BootOrder. By modifying this pr

Re: [edk2-devel] [PATCH v3 1/5] RedfishPkg: introduce EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, April 19, 2023 5:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v3 1/5] RedfishPkg: introduce > EDKII_REDFIS

[edk2-devel] [PATCH v3 5/5] RedfishPkg: Add Redfish Platform Config Protocol to RedfishPkg

Add RedfishPlatformConfigDxe driver and corresponding library to RedfishPkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishComponents.dsc.inc | 3 +++ RedfishPkg/RedfishLibs.dsc.inc | 2 ++ RedfishPkg/Red

[edk2-devel] [PATCH v3 4/5] RedfishPkg: Helper library of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

This is the helper library for using EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishPkg.dec | 5 + .../RedfishPlatformConfigLib.inf | 4

[edk2-devel] [PATCH v3 0/5] Introduce EDKII Redfish Platform Config Protocol

Introduce EDKII Redfish Platform Config Protocol and corresponding libraries. This protocol is the interface between UEFI platform configuration and Redfish property. It could handle different firmware implementation and the implementation here is to map EDK2 HII questions to the properties defin

[edk2-devel] [PATCH v3 1/5] RedfishPkg: introduce EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

EDKII Redfish Platform Config Protocol defines the protocol interfaces that abstracts the platform configuration format and storage from EDK2 Redfish Feature driver. This protocol provides the interfaces to get and set platform configuration with the format and configuration storage agnostic to the

[edk2-devel] [PATCH 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

Fix Arm CI build error: - ArmPkg/Library/CompilerIntrinsicsLib/memset.c:39:1: warning: type of ‘memset’ does not match original declaration [-Wlto-type-mismatch] MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c:123:1: note: type ‘char’ should match type ‘int’ - multiple definition of