Re: [edk2-devel] [edk2-redfish-client][PATCH] Initial edk2 redfish client repository

[AMD Official Use Only - General] Reviewed-by: Abner Chang I have no feedbacks to this patch as we had reviewed this off line. However I would like to see @Michael D Kinney's comment on it. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle > Wang via

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

[AMD Official Use Only - General] Hi Tinh, V3 patch just sent, I will wait for your feedback on my response below. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, April 21, 2023 8:51 AM > To: Tinh Nguyen ; >

[edk2-devel] [edk2-platforms][PATCH V3 14/14] ManageabilityPkg: Add Manageability FDFs

From: Abner Chang Add FDF include files for build in ManageabilityPkg modules to firmware device. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen Reviewed-by: Tinh Nguyen Reviewed-by: Nickle Wang ---

[edk2-devel] [edk2-platforms][PATCH V3 13/14] ManageabilityPkg: Relocate Manageability.dsc

From: Abner Chang Relocate Manageability.dsc to just under \Include folder. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen Reviewed-by: Tinh Nguyen Reviewed-by: Nickle Wang --- Features/ManageabilityPkg/Include/{Dsc

[edk2-devel] [edk2-platforms][PATCH V3 11/14] ManageabilityPkg/PldmProtocol: Add PLDM protocol

From: Abner Chang PldmProtocol that transmits PLDM message over manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../Include/Dsc/Manageability.dsc |

[edk2-devel] [edk2-platforms][PATCH V3 12/14] ManageabilityPkg: Add Manageability PCDs

From: Abner Chang Add PCDs to control ManageabilityPkg modules. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen Reviewed-by: Tinh Nguyen Reviewed-by: Nickle Wang --- Features/ManageabilityPkg/ManageabilityPkg.dec |

[edk2-devel] [edk2-platforms][PATCH V3 10/14] ManageabilityPkg: Add MCTP transport interface

From: Abner Chang Add MCTP manageability transport interface library. The functionality is verified by checking the binary debug output of payload. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy ---

[edk2-devel] [edk2-platforms][PATCH V3 09/14] ManageabilityPkg/MctpProtocol: Add MctpProtocol

From: Abner Chang MctpProtocol that transmits MCTP message over manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Include/Dsc/Manageability.dsc | 1 +

[edk2-devel] [edk2-platforms][PATCH V3 08/14] ManageabilityPkg: Add MCTP manageability header file

From: Abner Chang Add C header file of MCTP manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../Library/ManageabilityTransportMctpLib.h | 54 +++

[edk2-devel] [edk2-platforms][PATCH V3 07/14] ManageabilityPkg: Add definitions of MCTP

From: Abner Chang Add definitions of MCTP manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- Features/ManageabilityPkg/ManageabilityPkg.dec | 16 1

[edk2-devel] [edk2-platforms][PATCH V3 05/14] ManageabilityPkg: Add PldmSmbiosTransferDxe driver

From: Abner Chang Add edk2 driver that supports PLDM SMBIOS Transfer Specification. https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf We currently only support "Push" mode of PLDM SMBIOS transfer. That says only BIOS to BMC direction is supported. The functionality

[edk2-devel] [edk2-platforms][PATCH V3 03/14] ManageabilityPkg: Add HeaderSize and TrailerSize

From: Abner Chang Add HeaderSize and TrailerSize in MANAGEABILITY_TRANSFER_TOKEN structure. Manageability transport interface may used by multiple protocols which have different header and trailer of payload. (e.g. MCTP over KCS and IPMI over KCS). Signed-off-by: Abner Chang Cc: Isaac Oram

[edk2-devel] [edk2-platforms][PATCH V3 02/14] ManageabilityPkg: Support Maximum Transfer Unit

From: Abner Chang Update GetTransportCapability to support Maximum Transfer Unit (MTU) of transport interface. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Abdul Lateef Attar Reviewed-by: Nickle Wang ---

[edk2-devel] [edk2-platforms][PATCH V3 01/14] ManageabilityPkg: Add more helper functions

From: Abner Chang 1. Add a helper function to output payload binary to debug output device. 2. Add a helper function to split payload into packages according to maximum transfer unit of transport interface. 3. Add a helper function to generate CRC8. Signed-off-by: Abner Chang Cc:

[edk2-devel] [edk2-platforms][PATCH V3 00/14] ManageabilityPkg part II

From: Abner Chang In V3: Address comments given to V2. In V2: - Address uncrustify issues. - Use DBBUG_MANAGEABILITY_INFO to output detailed manageability information. DEBUG_INFO is used for the function entry point, while DEBUG_ERROR is used for the error situations. In part

[edk2-devel] [PATCH v5 10/10] BaseTools: remove duplicate includes: IndustryStandard/*.h

Use the MdePkg versions instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/EfiRom/EfiRom.h| 4 +- .../C/Include/IndustryStandard/Bluetooth.h| 56 -- .../C/Include/IndustryStandard/EfiPci.h | 51 --

[edk2-devel] [PATCH v5 09/10] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Reviewed-by: Chao Li --- .../C/Include/IndustryStandard/PeImage.h | 790 -- 1 file changed, 790 deletions(-) delete mode 100644

[edk2-devel] [PATCH v5 05/10] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Acked-by: Sunil V L --- .../Source/C/Include/IndustryStandard/Acpi.h | 117 --- .../C/Include/IndustryStandard/Acpi1_0.h | 285 .../C/Include/IndustryStandard/Acpi2_0.h | 520

[edk2-devel] [PATCH v5 04/10] BaseTools: remove duplicate includes: /ProcessorBind.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Reviewed-by: Chao Li --- .../Source/C/Include/AArch64/ProcessorBind.h | 148 -- .../Source/C/Include/Arm/ProcessorBind.h | 147 --

[edk2-devel] [PATCH v5 06/10] MdePkg/PeImage.h: add bits from BaseTools version

The BaseTools and MdePkg versions of PeImage.h diverged over time, add some missing bits to the MdePkg header file in preparation for removing the BaseTools version. Signed-off-by: Gerd Hoffmann --- MdePkg/Include/IndustryStandard/PeImage.h | 31 +++ 1 file changed, 31

[edk2-devel] [PATCH v5 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*

Use the newer versions of the machine #defines. Signed-off-by: Gerd Hoffmann Reviewed-by: Chao Li --- BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++--- .../C/Include/IndustryStandard/PeImage.h | 1 + BaseTools/Source/C/Common/BasePeCoff.c| 28 ++---

[edk2-devel] [PATCH v5 03/10] BaseTools: remove WinNtInclude.h

Appears to be a relic for ancient windows / compiler versions, windows builds in CI work just fine without it. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/Common/WinNtInclude.h| 66 - BaseTools/Source/C/GenFv/GenFvInternalLib.c | 1 -

[edk2-devel] [PATCH v5 07/10] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks

The #define for IMAGE_FILE_MACHINE_ARM is not present in MdePkg, this looks like a relic not used any more. Remove. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/Common/BasePeCoff.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git

[edk2-devel] [PATCH v5 01/10] BaseTools: make sure the got is empty

Add ASSERT()s that .got and .got.plt sections are empty to linker scripts for gcc and clang. Suggested-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann --- BaseTools/Scripts/ClangBase.lds | 10 ++ BaseTools/Scripts/GccBase.lds | 10 ++ 2 files changed, 20 insertions(+) diff

[edk2-devel] [PATCH v5 02/10] MdePkg: don't set visibility to hidden

Not needed any more on modern toolchains, they are better in not creating a GOT without this trick. Signed-off-by: Gerd Hoffmann --- MdePkg/Include/X64/ProcessorBind.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/MdePkg/Include/X64/ProcessorBind.h

[edk2-devel] [PATCH v5 00/10] BaseTools: remove duplicate includes.

There is alot of code duplication between BaseTools and MdePkg (and also MdeModulePkg). This patch series starts reducing this by removing some header files. BaseTools are switched over to use the include files in MdePkg instead. It also cleans up some (apparently) obsolete code and adapts

Re: [edk2-devel] [edk2-redfish-client][PATCH] Initial edk2 redfish client repository

Hi @Michael D Kinney, May I have your comment to my copyright year question? The copyright year in LICENSE file that I use is 2021 because the earliest file in RedfishClientPkg from edk2-staging is created in 2021. But since this repository is created in

[edk2-devel] [PATCH v1 2/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm: Add USB Cdc ECM devices support

This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni R: Rebecca Cran Tested-by: Tinh Nguyen Reviewed-by: Tony Lo ---

[edk2-devel] [PATCH v1 3/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm: Add USB Cdc NCM devices support

This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni R: Rebecca Cran Tested-by: Tinh Nguyen Reviewed-by: Tony Lo ---

回复: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

Gerd, Ard, Marvin: I think we all agree that this patch set is valuable to reduce the duplication header files. The current concern is that BASETOOLS macro name. This name matches Edk2 BaseTools directory. If no better name, I would suggest to keep it. And, the second request is to

[edk2-devel] [edk2-redfish-client][PATCH] Initial edk2 redfish client repository

Add required files to initial edk2 redfish client repository. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Michael D Kinney --- .gitignore | 6 + CONTRIBUTING.md | 3 +++ LICENSE | 51 ++ Maintainers.txt | 48

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

Hi Liming, I noticed the build error from this CI test: Build and Test NetworkPkg,RedfishPkg IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64. And after applying my patch, CI reports build pass. Since this CI test also cover AARCH64, RISCV64 and LOONGARCH64, I think that the failure only happens to

回复: [edk2-devel] [PATCH 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

Nickle: Is this only for MDE_CPU_ARM? I may propose to add the judgement of MDE_CPU_IA32 and MDE_CPU_X64 for memcpy & memset. memcpy & memset are for X86 only. Thanks Liming 发件人: devel@edk2.groups.io 代表 Nickle Wang via groups.io 发送时间: 2023年4月21日 8:26 收件人: devel@edk2.groups.io; Nickle

[edk2-devel] 回复: [PATCH v4 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF

Rebecca: For the whole patch set, I give the comments for 09/13. Others are good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2023年4月20日 3:58 > 收件人: devel@edk2.groups.io; Liming Gao ; > Bob Feng ; Yuwei Chen ; > Michael D Kinney ; Michael Kubacki

Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support

+ Related folk I want to let the PR for related stakeholder review it. And have any open ? https://github.com/tianocore/edk2/pull/3901 Thanks, Gua -Original Message- From: devel@edk2.groups.io On Behalf Of victorx@intel.com Sent: Tuesday, April 18, 2023 7:05 PM To:

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

Hi Mike, Thanks for bringing this good point! We would like to document that all FDT structure data are in *big endian* format and remove those SwapBytes MACROs from FdtLib.h It makes sense to handle this from library consumer side (consumer can define their own MACROs) because we cannot

[edk2-devel] 回复: [PATCH v4 09/13] BaseTools/Conf/tools_def.template: Add GCC and GCCNOLTO toolchains

Rebecca: I add my comments below. > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2023年4月20日 3:58 > 收件人: devel@edk2.groups.io; Liming Gao ; > Bob Feng ; Yuwei Chen ; > Michael D Kinney ; Michael Kubacki > ; Sean Brogan > ; Chasel Chiu ; Nate > DeSimone ; Star Zeng > ; Andrew Fish > 抄送: Rebecca

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM Base definitions

Merged Mike > -Original Message- > From: Chang, Abner > Sent: Wednesday, April 19, 2023 8:25 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Nickle Wang ; Igor > Kulchytskyy ; Oram, Isaac W ; Attar, > AbdulLateef (Abdul Lateef) > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

[AMD Official Use Only - General] > -Original Message- > From: Tinh Nguyen > Sent: Thursday, April 20, 2023 2:08 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Igor > Kulchytskyy > Subject: Re: [edk2-devel]

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

Thanks a lot! I'll update my patch set later. Thanks, Dun -Original Message- From: Tom Lendacky Sent: Thursday, April 20, 2023 11:45 PM To: devel@edk2.groups.io; Tan, Dun ; Ni, Ray Subject: Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table On

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

Hi @Jian J Wang, @Liming Gao, Could you please help me to review this patch? There is CI build error, and it blocks my pull request here: https://github.com/tianocore/edk2/pull/4285 Thanks, Nickle > -Original

Re: [edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

[AMD Official Use Only - General] Thanks Igor, You probably can ask community if any one has the similar issue on patch email format. I already gave R-B to this change, please create a PR against to edk2 and let me know the PR#. I will push it once it passes CI. Thanks Abner > -Original

Re: [edk2-devel] [PATCH V2] RedfishPkg: Remove the Discover Token global variables

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Igor Kulchytskyy > Sent: Friday, April 21, 2023 6:48 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > > Subject: [PATCH V2] RedfishPkg: Remove the Discover Token global variables >

[edk2-devel] [PATCH V2] RedfishPkg: Remove the Discover Token global variables

gRedfishDiscoveredToken may be allocated several times, if multiple NIC installed on the system. To avoid this issue Discover Token related global variables replaced with the local variables. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH] MdePkg: Add DEBUG_MANAGEABILITY print error level

Hi Abner, This seems like a reasonable additional to the debug levels. Do you intend to mix this debug level with DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO, DEBUG_VERBOSE. DEBUG_INFO | DEBUG_LOAD example:

Re: [edk2-devel] [PATCH 1/1] ArmPkg: older assemblers may lack ID_AA64ISAR2_EL1

On Thu, Apr 20, 2023 at 21:45:32 +0200, Marcin Juszkiewicz wrote: > ArmCpuInfo needs to be able to read ID_AA64ISAR2_EL1 system register. > Older toolchains do not know it. > > Same solution as one for QEMU: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg929586.html > > Signed-off-by:

[edk2-devel] [PATCH 1/1] ArmPkg: older assemblers may lack ID_AA64ISAR2_EL1

ArmCpuInfo needs to be able to read ID_AA64ISAR2_EL1 system register. Older toolchains do not know it. Same solution as one for QEMU: https://www.mail-archive.com/qemu-devel@nongnu.org/msg929586.html Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Include/Chipset/AArch64.h | 4 1 file

Re: [edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

Hi Abner, I did what you asked to do - Patchcheck.py and UncrustiyCheck (got binary). Going to send PATCH V2. But I'm not sure what happened with white space. Going to check with MIS. Thank you, Igor -Original Message- From: Chang, Abner Sent: Wednesday, April 19, 2023 9:00 PM To: Igor

Re: [edk2-devel] [PATCH v4 05/13] edksetup.bat: Remove VS2008-VS2013 remnants

On Wed, Apr 19, 2023 at 13:57:38 -0600, Rebecca Cran wrote: > Since Visual Studio versions older than VS2015 are no longer supported, > remove mention of them from edksetup.bat. > > Signed-off-by: Rebecca Cran > Reviewed-by: Oliver Smith-Denny Reviewed-by: Leif Lindholm > --- > edksetup.bat

Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

On Thu, Apr 20, 2023 at 16:44:23 +0200, Marcin Juszkiewicz wrote: > App goes through ID_AA64*_EL1 system registers and decode their values. > > Signed-off-by: Marcin Juszkiewicz For the series: Reviewed-by: Leif Lindholm After discussing with Marcin on side channel, I folded in a statement at

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

Hi Leif, What is your opinion on FDT being big endian. Do we want the lib to help with that aspect, or leave it up to the consumer of the lib to convert as needed? Seems like an area that could be very error prone if we are not careful. Mike > -Original Message- > From: Lin, Benny

Re: [edk2-devel] [PATCH v3 2/2] ArmPkg/ArmMmuLib: Fix ArmReplaceLiveTranslationEntry() alignment

On Thu, 20 Apr 2023 at 17:24, Marvin Häuser wrote: > > As the ASM_FUNC() macro performs a section switch, the preceding > .balign directive applies the alignment constraint to the current > location in the previous section. As the linker may not merge the > sections in-order,

Re: [edk2-devel] [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: Add more helper functions

[AMD Official Use Only - General] Hi Nickle, I will fix them in the next version. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Thursday, April 20, 2023 2:42 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Igor

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

On 4/20/23 04:07, duntan via groups.io wrote: Hi Tom, Thanks for confirming. Is 1G page table supported in your test? If supported, there is a reason can explain why this difference exists. In current upstream master branch: Smm code always create 2M page table for [0, 4G] range(in

[edk2-devel] [PATCH v3 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

With the current ASM_FUNC() macro, there is no good way to declare an alignment constraint for a function. As ASM_FUNC() switches sections, declaring the constraint before the macro invocation applies it to the current location in the previous section. Declaring the constraint after the macro

[edk2-devel] [PATCH v3 2/2] ArmPkg/ArmMmuLib: Fix ArmReplaceLiveTranslationEntry() alignment

As the ASM_FUNC() macro performs a section switch, the preceding .balign directive applies the alignment constraint to the current location in the previous section. As the linker may not merge the sections in-order, ArmReplaceLiveTranslationEntry() may be left unaligned. Replace the explicit

Re: [edk2-devel] [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: Add more helper functions

[AMD Official Use Only - General] Hi Abdul, I don't use EFIAPI is because this is a library linked with the module, so there is no calling convention problem. However, I should have a consistent coding style for this file. I will update this file and remove EFIAPI for other functions. Thanks

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

On 4/14/23 05:20, Gerd Hoffmann wrote: Hi, -drive if=pflash,format=raw,unit=0,file=/root/kernels/qemu-install/OVMF_CODE.fd,readonly=on -drive if=pflash,format=raw,unit=1,file=./fedora.fd In this case, only OVMF_CODE.fd will be encrypted. The fedora.fd (OVMF_VARS.fd) will be

[edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

App goes through ID_AA64*_EL1 system registers and decode their values. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/ArmPkg.dsc|1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 33 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2346 ++ 3

[edk2-devel] [PATCH v6 1/2] ArmLib: add functions to read system registers

ArmCpuInfo uses those to read system registers and other parts of EDK2 may find them useful. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h| 50 +++- .../Library/ArmLib/AArch64/AArch64Support.S | 58 --- 2 files changed, 99

Re: [edk2-devel] [PATCH v5 2/2] add ArmCpuInfo EFI application

W dniu 20.04.2023 o 14:43, Leif Lindholm pisze: On Fri, Apr 07, 2023 at 17:29:57 +0200, Marcin Juszkiewicz wrote: +# +# This flag specifies whether HII resource section is generated into PE image. +# + UEFI_HII_RESOURCE_SECTION = TRUE The above stanza, and its comment, can be

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver

libvirt snippet (add to ): Was thinking about the motivation to add the virtio serial device. AFAIU this can provide a console in bios/early boot based on "virtio". Currently we can only get it with emulated PTY device which is slow because of frequent VMEXITS because

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: 18 April 2023 12:46 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V2 02/14]

Re: [edk2-devel] [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface

Hi Chang, It seems like my email has the problem, please expect the delay for my v2 patches while my email's fixing. Thanks for your patience. Thanks, Minh Nguyen From: Chang, Abner Sent: Sunday, April 16, 2023 11:36 AM To: Minh Nguyen OS ;

Re: [edk2-devel] [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface

Hi Chang, Yes, this is the first time and the issue comes from my internal mail and waiting for fixing. Thanks for that information and will check with miki.deme...@intel.com as well. Thanks, Minh Nguyen. From: Chang, Abner Sent: Thursday, April 20, 2023 8:28

[edk2-devel] [PATCH] UefiPayloadPkg: Move Network modules from Dxe FV to Network FV in elf

From: Linus Wu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4417 Since UefiPayload had supported multiple FV, move Network.fdf.inc to new firmware volume and add this network FV into elf file. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Linus Wu

Re: [edk2-devel] [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: Add more helper functions

[AMD Official Use Only - General] Comments inline. -Original Message- From: Chang, Abner Sent: 18 April 2023 12:46 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V2 01/14] ManageabilityPkg:

Re: [edk2-devel] [PATCH v5 2/2] add ArmCpuInfo EFI application

On Fri, Apr 07, 2023 at 17:29:57 +0200, Marcin Juszkiewicz wrote: > App goes through ID_AA64*_EL1 system registers and decode their values. > > Signed-off-by: Marcin Juszkiewicz > --- > ArmPkg/ArmPkg.dsc|1 + > ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver

Hi, > > libvirt snippet (add to ): > > > > > > > > > Was thinking about the motivation to add the virtio serial device. > > AFAIU this can provide a console in bios/early boot based on "virtio". > Currently we can only get it with emulated PTY device which is slow >

Re: [edk2-devel] [PATCH v5 1/2] ArmLib: add functions to read system registers

On Fri, Apr 07, 2023 at 17:29:56 +0200, Marcin Juszkiewicz wrote: > ArmCpuInfo uses those to read system registers and other parts of EDK2 > may find them useful. This is excellent, thanks! Sorry for nitpicking, but could you please sort the function declarations and definitions alphabetically?

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Move Network modules from Dxe FV to Network FV in elf

Reviewed-by: James Lu Thanks, James -Original Message- From: Wu, LinusX Sent: Thursday, April 20, 2023 3:31 PM To: devel@edk2.groups.io Cc: Wu, LinusX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Move Network modules from Dxe FV to

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: Reduce System Memory Size for FVP with RME extensions

Merged as ab9805e0020b..310d31231d69 Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103295): https://edk2.groups.io/g/devel/message/103295 Mute This Topic: https://groups.io/mt/98319017/21656 Group Owner:

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver

Hi Gerd, This seems useful - how do I use it? bare qemu (with guest console on stdin/stdout): qemu-system-x86_64 \ -enable-kvm -nodefaults -display none \ -bios Build/OvmfX64/DEBUG_GCC5/FV/OVMF.fd \ -chardev stdio,id=hvc0 \ -device virtio-serial-pci \

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

Hi Tom, Thanks for confirming. Is 1G page table supported in your test? If supported, there is a reason can explain why this difference exists. In current upstream master branch: Smm code always create 2M page table for [0, 4G] range(in Gen4GPageTable ) to reuse code. In QemuFlashBeforeProbe()

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Move Network modules from Dxe FV to Network FV in elf

Reviewed-by: gua@intel.com -Original Message- From: Wu, LinusX Sent: Thursday, April 20, 2023 3:31 PM To: devel@edk2.groups.io Cc: Wu, LinusX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Move Network modules from Dxe FV to Network

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: Reduce System Memory Size for FVP with RME extensions

Hi Leif, Thank you for reviewing the patch and for the feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 18/04/2023 02:30 pm, Leif Lindholm wrote: Hi Sami, On Mon, Apr 17, 2023 at 14:22:49 +0100, Sami Mujawar wrote: For older FVPs (without support for RME

Re: [edk2-devel] [edk2-platforms][PATCH V2 14/14] ManageabilityPkg: Add Manageability FDFs

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > ; Tinh Nguyen > Subject: [edk2-platforms][PATCH V2

Re: [edk2-devel] [edk2-platforms][PATCH V2 13/14] ManageabilityPkg: Relocate Manageability.dsc

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > ; Tinh Nguyen > Subject: [edk2-platforms][PATCH V2

Re: [edk2-devel] [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add Manageability PCDs

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > ; Tinh Nguyen > Subject: [edk2-platforms][PATCH V2

Re: [edk2-devel] [edk2-platforms][PATCH V2 11/14] ManageabilityPkg/PldmProtocol: Add PLDM protocol

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 11/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 10/14] ManageabilityPkg: Add MCTP transport interface

Please find my comments below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 10/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 09/14] ManageabilityPkg/MctpProtocol: Add MctpProtocol

Please find my comment below. Thanks, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 09/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 08/14] ManageabilityPkg: Add MCTP manageability header file

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 08/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 07/14] ManageabilityPkg: Add definitions of MCTP

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 07/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 06/14] ManageabilityPkg/KCS: KCS transport interface

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 06/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 05/14] ManageabilityPkg: Add PldmSmbiosTransferDxe driver

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 05/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 04/14] ManageabilityPkg: Add PldmProtocolLib

Please find my comment inline below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2

Re: [edk2-devel] [edk2-platforms][PATCH V2 03/14] ManageabilityPkg: Add HeaderSize and TrailerSize

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 03/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2 02/14]

Re: [edk2-devel] [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: Add more helper functions

Hi Abner, Please find my comments below. Thanks, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

Hi Abner, I have some inline comments below On 18/04/2023 14:15, Chang, Abner via groups.io wrote: From: Abner Chang Update GetTransportCapability to support Maximum Transfer Unit (MTU) of transport interface. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle