Reviewed-by: Chen Gang C mailto:gang.c.c...@intel.com>>
Best Regards
Gang
From: Kuo, Ted
Sent: Thursday, April 27, 2023 11:45 AM
To: Mohapatra, Susovan ; Chiu, Chasel
; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Ng, Ray Han Lim ; Chen,
Gang C ; Zeng,
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4425
This change is to support the pre-built EFI image on the old Edk2 code.
Old Edk2 GenFw tool generates the wrong debug entry in EFI image.
Those pre-built images can be loaded before d6457b309.
Signed-off-by: Liming Gao
Cc: Ard Biesheuvel
C
Reviewed-by: Gua Guo
-Original Message-
From: Hsieh, PaytonX
Sent: Thursday, April 27, 2023 2:14 PM
To: devel@edk2.groups.io
Cc: Hsieh, PaytonX ; Dong, Guo ;
Ni, Ray ; Rhodes, Sean ; Lu, James
; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is
From: VincentX Ke
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
Calculating CRC based on checksum from all ACPI tables.
Update HWSignature filed in FADT based on CRC while ACPI table changed.
Signed-off-by: VincentX Ke
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming G
CC: Jian J Wang
CC: Liming Gao
CC: Dandan Bi
CC: Eric Dong
CC: devel@edk2.groups.io
Signed-off-by: JoeX Lu
---
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
b/MdeModu
Hi, Nhi Pham
Yao, Jiewen and Wang, Jian are the maintainers of SecurityPkg.
They can help to merge the patch if they have no concerns about the patch.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nhi Pham
> via groups.io
> Sent: Thursday, April 27, 2023 1:38 PM
> To: Xu
Thanks Min.
Could you help merge this patch to edk2?
Regards,
Nhi
On 4/26/2023 2:54 PM, Xu, Min M wrote:
It's good to me.
Reviewed-by: Min Xu
Thanks
-Original Message-
From: Nhi Pham
Sent: Thursday, April 20, 2023 11:49 AM
To: Xu, Min M ; devel@edk2.groups.io;
n...@os.amperecompu
Hi Sami,
On 4/26/23 21:47, Sami Mujawar wrote:
Hi Vivek,
Thank you for this patch.
I have some minor feedback that I will address before merging.
Reviewed-by: Sami Mujawar
Thank you for the review of this patch and other patches in the series.
Please find my comments inline below.
Re
From: Gua Guo
Switch default linux build image from Fedora-35 to Fedora-37
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Oliver Steffen
Cc: Chris Fernald
Signed-off-by: Gua Guo
Reviewed-by: Michael Kubacki
---
.azurepipelines/templates/defaults.yml | 2 +-
1 file changed,
From: Gua Guo
If code coverage exist failure, CI/CD need to catch it
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Michael Kubacki
Signed-off-by: Gua Guo
Reviewed-by: Michael D Kinney
Reviewed-by: Michael Kubacki
---
.../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py| 8 ++--
1 fil
From: Gua Guo
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.
Update docker setting, pick below solution between 47addc9 and 3b3eb8f
3b3eb8f Fixes and improvements to dev containers (#69)
54e5bd1 Enable GTK on Fedora QEMU (#63)
f1c7a20 Fedora: ins
Reviewed-by: Kuo, Ted mailto:ted@intel.com>>
From: Mohapatra, Susovan
Sent: Thursday, April 27, 2023 11:20 AM
To: Chiu, Chasel ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Ng, Ray Han Lim ; Chen,
Gang C ; Zeng, Star ; Kuo, Ted
; S, Ashraf Ali
Subj
Rebecca:
This change will break some development machines those have not installed
Python 3.9 or above. Now, those machines can still work.
I suggest to report warning message first if the python version doesn't
match.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Rebecca C
Hi Liming,
A1: Just compiler with GCC5 in Linux and search Wreturn-local-addr in Build
log
A2: Thanks for your comment, I will resend the patches after separating the
patch for different patches.
Best Regards,
Joe Lu
-Original Message-
From: gaoliming
Sent: Thursday, April 27, 202
Lu, Pen-ChunX would like to recall the message, "[edk2-devel] [PATCH] Fix GCC5
Release build warning [-Wreturn-local-addr]".
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103685): https://edk2.groups.io/g/devel/message/103685
Mute This T
Hi Liming,
A1: Just execute "python3.8 BirchStreamRpPkg/PlatformBIOSBuild.py -b RELEASE
-t GCC5" in Linux and search Wreturn-local-addr in Build log
A2: Thanks for your comment, I will resend the patches after separating the
patch for different patches.
Best Regards,
Joe Lu
-Original Me
Pen:
How do you find this warning message?
And, please separate the patch for the different packages.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 JoeX Lu
> 发送时间: 2023年4月25日 14:40
> 收件人: devel@edk2.groups.io
> 抄送: JoeX Lu ; Jian J Wang
> ; Liming Gao ; Dandan
> Bi ; Eric Do
Except the context previously mentioned by Mike and Michael, looks good
to me.
Reviewed-by: Chris Fernald
On 4/26/2023 5:34 PM, Guo, Gua wrote:
From: Gua Guo
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.
Cc: Michael D Kinney
Cc: Sean Brog
From: VincentX Ke
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
Calculating CRC based on checksum from all ACPI tables.
Update HWSignature filed in FADT based on CRC while ACPI table changed.
Signed-off-by: VincentX Ke
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.
I agree with Mike that there should be more context in the commit
message about the change that added lcov installation to the container
(https://github.com/tianocore/containers/commit/f1c7a20f641852034b0d7e8c1b209407c92560f2).
Ideally, a summary of changes from the previous container version t
Thanks Oliver,
Agree with your points. Let's keep "Sq" as is and mark "Cq" as volatile.
Best Regards,
Hao Wu
> -Original Message-
> From: Oliver Smith-Denny
> Sent: Thursday, April 27, 2023 5:07 AM
> To: devel@edk2.groups.io; Wu, Hao A ; Ni, Ray
>
> Cc: Wang, Jian J ; Gao, Liming
> ; M
Sure, I will update the commit message.
From: Kinney, Michael D
Sent: Thursday, April 27, 2023 8:52:40 AM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Sean Brogan ; Michael Kubacki
; Oliver Steffen ; fernald,
chris ; Kinney, Michael D
Subject: RE: [PATCH v2 2/2] .az
Reviewed-by: Michael Kubacki
On 4/26/2023 8:34 PM, Guo, Gua wrote:
From: Gua Guo
If code coverage exist failure, CI/CD need to catch it
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py| 8
Hi Gua,
It is hard to review this type of patch without more context.
Can you provide a link to the PR or branch where the docker image was updated?
That information should be part of the commit message.
Thanks,
Mike
> -Original Message-
> From: Guo, Gua
> Sent: Wednesday, April 26,
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Guo, Gua
> Sent: Wednesday, April 26, 2023 5:34 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua ; Kinney, Michael D
> ; Sean Brogan ;
> Michael Kubacki
> Subject: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage
> f
From: Gua Guo
If code coverage exist failure, CI/CD need to catch it
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py| 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/Bas
From: Gua Guo
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Oliver Steffen
Cc: Chris Fernald
Signed-off-by: Gua Guo
---
.azurepipelines/templates/defaults.yml | 2 +-
1 file cha
You can check with network_fv or bds_fv
[cid:image001.png@01D978D3.909189F0]
Thanks,
Gua
From: devel@edk2.groups.io On Behalf Of Sheng Lean Tan
Sent: Wednesday, April 26, 2023 9:11 PM
To: devel@edk2.groups.io; Guo, Gua
Cc: Rhodes, Sean ; Benjamin Doron
; Dong, Guo ; Ni, Ray
; Lu, James
Subj
Hi,
Is there merit to removing the assert statement? When this instance of the
RngLib class is used, the platform builder says there's RNG support. Asserts
are a little easier to see than debug prints, especially when they stall the
platform. I think that leaving it in is better. If asserts don'
I hadn't seen the bugzilla yet, though I know the issue. See patch 1/2, the
current approach is to use RngLibTimerLib if the build-time configuration
indicates. This isn't recommended but sufficient for building for platforms
which require the library class - I think OpensslLib has a dependency.
Hello to all,
I believe that I'm asking this question in the correct group. I asked this
on Stack Overflow too so I'm just posting that below. Since this is
straight text, please forgive the Markdown but hopefully it will help
separate things.
I have need to make a RAM Disk during the DXE phase o
From: BruceX Wang
REF: TBD
Use Python to replace llvm-objcopy in UniversalPayloadBuild.py.
1. AddSection32() and AddSection64(): Make a section named
with the contents of .
2. RemoveSection32() and RemoveSection64(): Remove .
3. ReplaceFv (): remove the section before add the section
if the fil
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Cc: Eric Dong
Cc: devel@edk2.groups.io
Cc: Jiewen Yao
Signed-off-by: JoeX Lu
---
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 20 ---
.../HashLibBaseCryptoRouterPei.c | 19 ++
2 files changed, 28 ins
On 4/24/23 04:45, Gerd Hoffmann wrote:
On Fri, Apr 21, 2023 at 03:49:27PM -0500, Tom Lendacky wrote:
On 4/21/23 04:18, Gerd Hoffmann wrote:
Hmm, good question. Can the guest figure what memory ranges are part
of the launch measurement?
I have a patch here (attached below) which refines flash
On Tue, Apr 25, 2023 at 6:09 PM Benjamin Doron
wrote:
>
> From: Benjamin Doron
>
> Uses CPU RDRAND support and installs the EfiRngProtocol.
> The protocol may be used by iPXE or the Linux kernel to gather entropy.
>
> Cc: Guo Dong
> Cc: Ray Ni
> Cc: Sean Rhodes
> Cc: James Lu
> Cc: Gua Guo
>
I've not been able to replicate either of those problems, so it sounds
like I'll need to leave this until you can figure it out.
--
Rebecca Cran
On 4/26/23 09:09, Kinney, Michael D wrote:
Yes.
Actually 2 issues. Working on ways to reproduce both in edk2 repo.
One is in build.py that is g
The code blindly assumes a TIS interface is present in case both CRB and
FIFO checks fail. Check the InterfaceType for TIS instead and only
return PtpInterfaceTis in case it matches, PtpInterfaceMax otherwise.
Signed-off-by: Gerd Hoffmann
---
SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c |
The code blindly assumes a TIS interface is present in case both CRB and
FIFO checks fail. Check the InterfaceType for TIS instead and only
return Tpm2PtpInterfaceTis in case it matches, Tpm2PtpInterfaceMax
otherwise.
Signed-off-by: Gerd Hoffmann
---
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Pt
Gerd Hoffmann (2):
SecurityPkg: add TIS sanity check (tpm2)
SecurityPkg: add TIS sanity check (tpm12)
SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 6 +-
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 6 +-
2 files changed, 10 insertions(+), 2 deletions(-)
--
2.40.0
Hi Vivek,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
For all the RD-N2 platform variants, include the SSDT ACPI table that
describes the devices present in SoC expansion block that is connected
to the IO virtualizati
Hi Vivek,
Thank you for this patch.
I have some minor feedback that I will address before merging.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
From: Shriram K
The IO virtualization block on reference design platforms allow
connecting SoC ex
Hi Vivek,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
Arm reference design platforms have multiple IO virtualization blocks
that allow connecting PCIe root bus or non-PCIe SoC peripherals to the
system. Each of these
Hi Vivek,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
Enable the virtio-p9 device that is present as part of the RoS
peripherals on RD-N2 platform variants. This will allow filesystem
s
Hi Vivek,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:02 am, Vivek Gautam wrote:
Some of the Arm reference design FVP platforms support the Virtio-p9
device as part of the RoS subsystem. Add an entry for this dev
Yes.
Actually 2 issues. Working on ways to reproduce both in edk2 repo.
One is in build.py that is generating a python traceback when a tool chain tag
is used that will be retired in the future.
The 2nd one is in CLANGDWARF changes. Main break is that one of the PATHs used
to map to echo and
Merged https://github.com/tianocore/edk2/pull/4313
> -Original Message-
> From: Michael Roth
> Sent: Wednesday, April 26, 2023 4:33 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Tom Lendacky
> ; Yao, Jiewen ; Ni,
> Ray ; Gerd Hoffmann ; Aktas,
> Erdem ; James Bottomley ;
> Xu, Min
Hi Sahil,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 01/02/2023 08:13 am, sahil wrote:
NT_FW_CONFIG DTB contains platform information passed by
Tf-A boot stage.
This information is used for Virtual memory map generation
during PEI phase a
Hi Nickle,
Sorry for the delay.
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: Nickle Wang
Sent: Friday, April 21, 2023 10:45 PM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ;
Michael D Kinney
Subject: [EXTERNAL] [edk2-redfish-client][PATCH v2] Initial edk2 redf
Do you have an update?
--
Rebecca Cran
On 4/25/23 09:26, Michael D Kinney wrote:
Made some progress on root cause. Related to rename of CLANG38 to CLANGDWARF
definitions for IA32.
Wil give an update in a few hours after some more testing.
Mike
-Original Message-
From: devel@edk
Hi Gua,
Thanks for the review. Do you have a proposal or small example on how you
want to separate into another FV?
Thanks,
Sheng
On Wed, 26 Apr 2023 at 14:55, Guo, Gua wrote:
> Do we separate these Security Driver into separate FV ?
>
>
>
> I really don’t want to see gather everything into u
Hi Gua,
Thanks for the review. Do you have a proposal or small example on how you want
to see to separate into another FV?
Thanks,
Sheng
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103648): https://edk2.groups.io/g/devel/message/1036
Do we separate these Security Driver into separate FV ?
I really don’t want to see gather everything into uefi_fv.
Separate it into a lot of fv, we can easy to plug in and plug out.
Thanks,
Gua
From: devel@edk2.groups.io On Behalf Of Sean Rhodes
Sent: Wednesday, April 26, 2023 8:33 PM
To: Benja
Reviewed-by: Sean Rhodes
On Tue, 25 Apr 2023 at 18:09, Benjamin Doron
wrote:
> From: Benjamin Doron
>
> Uses CPU RDRAND support and installs the EfiRngProtocol.
> The protocol may be used by iPXE or the Linux kernel to gather entropy.
>
> Cc: Guo Dong
> Cc: Ray Ni
> Cc: Sean Rhodes
> Cc: Ja
Reviewed-by: Sean Rhodes
On Tue, 25 Apr 2023 at 18:09, Benjamin Doron
wrote:
> From: Benjamin Doron
>
> Presently, `ArchIsRngSupported()` always returns TRUE, per
>
> https://github.com/tianocore/edk2/blob/1eeca0750af5af2f0e78437bf791ac2de74bde74/MdePkg/Library/BaseRngLib/Rand/RdRand.c#L124-L1
In case ShellConvertStringToUint64() fails the Handles are left
uninitialized. That can for example happen for Handle2 and Handle3 in
case only one parameter was specified on the command line. Which can
trigger the ASSERT() in line 185.
Reproducer: boot ovmf to efi shell in qemu, using q35 machi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4424
In Relaxed-AP Sync Mode, BSP will not wait for all Aps arrive. However,
SmmReadyToLock needs all Aps to arrive to set memory map Attributes and
check config Smm code access in PerformRemainingTasks.
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by
On Wed, Apr 26, 2023 at 12:52:25PM +0530, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
>
> Implements MmSaveStateLib library interfaces
> to read and write save state
> registers for Ovmf/Qemu.
You can drop this patch and use t
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhiguang
> Liu
> Sent: Wednesday, April 26, 2023 2:16 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang
> Subject: [edk2-devel] [PATCH v2 0/5] refine Smm range code in
> BoardX58Ich10
>
> In BoardX58Ich1
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, April 26, 2023 4:13 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Dong, Eric
> ; Ni, Ray ; Kumar, Rahul R
> ; Gerd Hoffmann ; De,
> Debkumar ; West, Catharine
>
> Subject: [PATCH v2 2/2] UefiCpuPkg: Support 5 level pag
1. Can you please update the comments to use proper name for each level of
paging entry?
Page-directory pointer table Pointers -> Page Directory Pointer Table
PML4 table pointers -> PML4
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, April 26, 2023 4:25 PM
> To: devel@edk2
Correct a typo in commit message inline.
Thanks
Zhiguang
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, April 26, 2023 4:13 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Dong, Eric
> ; Ni, Ray ; Kumar, Rahul R
> ; Gerd Hoffmann ; De,
> Debkumar ; West, Catharine
>
>
Add a macro USE_5_LEVEL_PAGE_TABLE to determine whether to create
5 level page table.
If macro USE_5_LEVEL_PAGE_TABLE is defined, PML5Table is created
at (4G-12K), while PML4Table is at (4G-16K). In runtime check, if
5level paging is supported, use PML5Table, otherwise, use PML4Table.
If macro USE_
In ResetVector, if create page table, its highest address is fixed
because after page table, code layout is fixed(4K for normal code,
and another 4K only contains reset vector code).
Today's implementation organizes the page table as following if 1G
page table is used:
4G-16K: PML4 page (PML4[0]
Thanks for the update. I missed that portion. The new change is better.
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Wednesday, April 26, 2023 4:03 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch V4 0/2] Update ProcTrace
Update ProcTrace feature code to support enable collect performance
data by generating CYC and TSC packets. Add a new dynamic
PCD to indicate if enable performance collecting. In ProcTrace.c
code, if this new PCD is true, after check cpuid, CYC and TSC
packets will be generated by setting the corre
Update code to support enable ProcTrace only on BSP. Add a new
dynamic PCD to indicate if enable ProcTrace only on BSP. In
ProcTrace.c code, if this new PCD is true, only allocate buffer
and set CtrlReg.Bits.TraceEn to 1 for BSP.
Bugzila: https://bugzilla.tianocore.org/show_bug.cgi?id=4423
Signed-
In V4 patch set:
Move the two new PCD from '[PcdsDynamic, PcdsDynamicEx]' section to
'[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]' section.
Dun Tan (2):
UefiCpuPkg: Update code to support enable ProcTrace only on BSP
UefiCpuPkg: Update PT code to support enable colle
On April 25, 2023 10:51 AM, Ni Ray wrote:
> >
> > On Fri, Apr 21, 2023 at 09:26:44AM -0500, Tom Lendacky wrote:
> > > On 4/21/23 03:36, Dun Tan wrote:
> > > > Remove code that apply AddressEncMask to non-leaf entry when split
> > > > smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it
It's good to me.
Reviewed-by: Min Xu
Thanks
> -Original Message-
> From: Nhi Pham
> Sent: Thursday, April 20, 2023 11:49 AM
> To: Xu, Min M ; devel@edk2.groups.io;
> n...@os.amperecomputing.com; Yao, Jiewen ; Wang,
> Jian J
> Cc: patc...@amperecomputing.com
> Subject: Re: [edk2-devel]
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib library interfaces
to read and write save state
registers for Ovmf/Qemu.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoff
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
moves Intel-specific code to the arch-dependent file.
Other processor families might have different
implementation of these functions.
Hence, moving out of the common file.
Cc: Abner Chang
Cc: Garrett Kirkendall
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Uses new MmSaveStateLib library instance.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Just
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Removes SmmCpuFeaturesReadSaveStateRegister and
SmmCpuFeaturesWirteSaveStateRegister
function from SmmCpuFeaturesLib library.
MmSaveStateLib library replaces the functionality of the above
functions.
Platform old/new need to use MmSaveState
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds MmSaveStateLib Library class in UefiCpuPkg.dec.
Adds function declaration header file.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib library interfaces
to read and write save state
registers for Intel processor family.
Moves Intel and AMD common functionality to common area.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements interfaces to read and write save state
registers of AMD's processor family.
Initializes processor SMMADDR and MASK depends
on PcdSmrrEnable flag.
Program or corrects the IP once control returns from SMM.
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib Library class for
AMD cpu family.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Atta
PR: https://github.com/tianocore/edk2/pull/4282
V9: Delta changes:
Addressed review comments.
Rename to MmSaveStateLib.
Also rename SMM_ defines to MM_.
Implemented OVMF MmSaveStateLib.
Removes SmmCpuFeaturesReadSaveStateRegister and
SmmCpuFeaturesWriteSaveStateRegister
function inter
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds an SMM SMRAM save-state map for AMD processors.
SMRAM save state maps for the AMD processor family are now supported.
Save state map structure is added based on
AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2.
The AMD le
@Wang, BruceX
Bugzilla please fill this link
https://bugzilla.tianocore.org/show_bug.cgi?id=4426
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Wednesday, April 26, 2023 3:12 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Dong, Guo ; Ni,
Ray ; Rhodes, Sean ; Lu, Ja
80 matches
Mail list logo
