Re: [edk2-devel] [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build

Thank you! > -Original Message- > From: Chiu, Chasel > Sent: Thursday, May 25, 2023 7:07 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric > Subject: RE: [PATCH 4/6] MinPlatform/build_bios.py: Support performance > enabled

Re: [edk2-devel] GoogleTest Compatibility with MdePkg's IndustyStandard header files

That is exactly what I did. Along with pragma to disable error on macros redefining operators. With that change use of "operator" did not generate a warning or error and the build completed. Did not work for "xor", and can not find any additional pragma to suppress that error. Mike >

Re: [edk2-devel] [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 24, 2023 5:29 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: [PATCH 4/6]

Re: [edk2-devel] GoogleTest Compatibility with MdePkg's IndustyStandard header files

On Wed, May 24, 2023 at 10:23 PM Michael D Kinney wrote: > > After trying a few GCC experiments, there does not appear to be any way to > work around “xor” keyword. > > > > I recommend we update EDK II sources to not use c++ keywords to avoid this > issue all together. > > > > This may require

Re: [edk2-devel] GoogleTest Compatibility with MdePkg's IndustyStandard header files

After trying a few GCC experiments, there does not appear to be any way to work around "xor" keyword. I recommend we update EDK II sources to not use c++ keywords to avoid this issue all together. This may require changes that do not match names from industry standard specs. Mike From: Aaron

Re: [edk2-devel] GoogleTest Compatibility with MdePkg's IndustyStandard header files

Hi Mike, What you suggested does work for MSVC, but it is failing with GCC. It sems that GCC is very strict about operator names. Relevant errors below: error: "xor" cannot be used as a macro name as it is an operator in C++ #define xor XOR ^~~ error: "xor" cannot be used

Re: [edk2-devel] GoogleTest Compatibility with MdePkg's IndustyStandard header files

Hi Aaron, Don't know if this will completely resolve your issues, but if you add some preprocessor statements around the problematic includes in your unit test CPP file, you may be able to get it to build. For example, I added the highlighted lines to

Re: [edk2-devel] [edk2-platforms:PATCH v2] MinPlatformPkg: Fix SetLargeVariable fail issue

Patch merged: https://github.com/tianocore/edk2-platforms/commit/b71f2bda9e4fc183068eef5d1d90a631181a2506 Thanks, Chasel > -Original Message- > From: Shindo, Miki > Sent: Tuesday, May 23, 2023 5:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao,

[edk2-devel] [PATCH 1/1] MdeModulePkg: Cache device path during LoadImage calls

During LoadImage, there 6-7 of the same call to CoreLocateDevicePath and can be cached during a particular call to LoadImage. For implementations with significant numbers of calls to LoadImage (>250), this change will improve the boot time by >10ms. Signed-off-by: Nolan Hergert ---

[edk2-devel] [PATCH 1/1] MdeModulePkg: Cache device path during LoadImage calls

During LoadImage, there 6-7 of the same call to CoreLocateDevicePath and can be cached during a particular call to LoadImage. For implementations with significant numbers of calls to LoadImage (>250), this change will improve the boot time by >10ms. Cc: Dandan Bi Cc: Liming Gao Signed-off-by:

Re: [edk2-devel] [Patch V4 07/15] UefiCpuPkg/PiSmmCpuDxeSmm: Add 2 function to disable/enable CR0.WP

Hi Dun, Thanks for your reply. That was helpful! Just a follow-up question, is there any plan to support heap guard with PcdCpuSmmRestrictedMemoryAccess enabled after these changes? I think it would be a great value prop for the developers to have both features enabled during firmware

Re: [edk2-devel] [PATCH v2 3/6] UefiCpuPkg: RISC-V: Support MMU with SV39/48/57 mode

Agree it makes more sense to put the MMU library into UefiCpuPkg. From: Ni, Ray Date: Wednesday, May 24, 2023 at 2:52 AM To: devel@edk2.groups.io , lic...@loongson.cn , tp...@ventanamicro.com , Ard Biesheuvel Cc: Kinney, Michael D , Gao, Liming , Liu, Zhiguang , suni...@ventanamicro.com ,

Re: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

On Mon, Mar 6, 2023 at 9:53 AM Ard Biesheuvel wrote: > On Mon, 6 Mar 2023 at 18:33, Tuan Phan wrote: > > > > The flash base address can be added to GCD before this driver run. > > So only add it if it has not been done. > > > > How do you end up in this situation? > > You cannot skip this

[edk2-devel] [PATCH] MdeModulePkg Universal: Fix typos

Adress->Address agregates->aggregates assoicated->associated availiable->available begining->beginning Caspule->Capsule CHNAGED->CHANGED continous->continuous Determin->Determine Devcice->Device dyanmic->dynamic existance->existence FLASE->FALSE functin->function implictly->implicitly

[edk2-devel] [PATCH] NetworkPkg: Fix typos

Fix few typos in NetworkPkg Erros->Errors failded->failed instrinsic->intrinsic Signed-off-by: Giri Mudusuru Cc: Maciej Rabeda Cc: Siyuan Fu Cc: Andrew Fish --- NetworkPkg/NetworkPkg.dsc | 2 +-

Re: [edk2-devel] BaseTools: how to generate PcdValueInit without VS?

It is supposed to use the host compiler. Same one used to build BaseTools/Source/C Mike From: devel@edk2.groups.io On Behalf Of yepi...@qti.qualcomm.com Sent: Wednesday, May 24, 2023 1:58 AM To: devel@edk2.groups.io Subject: [edk2-devel] BaseTools: how to generate PcdValueInit without VS?

Re: [edk2-devel] [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode

Hi Leif and Ard  Could you please help merge this series? Thanks, Minh Nguyen On 5/11/2023 2:51 PM, Minh Nguyen wrote: These patches help to improve PCIe core for Link training sequence and add logic to check PCIe card is present or not. One patch also removes unnecessary checks for PCIe

[edk2-devel] [edk2-platforms][PATCH 3/4] JadePkg: Refactor SmbiosPlatformDxe

This refactor is derrived from ArmPkg/SMBIOS and customize to adapt with platform. These changes help to separate each Type of SMBIOS table into individual modules. It makes the structure of SmbiosPlatformDxe module clear and easier to add new type of table. Signed-off-by: Minh Nguyen ---

[edk2-devel] BaseTools: how to generate PcdValueInit without VS?

Hi maintainers, PcdValueInit compilation requests VS on windows OS. Is there any other way to generate PcdValueInit without VS? Thanks Yepings. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105271):

[edk2-devel] [edk2-platforms][PATCH 1/4] JadePkg: Correct PCD names for SMBIOS Type 0

This corrects "PcdSmbiosTables1MajorVersion" and "PcdSmbiosTables1MinorVersion" of SMBIOS Type 1, these PCDs should be for Type 0. Signed-off-by: Minh Nguyen --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec| 14 --

[edk2-devel] [edk2-platforms][PATCH 4/4] JadePkg: Add support SMBIOS Table Type 16, 17, 19

This adds support SMBIOS Tables Type 16, 17, 19 for information of Physical Memory, Memory Device and Memory Array Mapped Address. Signed-off-by: Minh Nguyen --- Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 6 +

[edk2-devel] [edk2-platforms][PATCH 0/4] Add support new SMBIOS Tables and refactor to adapt with ArmPkg/SMBIOS

These patches helps to add new SMBIOS Tables (Type 16, 17, 19) and refactor SmbiosPlatformDxe. Minh Nguyen (4): JadePkg: Correct PCD names for SMBIOS Type 0 JadePkg: Leverage ArmPkg/Smbios (Type 0, 1, 2, 3, 13, 32) JadePkg: Refactor SmbiosPlatformDxe JadePkg: Add support SMBIOS Table

[edk2-devel] [edk2-platforms][PATCH 2/4] JadePkg: Leverage ArmPkg/Smbios (Type 0, 1, 2, 3, 13, 32)

This implementation helps SMBIOS Table (Type 0, 1, 2, 3, 13, 32) of Altra and AltraMax platform to utilize framework from ArmPkg. Signed-off-by: Minh Nguyen --- Platform/Ampere/JadePkg/Jade.dsc| 7 +- Platform/Ampere/JadePkg/Jade.fdf

[edk2-devel] [PATCH 1/1] MdeModulePkg: Cache device path during LoadImage calls

>From 4282ca25cde475a4ec2b81c5e878414a5829f88b Mon Sep 17 00:00:00 2001 Message-Id: <4282ca25cde475a4ec2b81c5e878414a5829f88b.1684880087.git.nolan.herg...@intel.com> In-Reply-To: References: From: Nolan Hergert Date: Fri, 19 May 2023 14:58:00 -0700 Subject: [PATCH 1/1] MdeModulePkg: Cache

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO - Thursday, June 8, 2023 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20230407T050750Z

[edk2-devel] Updated Event: TianoCore Community Meeting EMEA/NAMO - Thursday, June 8, 2023 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20230407T050750Z

[edk2-devel] [PATCH v6 04/11] BaseTools: remove WinNtInclude.h

Appears to be a relic for ancient windows / compiler versions, windows builds in CI work just fine without it. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- BaseTools/Source/C/Common/WinNtInclude.h| 66 -

[edk2-devel] [PATCH v6 02/11] BaseTools: add -fdirect-access-external-data to clang pie builds

Tell clang to not use external (via got) references for data access. Signed-off-by: Gerd Hoffmann Reviewed-by: Ard Biesheuvel --- BaseTools/Conf/tools_def.template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Conf/tools_def.template

[edk2-devel] [PATCH v6 07/11] MdePkg/PeImage.h: add bits from BaseTools version

The BaseTools and MdePkg versions of PeImage.h diverged over time, add some missing bits to the MdePkg header file in preparation for removing the BaseTools version. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- MdePkg/Include/IndustryStandard/PeImage.h |

[edk2-devel] [PATCH v6 06/11] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Acked-by: Sunil V L Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- .../Source/C/Include/IndustryStandard/Acpi.h | 117 --- .../C/Include/IndustryStandard/Acpi1_0.h | 285

[edk2-devel] [PATCH v6 10/11] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Reviewed-by: Chao Li Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- .../C/Include/IndustryStandard/PeImage.h | 790 -- 1 file changed, 790 deletions(-) delete mode

[edk2-devel] [PATCH v6 11/11] BaseTools: remove duplicate includes: IndustryStandard/*.h

Use the MdePkg versions instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- BaseTools/Source/C/EfiRom/EfiRom.h| 4 +- .../C/Include/IndustryStandard/Bluetooth.h| 56 --

[edk2-devel] [PATCH v6 00/11] BaseTools: remove duplicate includes.

There is alot of code duplication between BaseTools and MdePkg (and also MdeModulePkg). This patch series starts reducing this by removing some header files. BaseTools are switched over to use the include files in MdePkg instead. It also cleans up some (apparently) obsolete code and adapts

[edk2-devel] [PATCH v6 09/11] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*

Use the newer versions of the machine #defines. Signed-off-by: Gerd Hoffmann Reviewed-by: Chao Li Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++--- .../C/Include/IndustryStandard/PeImage.h | 1 +

[edk2-devel] [PATCH v6 08/11] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks

The #define for IMAGE_FILE_MACHINE_ARM is not present in MdePkg, this looks like a relic not used any more. Remove. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- BaseTools/Source/C/Common/BasePeCoff.c | 23 --- 1 file changed, 4

[edk2-devel] [PATCH v6 03/11] MdePkg: don't set visibility to hidden

Not needed any more on modern toolchains, they are better in not creating a GOT without this trick. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- MdePkg/Include/X64/ProcessorBind.h | 14 -- 1 file changed, 14 deletions(-) diff --git

[edk2-devel] [PATCH v6 05/11] BaseTools: remove duplicate includes: /ProcessorBind.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann Reviewed-by: Chao Li Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- .../Source/C/Include/AArch64/ProcessorBind.h | 148 -- .../Source/C/Include/Arm/ProcessorBind.h | 147

[edk2-devel] [PATCH v6 01/11] BaseTools: make sure the got is empty

Add ASSERT()s that .got and .got.plt sections are empty to linker scripts for gcc and clang. Suggested-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao Reviewed-by: Rebecca Cran --- BaseTools/Scripts/ClangBase.lds | 10 ++ BaseTools/Scripts/GccBase.lds | 10

[edk2-devel] [PATCH v2 10/11] ArmPkg: Adjust variable type and cast for RegShift & RegOffset

According to the GIC architecture version 3 and 4 specification, the maximum number of INTID bits supported in the CPU interface is 24. Considering this the RegShift variable is not required to be more than 8 bits. Therefore, make the RegShift variable type to UINT8. Also add necessary typecasts

[edk2-devel] [PATCH v2 11/11] ArmPkg: Fix ArmGicAcknowledgeInterrupt () for GICv3

The ArmGicAcknowledgeInterrupt () returns the value returned by the Interrupt Acknowledge Register and the InterruptID separately in an out parameter. The function documents the following: 'InterruptId is returned separately from the register value because in the GICv2 the register value contains

[edk2-devel] [PATCH v2 07/11] ArmPkg: Typecast IntID to UINT32 in ArmGicV2EndOfInterrupt

The EIOR register of the Gic CPU interface is a 32 bit register. However, the HARDWARE_INTERRUPT_SOURCE used to represent the interrupt source (Interrupt ID) is typedefed as UINTN, see EmbeddedPkg\Include\Protocol\HardwareInterrupt.h Therfore, typecast the interrupt ID (Source) value to UINT32

[edk2-devel] [PATCH v2 08/11] ArmPkg: Remove unused function declarations

The IrqInterruptHandler () and ExitBootServicesEvent () function declarations were unused. Therefore, remove these declarations. Signed-off-by: Sami Mujawar --- Notes: v2: - No updates since v1 series. [Sami] ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 14

[edk2-devel] [PATCH v2 04/11] ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor

According to edk2 coding standard specification, Non-Boolean comparisons must use a compare operator (==, !=, >, < >=, <=). See Section 5.7.2.1 at https://edk2-docs.gitbook.io/ edk-ii-c-coding-standards-specification/5_source_files/ 57_c_programming Therefore, fix the comparison in

[edk2-devel] [PATCH v2 01/11] ArmPkg: Fix data type used for GicDistributorBase

The data type used by variables representing the GicDistributorBase has been inconsistently used in the ArmGic driver and the library. The PCD defined for the GIC Distributor base address is UINT64. However, the data types for the variables used is UINTN, INTN, and at some places UINT32.

[edk2-devel] [PATCH v2 06/11] ArmPkg: Make variables used for GicInterrupt UINTN

Although the maximum interrupt ID on GicV2 is 10bit and for GicV3/4 is 24bit, and that the IAR and EOIR registers of the Gic CPU interface are 32 bit; the typedef HARDWARE_INTERRUPT_SOURCE is defined as UINTN in EmbeddedPkg\Include\Protocol\HardwareInterrupt.h Therefore, use UINTN for Gic

[edk2-devel] [PATCH v2 05/11] ArmPkg: Fix return type for ArmGicGetInterfaceIdentification

The CPU Interface Identification Register (GICC_IIDR) is a 32-bit register. Since ArmGicGetInterfaceIdentification () returns the value read from the GICC_IIDR register, update the return type for this function to UINT32. Signed-off-by: Sami Mujawar --- Notes: v2: - No code change

[edk2-devel] [PATCH v2 03/11] ArmPkg: Fix ArmGicSendSgiTo() parameters

The Software Generated Interrupt Register (GICD_SGIR) is a 32 bit register with the following bit assignment: TargetListFilter, bits [25:24] CPUTargetList, bits [23:16] NSATT, bit [15] SGIINTID, bits [3:0] Therefore, modify the TargetListFilter, CPUTargetList, SGI Interrupt ID parameters

[edk2-devel] [PATCH v2 09/11] ArmPkg: Prevent SgiId from setting RES0 bits of GICD_SGIR

GICD_SGIR is a 32-bit register, of which INTID is bits [3:0] and Bits [14:4] is RES0. Since SgiId parameter in the function ArmGicSendSgiTo () is UINT8, mask unused bits of SgiId before writing to the GICD_SGIR register to prevent accidental setting of the RES0 bits. Signed-off-by: Sami Mujawar

[edk2-devel] [PATCH v2 00/11] ArmPkg: Arm GIC Library and Driver improvements

Bugzilla: Bug 3399 (https://bugzilla.tianocore.org/show_bug.cgi?id=3399) This patch series address the issues reported in https://bugzilla.tianocore.org/show_bug.cgi?id=3399 and also has general improvements and fixes for other issues in the Arm GIC Library and driver. This patch series is

[edk2-devel] [PATCH v2 02/11] ArmPkg: Fix data type used for GicInterruptInterfaceBase

The data type used by variables representing the GicInterruptInterfaceBase has been inconsistently used in the ArmGic driver and the library. The PCD defined for the GIC Interrupt interface base address is UINT64. However, the data types for the variables used is UINTN, INTN, and at some places

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug

Gerd, I was busy on something else. The patch was ready and I am testing it before sending them out. Thanks, Ray > -Original Message- > From: kra...@redhat.com > Sent: Wednesday, May 3, 2023 3:24 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Pawel Polawski ; Kumar, > Rahul R ; Oliver

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification()

On Wed, 24 May 2023 at 14:28, Laszlo Ersek wrote: > > On 5/24/23 11:11, Gerd Hoffmann wrote: > > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While > > being at it also remove it from Bhyve (where it is dead code). > > > > Fixed by commits: > > - 8bd2028f9ac3 ("MdeModulePkg:

[edk2-devel] [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build

build_bios.py supports caller to pass in "--performance" flag but the script implemnetation just ignores this flag. The patch adds the missing logic to invoke build.py with "--pcd gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=True" when "--performance" is supplied. Signed-off-by: Ray Ni

[edk2-devel] [PATCH 6/6] SimicsOpenBoardPkg: Disable DriverBindingSupport perf logging

DriverBindingSupport() is called lots of time during post. If it's also included in the perf logging, it's very easy to use all the FPDT table memory pre-allocated at EndOfDxe because the driver binding connect process happens after EndOfDxe. PcdExtFpdtBootRecordPadSize was added for holding the

[edk2-devel] [PATCH 5/6] SimicsOpenBoardPkg: Add "dp" command in performance build

Signed-off-by: Ray Ni Cc: Nate DeSimone Cc: Zhiguang Liu Cc: Michael D Kinney --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 8 .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 3 +++ 2 files changed, 11 insertions(+) diff --git

[edk2-devel] [PATCH 3/6] SimicsOpenBoardPkg: Enable serial terminal

Signed-off-by: Ray Ni Cc: Nate DeSimone Cc: Zhiguang Liu Cc: Michael D Kinney --- .../BoardX58Ich10/OpenBoardPkg.fdf| 1 - .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 1 + .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 56 --- 3 files changed, 24

[edk2-devel] [PATCH 2/6] SimicsOpenBoardPkg: Remove logic that loads variable from disk file

Simics QSP platform always supports flash devices. The logic that was ported from OVMF where the flash devices might not be supported in some configurations is useless in QSP platform. So, the patch removes all of them. Signed-off-by: Ray Ni Cc: Nate DeSimone Cc: Zhiguang Liu Cc: Michael D

[edk2-devel] [PATCH 1/6] SimicsOpenBoardPkg: Remove un-used PlatformBootManagerLib

Signed-off-by: Ray Ni Cc: Nate DeSimone Cc: Zhiguang Liu Cc: Michael D Kinney --- .../PlatformBootManagerLib/BdsPlatform.c | 1532 - .../PlatformBootManagerLib/BdsPlatform.h | 172 -- .../PlatformBootManagerLib.inf| 72 -

[edk2-devel] [PATCH 0/6] Fine tune SimicsOpenBoardPkg

Ray Ni (6): SimicsOpenBoardPkg: Remove un-used PlatformBootManagerLib SimicsOpenBoardPkg: Remove logic that loads variable from disk file SimicsOpenBoardPkg: Enable serial terminal MinPlatform/build_bios.py: Support performance enabled build SimicsOpenBoardPkg: Add "dp" command in

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification()

On 5/24/23 11:11, Gerd Hoffmann wrote: > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While > being at it also remove it from Bhyve (where it is dead code). > > Fixed by commits: > - 8bd2028f9ac3 ("MdeModulePkg: Supporting S3 in 64bit PEI") > - 6acf72901a2e ("UefiCpuPkg:

Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types

Hi Neil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105227): https://edk2.groups.io/g/devel/message/105227 Mute This Topic:

Re: [edk2-devel] [PATCH v2 3/6] UefiCpuPkg: RISC-V: Support MMU with SV39/48/57 mode

X86 version is in UefiCpuPkg. So be consistent, I would prefer the LoongArch64 version be in UefiCpuPkg as well. I know that ARM has similar code (I didn’t check in detail, +@Ard Biesheuvel). The trending is to abstract the memory attribute implementation behind

Re: [edk2-devel] [PATCH v4 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

Thanks for quickly review also update reviewed-by info on the PR. https://github.com/tianocore/edk2/pull/4416 -Original Message- From: Ni, Ray Sent: Wednesday, May 24, 2023 5:45 PM To: Guo, Gua ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: [PATCH v4 1/1] PcAtChipsetPkg: RTC

Re: [edk2-devel] [PATCH v4 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

Reviewed-by: Ray Ni > -Original Message- > From: Guo, Gua > Sent: Wednesday, May 24, 2023 4:43 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Ni, Ray ; Kinney, > Michael D > Subject: [PATCH v4 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO > port by PCD > > From: Gua Guo >

[edk2-devel] [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification()

Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While being at it also remove it from Bhyve (where it is dead code). Fixed by commits: - 8bd2028f9ac3 ("MdeModulePkg: Supporting S3 in 64bit PEI") - 6acf72901a2e ("UefiCpuPkg: Supporting S3 in 64bit PEI") See also

Re: [edk2-devel] [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

V4 patch can locate all previous comment. -Original Message- From: Guo, Gua Sent: Wednesday, May 24, 2023 4:43 PM To: devel@edk2.groups.io Cc: Guo, Gua Subject: [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD From: Gua Guo PR:

[edk2-devel] [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

From: Gua Guo PR: https://github.com/tianocore/edk2/pull/4416 V4: merge mRtcIndexRegisterIo and mRtcTargetRegisterIo into mRtcIndexRegister and mRtcTargetRegister V3: change UINTN to UINT8 on global data mRtcIndexRegisterIo mRtcTargetRegisterIo V2: Add more dynamic PCD for runtime

[edk2-devel] [PATCH v4 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

From: Gua Guo RTC runtime is unable to get dynamic PCD value after booting to OS using runtime services. Resolution: Cache the dynamic PCD value in RTC driver entry point Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Gua Guo --- .../PcatRealTimeClockRuntimeDxe/PcRtc.c | 36

[edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

From: VincentX Ke REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428 Calculating CRC based on each ACPI table. Update HWSignature field in FACS based on CRC while ACPI table changed. Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c Signed-off-by: VincentX Ke Cc: Chasel Chiu Cc:

Re: [edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

Thank for the review, will update v4 to take care it. -Original Message- From: Ni, Ray Sent: Wednesday, May 24, 2023 4:14 PM To: devel@edk2.groups.io; Guo, Gua Cc: Kinney, Michael D Subject: RE: [edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by

[edk2-devel] [PATCH v3 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

From: Gua Guo PR: https://github.com/tianocore/edk2/pull/4416 V3: change UINTN to UINT8 on global data mRtcIndexRegisterIo mRtcTargetRegisterIo V2: Add more dynamic PCD for runtime service support instead of taking for FixedAtBuild case V1: After

[edk2-devel] [PATCH v3 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

From: Gua Guo RTC runtime is unable to get dynamic PCD value after booting to OS using runtime services. Resolution: Cache the dynamic PCD value in RTC driver entry point Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Gua Guo --- .../PcatRealTimeClockRuntimeDxe/PcRtc.c | 38

Re: [edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

> > -extern UINTN mRtcIndexRegister; > > -extern UINTN mRtcTargetRegister; > > - > > +extern UINTN mRtcIndexRegister; > > +extern UINTN mRtcTargetRegister; > > +extern UINTN mRtcIndexRegisterIo; > > +extern UINTN mRtcTargetRegisterIo; Can you avoid adding the mRtcIndexRegisterIo/