1. Do we want to catch a case that platform wrongly sets BIT61 but drivers run
before CpuDxe are not XIP?
2. Why BIT61 set is the "Default state"?
The setting of BIT61 is a bit confusing. Is there a way to avoid adding BIT61
through code optimization?
Thanks,
Ray
> -Original Message-
>
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, May 30, 2023 2:33 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, May 30, 2023 2:33 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH 1/2] ManageabilityPkg: Repl
1. is it possible that a PE image sits in the right location but the
SectionAlignment is larger than FileAlignment so each section still needs to be
copied to the aligned memory location?
2. PeCoffLoaderRelocateImage() might not be called for XIP
> -Original Message-
> From: devel@edk2
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../BaseManageabilityTransportHelper.c| 36 +--
.../Common/KcsCommon.c| 12 +++
.../Dxe/ManageabilityTransportKcs.c
From: Abner Chang
Use debug print level DEBUG_MANAGEABILITY in
ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../Library/ManageabilityTransportHelperLib.h | 2 +-
.../BaseManageabilityTransportHelper.c
I didn't review the existing logic carefully. Several comments:
1. Assignments of several fields are skipped when executing in place. Do they
matter?
a). Image->NumberOfPages
b). Image->ImageBasePage
2. PeCoffLoaderRelocateImage() is called even for XIP case. But I don't think
it's expec
As I replied to patch #5, we may avoid installing the MMFV protocol.
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, May 29, 2023 6:17 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Yao, Jiewen
> ; Gerd Hoffmann ; Taylor Beebe
> ; Oliver Smith-Denny ; Bi, Danda
GetFileBufferByFilePath() always returns a copy of file buffer even when the
file
is in a memory-mapped device.
So, your patch adds a new implementation (abstracted through the new MM FV
protocol) that can directly return the file location in the MMIO device.
Several comments:
1. I am not sure i
I don't know why the FFS file is cached. Without knowing the reason of caching,
I cannot say it's good to remove the caching logic.
I will let @Gao, Liming, @Kinney, Michael D to comment.
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, May 29, 2023 6:17 PM
> To: devel@edk2.g
Reviewed-by: Ray Ni
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, May 29, 2023 6:17 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Yao, Jiewen
> ; Gerd Hoffmann ; Taylor Beebe
> ; Oliver Smith-Denny ; Bi, Dandan
> ; Gao, Liming ; Kinney,
> Michael D ; Leif L
Reviewed-by: Ray Ni
One comment regarding the needing of "static".
(I saw you added static" to CoreLoadPeImage in this patch😊)
But let's discuss in the first patch thread.
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, May 29, 2023 6:17 PM
> To: devel@edk2.groups.io
> Cc: A
I really like the code simplification! Just 2 comments below:
1. Can you describe the calling flow explicitly in commit message:
CoreLoadImage (public api) -> CoreLoadImageCommon -> CoreLoadPeImage
2. You added "static" to CoreLoadImageCommon but didn't add to CoreLoadPeImage.
I think you are t
Patch merged:
https://github.com/tianocore/edk2/commit/48c53994e649d51a388dc414944c9a9b717a1c3c
Thanks,
Chasel
> -Original Message-
> From: Ranbir Singh
> Sent: Wednesday, May 17, 2023 11:29 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Ran
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Tuesday, May 30, 2023 1:07 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Oliver Smith-Denny ;
> Pedro Falcato ; Pop, Aaron
>
> Subject: [edk2-devel] [P
Patch merged:
https://github.com/tianocore/edk2/commit/69e10f02111bf7e719237f05233abff4e50016fa
Thanks,
Chasel
> -Original Message-
> From: Tan, Ming
> Sent: Sunday, May 21, 2023 11:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Duggapu, Chinni B
>
> Subject: [PATCH] IntelFsp
That’s good suggestion Pedro!
Ranbir, would you like me to modify your patch to "return 0" during merging?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Friday, May 19, 2023 5:29 AM
> To: devel@edk2.groups.io; rsi...@ventanamicro.
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, May 30, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4
*Tools, CI, Code base construction meeting series*
*When:*
Monday, May 29, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890536 )
*Description:*
TianoCore communit
[AMD Official Use Only - General]
Emulator PR failed, that might be the reason its not allowing to push
https://github.com/tianocore/edk2/pull/4442/checks?check_run_id=13834435150
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
via groups.io
Sent: Monday, May 2
[AMD Official Use Only - General]
Hi Abner,
Yes, its same patch series with V2 version.
Thanks
AbduL
-Original Message-
From: Chang, Abner
Sent: Friday, May 26, 2023 7:07 AM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef)
Subje
Some features like RAS need to use processor extended information
under smm, So add code to support it
Signed-off-by: Hongbin1 Zhang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Star Zeng
Cc: Jiaxin Wu
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +-
1 file changed,
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, May 29, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890536 )
*Description:*
TianoCor
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords
operator and xor in C structures to support use of these
include files when building with a C++ compiler.
* Change operator -> Operator
* Change xor -> Xor
NOTE: This is a non-backwards compatible change to Tpm12.h
and Tmp20.h. And cons
Change xor to Xor to avoid C++ reserved work name collisions
when building with C++ compilers.
NOTE: This is a non-backwards compatible change to Tpm12.h
and Tmp20.h. And consumers of these include files that access
the "operator" or "xor" fields must be updated.
Cc: Jiewen Yao
Cc: Jian J Wang
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords
operator and xor in C structures to support use of these
include files when building with a C++ compiler.
Update SecurityPkg Tpm2CommandLib to use updated field names.
* Change operator -> Operator
* Change xor -> Xor
NOTE: This is a
Since it’s Memorial Day, I guess this meeting won’t happen?
On Sun, May 28, 2023, at 5:30 PM, Group Notification wrote:
> *Reminder: Tools, CI, Code base construction meeting series*
>
> *When:*
> Monday, May 29, 2023
> 4:30pm to 5:30pm
> (UTC-07:00) America/Los Angeles
>
> *Where:*
> https://gi
Hi Sean,
I see the "rerun" button on the "checks" page of GitHub from my login.
We have a mix of both Azure Pipelines and GitHub Actions today, so I think it
is important to see the "rerun" from GitHub view for Maintainers.
This github page describes the feature, but not the permissions require
I pay for a Visual Studio subscription, so I shouldn’t count towards the limit
then.
My GitHub email address is the same as I use here.
—
Rebecca
On Mon, May 29, 2023, at 9:37 AM, Sean wrote:
> It has changed over time and I no longer see a button on the "checks"
> page of GitHub. I only see
It has changed over time and I no longer see a button on the "checks" page of
GitHub. I only see the button in the azure pipeline which would mean
maintainers would need to be "contributors" in the azure DevOps
organization/project. I have no problem with that and it looks like you can
sign in
Hi Sean,
Do you know what GitHub permissions are required to see the re-run button?
I think it is reasonable for all Maintainers to have that available.
Mike
From: devel@edk2.groups.io On Behalf Of Sean
Sent: Monday, May 29, 2023 8:12 AM
To: devel@edk2.groups.io; a...@kernel.org; Rebecca Cran
W dniu 16.05.2023 o 12:21, Graeme Gregory pisze:
On Mon, May 15, 2023 at 06:23:30PM +0200, Marcin Juszkiewicz via groups.io
wrote:
Update the TF-A binaries to have FEAT_FGT support.
This support was merged into TF-A:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/19459
This a
It has been rerun.
From: devel@edk2.groups.io on behalf of Ard Biesheuvel
Sent: Monday, May 29, 2023 7:44:37 AM
To: Rebecca Cran
Cc: devel@edk2.groups.io ; Michael Kinney
; Michael Kubacki ;
Liming Gao (Byosoft address)
Subject: Re: [edk2-devel] failed Pr
O
On Mon, 29 May 2023 at 16:37, Rebecca Cran wrote:
>
> It looks like the agent or machine running the CI task crashed.
>
> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
> agent machine is running and has a healthy network connection. Anything
> that terminates an agent proc
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 22, 2023 5:29 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner
> Subject: [PATCH v2 2/2] AMD/AmdMinBoardkPkg: Implements
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 22, 2023 5:29 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner
> Subject: [PATCH v2 1/2] AMD/AmdMinBoardPkg: Implements P
It looks like the agent or machine running the CI task crashed.
"##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
agent machine is running and has a healthy network connection. Anything
that terminates an agent process, starves it for CPU, or blocks its
network access can
On Sat, 27 May 2023 at 01:18, Tuan Phan wrote:
>
> Normally, DXE driver would add device resource to GCD before start using.
> But some key resources such as uart, flash base address are being accessing
> directly in some core modules.
>
> Those resources should be populated to HOB in SEC phase so
On Thu, May 25, 2023 at 04:30:35PM +0200, Ard Biesheuvel wrote:
> The RISC-V version of the DXE IPL does not implement setting the stack
> NX, so before switching to an implementation that will ASSERT() on the
> missing support, drop the PCD setting that enables it.
>
> Signed-off-by: Ard Biesheuv
Hello all,
Regarding
https://github.com/tianocore/edk2/pull/4442
could someone please explain to me:
- what went wrong,
- where to find the button to push to resubmit this PR to CI
Thanks,
Ard.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply On
On Wed, 24 May 2023 at 12:48, Sami Mujawar wrote:
>
> Hi Neil,
>
> Thank you for this patch.
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar
>
I cannot apply this. Please resend this (with me on cc) using git send-email
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all m
On Wed, 24 May 2023 at 14:29, Ard Biesheuvel wrote:
>
> On Wed, 24 May 2023 at 14:28, Laszlo Ersek wrote:
> >
> > On 5/24/23 11:11, Gerd Hoffmann wrote:
> > > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While
> > > being at it also remove it from Bhyve (where it is dead code).
On Thu, 25 May 2023 at 17:47, Ard Biesheuvel wrote:
>
> On Tue, 16 May 2023 at 11:48, Gerd Hoffmann wrote:
> >
> > Flip the default for IO address space reservations for PCI(e) bridges
> > and root ports with hotplug support from TRUE to FALSE.
> >
> > PCI(e) bridges will still get IO address spa
On Thu, 25 May 2023 at 17:48, Ard Biesheuvel wrote:
>
> On Wed, 17 May 2023 at 12:24, Gerd Hoffmann wrote:
> >
> >
> >
> > Gerd Hoffmann (3):
> > OvmfPkg/PlatformInitLib: check PcdUse1GPageTable
> > OvmfPkg/OvmfPkgIa32X64: enable 1G pages
> > OvmfPkg/MicrovmX64: enable 1G pages
> >
>
> Acke
Now that both PEI and DXE can deal with memory being mapped non-execute
by default, update the early mapping code to create non-execute mappings
for all of DRAM. While at it, map the NOR flash read-only as well.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemu.dsc
Add ArmCpuDxe and its dependencies to the APRIORI DXE section, and use a
rule override to emit the executable images in a way that permits them
to execute in place from the firmware volume. This allows them to be
mapped with the appropriate permissions before dispatching the DXE core.
Signed-off-b
Introduce a new bit in the NX memory protection policy PCD mask that
specifies that the platform enters DXE with all unused and all non-code
regions mapped with non-execute permissions.
This removes the need to do a pass over all memory regions to update
their NX memory attributes.
Signed-off-by:
Before handing over to the DXE core, iterate over all known FFS files
and find the ones that can execute in place. These files are then
relocated in place and mapped with restricted permissions, allowing the
DXE core to dispatch them without the need to perform any manipulation
of the file contents
In the image loader, check whether an image has already been relocated
to the address from which it is being loaded. This is not something that
can happen by accident, and so we can assume that this means that the
image was intended to be executed in place.
This removes a redundant copy of the ima
Expose the EDK2 specific memory mapped FV protocol in addition to the
firmware volume protocol defined by PI when the underlying firmware
volume block protocol informs us that the firmware volume is memory
mapped. This permits the image loader to access any FFS files in the
image directly, rather t
Use the memory mapped FV protocol to obtain the existing location in
memory and the size of an image being loaded from a firmware volume.
This removes the need to do a memcopy of the file data.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/DxeMain.h| 1 +
MdeModulePkg
If a firmware volume is memory mapped, it means we can access it
contents directly, and so caching serves little purpose beyond
potentially a minor performance improvement. However, given that most
files are read only a single time, and dispatched from a decompressed
firmware volume in DRAM, we can
CoreLoadImageCommon's only user passes NULL for its EntryPoint argument,
so it has no purpose and can simply be dropped. While at it, make
CoreLoadImageCommon STATIC to prevent it from being accessed from other
translation units.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Image/Imag
The FreePage argument to CoreUnloadAndCloseImage () is now always TRUE
so drop it from the prototype. While at it, make the function static as
it is never called from another translation unit.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Image/Image.c | 15 +++
1 file chan
The DstBuffer and NumberOfPages arguments to CoreLoadImageCommon () are
never set by its only caller CoreLoadImage() so let's drop them from the
prototype.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Image/Image.c | 174 +++-
1 file changed, 56 insertions(+), 118 dele
TL;DR - allow DXE drivers to execute in place from the decompressed FV
loaded into memory by DxeIpl so we can apply strict permissions before
dispatching DXE core.
Currently, executable images loaded from firmware volumes are copied at
least three times: once in the firmware volume driver, once in
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 29, 2023 2:24 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue.
>
>
57 matches
Mail list logo
