Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Monday, June 5, 2023 4:32 PM > To: Ranbir Singh > Cc: devel@edk2.groups.io; pedro.falc...@gmail.com; Wu, Hao A > ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH 2/2] > MdeModulePkg/Bus/Ata/AtaAtapiPassTh

Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.

It should be same with my PR. But you miss my Reviewed-by. I just rebase my PR: ShellPkg/SmbiosView: type 45 and type 46 support. by ZhichaoGao · Pull Request #4528 · tianocore/edk2 (github.com) If you want the maintainer to push your patch directly wi

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices support

Thanks. Please help to: * Update the DSC file in the last commit (patch 3/3 of the series). Patch 1/3 only adds NetworkCommon & UsbRndis, this will cause build failure in certain scenario. * Add the Bugzilla link information in the commit log message. With above handled: Acked-by: Hao A Wu Al

Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.

Zhichao, PR, ShellPkg/SmbiosView: type 45 and type 46 support. by wangsim · Pull Request #4482 · tianocore/edk2 (github.com) ( https://github.com/tianocore/edk2/pull/4482 ) Just finished CI/CD check. Thanks, Simon -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

[edk2-devel] [PATCH 4/4] UefiCpuPkg: Init new MSR value for MtrrLib Unit Test

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Using new API GetMaxPlatformAddressBits, MtrrLib Unit Test needs to provide the value of MSR MSR_IA32_TME_CAPABILITY. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Zhiguang Liu --- UefiCpuPkg/Library/MtrrLi

[edk2-devel] [PATCH 3/4] UefiCpuPkg: Clean up some Mtrr code using new API

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 With new API GetMaxPlatformAddressBits, the API MtrrLibInitializeMtrrMask and InitializeMtrrMask can be replaced. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Zhiguang Liu --- UefiCpuPkg/CpuDxe/CpuDxe.c

[edk2-devel] [PATCH 1/4] MdePkg: Add new API GetMaxPlatformAddressBits

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Add new API GetMaxPlatformAddressBits to get the max platform address bits. Max physical address bits can be get from CPUID. When TME-MK feature is enabled, the upper bits of the max physical address bits are repurposed for usage as a KeyID.

[edk2-devel] [PATCH 2/4] PrmPkg: Use new API to replace MtrrLibInitializeMtrrMask

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 The function MtrrLibInitializeMtrrMask is a private function in MtrrLib.c from UefiCpuPkg, and it can be replace with new API GetMaxPlatformAddressBits. Cc: Michael Kubacki Cc: Nate DeSimone Signed-off-by: Zhiguang Liu --- .../PrmSample

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, June 8, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, June 8, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e34

[edk2-devel] [Patch V5 12/14] UefiCpuPkg: Sort mProtectionMemRange when ReadyToLock

Sort mProtectionMemRange in InitProtectedMemRange() when ReadyToLock. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 32 1 file changed, 32 insertions(+) diff --git a/UefiCpuPkg/

[edk2-devel] [Patch V5 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove unnecessary function

Remove unnecessary function SetNotPresentPage(). We can directly use ConvertMemoryPageAttributes to set a range to non-present. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 ++-- Uef

[edk2-devel] [Patch V5 13/14] UefiCpuPkg: Refinement to smm runtime InitPaging() code

This commit is code refinement to current smm runtime InitPaging() page table update code. In InitPaging(), if PcdCpuSmmProfileEnable is TRUE, use ConvertMemoryPageAttributes() API to map the range in mProtectionMemRange to the attrbute recorded in the attribute field of mProtectionMemRange, map th

[edk2-devel] [Patch V5 11/14] UefiCpuPkg: Sort mSmmCpuSmramRanges in FindSmramInfo

Sort mSmmCpuSmramRanges after get the SMRAM info in FindSmramInfo() function. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 32 1 file changed, 32 insertions(+) diff --git

[edk2-devel] [Patch V5 10/14] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 page table

Use GenSmmPageTable() to create both IA32 and X64 Smm S3 page table. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmProfileArch.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 130 ---

[edk2-devel] [Patch V5 09/14] UefiCpuPkg: Add GenSmmPageTable() to create smm page table

This commit is code refinement to current smm pagetable generation code. Add a new GenSmmPageTable() API to create smm page table based on the PageTableMap() API in CpuPageTableLib. Caller only needs to specify the paging mode and the PhysicalAddressBits to map. This function can be used to create

[edk2-devel] [Patch V5 08/14] UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h

Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h and remove extern for mSmmShadowStackSize in c files to simplify code. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 3 +-- UefiCpuPkg/PiSmmCpuDxeSmm/MpServi

[edk2-devel] [Patch V5 07/14] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR0.WP before modify page table

Clear CR0.WP before modify smm page table. Currently, there is an assumption that smm pagetable is always RW before ReadyToLock. However, when AMD SEV is enabled, FvbServicesSmm driver calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask bit in smm page table for this range: [PcdOvmfFdBa

[edk2-devel] [Patch V5 06/14] UefiCpuPkg/PiSmmCpuDxeSmm: Add 2 function to disable/enable CR0.WP

Add two functions to disable/enable CR0.WP. These two unctions will also be used in later commits. This commit doesn't change any functionality. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h |

[edk2-devel] [Patch V5 05/14] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid setting non-present range to RO/NX

In PiSmmCpuDxeSmm code, SetMemMapAttributes() marks memory ranges in SmmMemoryAttributesTable to RO/NX. There may exist non-present range in these memory ranges. Set other attributes for a non-present range is not permitted in CpuPageTableMapLib. So add code to handle this case. Only map the presen

[edk2-devel] [Patch V5 04/14] UefiCpuPkg: Add DEBUG_CODE for special case when clear RP

In ConvertMemoryPageAttributes() function, when clear RP for a specific range [BaseAddress, BaseAddress + Length], it means to set the present bit to 1 and assign default value for other attributes in page table. The default attributes for the input specific range are NX disabled and ReadOnly. If t

[edk2-devel] [Patch V5 03/14] UefiCpuPkg: Use CpuPageTableLib to convert SMM paging attribute.

Simplify the ConvertMemoryPageAttributes API to convert paging attribute by CpuPageTableLib. In the new API, it calls PageTableMap() to update the page attributes of a memory range. With the PageTableMap() API in CpuPageTableLib, we can remove the complicated page table manipulating code. Signed-o

[edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

Remove RO and NX protection when unset guard page. When UnsetGuardPage(), remove all the memory attribute protection for guarded page. Signed-off-by: Dun Tan Cc: Liming Gao Cc: Ray Ni Cc: Jian J Wang --- MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[edk2-devel] [Patch V5 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry

Remove code that apply AddressEncMask to non-leaf entry when split smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask bit in page table for a specific range. In AMD SEV feature, this AddressEncMask bit in page table is us

[edk2-devel] [Patch V5 00/14] Use CpuPageTableLib to create and update smm page table

In V5 patch set: 1.Remove duplicated patches to add CpuPageTableLib into some DSC files. 2.Seperate the DEBUG_CODE of ConvertMemoryPageAttributes() to a new patch 'Add DEBUG_CODE for special case when clear RP'. Also fix issues in the DEBUG_CODE and add more detailed debug message about it 3.Fix

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix workflows folder location

[AMD Official Use Only - General] Reviewed-by: Abner Chang Get Outlook for Android From: Nickle Wang Sent: Thursday, June 8, 2023 10:03:45 AM To: devel@edk2.groups.io Cc: Chang, Abner ; Igor Kulchytskyy Subject: [edk2-redfish-client][P

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix workflows folder location

There is additional ".github" folder in early commit. Move the workflows folder to correct location. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/{.github => }/workflows/build.sh| 0 .github/{.github => }/workflows/build.yml | 0 .github/{.g

Re: [edk2-devel] [PATCH] ShellPkg: Increase PcdShellPrintBufferSize from UINT16 to UINT32

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Giri Mudusuru > Sent: Tuesday, June 6, 2023 2:02 PM > To: devel@edk2.groups.io > Cc: Giri Mudusuru ; Ni, Ray ; Gao, > Zhichao ; Andrew Fish > Subject: [PATCH] ShellPkg: Increase PcdShellPrintBufferSize from UINT16 to

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove UEFI Shell Binaries section

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, June 7, 2023 5:54 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Gao, Zhichao ; Leif Lindholm > > Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Remove UEFI Shell > Binaries secti

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove me from maintainers of UefiPayloadPkg,ShellPkg

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Guo, Gua > Sent: Wednesday, June 7, 2023 2:19 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Dong, Guo ; Rhodes, Sean > ; Lu, James ; Gao, Zhichao > > Subject: RE: [edk2-devel] [PATCH] Maintainers.txt: Remove me from

Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.

I create the PR: ShellPkg/SmbiosView: type 45 and type 46 support. by ZhichaoGao · Pull Request #4528 · tianocore/edk2 (github.com) But it fail because some CI canceled. Thanks, Zhichao From: gaoliming Sent: Friday, June 2, 2023 9:22 AM To: devel@ed

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

Thank you, Nickle Get Outlook for Android From: Chang, Abner Sent: Wednesday, June 7, 2023 8:28:11 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg/.gith

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

[AMD Official Use Only - General] Nice work Nickle!! Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, June 8, 2023 12:12 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/.g

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

On Wed, Sep 23, 2020 at 08:36 PM, Henz, Patrick wrote: > > From: Patrick Henz > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 > > Timeouts in the XhciDxe driver are taking longer than > expected due to the timeout loops not accounting for > code execution time. As en example, 5 seco

[edk2-devel] errors in ovmf log

Hi, On 'AMD platform + xen +ubuntu dom0', while booting Android domu , ovmf.log shows below errors. Can someone help me how to avoid these errors. Though boot succeeds, it takes a long time to boot. 1) Error: Image at 000EF785000 start failed: Unsupported 2) Error: Image at 000EF7C3000 start fai

Re: [edk2-devel][PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

On 6/7/2023 10:31 AM, Ard Biesheuvel wrote: On Wed, 7 Jun 2023 at 18:10, Oliver Smith-Denny wrote: Per the discussion in the memory protections design meeting this morning, I am kicking this patch back to the top of the inbox for review. If folks would like me to resend this patchset since the

Re: [edk2-devel][PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

On Wed, 7 Jun 2023 at 18:10, Oliver Smith-Denny wrote: > > Per the discussion in the memory protections design meeting > this morning, I am kicking this patch back to the top of > the inbox for review. If folks would like me to resend this > patchset since the thread got bogged down with schedulin

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg: RISC-V: TimerLib: Fix delay function to use 64-bit

The timer compare register is 64-bit so simplifying the delay function. Cc: Andrei Warkentin Signed-off-by: Tuan Phan Reviewed-by: Sunil V L --- V2: Fix format issue with uncrustify. MdePkg/Include/Register/RiscV64/RiscVImpl.h | 1 - .../BaseRiscV64CpuTimerLib/CpuTimerLib.c | 53 +

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg: CpuTimerDxeRiscV64: Fix incorrect value sent to SbiSetTimer

SbiSetTimer expects core tick value. Cc: Andrei Warkentin Signed-off-by: Tuan Phan Reviewed-by: Sunil V L --- V2: Fixed format issue with uncrustify. .../CpuTimerDxeRiscV64/CpuTimerDxeRiscV64.inf | 3 +++ UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c | 26 --- UefiCpuPkg/CpuT

Re: [edk2-devel] failed pr

On Wed, 7 Jun 2023 at 19:02, Rebecca Cran wrote: > > > On 6/7/23 11:00, Ard Biesheuvel wrote: > > On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote: > >> I've pushed it. > >> > > > > Thanks! How did you manage that? > > > I just realized I pushed the wrong one! I went to the checks tab and > clicke

Re: [edk2-devel] failed pr

On 6/7/23 11:00, Ard Biesheuvel wrote: On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote: I've pushed it. Thanks! How did you manage that? I just realized I pushed the wrong one! I went to the checks tab and clicked the button to re-run all the checks. -- Rebecca Cran -=-=-=-=-=-

Re: [edk2-devel] failed pr

On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote: > > I've pushed it. > Thanks! How did you manage that? > > On 6/7/23 09:09, Ard Biesheuvel wrote: > > I found the button too, and it works as expected. > > > > While the ongoing CI issues are investigated, could someone please > > push the button

Re: [edk2-devel][PATCH v1 1/1] ArmPkg: CpuDxe: Report AARCH64 Memory Protections Attributes To GCD

On Wed, 7 Jun 2023 at 18:13, Oliver Smith-Denny wrote: > > Hi Ard, > > Thanks for the review. Looks like there isn't much conversation > on this one, just reviewed-by's from Michael and you. Can this be > merged? It is ideal for this to go in before the GCD sync patchset, > because without this pa

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

Enable Github Actions to check below items: - RedfishClientPkg build check on push and pull request - Uncrustify check on pull request Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/.github/workflows/build.sh| 70 +++ .github/.github/wor

Re: [edk2-devel][PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

Per the discussion in the memory protections design meeting this morning, I am kicking this patch back to the top of the inbox for review. If folks would like me to resend this patchset since the thread got bogged down with scheduling meetings, just let me know. I'll also pull up the BZ link for

Re: [edk2-devel] failed pr

I've pushed it. -- Rebecca Cran On 6/7/23 09:09, Ard Biesheuvel wrote: I found the button too, and it works as expected. While the ongoing CI issues are investigated, could someone please push the button on this one? Thanks. https://github.com/tianocore/edk2/pull/4529 On Wed, 7 Jun 2023

Re: [edk2-devel] failed pr

I found the button too, and it works as expected. While the ongoing CI issues are investigated, could someone please push the button on this one? Thanks. https://github.com/tianocore/edk2/pull/4529 On Wed, 7 Jun 2023 at 05:16, Wu, Hao A wrote: > > Thanks. Below approach works for me: > > > Fr

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, June 8, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, June 8, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join

[edk2-devel] enable MemoryProfile for uefi shell app

Hello group I'm looking for some help with MemoryProfile to catch some memory leaks in a custom uefi application. I followed the instructions found on: https://github.com/tianocore/tianocore.github.io/wiki/Memory-leak-detection-with-memory-profile-feature However I can't seem to get this to work

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/Bhyve: include TPM driver

Reviewed-by: Rebecca Cran -- Rebecca Cran On 6/7/23 07:17, Corvin Köhne wrote: From: Corvin Köhne Bhyve will gain support for TPM emulation in the near future. Therefore, prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the bhyve OVMF DSC. Signed-off-by: Corvin Köhne

[edk2-devel] Now: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 (2nd session) - Wednesday, June 7, 2023 #cal-notice

*UEFI Memory Map, GCD, Page Table discussion - ARM/X86 (2nd session)* *When:* Wednesday, June 7, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_M2RjMDI1NjEtMmQ3MS00ZWM0LTlkMzEtOWU1NGE2MGUwYmYx%40thread.v2/0?context=%7b%22Tid%22%3a

[edk2-devel] Event: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 (2nd session) - Wednesday, June 7, 2023 #cal-reminder

*Reminder: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 (2nd session)* *When:* Wednesday, June 7, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_M2RjMDI1NjEtMmQ3MS00ZWM0LTlkMzEtOWU1NGE2MGUwYmYx%40thread.v2/0?context=%7b%2

[edk2-devel] [PATCH v2 1/1] OvmfPkg/Bhyve: include TPM driver

From: Corvin Köhne Bhyve will gain support for TPM emulation in the near future. Therefore, prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the bhyve OVMF DSC. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca C

[edk2-devel] [PATCH v2 0/1] bhyve: tpm support

Hi, I'm working on TPM emulation for bhyve and would like to merge this patchset to edk2. As already send this patch to edk2 by mistake, I'm now resending this patch as v2. I've already created a PR to run all CI checks at: https://github.com/tianocore/edk2/pull/4531 Thanks, Corvin Corvin Köhn

Re: [edk2-devel] [PATCH v1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

Thanks Jiewen. I will change this. -Original Message- From: Yao, Jiewen Sent: Wednesday, June 7, 2023 10:31 AM To: Zhang, Hongbin1 ; Ni, Ray ; devel@edk2.groups.io Cc: Zeng, Star ; Wu, Jiaxin ; Sami Mujawar ; Ard Biesheuvel ; Supreeth Venkatesh ; Bu, Daocheng ; Chen, Bo Subject: RE:

Re: [edk2-devel] [PATCH v1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

Thanks Ray. Replied your code comments with [Hongbin]. And I will split to several patches, it will be better for reviewing. -Original Message- From: Ni, Ray Sent: Wednesday, June 7, 2023 10:04 AM To: Zhang, Hongbin1 ; devel@edk2.groups.io; Yao, Jiewen Cc: Zeng, Star ; Wu, Jiaxin ; Sam

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Remove reviewer for StandaloneMmPkg

On Wed, 7 Jun 2023 at 12:32, Sami Mujawar wrote: > > Supreeth is no longer supreeth.venkat...@arm.com. Therefore, > remove the reviewer entry from StandaloneMmPkg. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Ray Ni > > Signed-off-by: Sami Mujawar Thanks, I'll merge this along with the other

Re: [edk2-devel] [PATCH] Maintainers.txt: Update maintainers for StandaloneMmPkg

Hi Ard, On Wed, Jun 7, 2023 at 01:29 AM, Ard Biesheuvel wrote: > > On Wed, 7 Jun 2023 at 09:40, Sami Mujawar wrote: > >> Reviewed-by: Sami Mujawar > > Thanks, I'll pick this up. > > While we're at it, mind sending a patch to remove Supreeth? I have submitted a patch to update the reviewer

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Remove reviewer for StandaloneMmPkg

Supreeth is no longer supreeth.venkat...@arm.com. Therefore, remove the reviewer entry from StandaloneMmPkg. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Ray Ni Signed-off-by: Sami Mujawar --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove UEFI Shell Binaries section

On Wed, 7 Jun 2023 at 05:26, Ni, Ray wrote: > > The Shell binaries are not generated anymore in each > stable tag release. > So, remove the section. > > Cc: Zhichao Gao > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Ray Ni Reviewed-by: Ard Biesheuvel > --- > Maintainers.txt | 8

Re: [edk2-devel] [PATCH] UefiCpuPkg/SmmCpu: Add PcdSmmApPerfLogEnable control AP perf-logging

This patch is based on patch series: https://edk2.groups.io/g/devel/message/105492. I don't want to send a V3 for just including the additional patch. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, June 7, 2023 4:38 PM > To: devel@edk2.groups.io

[edk2-devel] [PATCH] UefiCpuPkg/SmmCpu: Add PcdSmmApPerfLogEnable control AP perf-logging

When a platform has lots of CPU cores/threads, perf-logging on every AP produces lots of records. When this multiplies with number of SMIs during post, the records are even more. So, this patch adds a new PCD PcdSmmApPerfLogEnable (default TRUE) to allow platform to turn off perf-logging on APs.

Re: [edk2-devel] [PATCH] Maintainers.txt: Update maintainers for StandaloneMmPkg

On Wed, 7 Jun 2023 at 09:40, Sami Mujawar wrote: > > Reviewed-by: Sami Mujawar > Thanks, I'll pick this up. While we're at it, mind sending a patch to remove Supreeth? > > On 07/06/2023, 04:20, "Ray Ni" mailto:ray...@intel.com>> > wrote: > > > Signed-off-by: Ray Ni mailto:ray...@intel.com>>

Re: [edk2-devel] [PATCH] Maintainers.txt: Update maintainers for StandaloneMmPkg

Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 07/06/2023, 04:20, "Ray Ni" mailto:ray...@intel.com>> wrote: Signed-off-by: Ray Ni mailto:ray...@intel.com>> Cc: Ard Biesheuvel mailto:ardb+tianoc...@kernel.org>> Cc: Sami Mujawar mailto:sami.muja...@arm.com>> Cc: Jiewen Yao mailto:jiewen..

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg: Introduce Hii2RedfishBootDxe driver

[AMD Official Use Only - General] Same as the comment given to 1/3, let's rename Hii2 to HiiTo. The same comment applied to 3/3. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 6, 2023 9:38 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy

[edk2-devel] [PATCH] OvmfPkg: RiscVVirt: Fix wrong checking Pci IO access

RiscV uses memory access for IO and MMIO resources, the address limit is MAX_ADDRESS for both of them. Signed-off-by: Tuan Phan --- OvmfPkg/RiscVVirt/PciCpuIo2Dxe/PciCpuIo2Dxe.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/RiscVVirt/PciCpuIo2Dxe/PciCpuIo2Dx