Re: [edk2-devel] [PATCH] UefiCpuPkg/SmmCpu: Add PcdSmmApPerfLogEnable control AP perf-logging

Looks good to me. Thanks, Eric -Original Message- From: Ni, Ray Sent: Wednesday, June 7, 2023 4:38 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: [PATCH] UefiCpuPkg/SmmCpu: Add PcdSmmApPerfLogEnable control AP perf-logging When a platform has

Re: [edk2-devel] [PATCH V2 0/6] Enable perf-logging in SMM environment

This patch serial looks good to me. Thanks, Eric -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Wednesday, May 31, 2023 7:35 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH V2 0/6] Enable perf-logging in SMM environment Ray Ni (6):

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, June 8, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, June 8, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

Hello, Is it possible for you to verify the proposed change on a hard disk working under IDE mode to see: a) If it can still be successfully recognized; b) The SetDriveParameters call has been reached and returns with no error. My opinion is that the change needs to be tested at least to

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

Ard, https://github.com/tianocore/edk2/blob/8314a85893f5b75baa0031a5138028188a626243/UefiCpuPkg/SecCore/SecMain.c#L637 is changed by @Wu, Jiaxin to create page table in permanent memory. (I didn't check your patch in detail. But it sounds like you try to do the same thing that above code has

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

On Thu, 8 Jun 2023 at 21:32, Michael Kubacki wrote: > > I think Sean's point aligns more closely with traditional PI boot phase > separation goals. Btw, in the project we discussed, this issue was meant > to capture the DXE memory protection init dependencies - >

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

Acked-by: Michael Kubacki Inline code comment below. On 4/12/2023 5:25 PM, Abhimanyu Singh wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4410 Inside TcgMorLockSmm.c, the SetVariableCheckHandlerMorLock() function contains a scenario to prevent a possible dictionary attack on the

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

Jian and Liming, I was wondering if y'all could review this patch? It is a small change so hopefully there is not much downtime to review/test. Thank you, Abhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105957):

[edk2-devel] [PATCH v1 2/2] MdeModulePkg: Variable: Introduce MM based variable read service in PEI

From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This change introduced the Standalone MM based variable read capability in PEI phase for applicable platforms (such as ARM platforms). Similar to the x86 counterpart, MM communicate PPI is used to request variable

[edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 As of today, there has been a void in the variable service in PEI phase on ARM systems that support PEI phase and standalone MM hosted variable service. This change adds the support through: 1. Add MM communication services in PEI phase

[edk2-devel] [PATCH v1 1/2] ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI

From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This change introduced the MM communicate support in PEI phase for ARM based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is used as communicate buffer and SMC will be invoked to communicate to TrustZone when

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

On 6/8/2023 1:23 PM, Ard Biesheuvel wrote: Currently, we rely on the logic in DXE IPL to create new page tables from scratch when executing in X64 mode, which means that we run with the initial page tables all throughout PEI, and never enable protections such as the CPU stack guard, even though

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

I think Sean's point aligns more closely with traditional PI boot phase separation goals. Btw, in the project we discussed, this issue was meant to capture the DXE memory protection init dependencies - https://github.com/tianocore/edk2/issues/4502 if someone would like to update that at some

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuMpPei: Print correct buffer size used for page table

Reviewed-by: Michael Kubacki A couple comments below. On 6/8/2023 1:23 PM, Ard Biesheuvel wrote: The DEBUG print that outputs the base and size of the page table allocation always prints 0x0 for the size, given that BufferSize will be updated by PageTableMap () and contain the unused

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

On 6/8/2023 10:48 AM, Ard Biesheuvel wrote: On Thu, 8 Jun 2023 at 19:39, Oliver Smith-Denny wrote: On 6/8/2023 10:23 AM, Ard Biesheuvel wrote: Currently, we rely on the logic in DXE IPL to create new page tables from scratch when executing in X64 mode, which means that we run with the initial

[edk2-devel] [PATCH v2 3/3] SecurityPkg: SubClassTpm: Updated default value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This change updated the default value of TPM device subclass PCD to `0x010E` in order to match the definition of EFI_PERIPHERAL_TPM from PI specification v1.8. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar

[edk2-devel] [PATCH v2 1/3] MdePkg: PiStatusCode: Add new Host Software class Error Code to MdePkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 This change introduces a new error code definitions under Host Software class according to PI specification v1.8. The new error code definition will cover system reboot events under the conditions of inconsistent memory map from one boot

[edk2-devel] [PATCH v2 2/3] MdePkg: PiStatusCode: Add TPM subclass definition to MdePkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This change introduces a new peripheral subclass definition from PI specification v1.8. The new subclass definition will cover system reboot events under the status reports from Trusted Platform Modules (TPMs). These definition could

[edk2-devel] [PATCH v2 0/3] Adding Status Code Definitions from PI Spec v1.8

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This v2 series is a follow up of previously submitted patches: https://edk2.groups.io/g/devel/message/105599 The v2 patches include `Reviewed-by` tags collected during the v1 round

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

On Thu, 8 Jun 2023 at 19:39, Oliver Smith-Denny wrote: > > On 6/8/2023 10:23 AM, Ard Biesheuvel wrote: > > Currently, we rely on the logic in DXE IPL to create new page tables > > from scratch when executing in X64 mode, which means that we run with > > the initial page tables all throughout PEI,

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

On 6/8/2023 10:23 AM, Ard Biesheuvel wrote: Currently, we rely on the logic in DXE IPL to create new page tables from scratch when executing in X64 mode, which means that we run with the initial page tables all throughout PEI, and never enable protections such as the CPU stack guard, even though

[edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuMpPei: Print correct buffer size used for page table

The DEBUG print that outputs the base and size of the page table allocation always prints 0x0 for the size, given that BufferSize will be updated by PageTableMap () and contain the unused allocation on return. So move the DEBUG print right after the allocation. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuMpPei X64: Reallocate page tables in permanent DRAM

Currently, we rely on the logic in DXE IPL to create new page tables from scratch when executing in X64 mode, which means that we run with the initial page tables all throughout PEI, and never enable protections such as the CPU stack guard, even though the logic is already in place for IA32. So

[edk2-devel] [PATCH 0/2] UefiCpuPkg/CpuMpPei X64: reallocate page tables in PEI

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4468 Take a step towards enabling a generic approach to manage memory permissions in PEI, by wiring up the existing IA32 page table creation logic in CpuMpPei for X64 as well. This will enable future work to expose a PPI that is available

Re: [edk2-devel] Using Depex for Standalone MM drivers on ARM

Forgot to add applicable maintainers earlier.. It would be great if StandaloneMmPkg maintainers could shed some light here. Thanks, Kun On 6/6/2023 5:57 PM, Kun Qin via groups.io wrote: Hi all, We found an issue a while back on ARM systems, where the Standalone MM drivers with Depex

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

Hi Jess, Thank you for reporting this, it's certainly a bug. I'm planning to implement a fix. Thanks, Patrick Henz -Original Message- From: Jessica Clarke Sent: Wednesday, June 7, 2023 4:38 PM To: h...@mx0a-002e3701.pphosted.com; Henz, Patrick ; devel@edk2.groups.io Subject: Re:

[edk2-devel] Now: TianoCore Community Meeting EMEA/NAMO - Thursday, June 8, 2023 #cal-notice

*TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, June 8, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join on the

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, June 8, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, June 8, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

I mentioned similar approach in https://bugzilla.tianocore.org/show_bug.cgi?id=4204#c1 Let me know if I should update the patch as Hao proposed - if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Set drive parameters Fail, Status = %r\n", Status)); continue; } On Thu, Jun 8, 2023 at

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue

Yes, I have already noted to update this patch on the same lines as discussed in context of https://edk2.groups.io/g/devel/topic/99293622 On Thu, Jun 8, 2023 at 12:48 PM Wu, Hao A wrote: > > -Original Message- > > From: Ranbir Singh > > Sent: Saturday, June 3, 2023 12:09 AM > > To:

[edk2-devel] [PATCH v2] StandaloneMmPkg: Add StandaloneMmIplPei driver.

Add StandaloneMmIplPei IA32/X64 driver at PEI stage. FSP will use this driver to load Standalone MM code to dispatch other Standalone MM drivers. And this is the 1st patch to implement the entrypoint to find the correct SMRAM range and dump it Signed-off-by: Hongbin1 Zhang Cc: Jiewen Yao Cc:

Re: [edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

On Thu, 8 Jun 2023 at 04:28, duntan wrote: > > Remove RO and NX protection when unset guard page. > When UnsetGuardPage(), remove all the memory attribute protection > for guarded page. > Why is it acceptable to remove NX protections here? > Signed-off-by: Dun Tan > Cc: Liming Gao > Cc: Ray

Re: [edk2-devel] [Patch V5 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:27 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; Gerd > Hoffmann ; Tom Lendacky > ; Ni, Ray > Subject: [Patch V5 01/14] OvmfPkg:Remove code that apply

Re: [edk2-devel] [Patch V5 04/14] UefiCpuPkg: Add DEBUG_CODE for special case when clear RP

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 04/14] UefiCpuPkg: Add DEBUG_CODE for special case > when clear RP > > In

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

+maintainers On 2023-06-07 22:37, Jessica Clarke wrote: On Wed, Sep 23, 2020 at 08:36 PM, Henz, Patrick wrote: From: Patrick Henz REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 Timeouts in the XhciDxe driver are taking longer than expected due to the timeout loops not accounting

Re: [edk2-devel] [Patch V5 05/14] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid setting non-present range to RO/NX

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [edk2-devel] [Patch V5 05/14] UefiCpuPkg/PiSmmCpuDxeSmm:

Re: [edk2-devel] [Patch V5 03/14] UefiCpuPkg: Use CpuPageTableLib to convert SMM paging attribute.

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 03/14] UefiCpuPkg: Use CpuPageTableLib to convert SMM > paging attribute. > >

Re: [edk2-devel] [Patch V5 08/14] UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 08/14] UefiCpuPkg: Extern mSmmShadowStackSize in > PiSmmCpuDxeSmm.h > >

Re: [edk2-devel] [Patch V5 13/14] UefiCpuPkg: Refinement to smm runtime InitPaging() code

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 13/14] UefiCpuPkg: Refinement to smm runtime > InitPaging() code > > This

Re: [edk2-devel] [Patch V5 12/14] UefiCpuPkg: Sort mProtectionMemRange when ReadyToLock

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 12/14] UefiCpuPkg: Sort mProtectionMemRange when > ReadyToLock > > Sort

Re: [edk2-devel] [Patch V5 11/14] UefiCpuPkg: Sort mSmmCpuSmramRanges in FindSmramInfo

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 11/14] UefiCpuPkg: Sort mSmmCpuSmramRanges in > FindSmramInfo > > Sort

Re: [edk2-devel] [Patch V5 09/14] UefiCpuPkg: Add GenSmmPageTable() to create smm page table

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 09/14] UefiCpuPkg: Add GenSmmPageTable() to create > smm page table > > This

Re: [edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Ni, Ray ; > Wang, Jian J > Subject: [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection > when unset guard page > > Remove RO and NX

[edk2-devel] [PATCH] UefiPayloadPkg: change capsulelib to null lib and move to bdsfv

From: MarsX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4479 CapsuleRuntimeDxe consume null CapsuleLib instance and move the driver into BDSFV. then, platform code could change it in its owned platform BDSFV. Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Cc: James Lu Cc: Guo Dong

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue

> -Original Message- > From: Ranbir Singh > Sent: Saturday, June 3, 2023 12:09 AM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix > SIGN_EXTENSION Coverity issue > > From: Ranbir Singh > > Line

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Monday, June 5, 2023 4:32 PM > To: Ranbir Singh > Cc: devel@edk2.groups.io; pedro.falc...@gmail.com; Wu, Hao A > ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH 2/2] >

Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.

It should be same with my PR. But you miss my Reviewed-by. I just rebase my PR: ShellPkg/SmbiosView: type 45 and type 46 support. by ZhichaoGao · Pull Request #4528 · tianocore/edk2 (github.com) If you want the maintainer to push your patch directly

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices support

Thanks. Please help to: * Update the DSC file in the last commit (patch 3/3 of the series). Patch 1/3 only adds NetworkCommon & UsbRndis, this will cause build failure in certain scenario. * Add the Bugzilla link information in the commit log message. With above handled: Acked-by: Hao A Wu

Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.

Zhichao, PR, ShellPkg/SmbiosView: type 45 and type 46 support. by wangsim · Pull Request #4482 · tianocore/edk2 (github.com) ( https://github.com/tianocore/edk2/pull/4482 ) Just finished CI/CD check. Thanks, Simon -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this