Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

Thanks All. This patch set is merged just now. - https://github.com/tianocore/edk2/pull/4728 The size increase is indeed a concern since last year. Currently, we have another staging tree - https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL to handle that. Thank you Yao, Jiewen > ---

[edk2-devel] [PATCH v1] UefiCpuPkg/SmmCpu: Refine semaphore sync between BSP and AP

For SMM CPU semaphore sync, there is no need atomic semaphore operation, just use the flag to indicate it has complete the wait/release. Based on this, this patch is to refine 2 functions (WaitForAllAPs & ReleaseAllAPs) and define 2 new functions (WaitForBsp & ReleaseBsp) used for the semaphore syn

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/README: Document Secure Boot

ping. Is anyone interested in reviewing this patch? On Fri, 30 Jun 2023 02:26:03 +0400 "Joursoir" wrote: > Add the new section for Secure Boot. > > Signed-off-by: Alexander Goncharov > --- > OvmfPkg/README | 40 > 1 file changed, 40 insertions(+) > >

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

On Tue, 8 Aug 2023 at 23:16, Desimone, Nathaniel L wrote: > > Reviewed-by: Nate DeSimone > Pushed as 648aa9ee26926f33..8c09bd0955338db3 Thanks, > > -Original Message- > > From: Tommy Huang > > Sent: Monday, August 7, 2023 11:12 PM > > To: devel@edk2.groups.io > > Cc: a...@kernel.org;

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

Hi Sami, Any chance we can try to get your dispatcher patches in for the upcoming release.(if there are no other comments). Best Regards Girish On 7/25/2023 5:29 PM, Girish Mahadevan via groups.io wrote: External email: Use caution opening links or attachments Hi Sami My responses inline

[edk2-devel] Runtime Page Granularity on ARM64

Hi Ard, I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page) to fix HeapGuard GuardAlignedToTail behavior on ARM64. However, this raised a question of why ARM64 sets RUNTIME_PAGE_ALLOCATION_GRANULARITY to 64k when X64 does not. You added this in Proces

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page

On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny wrote: > > Currently, HeapGuard, when in the GuardAlignedToTail mode, assumes that > the pool head has been allocated in the first page of memory that was > allocated. This is not the case for ARM64 platforms when allocating > runtime pools, as RUNTI

Re: [edk2-devel] Runtime Page Granularity on ARM64

Hi, On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny wrote: > > Hi Ard, > > I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head > Allocated In First Page) to fix HeapGuard GuardAlignedToTail behavior on > ARM64. However, this raised a question of why ARM64 sets > RUNTIME_PAGE_

Re: [edk2-devel] Runtime Page Granularity on ARM64

Oliver, My understanding is that AArch64 (ARMv8) supports 3 page table granules: 4KB, 16KB, and 64KB [1]. These granules represent the smallest range for a page table, and this granule changes which bits of the VA index into what level of paging. On x86 this indexing was fixed an a 2 MiB page t

Re: [edk2-devel] Runtime Page Granularity on ARM64

Thanks Ard and Andrew, I appreciate the info! That clears things up for me. Oliver On 8/9/2023 3:56 PM, Ard Biesheuvel wrote: Hi, On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny wrote: Hi Ard, I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page)

[edk2-devel] [PATCH 1/2] MdePkg: Add ProcessorUpgradeSocket definitios from SMBIOS 3.7.0

This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 - ProcessorUpgradeSock

[edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update

Introduce cpp-specific formatting rules to Uncrustify for readability: * indent_class: indent lines inside of a class * indent_extern: indent lines inside of an extern Apply all Uncrustify formatting rules defined in the config to existing cpp and header files (GoogleTest files). Moving forward

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Hi @Yao, Jiewen, The proposed solution to clear screen will be called only when user has to provide the input key. This call will not execute in other conditions. When there is a pending request in Tcg2, system will wait until user press input key. If there is no pro

[edk2-devel] [PATCH 2/2] ShellPkg: Add ProcessorUpgradeSocket definitios from SMBIOS 3.7.0

This patch adds below definitions from SMBIOS 3.7.0 into QueryTable.c - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 - ProcessorUpgrade

[edk2-devel] [PATCH V7 0/2] Support RSA4096 and RSA3072

Patch V7: Drop raw RSA3072 and RSA4096. Only use gEfiCertX509Guid for RSA3072 and RSA4096 Do the positive tests and the negative tests below. And got all the expected results. Patch V6: Remove the changes in MdePkg. The changes of patch v6 are in CryptoPkg and SecurityPkg. Set signature type to g

[edk2-devel] [PATCH V7 1/2] CryptoPkg/Library/BaseCryptLib: add sha384 and sha512 to ImageTimestampVerify

Register and initialize sha384/sha512 digest algorithms for PKCS#7 Handling. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413 Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Cc: Zeyi Chen Cc: Fiona Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Change-Id: I208a618e3f6eb12704e

[edk2-devel] [PATCH V7 2/2] SecurityPkg/SecureBoot: Support RSA4096 and RSA3072

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413 Change-Id: Ic13595ffb0581a178db71d231ba34f17862fa5d8 Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Cc: Zeyi Chen Cc: Fiona Wang Signed-off-by: Sheng Wei --- .../Library/AuthVariableLib/AuthService.c | 218 +++--- .../AuthV

Re: [edk2-devel] [PATCH V6 0/2] SecureBoot: Support RSA 512 and RSA 384

Hi Jiewen, Thank you for comments. I update the patch V6 to V7, drop raw RSA3K and RSA4K. The change is in SecurityPkg. And I did all the tests which are listed in the cover letter. I got the expected results. Could you help to review/merge the patches ? Thank you. BR Sheng Wei > -Original

Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue

> -Original Message- > From: Ranbir Singh > Sent: Monday, July 17, 2023 7:39 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray ; Veeresh > Sangolli > Subject: [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT > Coverity issue > > From: Ranbir Singh

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: Ranbir Singh > Sent: Monday, July 17, 2023 7:59 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH v2 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix > SIGN_EXTENSION Coveri

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: Ranbir Singh > Sent: Monday, July 17, 2023 7:40 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray ; Veeresh > Sangolli > Subject: [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fi

Re: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix FORWARD_NULL Coverity issues

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: Ranbir Singh > Sent: Monday, July 17, 2023 7:39 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray ; Veeresh > Sangolli > Subject: [PATCH v1 2/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix > FO