Re: [edk2-devel] [PATCH 2/2] ShellPkg: Add ProcessorUpgradeSocket definitios from SMBIOS 3.7.0

2023-08-10 Thread Gao, Zhichao
With title fix: Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Zeng, Star > Sent: Thursday, August 10, 2023 7:07 PM > To: devel@edk2.groups.io; Cuevas Farfan, Eduardo > > Cc: Gao, Zhichao ; Zeng, Star > Subject: RE: [edk2-devel] [PATCH 2/2] ShellPkg: Add >

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

2023-08-10 Thread Wu, Hao A
My personal preference is to do this as two steps. Address the issue in XhciDxe first. Then add new TimerLib API to replace all driver/library internal implementations. Best Regards, Hao Wu > -Original Message- > From: Henz, Patrick > Sent: Friday, August 11, 2023 6:45 AM > To:

Re: [edk2-devel] [edk2-platforms][PATCH V1] Platform/Loongson: Add AcpiPlatformLib to fix compile error

2023-08-10 Thread Chao Li
Reviewed-by: Chao Li Thanks, Chao 在 2023/8/10 15:05, xianglai 写道: Adding a reference to AcpiPlatformLib to the dsc file as loongarch is used to fix compilation errors. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

2023-08-10 Thread Henz, Patrick
I can certainly make that change. For what it's worth I have been working on adding the new function, GetElapsedTicks, to the various implementations of TimerLib. I've finished up testing, I would just need to clean up the commits for a patch. Should I move forward with that, or would we

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-10 Thread Michael Kubacki
I'm not sure why test results are not being reported that may be a larger issue. I pulled the branch locally, run uncrustify, and it automatically fixed the code to pass. The issue is the following function call: BuildPlatformInfoHob(); Should be: BuildPlatformInfoHob (); On

Re: [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files

2023-08-10 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of VivianNK > Sent: Wednesday, August 9, 2023 2:32 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: Apply > uncrustify formatting to relevant files > >

Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib

2023-08-10 Thread Sami Mujawar
Hi Pierre, Please send an updated version with the r-b collected. That way it would be less work for the maintainer. Regards, Sami Mujawar From: Pierre Gondois Sent: Thursday, August 10, 2023 6:49:40 PM To: Sami Mujawar ; devel@edk2.groups.io Subject: Re:

[edk2-devel] [PATCH v1 0/1] Fix Memory Bin Range Calculation to Account for Guard Page

2023-08-10 Thread Taylor Beebe
From: Taylor Beebe The following flow will produce an issue: If page guards are active for EfiReservedMemoryType and SMM NULL pointer protection is active with nonstop mode enabled, then a large (600 page) allocation of EfiReservedMemoryType will be made for profiling. 0. InitSmmProfile() will

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: Memory Bin Range Update Accounts for Guard Page

2023-08-10 Thread Taylor Beebe
From: Taylor Beebe When finding a free page range for allocation, if the found range starts below the tracked memory bin address range, the lowest memory bin address is updated which will not include the guard page if present. When CoreConvertPagesWithGuard() is called on the range being

[edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

2023-08-10 Thread Eduardo Cuevas Farfan
This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 -

[edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

2023-08-10 Thread Eduardo Cuevas Farfan
This patch adds below definitions from SMBIOS 3.7.0 into QueryTable.c - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 -

[edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

2023-08-10 Thread Eduardo Cuevas Farfan
Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 sources Eduardo Cuevas Farfan (2): MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 MdePkg/Include/IndustryStandard/SmBios.h | 12 +--

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-10 Thread Ard Biesheuvel
Could someone please decipher this for us please? I am sick and tired of the CI impeding my work. On Thu, 10 Aug 2023 at 15:33, Corvin Köhne wrote: > > On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote: > > On Thu, 10 Aug 2023 at 14:53, Corvin Köhne > > wrote: > > > > > > On Tue,

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-10 Thread Andrew Fish via groups.io
I think that you are advocating that since we have code that error checks on DEBUG and not RELEASE builds we should relax the RELEASE build compiler flags? /home/abuild/rpmbuild/BUILD/edk2-edk2-stable202305/MdeModulePkg/Core/Dxe/Hand/Handle.c:1183:24: error: ‘Prot’ may be used uninitialized

[edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Fix/Update code design gap.

2023-08-10 Thread Susovan Mohapatra
https://bugzilla.tianocore.org/show_bug.cgi?id=4461 1. The function GetRandomNumber128() returns a boolean TRUE/FALSE. The existing code was getting data in EFI_STATUS.0==FALSE==EFI_SUCCESS Updated code to check for the return value before proceeding further. 2. The 'seed' from the

[edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-10 Thread 汪流
I want to build a rpm package for edk2-stable202305 on riscv64, however I get some uninitialized variable error, I have found that the reason is -Werror flag. My build target was release. I think the flag should used in the debug ,not in release. My build command: build -t GCC5 -n $NCPUS -b

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-10 Thread Corvin Köhne
On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote: > On Thu, 10 Aug 2023 at 14:53, Corvin Köhne > wrote: > > > > On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: > > > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran > > > wrote: > > > > > > > > Nit: "sizeof" is normally used like a

Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib

2023-08-10 Thread PierreGondois
Hi Sami, Yes indeed, this line should be removed, do you want me to send a new version of this patch ? Regards, Pierre On 8/7/23 07:16, Sami Mujawar wrote: Hi Pierre, Thank you for this patch. On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote: + gEfiRngAlgorithmArmRndr ##

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-10 Thread Ard Biesheuvel
On Thu, 10 Aug 2023 at 14:53, Corvin Köhne wrote: > > On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: > > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > > > > > > Nit: "sizeof" is normally used like a function. And this patch > > > mixes the > > > two styles. > > > > > > > Actually,

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-10 Thread Corvin Köhne
On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > > > > Nit: "sizeof" is normally used like a function. And this patch > > mixes the > > two styles. > > > > Actually, this is not unidiomatic for OVMF - sizeof takes either a > type

Re: [edk2-devel] [Patch V7 0/4] Wake up APs after power-up or RESET through SIPI.

2023-08-10 Thread Ard Biesheuvel
On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote: > > The implementation of this new behavior aligns with the > guidelines outlined in the Intel SDM. > > Following a power-up or RESET of an MP system, system hardware > dynamically selects one of the processors on the system bus as > the BSP. The

Re: [edk2-devel] [Patch V7 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-08-10 Thread Ard Biesheuvel
On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote: > > Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by > INIT-SIPI-SIPI. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Signed-off-by:

Re: [edk2-devel] [PATCH 2/2] ShellPkg: Add ProcessorUpgradeSocket definitios from SMBIOS 3.7.0

2023-08-10 Thread Zeng, Star
There is typo definitios -> definitions in subject. Please correct it. Cc maintainers. Thanks, Star -Original Message- From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas Farfan Sent: Wednesday, August 9, 2023 11:03 AM To: devel@edk2.groups.io Cc: Cuevas Farfan, Eduardo Subject:

Re: [edk2-devel] [PATCH 1/2] MdePkg: Add ProcessorUpgradeSocket definitios from SMBIOS 3.7.0

2023-08-10 Thread Zeng, Star
There is typo definitios -> definitions in subject. Please correct it. Cc maintainers. Thanks, Star -Original Message- From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas Farfan Sent: Wednesday, August 9, 2023 11:03 AM To: devel@edk2.groups.io Cc: Cuevas Farfan, Eduardo Subject:

[edk2-devel] [edk2-platforms][PATCH V1] Platform/Loongson: Add AcpiPlatformLib to fix compile error

2023-08-10 Thread xianglai
Adding a reference to AcpiPlatformLib to the dsc file as loongarch is used to fix compilation errors. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 1 + 1