[edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

From: Ranbir Singh The function GetNextHidItem has a switch-case code in which the case 1: falls through to case 2: and then case 2: falls through to case 3: in the block. While this may be intentional, it is not evident to any general code reader as well as any static analyzer tool. Just

[edk2-devel] [PATCH v1 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

From: Ranbir Singh The function USBMouseDriverBindingStart do have ASSERT (UsbMouseDevice != NULL); after AllocateZeroPool, but it is applicable only in DEBUG mode. In RELEASE mode, if for whatever reasons UsbMouseDevice is NULL at this point, the code proceeds to dereference

[edk2-devel] [PATCH v1 0/2] BZ 4222: Fix MdeModulePkg/Bus/Usb/UsbMouseDxe issues pointed by Coverity

Ranbir Singh (2): MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 8 MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 4 2 files changed, 12

Re: [edk2-devel] [PATCH] UefiCpuPkg: RISC-V: MMU: Introduce a PCD for SATP mode

Reviewed-by: Dhaval Sharma -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109306): https://edk2.groups.io/g/devel/message/109306 Mute This Topic: https://groups.io/mt/101742937/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Fix issue with ACPI table creation

Hi everyone, A gentle remonder to review the patch.. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109305): https://edk2.groups.io/g/devel/message/109305 Mute This Topic: https://groups.io/mt/101633356/21656 Group Owner:

Re: [edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: update Readme.md

[AMD Official Use Only - General] Thanks! Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 3, 2023 8:02 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH v2] RedfishClientPkg: update

[edk2-devel] [PATCH] UefiCpuPkg: RISC-V: MMU: Introduce a PCD for SATP mode

Introduce a PCD to control the maximum SATP mode that MMU allowed to use. This PCD helps RISC-V platform set bare or minimum SATA mode during bring up to debug memory map issue. Signed-off-by: Tuan Phan --- UefiCpuPkg/Library/BaseRiscVMmuLib/BaseRiscVMmuLib.c | 6 +-

Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

Thank you , Ard. I very much appreciate your responsiveness. The majority of these patches fall under MdeModulePkg maintainers so I'll also need help from them to drive this forward. On 10/3/2023 11:57 AM, Ard Biesheuvel wrote: On Tue, 3 Oct 2023 at 17:56, Taylor Beebe wrote: Have we given

Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

On Tue, 3 Oct 2023 at 17:56, Taylor Beebe wrote: > > Have we given up on this patch series and Bug 4492? > I haven't, I promise. I will get to this on Thursday or Friday. > On 9/26/2023 9:02 AM, Taylor Beebe via groups.io wrote: > > Reviews on this patch series would be much appreciated :) > >

Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

Have we given up on this patch series and Bug 4492? On 9/26/2023 9:02 AM, Taylor Beebe via groups.io wrote: Reviews on this patch series would be much appreciated :) On 8/28/23 9:38 AM, Ard Biesheuvel wrote: I was hoping to get around to this before the end of the week (but I am not a

Re: [edk2-devel] reg: Two IAID assignment for single MAC Address

+ Saloni and Zachary. From: Sivaraman Nainar Sent: Tuesday, October 3, 2023 10:39 PM To: devel@edk2.groups.io; Maciej Rabeda Cc: Santhosh Kumar V ; Mike Su (蘇得緣) ; Dhanaraj V Subject: reg: Two IAID assignment for single MAC Address Hello Maciej: When IPV6 PXE Boot performed in the

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support

On Tue, Oct 03, 2023 at 18:21:44 +0200, Marcin Juszkiewicz wrote: > It is weird that I can have NVME, can install OS on it but cannot boot > from it. > > This change adds NVME support so it can be mapped and used. Oops, that's a silly thing to have left out. > Signed-off-by: Marcin Juszkiewicz

Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf

+Zhiguang Tested-by: Leif Lindholm MdePkg maintainers - this is currently breaking several platforms in edk2-platforms. Regards, Leif On Fri, Sep 29, 2023 at 13:08:50 +, Sami Mujawar wrote: > Hi Pierre, > > Thank you for this fix. > > Unfortunately, this did not get trapped by the edk2

[edk2-devel] reg: Two IAID assignment for single MAC Address

Hello Maciej: When IPV6 PXE Boot performed in the environment where client and server are connected behind Routers, there are two SARR process happens, and both are using different IAID’s. During the PXE Boot IPV6, SARR Process Initiated to get the Boot File information. During that time one

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support

It is weird that I can have NVME, can install OS on it but cannot boot from it. This change adds NVME support so it can be mapped and used. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 ++ Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 5 + 2 files changed, 11

Re: [edk2-devel] [PATCH] BaseStackCheckLib: Fix STACK FAULT message

I think the macro RETURN_ADDRESS from Base.h should be used instead of direct use of the builtin. Mike > -Original Message- > From: Name j...@nvidia.com > Sent: Tuesday, October 3, 2023 6:20 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Jake >

Re: [edk2-devel] [PATCH v2 5/5] MdePkg/BaseLib: ensure ARM LongJump never returns 0

On 26/9/23 19:15, Leif Lindholm wrote: The ARM implementation of of InternalLongJump always returned the value Value - but it is not supposed to ever return 0. Add the test to prevent that, and return 1 if Value is 0 - as is already present in AArch64. Signed-off-by: Leif Lindholm Cc: Ard

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

On 26/9/23 19:15, Leif Lindholm wrote: Both in SetJump and in InternalLongJump, 32-bit w register views were used for the UINTN return value. In SetJump, this did not cause errors; it was only counterintuitive. But in InternalLongJump, it meant the top 32 bits of Value were stripped off. Change

[edk2-devel] [PATCH 0/1] ShellPkg/SmbiosView: Add Type45 entry to query table

Entry added to display Firmware Inventory Information title for Type45 tables in smbiosview, as per SMBIOS Specification 3.5. Werner Lewis (1): ShellPkg/SmbiosView: Add Type45 entry to query table .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 5 + 1 file changed, 5

Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

Hi Leif, On 26/9/23 19:15, Leif Lindholm wrote: There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readable mov r0, #0 instead. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar ---

[edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Add Type45 entry to query table

The type field for Smbios tables in smbiosview is set from values in this query table. An entry is added to correctly display the Type 45 table name rather than "Undefined Value" in smbiosview output. Signed-off-by: Werner Lewis --- .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c |

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump

On 3/10/23 12:39, Leif Lindholm wrote: RO -> R0 Signed-off-by: Leif Lindholm Reported-by: Philippe Mathieu-Daudé Cc: Ard Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General] It looks good to me. Reviewed-by: Zhai MingXin Thanks! Duke Zhai -Original Message- From: Chang, Abner Sent: Saturday, September 30, 2023 12:18 AM To: Leif Lindholm ; devel@edk2.groups.io Cc: Xing, Eric ; Michael D Kinney ; Attar, AbdulLateef (Abdul

Re: [edk2-devel] [PATCH] DynamicTablesPkg/AmlLib: Enumerate memory cacheability and type

On Mon, Oct 02, 2023 at 21:52:52 +, Jeshua Smith wrote: > AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable > and MemoryRangeType parameters treat specific values as having > specific meanings. This change adds enums to map those meanings to their > corresponding values. > >

[edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

Ignore old style declaration warnings in oniguruma/src/st.c. This was already ignored for MSFT, but newer versions of clang complain as well. Signed-off-by: Jake Garver --- .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH v2] 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

On Fri, Sep 29, 2023 at 01:06:45 +0800, eric.x...@amd.com wrote: > From: Eric Xing > > Cc: Michael D Kinney > Cc: Abner Chang > Cc: Leif Lindholm > Cc: Abdul Lateef Attar > Signed-off-by: Eric Xing Reviewed-by: Leif Lindholm Pushed as 00cba21930fc. / Leif > --- > Maintainers.txt |

Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

Patch set Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Hi @Mike Maslenkin, could you please add Abner and my Reviewed-by to two commit messages in this PR? https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: update Readme.md

Update readme for below topics: - The call flow of BIOS Redfish provisioning scenario. - The call flow of BIOS Redfish pending settings scenario. - The call flow of Redfish feature driver dispatch. - Redfish foundation driver stack design. - The design of Redfish Platform Config Protocol. - The

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump

On Tue, Oct 03, 2023 at 11:22:26 +, Sami Mujawar wrote: > Hi Leif, > > Thank you for this fix. > Reviewed-by: Sami Mujawar Thanks! Merged as 1497c4b07494. / Leif > Regards, > > Sami Mujawar > > On 03/10/2023, 11:39, "Leif Lindholm" > wrote: > >

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump

Hi Leif, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 03/10/2023, 11:39, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote: RO -> R0 Signed-off-by: Leif Lindholm mailto:quic_llind...@quicinc.com>> Reported-by: Philippe Mathieu-Daudé

Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

On Mon, Oct 02, 2023 at 20:00:21 +0200, Philippe Mathieu-Daudé wrote: > Hi Leif, > > On 26/9/23 19:15, Leif Lindholm wrote: > > There may be architectures on which there are benefits to > >eor r0, r0(, r0) > > but ARM was never one of them. Change to more readable > >mov r0, #0 > >

[edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump

RO -> R0 Signed-off-by: Leif Lindholm Reported-by: Philippe Mathieu-Daudé Cc: Ard Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm

Re: [edk2-devel] [PATCH] DynamicTablesPkg/AmlLib: Enumerate memory cacheability and type

Hello Jeshua, just a few NITs: On 10/2/23 23:52, Jeshua Smith wrote: AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable and MemoryRangeType parameters treat specific values as having specific meanings. This change adds enums to map those meanings to their corresponding values.