Re: [edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library

Hi Laszlo, OK, I will do plan B. Moved ARM version to OvmfPkg/Library/ and rename it to PlatformBootManagerLibLight. Thanks, Chao On 2023/11/15 20:52, Laszlo Ersek wrote: Hi Chao, On 11/15/23 04:21, Chao Li wrote: Well, let's discuss the ARM version name once moved. I have two plans: *Pl

Re: [edk2-devel] [PATCH v4 1/1] MdePkg:Add NVME Sanitize command support to Nvme.h

Reviewed-by: Michael D Kinney > -Original Message- > From: Chen, Tina > Sent: Wednesday, November 8, 2023 11:51 PM > To: devel@edk2.groups.io > Cc: Chen, Tina ; Ni, Ray ; > Chen, Xiao X ; Chen, Arthur G > ; Gao, Liming ; > Liu, Zhiguang ; Sean Brogan > ; Kinney, Michael D > > Subject: [

[edk2-devel] [PATCH v6 2/2] [edk2-stable202311] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Filter out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 196 ++-- RedfishPkg/RedfishDiscoverDxe/Redfis

[edk2-devel] [PATCH v6 1/2] [edk2-stable202311] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all network interface to be installed. Reviewed-by: Abner Chang Reviewed-by: Nickle Wang Acked-by Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++-- 1 file change

[edk2-devel] [PATCH v6 0/2] [edk2-stable202311] Fix and optimize the issue if IPv4 installed after RestEx

Igor Kulchytskyy (2): RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 -- .../RedfishDiscoverInternal.h | 4 +

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

I cannot remember if CPUID.0B and CPUID.1F return the same value for package ID. And I am not sure about the benefit if we get the package id from location2. Thanks, Ray From: Wu, Jiaxin Sent: Wednesday, November 15, 2023 7:15 PM To: devel@edk2.groups.io Cc: Las

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib: Fix CPUID_V2_EXTENDED_TOPOLOGY detection

Reviewed-by: Ray Ni Thanks, Ray From: Wu, Jiaxin Sent: Wednesday, November 15, 2023 7:15 PM To: devel@edk2.groups.io Cc: Laszlo Ersek ; Dong, Eric ; Ni, Ray ; Kumar, Rahul R ; Gerd Hoffmann ; Zeng, Star Subject: [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib: Fix CPU

回复: edk2-stable202311 Code freeze process violation Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Mike: Yes. We should set Read access in code freeze phase. Abner: In hard code freeze phase, the critical issue is still allowed to be merged after it got approval from Stewards. Can you resend the patch with edk2-stable202311 title to get maintainer review and Stewards approval? For the me

[edk2-devel] [PATCH v6 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Filter out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 196 ++-- RedfishPkg/RedfishDiscoverDxe/Redfis

[edk2-devel] [PATCH v6 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all network interface to be installed. Reviewed-by: Abner Chang Reviewed-by: Nickle Wang Acked-by Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++-- 1 file change

[edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

Igor Kulchytskyy (2): RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 -- .../RedfishDiscoverInternal.h | 4 +

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

-Original Message- From: Mike Maslenkin Sent: Wednesday, November 15, 2023 2:26 PM To: Igor Kulchytskyy Cc: Leif Lindholm ; devel@edk2.groups.io; Abner Chang ; Nickle Wang Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Dis

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Hi Igor, On Wed, Nov 15, 2023 at 9:37 PM Igor Kulchytskyy wrote: > > Hi Mike, > My implementation of checking the IpType supposed to be like this: > /** > Check if Network Protocol Type matches with SMBIOS Type 42 IP Address Type. > > @param[in] NetworkProtocolType The Network Protocol Type

Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

On 2023-11-06 03:29, Chao Li wrote: Added LoongArch64 architecture CPU IO width. https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Chao Li Reviewed-by: Leif Lindholm I note that as a result of thi

Re: [edk2-devel] [PATCH v3 1/6] ArmPkg/ArmLib: Move ArmReadIdAA64Isar0() to ArmLib

Hi Pierre, I apologise for asking this level of rework on a v3, but I would much prefer if we could add these definitions in ArmPkg/Include/Chipset/AArch64.h, add helper functions in AArch64Lib* and declare those in ArmLib.h - and then use those instead of doing the direct ID register accesses in

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Hi Mike, My implementation of checking the IpType supposed to be like this: /** Check if Network Protocol Type matches with SMBIOS Type 42 IP Address Type. @param[in] NetworkProtocolType The Network Protocol Type to check with. @param[in] IpType The Host IP Address Type from

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

On Wed, Nov 15, 2023 at 4:52 PM Igor Kulchytskyy wrote: > > Hello Leif and Mike, > Let me try to explain the idea of the filtering IP. > That filtering should work only if we know exactly that IP is IPv4 or IPv6 in > SMBIOS Type 42. Hm. I've already composed a reply below, but then a returned to

[edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE

The struct used for GHCB-based page-state change requests uses a 40-bit bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a 64-bit address. However, anything beyond 40-bits simply gets shifted off when doing this, which will cause issues when dealing with 1TB+ addresses. Fix this by

Re: [edk2-devel] [PATCH] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE

Quoting Gerd Hoffmann (2023-11-13 04:48:10) > On Fri, Nov 10, 2023 at 08:14:39PM -0600, Michael Roth wrote: > > The struct used for GHCB-based page-state change requests uses a 40-bit > > bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a > > 64-bit address. However, anything beyon

Re: edk2-stable202311 Code freeze process violation Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Hello, Looks like the process for permissions needs to be adjusted during soft/hard freeze. Liming reduced EDK II Maintainers team to "Triage" for edk2 repo. But from this documentation lists Triage as allowing add/remove labels. https://docs.github.com/en/organizations/managing-user-access-to

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

From: Leif Lindholm Sent: Wednesday, November 15, 2023 10:20 AM To: devel@edk2.groups.io ; Ashish Singhal Cc: ardb+tianoc...@kernel.org ; sami.muja...@arm.com ; Jeff Brasen Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation External em

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

On Wed, Nov 15, 2023 at 16:24:46 +, Ashish Singhal via groups.io wrote: > On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote: > > Just like CPU _UID, ETE UID also needs to be unique so > > use AcpiProcessorUid instead of CpuName > > > > Signed-off-by: Ashish Singhal > > --- > > .../

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

From: Leif Lindholm Sent: Wednesday, November 15, 2023 9:21 AM To: Ashish Singhal Cc: devel@edk2.groups.io ; ardb+tianoc...@kernel.org ; sami.muja...@arm.com ; Jeff Brasen Subject: Re: [PATCH] DynamicTablesPkg: Fix ETE _UID Creation External email: Use cauti

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote: > Just like CPU _UID, ETE UID also needs to be unique so > use AcpiProcessorUid instead of CpuName > > Signed-off-by: Ashish Singhal > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 - > 1 file changed, 4 i

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib: Fix CPUID_V2_EXTENDED_TOPOLOGY detection

On 11/15/23 12:15, Jiaxin Wu wrote: > This patch is to complete 170d4ce8, sync the change to BaseXApicLib. > > Checking the max cpuid leaf is not enough to figure whenever > CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says: > > Software must detect the presence of CPUID leaf 1FH by verify

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Hello Leif and Mike, Let me try to explain the idea of the filtering IP. That filtering should work only if we know exactly that IP is IPv4 or IPv6 in SMBIOS Type 42. And it just helping to reduce the work in case we know the exact type of IP, which supposed to be used in BIOS BMC communication.

Re: [edk2-devel] [PATCH 1/1] Maintainers: add myself as reviewer for sbsa-ref

On Mon, May 15, 2023 at 16:33:52 +0200, Marcin Juszkiewicz wrote: > At Linaro I work on sbsa-ref, know direction it goes. > > May not get code details each time. > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm Pushed as 4b07df2e6f38. > --- > Maintainers.txt | 1 + > 1 file c

Re: [edk2-devel] TPM2 NVM WRITE IN EDK2

On 11/15/23 13:03, Hamit Can Karaca wrote: > Thanks for your Laszlo, > > I am using the functions that are available in EDK2 TpmCommandLib. I am > not sure where I fail because all the structs that I use are those which > are given in EDK2. I will add my code below. It would be very nice If > you

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: fix Phytium entry

On Wed, Nov 15, 2023 at 13:48:10 +0100, Marcin Juszkiewicz wrote: > Signed-off-by: Marcin Juszkiewicz Oops. Reviewed-by: Leif Lindholm Pushed as eac04509004e. Thanks! > --- > Maintainers.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers

Re: [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types

On Wed, Nov 15, 2023 at 13:46:08 +0100, Marcin Juszkiewicz wrote: > acpiview complains: > > ERROR: On Arm based systems, all cache properties must be provided in > the cache type structure. Missing 'Write Policy Valid' flag. > > ACPI specification says: > > > Set to 1 if the write policy attribu

Re: [edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library

Hi Chao, On 11/15/23 04:21, Chao Li wrote: > Well, let's discuss the ARM version name once moved. > > I have two plans: > > *Plan A:* > > Merge the ARM version into PlatformBootmanagerLib and modify the inf > file to separate X64 and other ARCH, like be: > > [Sources.Common] > >     QemuKerne

[edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: fix Phytium entry

Signed-off-by: Marcin Juszkiewicz --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index affb2632e0db..7bfd3c850a30 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -407,7 +407,7 @@ M: Daniel Schaefer Phytium platfo

[edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types

acpiview complains: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid' flag. ACPI specification says: > Set to 1 if the write policy attribute described is valid. A value > of 0 indicates that, where possible, processor a

Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol

Hi Jiaxin, Thanks for your reminder! I have tested Gerd's patch and it works to me! Joey Lee On Wed, Nov 15, 2023 at 11:30:07AM +, Wu, Jiaxin wrote: > Hi Joey, > > Please check your local code whether has the commit > 170d4ce8e90abb1eff03852940a69c9d17f8afe5 from Gerd, > > Assert in 147

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

On 2023-11-14 23:52, Mike Maslenkin wrote: On Tue, Nov 14, 2023 at 9:57 PM Igor Kulchytskyy via groups.io wrote: Hi Leif, Please see my comments below. Thank you, Igor -Original Message- From: Leif Lindholm Sent: Tuesday, November 14, 2023 12:26 PM To: devel@edk2.groups.io; Igor Kul

Re: [edk2-devel] CodeQL Analysis in edk2

On 11/15/23 01:35, Michael Kubacki wrote: > On 11/13/2023 8:42 AM, Laszlo Ersek wrote: >> sorry, unfinished thought: >> >> On 11/13/23 14:39, Laszlo Ersek wrote: >> >>> - the "sarif emacs" output seems a bit broken, actually, so it's not >>> usable. Consider the following entry from the original JS

Re: edk2-stable202311 Code freeze process violation Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

[AMD Official Use Only - General] Ok, Liming as we are going to revert that two commits. Is that possible to wait for Igor sending out another patch to address Leif's comment? This may delay the stable release a little bit. As without this patch, users may encounter the problem when sending requ

Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg: Format with Uncrustify 73.0.8

On 11/14/23 21:22, Michael Kubacki wrote: > From: Michael Kubacki > > Cc: Ard Biesheuvel > Cc: Corvin Köhne > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Rebecca Cran > Signed-off-by: Michael Kubacki > --- > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 4 > ++-- >

Re: [edk2-devel] [PATCH v1 2/3] EmulatorPkg: Format with Uncrustify 73.0.8

On 11/14/23 21:22, Michael Kubacki wrote: > From: Michael Kubacki > > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Michael Kubacki > --- > EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/EmulatorPkg/FvbServicesRuntim

Re: [edk2-devel] [PATCH v1 1/3] .pytool/UncrustifyCheck: Update to 73.0.8

On 11/14/23 21:22, Michael Kubacki wrote: > From: Michael Kubacki > > Updates to the latest release. > > - Includes a fix for preventing endless indentation in struct > assignment. > - Include Windows Arm, Linux Arm, and Mac OS builds. > > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

Hi Chasel, On 11/10/23 02:13, Chiu, Chasel wrote: > > Hi Laszlo, > > I verified and encountered build failure as some files still consuming > definitions from LegacyBiosMpTable.h, for example: > https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/I

Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol

Hi Joey, Please check your local code whether has the commit 170d4ce8e90abb1eff03852940a69c9d17f8afe5 from Gerd, Assert in 1478 means you don't have that patch. Besides, I'm also porting the change to BaseXApicLib, see patch: https://edk2.groups.io/g/devel/message/111257 Thanks, Jiaxin > --

[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

This patch changes to use the processor extended information, which can reflect the value from CPUID leaf 1FH. The reasons are listed as below: 1. The processor package ID retrieved from CPUID 0x0Bh may be not correct/accurate if CPU has the module & die info, it depends on the CPUID implementatio

[edk2-devel] [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Get processor extended information

This patch is to extend SmmAddProcessor function to get processor extended information. It's to complete commit 1fadd18d. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Star Zeng Signed-off-by: Jiaxin Wu Reviewed-by: Laszlo Ersek Regression-tested-by: Laszl

[edk2-devel] [PATCH v2 0/3] Get and use Get processor extended information

The series patches are to complete commits 170d4ce8 & 1fadd18d, then SMM cpu driver will use the processor extended information. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Star Zeng Signed-off-by: Jiaxin Wu Jiaxin Wu (3): UefiCpuPkg/BaseXApicLib: Fix

[edk2-devel] [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib: Fix CPUID_V2_EXTENDED_TOPOLOGY detection

This patch is to complete 170d4ce8, sync the change to BaseXApicLib. Checking the max cpuid leaf is not enough to figure whenever CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says: Software must detect the presence of CPUID leaf 1FH by verifying (a) the highest leaf index supported by CPUI

Re: edk2-stable202311 Code freeze process violation Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

[AMD Official Use Only - General] Hi Leif, As we requested Liming to wait for this change last week, he accepted to wait for the PR. But you are right, suppose I shouldn't be allowed to merge the change during code freeze. Maybe only certain people have privilege to merge the code during code f

edk2-stable202311 Code freeze process violation Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

On 2023-11-15 03:55, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Just let you know I just merged this change. Igor can help to follow up the suggestions given by Leif and Mike. I was under the impression merging was disabled for everyone except Mike and Liming during

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

On 2023-11-15 01:19, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Hi Mike and Leif, Thanks for your comments on this change. As we are rushing to get this change to be pulled in stable release 202312 this week, I will just merge this code to master branch and let the dis

Re: [edk2-devel] [PATCH v5 1/6] MdePkg: Add macro definitions for CET feature for NASM files.

On 11/15/23 05:12, Sheng Wei wrote: > Signed-off-by: Sheng Wei > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Wu Jiaxin > Cc: Tan Dun > Reviewed-by: Laszlo Ersek > --- > MdePkg/Include/Cet.inc | 26 ++ > 1 file changed, 26 insertions(+) > create mode 100644 M

Re: [edk2-devel] [PATCH v5 6/6] MdePkg: Use macro CR4_CET_BIT to replace hard code value.

On 11/15/23 05:12, Sheng Wei wrote: > The macro is used in file LongJump.nasm and SetJump.nasm. > > Signed-off-by: Sheng Wei > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Wu Jiaxin > Cc: Tan Dun > --- > MdePkg/Library/BaseLib/Ia32/LongJump.nasm | 3 ++- > MdePkg/Library/BaseLib/Ia32

Re: [edk2-devel] [PATCH v4 1/5] UefiCpuPkg: Add macro definitions for CET feature for NASM files.

On 11/15/23 03:02, Ni, Ray wrote: > If only CpuSmm driver consumes these macros, can we move the macro > definitions into CpuSmm driver folder? Sounds like a good idea. I'm unsure how we can put "UefiCpuPkg/PiSmmCpuDxeSmm/" on the include path though, for assembly files located in UefiCpuPkg/PiSm

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/14/23 20:37, Michael Kubacki wrote: > On 11/14/2023 11:21 AM, Michael D Kinney wrote: >> Hi Ranbir, >> >> First I want to recognize your efforts to collect Coverity issues and >> propose changes to address >> >> them. >> >> I still disagree with adding CpuDealLoop() for any static analysis >>

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/14/23 17:53, Ranbir Singh wrote: > Generally speaking, there now seems to be different views coming from > you and Laszlo. Yes. > We might have to wait for some sort of agreement to be > reached. I don't insist on CpuDeadLoop() *specifically*. Only the following two generic points matter

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/14/23 17:21, Kinney, Michael D wrote: > Hi Ranbir, > >   > > First I want to recognize your efforts to collect Coverity issues and > propose changes to address > them. > > I still disagree with adding CpuDealLoop() for any static analysis issues. > > There have been previous discussions a

Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg: Format with Uncrustify 73.0.8

Reviewed-by: Jiewen Yao > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, November 15, 2023 4:22 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Corvin Köhne > ; Gerd Hoffmann ; Yao, Jiewen > ; Rebecca Cran > Subject: [PATCH v1 3/3] OvmfPkg: Format with U

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix OVERRUN Coverity issues

On 11/14/23 17:34, Ranbir Singh wrote: > Though you already gave R-b, the return statement needs to be added to > explicitly and completely rule out ARRAY_OVERRUN issue by static > analysis tools. > >              ASSERT (Index < TypeMax); > + > +            if (Index == TypeMax) { > +           

Re: [edk2-devel] [PATCH v3 2/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix MISSING_BREAK Coverity issue

On 11/14/23 17:11, Ranbir Singh wrote: > > > On Mon, Nov 13, 2023 at 10:03 PM Laszlo Ersek > wrote: > > On 11/9/23 18:39, Ranbir Singh wrote: > > From: Ranbir Singh > > > > The function SubmitResources has a switch-case code in which the > > case A

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On 11/14/23 16:12, Rebecca Cran wrote: > On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote: > >> Funnily enough, my stance is quite the opposite. I happen to disagree >> with some patterns that uncrustify enforces, but I'm thankful that at >> any given state of CI (= using any given version