Re: [edk2-devel] [Patch V2 1/3] UefiCpuPkg/MpInitLib:Repeat WakeUpAp of loading microcode,Syncing MTRR.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Xie, Yuanhao > Sent: Tuesday, November 21, 2023 3:40 PM > To: devel@edk2.groups.io > Cc: Xie, Yuanhao ; Ni, Ray ; > Dong, Eric ; Kumar, Rahul R > ; Tom Lendacky ; > Laszlo Ersek > Subject: [Patch V2 1/3]

Re: [edk2-devel] [PATCH v6 6/6] MdePkg: Use macro CR4_CET_BIT to replace hard code value.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Sheng, W > Sent: Tuesday, November 21, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Wu, Jiaxin ; Tan, Dun > > Subject: [PATCH v6 6/6] MdePkg: Use macro CR4_CET_BIT to replace hard >

Re: [edk2-devel] [PATCH v6 5/6] UefiCpuPkg: Backup and Restore MSR IA32_U_CET in SMI handler.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Sheng, W > Sent: Tuesday, November 21, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Wu, Jiaxin ; Tan, Dun > > Subject: [PATCH v6 5/6] UefiCpuPkg: Backup and Restore MSR IA32_U_CET in >

Re: [edk2-devel] [PATCH v6 4/6] UefiCpuPkg: Only change CR4.CET bit for enable and disable CET.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Sheng, W > Sent: Tuesday, November 21, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Wu, Jiaxin ; Tan, Dun > > Subject: [PATCH v6 4/6] UefiCpuPkg: Only change CR4.CET bit for enable and

Re: [edk2-devel] [PATCH v6 3/6] UefiCpuPkg: Use CET macro definitions in Cet.inc for SmiEntry.nasm files.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Sheng, W > Sent: Tuesday, November 21, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Wu, Jiaxin ; Tan, Dun > > Subject: [PATCH v6 3/6] UefiCpuPkg: Use CET macro definitions in Cet.inc

Re: [edk2-devel] [PATCH v6 2/6] UefiCpuPkg: Use macro CR4_CET_BIT to replace hard code value in Cet.nasm.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Sheng, W > Sent: Tuesday, November 21, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Wu, Jiaxin ; Tan, Dun > > Subject: [PATCH v6 2/6] UefiCpuPkg: Use macro CR4_CET_BIT to replace >

Re: [edk2-devel] [PATCH v6 1/6] MdePkg: Add macro definitions for CET feature for NASM files.

2023-11-20 Thread Ni, Ray
You might need to drop Reviewed-by from Laszlo as the patch content is so different than the reviewed version. Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Sheng, W > Sent: Tuesday, November 21, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ;

[edk2-devel] [Patch V2 3/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

2023-11-20 Thread Yuanhao Xie
The DXE stage's Microcode loading process has been elimincated by: 1. Microcode HOB consumption in MP initialization within the DXE phase. 2. Restricting MicrocodeDetect to the PEI phase instead of DXE for BSP. 3. BSP now WakeUpAp only for synchronizing MTRR settings, with Microcode loading no

[edk2-devel] [Patch V2 1/3] UefiCpuPkg/MpInitLib:Repeat WakeUpAp of loading microcode,Syncing MTRR.

2023-11-20 Thread Yuanhao Xie
This patch replicates the WakeUpAp operation, encompassing both microcode loading and MTRR synchronization, regardless of whether MpHandOff is NULL. The purpose of this patch is to enhance the review process. The separation in this patch is aimed at facilitating a more straightforward review,

[edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

2023-11-20 Thread Yuanhao Xie
Detect and apply Microcode on BSP, store BSP's MTRR setting only when CpuCount > 1. The purpose of this patch is to enhance the review process. The separation in this patch is aimed at facilitating a more straightforward review, with the ultimate goal of eliminating the microcode loading

[edk2-devel] [Patch V2 0/3] Eliminate redundant microcode loading in DXE.

2023-11-20 Thread Yuanhao Xie
The DXE stage's Microcode loading process has been elimincated. Compare to V1, V2 seperates the patches and adds more comments xieyuanh (3): UefiCpuPkg/MpInitLib:Repeat WakeUpAp of loading microcode,Syncing MTRR. UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

[edk2-devel] [PATCH v6 6/6] MdePkg: Use macro CR4_CET_BIT to replace hard code value.

2023-11-20 Thread Sheng Wei
The macro is used in file LongJump.nasm and SetJump.nasm. Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun Reviewed-by: Laszlo Ersek --- MdePkg/Library/BaseLib/Ia32/LongJump.nasm | 3 ++- MdePkg/Library/BaseLib/Ia32/SetJump.nasm | 3 ++-

[edk2-devel] [PATCH v6 5/6] UefiCpuPkg: Backup and Restore MSR IA32_U_CET in SMI handler.

2023-11-20 Thread Sheng Wei
OS may enable CET-IBT feature by set MSR IA32_U_CET.bit2. If IA32_U_CET.bit2 is set, CPU is in WAIT_FOR_ENDBRANCH state and the next assemble code is not ENDBR, it will trigger #CP exception when set CR4.CET bit. SMI handler needs to backup MSR IA32_U_CET and clear MSR IA32_U_CET before set

[edk2-devel] [PATCH v6 4/6] UefiCpuPkg: Only change CR4.CET bit for enable and disable CET.

2023-11-20 Thread Sheng Wei
Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 10 +++--- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 10 +++--- 2 files changed, 14 insertions(+), 6

[edk2-devel] [PATCH v6 3/6] UefiCpuPkg: Use CET macro definitions in Cet.inc for SmiEntry.nasm files.

2023-11-20 Thread Sheng Wei
Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 14 +- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 15 +-- 2 files changed, 2 insertions(+),

[edk2-devel] [PATCH v6 2/6] UefiCpuPkg: Use macro CR4_CET_BIT to replace hard code value in Cet.nasm.

2023-11-20 Thread Sheng Wei
Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/Cet.nasm | 5 +++-- UefiCpuPkg/PiSmmCpuDxeSmm/X64/Cet.nasm | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [PATCH v6 1/6] MdePkg: Add macro definitions for CET feature for NASM files.

2023-11-20 Thread Sheng Wei
Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun Reviewed-by: Laszlo Ersek --- MdePkg/Include/Ia32/Cet.inc | 26 ++ MdePkg/Include/X64/Cet.inc | 26 ++ 2 files changed, 52 insertions(+) create

[edk2-devel] [PATCH v6 0/6] MdePkg: Add macro definitions for CET feature for NASM files.

2023-11-20 Thread Sheng Wei
Patch V6: Cet.inc only contains definitions for x86 CPU. Move the file to \Ia32 and \X64 folder. Refine code for cet.inc. Patch V5: File cet.inc will be used in both MdePkg UefiCpuPkg. Move cet.inc file from UefiCpuPkg to MdePkg. Use macro CR4_CET_BIT to replace hard code value for

Re: [edk2-devel] [PATCH v3 27/39] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg

2023-11-20 Thread Chao Li
This patch accidentally breaks some platforms, I will fix them in V4. Thanks, Chao On 2023/11/17 18:02, Chao Li wrote: Moved the PlatformBootManagerLib to OvmfPkg and renamed to PlatformBootManagerLibLight for easy use by other ARCH. Build-tested only (with "ArmVirtQemu.dsc").

Re: [edk2-devel] [PATCH v5 1/6] MdePkg: Add macro definitions for CET feature for NASM files.

2023-11-20 Thread Ni, Ray
> --- > MdePkg/Include/Cet.inc | 26 ++ 1. I am not sure adding "Cet.inc" in MdePkg/Include is ok as Cet.inc only contains definitions for x86 CPU. Is it better to add the macros to existing Ia32/Nasm.inc, X64/Nasm.inc? But that would cause duplicated macro

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Igor, You can update the commit message with this BZ# information in this commit and resend the PR. https://github.com/tianocore/edk2/pull/5052/commits/45fbed1e540f902ee21eebeb0752ba24911e445e Also, let Liming knows you have this update. Thanks Abner From:

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-20 Thread Igor Kulchytskyy via groups.io
Hello, I created a ticket. https://bugzilla.tianocore.org/show_bug.cgi?id=4602 Since it is my first ticket, could you please check it and tell if it is what we need? Thank you, Igor From: Igor Kulchytskyy Sent: Monday, November 20, 2023 8:50 AM To: Chang, Abner ; Laszlo Ersek ;

[edk2-devel] [Patch V7 2/2] UefiCpuPkg/MpInitLib: Update the comments of _CPU_MP_DATA.

2023-11-20 Thread Yuanhao Xie
No functional changes in this patch. Updates the comments of _CPU_MP_DATA to delcared that duplications in CpuMpData are present to avoid to be direct accessed and comprehended in assembly code. CpuMpData: Intended for use in C code while ExchangeInfo are used in assembly code in this module.

[edk2-devel] [Patch V7 1/2] UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-20 Thread Yuanhao Xie
From: Yuanhao Xie This patch synchronizes the No-Execute bit in the IA32_EFER register for the APs before the RestoreVolatileRegisters operation. The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI sequence," replaces the second INIT-SIPI-SIPI sequence with the BSP calling the

[edk2-devel] [Patch V7 0/2]UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-20 Thread Yuanhao Xie
This patch series synchronizes the No-Execute bit in the IA32_EFER register for the APs before the RestoreVolatileRegisters operation. It also updated the comments of _CPU_MP_DATA to delcared that duplications in CpuMpData are present to avoid to be direct accessed and comprehended in assembly

[edk2-devel] [Patch V7 2/2] UefiCpuPkg/MpInitLib: Update the comments of _CPU_MP_DATA.

2023-11-20 Thread Yuanhao Xie
No functional changes in this patch. Updates the comments of _CPU_MP_DATA to delcared that duplications in CpuMpData are present to avoid to be direct accessed and comprehended in assembly code. CpuMpData: Intended for use in C code while ExchangeInfo are used in assembly code in this module.

[edk2-devel] [Patch V7 0/2]UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-20 Thread Yuanhao Xie
This patch series synchronizes the No-Execute bit in the IA32_EFER register for the APs before the RestoreVolatileRegisters operation. It also updated the comments of _CPU_MP_DATA to delcared that duplications in CpuMpData are present to avoid to be direct accessed and comprehended in assembly

[edk2-devel] [Patch V7 1/2] UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-20 Thread Yuanhao Xie
From: Yuanhao Xie This patch synchronizes the No-Execute bit in the IA32_EFER register for the APs before the RestoreVolatileRegisters operation. The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI sequence," replaces the second INIT-SIPI-SIPI sequence with the BSP calling the

[edk2-devel] [PATCH v1 1/1] BoardModulePkg\Library\BiosIdLib: Support Standalone MM

2023-11-20 Thread Huang, Li-Xia
Add Standalone Mm BiosIdLib. Also fix some EDKII Coding Style issue with uncrustify. Cc: Eric Dong Cc: Nate DeSimone Signed-off-by: Lixia Huang --- Platform/Intel/BoardModulePkg/Library/BiosIdLib/BiosIdCommon.c| 96

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 21, 2023 #cal-reminder

2023-11-20 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, November 21, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Get processor extended information

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, November 15, 2023 7:16 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Dong, Eric ; Ni, > Ray ; Kumar, Rahul R ; Gerd > Hoffmann ; Zeng, Star > Subject: [PATCH v2 2/3]

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib: Fix CPUID_V2_EXTENDED_TOPOLOGY detection

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, November 15, 2023 7:16 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Dong, Eric ; Ni, > Ray ; Kumar, Rahul R ; Gerd > Hoffmann ; Zeng, Star > Subject: [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib:

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-20 Thread Chiu, Chasel
Hi Laszlo, I think you have to clone all the required repos. edk2 repository git clone https://github.com/tianocore/edk2.git edk2-platforms repository git clone https://github.com/tianocore/edk2-platforms.git edk2-non-osi repository git clone https://github.com/tianocore/edk2-non-osi.git FSP

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove the duplicate loading of microcode in DXE.

2023-11-20 Thread Ni, Ray
> + > +if (!GetMicrocodePatchInfoFromHob ( > + >MicrocodePatchAddress, > + >MicrocodePatchRegionSize > + )) > +{ > + // > + // The microcode patch information cache HOB does not exist, which > means > + // the microcode patches data has not been

[edk2-devel] [PATCH 1/1] MdeModulePkg: Fix typos in Bus and Core

2023-11-20 Thread Page Chen via groups.io
begining -> beginning Cabability -> Capability CHNAGED -> CHANGED compatability -> compatibility concident -> coincident correspoding -> corresponding defered -> deferred Dispacher -> Dispatcher execuing -> executing exhausive -> exhaustive functio -> function funtion -> function funtions ->

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] >I did not add this intentionally and even sent out an email asking the same on >edk2-rfc if this should be done by maintainers unless you want me to do it as >a ??separate patch set. >Link to the message is https://edk2.groups.io/g/rfc/message/827 That's fine.

Re: [edk2-devel] [Patch V6 1/2] UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-20 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Xie, Yuanhao > Sent: Monday, November 20, 2023 12:55 PM > To: devel@edk2.groups.io > Cc: Xie, Yuanhao ; Laszlo Ersek > ; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Gerd > Hoffmann > Subject: [Patch V6 1/2]

Re: [edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command line

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ok, I got it. Thanks. Reviewed-by: Abner Chang Abner From: Ashish Singhal Sent: Tuesday, November 21, 2023 1:18 AM To: Chang, Abner ; devel@edk2.groups.io; quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; g...@danielschaefer.me; Jeff Brasen Subject:

Re: [edk2-devel] [PATCH v3 22/39] ArmPkg: Remove ArmPciCpuIo2Dxe from ArmPkg

2023-11-20 Thread Chao Li
OK, I will remove this patch in V4. Thanks, Chao On 2023/11/21 02:47, Leif Lindholm wrote: Hi Chao, Yes, correct. So we can update the existing users of this driver in edk2-platforms before deleting it. Regards, Leif On Mon, Nov 20, 2023 at 11:24:03 +0800, Chao Li wrote: Hi Leif, Do you

回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

2023-11-20 Thread gaoliming via groups.io
Sami: I am OK to merge this patch for this stable bug. I will add push label for https://github.com/tianocore/edk2/pull/5061 Thanks Liming > -邮件原件- > 发件人: Sami Mujawar > 发送时间: 2023年11月21日 0:07 > 收件人: Laszlo Ersek ; Liming Gao (Byosoft address) > ; Michael Kinney ; >

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, November 20, 2023 #cal-notice

2023-11-20 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, November 20, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, November 20, 2023 #cal-reminder

2023-11-20 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, November 20, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v4 11/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

2023-11-20 Thread Taylor Beebe
I missed this message before heading out on vacation, sorry :) Let me know if you have more questions. I've also split the MAT fixes into separate patches for the v5 version and will wait to hear back from you before sending to ensure the updated notes for this patch answer all your

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-20 Thread Ashish Singhal via groups.io
From: Chang, Abner Sent: Monday, November 20, 2023 5:13 AM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ; g...@danielschaefer.me ; Jeff Brasen Subject: RE: [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot

Re: [edk2-devel] [PATCH v3 22/39] ArmPkg: Remove ArmPciCpuIo2Dxe from ArmPkg

2023-11-20 Thread Leif Lindholm
Hi Chao, Yes, correct. So we can update the existing users of this driver in edk2-platforms before deleting it. Regards, Leif On Mon, Nov 20, 2023 at 11:24:03 +0800, Chao Li wrote: > Hi Leif, > > Do you mean that CpuIo2Dxe adds MMIO method first, then waits for this patch > series to be

Re: [edk2-devel] [PATCH v4 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks

2023-11-20 Thread Leif Lindholm
On Mon, Nov 20, 2023 at 14:48:25 +0100, Pierre Gondois wrote: > Add AARCH64 specific implementations of: > - OPENSSL_cpuid_setup(), probing hardware capabilitie > (presence of FEAT_AES, etc.) > - OPENSSL_rdtsc(), returning non-trusted entropy by accessing > system counter. > > Acked-by: Gerd

Re: [edk2-devel] [PATCH v4 1/6] ArmPkg/ArmLib: Add macros/helper functions around AA64Isar0 register

2023-11-20 Thread Leif Lindholm
On Mon, Nov 20, 2023 at 14:48:21 +0100, Pierre Gondois wrote: > Add macro definitions and helper functions to access AArch64 > capabilities described in the AA64Isar0 register. > > Signed-off-by: Pierre Gondois > --- > ArmPkg/Include/Chipset/AArch64.h | 60 +++- >

Re: [edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command line

2023-11-20 Thread Ashish Singhal via groups.io
From: Chang, Abner Sent: Monday, November 20, 2023 5:30 AM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ; g...@danielschaefer.me ; Jeff Brasen Subject: RE: [PATCH v2 2/2] EmbeddedPkg: Allow longer android

edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

2023-11-20 Thread Sami Mujawar
Hi Laszlo, Liming, Mike, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 17/11/2023 09:20 am, Laszlo Ersek wrote: On 11/15/23 04:19, Ashish Singhal via groups.io wrote: Just like CPU _UID, ETE UID also needs to be unique so use AcpiProcessorUid instead of CpuName

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

2023-11-20 Thread Michael Kubacki
On 11/15/2023 5:10 AM, Laszlo Ersek wrote: On 11/14/23 20:37, Michael Kubacki wrote: On 11/14/2023 11:21 AM, Michael D Kinney wrote: Hi Ranbir, First I want to recognize your efforts to collect Coverity issues and propose changes to address them. I still disagree with adding CpuDealLoop()

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-20 Thread Igor Kulchytskyy via groups.io
Hi Abner, I have an account. I will create a ticket. Thank you, Igor Get Outlook for Android From: Chang, Abner Sent: Sunday, November 19, 2023 11:31:37 PM To: Laszlo Ersek ; devel@edk2.groups.io ; Igor Kulchytskyy Subject: [EXTERNAL]

[edk2-devel] [PATCH v4 6/6] CryptoPkg: Enable Openssl Accel builds for AARCH64

2023-11-20 Thread PierreGondois
Enable the following modules builds for AARCH64: - OpensslLibAccel.inf - OpensslLibFullAccel.inf Acked-by: Gerd Hoffmann Signed-off-by: Pierre Gondois --- CryptoPkg/CryptoPkg.dsc | 23 ++- .../OpensslLib/OpensslStub/AArch64Cap.c | 15

[edk2-devel] [PATCH v4 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks

2023-11-20 Thread PierreGondois
Add AARCH64 specific implementations of: - OPENSSL_cpuid_setup(), probing hardware capabilitie (presence of FEAT_AES, etc.) - OPENSSL_rdtsc(), returning non-trusted entropy by accessing system counter. Acked-by: Gerd Hoffmann Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v4 3/6] CryptoPkg/OpensslLib: Add native instruction support for AARCH64

2023-11-20 Thread PierreGondois
Add native instruction support for AARCH64. Acked-by: Gerd Hoffmann Signed-off-by: Pierre Gondois --- .../Library/OpensslLib/OpensslLibAccel.inf| 21 ++- .../OpensslLib/OpensslLibFullAccel.inf| 21 ++- CryptoPkg/Library/OpensslLib/UefiAsm.conf |

[edk2-devel] [PATCH v4 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

2023-11-20 Thread PierreGondois
Allow dependency upon ArmPkg to pass the dependency Check. Signed-off-by: Pierre Gondois --- CryptoPkg/CryptoPkg.ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index f961d85927c0..3bbb220d3224 100644 ---

[edk2-devel] [PATCH v4 1/6] ArmPkg/ArmLib: Add macros/helper functions around AA64Isar0 register

2023-11-20 Thread PierreGondois
Add macro definitions and helper functions to access AArch64 capabilities described in the AA64Isar0 register. Signed-off-by: Pierre Gondois --- ArmPkg/Include/Chipset/AArch64.h | 60 +++- ArmPkg/Include/Library/ArmLib.h| 228 -

[edk2-devel] [PATCH v4 0/6] CryptoPkg: Enable Openssl native instruction support for AARCH64

2023-11-20 Thread PierreGondois
v4: - Added Acked-by from Gerd - Created bugzilla at: https://bugzilla.tianocore.org/show_bug.cgi?id=4601 - Replaced: - [PATCH v3 1/6] ArmPkg/ArmLib: Move ArmReadIdAA64Isar0() to ArmLib by: - [PATCH v4 1/6] ArmPkg/ArmLib: Add macros/helper functions around AA64Isar0 register and: -

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

2023-11-20 Thread Wu, Jiaxin
For core id in cpu features library, I agree it should be not easy or simple change to 0x1f. But in SMM CPU, there is no usage case depends on the number of cores retrieved from cupid 0x0b return value, only PackageId will be used. So, this patch doesn’t do bad things, should no regression

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

2023-11-20 Thread Sami Mujawar
Hi Ashish, I have created a bugzilla ticket for this at https://bugzilla.tianocore.org/show_bug.cgi?id=4600. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111471): https://edk2.groups.io/g/devel/message/111471

Re: [edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command line

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Ashish Singhal > Sent: Wednesday, November 15, 2023 11:12 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; Chang, Abner ; > g...@danielschaefer.me; jbra...@nvidia.com > Cc: Ashish Singhal

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation

2023-11-20 Thread Sami Mujawar
Hi Ashish, Thank you for this fix. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/11/2023 03:19 am, Ashish Singhal wrote: Just like CPU _UID, ETE UID also needs to be unique so use AcpiProcessorUid instead of CpuName Signed-off-by: Ashish Singhal

Re: [edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser

2023-11-20 Thread Rohit Mathew
Hi, Gentle reminder on the series. Regards, Rohit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rohit > Mathew via groups.io > Sent: Monday, October 2, 2023 6:14 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abraham > ; Sami Mujawar ; >

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks for this update and two more comments, > -Original Message- > From: Ashish Singhal > Sent: Wednesday, November 15, 2023 11:12 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; Chang, Abner ; >

Re: [edk2-devel] [Bug] Building NetworkPkg fails due to missing SynchronizationLib dependency of BaseCryptLib

2023-11-20 Thread CrossedCarpet
Good morning Laszlo, Thank you for your reply. I feared this was intentional due to believing that it would have been caught with automated testing. Doesn't the Azure Pipeline try to build all packages to make sure no dependency broke? Also Liming, would you do me the honour of creating a

[edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

2023-11-20 Thread Xu, Wei6
Defer the dispatch of the remaining MM drivers once the CPU driver has been dispatched. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4599 In MmDispatcher, return immediately if the MM Entry Point was registered. Then the MM IPL will reinvoke the MM Core Dispatcher. This is required so MM

[edk2-devel] [PATCH 0/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

2023-11-20 Thread Xu, Wei6
This patch is to add support to StandaloneMmCore for restarting MmDispatcher once MmEntryPoint is registered. Please check in detail in Bugzilla and PullRequest: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4599 PR: https://github.com/tianocore/edk2/pull/5056 Cc: Ard Biesheuvel Cc: Sami