Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

SmmCpuSyncGetArrivedCpuCount () won't have below requirement to caller: "The caller shall not call this function for the number of arrived CPU after look door in SMI since the value has been returned in the parameter of LockDoor()." The API will ways support to get the ArrivedCpuCount no mater

Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

I will the align the ReleaseSemaphore & WaitForSemaphore behavior as blow: ReleaseSemaphore() prevents increase the semaphore if locked, and it should return the locked value (MAX_UINT32); --> then we can check the return value is MAX_UINT32 or not in SmmCpuSyncCheckInCpu(), and sem itself

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

Hi Liming, The way to apply new VfrCompiler in Edk2 is detailed in the BaseTools/Source/Python/VfrCompiler/Readme.md file You can use this branch to have a try ~ https://github.com/yytshirley/edk2/tree/PyVfrCompiler_Tool Thanks, Yuting From: devel@edk2.groups.io On Behalf Of gaoliming via

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

Hi Mike, Per Redfish specification 7.9 POST(create) "The POST request is submitted to the resource collection to which the new resource will belong." If this is not a collection resource, we cannot use POST method. And /redfish/v1/Systems/SYS_ID/Bios is not a collection resource. The allowed

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: fix access to unitialized variable.

Thanks for catching this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 2/4]

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 1/4]

Re: [edk2-devel] [PATCH v3 4/6] OvmfPkg: Specifies SmmCpuSyncLib instance

Laszlo, I like the "local lib override" idea, similar to the C language recommendation to use local variables instead of global ones when possible. Thanks, Ray > -Original Message- > From: Laszlo Ersek > Sent: Thursday, December 14, 2023 12:53 AM > To: devel@edk2.groups.io; Wu, Jiaxin

Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

[AMD Official Use Only - General] > -Original Message- > From: Pedro Falcato > Sent: Wednesday, December 13, 2023 9:15 PM > To: devel@edk2.groups.io; mike.maslen...@gmail.com > Cc: Chang, Abner ; Nickle Wang > ; Igor Kulchytskyy > Subject: Re: [edk2-devel] [RFC PATCH] RedfishPkg:

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: fix access to unitialized variable.

It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used uninitialized in this function

[edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

If EdkIIRedfishResourceConfigCheck fails according to the logic and comment: new resources should be provisioned, so the POST method must be used. Fourth parameter of EdkIIRedfishResourceConfigProvisioning is BOOLEAN HttpPostMode, so we pass TRUE here. Cc: Abner Chang Cc: Igor Kulchytskyy Cc:

[edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 0/4] change method for provisioning + minor fixes

This patch set contains minor fixes and the one major change related to BIOS resources provisioning. PR: https://github.com/tianocore/edk2-redfish-client/pull/64 Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

[edk2-devel] [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default

Exercising reset to default does not reset the settings. Add handler code for the case where configuration is disabled. Signed-off-by: Ashish Singhal --- NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 25 + 1 file changed, 25 insertions(+) diff --git

[edk2-devel] [PATCH v1 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

From: Joseph Hemann -add tests for HashLogExtendEvent() -tests with valid, invalid, and out of range parameters -do extend of data to PCR 16 Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h

[edk2-devel] [PATCH v1 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

From: Joseph Hemann Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 5 + uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h | 71

[edk2-devel] [PATCH v1 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

From: Joseph Hemann -add test for GetEventLog() -test for valid and invalid event log format -test event log header -verify expected event log entry Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h

[edk2-devel] [PATCH v1 0/6] Tests for TCG2 Protocol

This patch series adds tests for the TCG2 Protocol which is implemented by EDK2. The protocol is defined in chapter 6 in the TCG EFI Protocol Specification: https://trustedcomputinggroup.org/resource/tcg-efi-protocol-specification/ The definition of the test cases is in a specification that has

[edk2-devel] [PATCH v1 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

From: Joseph Hemann Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 179 1 file changed, 179 insertions(+) diff --git a/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h b/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h new file mode 100644

[edk2-devel] [PATCH v1 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

From: Joseph Hemann -add test for GetActivePcrBanks() -checkpoint for NULL pointer passed for buffer -checkpoint for test of function with proper input Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h

[edk2-devel] [PATCH v1 2/6] uefi-sct/SctPkg: TCG2 Protocol: add test infrastructure and GetCapability Test

From: Joseph Hemann -implement initial infrastructure for the TCG2 protocol test including updates to .dsc file, inf file, GUID source files, update to Category.ini. -add test case for GetCapability(), as defined in the TCG EFI Protocol Spec 6.4.4. -add checkpoint for NULL pointer passed

Re: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data

Hello Gao, Checking if you have any feedback on this. Thanks Ashish From: Ashish Singhal Sent: Wednesday, December 6, 2023 5:21 PM To: devel@edk2.groups.io ; gaolim...@byosoft.com.cn ; Jeff Brasen Cc: Ashish Singhal Subject: [PATCH]

[edk2-devel] [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation error conditions.

Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 85 --- 1 file changed, 75 insertions(+), 10 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c

[edk2-devel] [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

URI is generated based on the RedfishLocation containing an ASCII string representing the IP address. So, in the case of IPv4 the canonical representation of an IPv4 address was inserted into the resulting Unicode string i.e: "http{,s}://X.X.X.X/". In the case of IPv6, to access resources, the IP

[edk2-devel] [PATCH v2 12/14] RedfishDiscoverDxe: refine InitInformationData() function

Cache size of ASCII string in local variable. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 --- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git

[edk2-devel] [PATCH v2 10/14] RedfishDiscoverDxe: introduce InitInformationData helper function

Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 -- 1 file changed, 74 insertions(+), 34 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c

[edk2-devel] [PATCH v2 11/14] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts

Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Pedro Falcato Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c

[edk2-devel] [PATCH v2 09/14] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable

Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishPlatformHostInterfaceLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c

[edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService

Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- EmulatorPkg/EmulatorPkg.dec | 8 .../RedfishPlatformCredentialLib.c | 12 ++-- .../RedfishPlatformCredentialLib.inf | 8 3 files changed, 14

[edk2-devel] [PATCH v2 07/14] RedfishPkg: add proper initialization of IPMI request

All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +--- 1 file changed, 5

[edk2-devel] [PATCH v2 06/14] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver

Currently there is no description for RedfishConfigHandler driver. This leads to in the "DRIVER NAME" column of a `drivers` command for example. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishConfigHandler/ComponentName.c | 216

[edk2-devel] [PATCH v2 05/14] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path.

Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c

[edk2-devel] [PATCH v2 04/14] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations

It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by:

[edk2-devel] [PATCH v2 01/14] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.

PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[edk2-devel] [PATCH v2 02/14] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo.

RedfishPlatformCredentialIpmiLib is the library instance name not the class name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformCredentialIpmiLib.inf| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2-devel] [PATCH v2 03/14] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h

It seems that initial implementation of this header file is based on CrtLibSupport.h from CryptoPkg. But uid, euid, gid, egid and sa_family_t sre not used in RedfishPkg. So remove them. Also take "true" and "false" definition from MdePkg's LibFdtSupport.h header file, that also seems based on a

[edk2-devel] [PATCH v2 0/14] Redfish related fixes and improvements

This is an exapanded version of the original set of 9 patches with additional patch introducing brackets for IPv6 Redfish resource location with required changes according to comments for the initial RFC patch. PR: https://github.com/tianocore/edk2/pull/5149 diff from v1: fixed typo double

Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

Mike, Would you be able to help us merge the patch? Thanks, Saloni -Original Message- From: Luo, Heng Sent: Thursday, December 14, 2023 3:20 AM To: Clark-williams, Zachary ; Kasbekar, Saloni ; devel@edk2.groups.io Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not

Re: [edk2-devel] [PATCH v3 7/7] OvmfPkg/RiscVVirt: SEC: Add IO memory resource hob for platform devices

On Thu, Dec 7, 2023 at 11:36 PM Andrei Warkentin wrote: > Hi Tuan, > > > > I noticed that the OvmfPkg RV Sec uses PopulateIoResources by adding > entries to GCD of type EFI_RESOURCE_MEMORY_MAPPED_IO. Contrast this with >

Re: [edk2-devel] [PATCH] ArmPkg/DebugPeCoffExtraActionLib: Drop RVCT and Cygwin support

On Thu, 14 Dec 2023 at 15:59, Sami Mujawar wrote: > > Hi Leif, Ard, > > On 14/12/2023, 14:46, "Leif Lindholm" > wrote: > > > +Sami (who I know once, a very long time ago, used cygwin) > [SAMI] Now that we have WSL, I have stopped using Cygwin. > Also, this

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

On 12/14/23 16:31, Gerd Hoffmann wrote: > Hi, > >> The general idea is, once we don't trust the varstore, there cannot be >> a *single* unchecked addition in the code. (Unless we can *prove* that >> overflow is impossible.) > > There are some cases where we add a small, constant number to a

Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

BTW, for SmmCpuSyncGetArrivedCpuCount (): we can't check the CpuCount (Original is named as Counter Sem) is locked or not, then decide return from the *Context->CpuCount or locked value for the arrived CPU in SMI. Just like: if (*Context->CpuCount == MAX_UINT32) {--> does not meet

Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

> > The code will be changed to: > > > > if ((INT32)InternalWaitForSemaphore (Context->CpuCount) < 0) { > > return RETURN_ABORTED; > > } > > I find this quite ugly. In the "semaphore post" operation, we already > have code that prevents incrementing if the semaphore is "locked". Can > we

[edk2-devel] [PATCH v3 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

Extend the ValidateFvHeader function, additionally to the header checks walk over the list of variables and sanity check them. In case we find inconsistencies indicating variable store corruption return EFI_NOT_FOUND so the variable store will be re-initialized. Signed-off-by: Gerd Hoffmann ---

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

Hi, > The general idea is, once we don't trust the varstore, there cannot be > a *single* unchecked addition in the code. (Unless we can *prove* that > overflow is impossible.) There are some cases where we add a small, constant number to a value we know is smaller than

Re: [edk2-devel] [PATCH v3 1/1] CloudHv: Add CI for CloudHv on AArch64

Merged as b8a3eec88cc7..59a952d9ab00 Thanks. Regards, Sami Mujawar On 14/12/2023, 13:54, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote: Hi Laszlo, On 14/12/2023, 12:28, "Laszlo Ersek" mailto:ler...@redhat.com> >> wrote: On

Re: [edk2-devel] [PATCH] ArmPkg/DebugPeCoffExtraActionLib: Drop RVCT and Cygwin support

Hi Leif, Ard, On 14/12/2023, 14:46, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote: +Sami (who I know once, a very long time ago, used cygwin) [SAMI] Now that we have WSL, I have stopped using Cygwin. Also, this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami

Re: [edk2-devel] [PATCH] ArmPkg/DebugPeCoffExtraActionLib: Drop RVCT and Cygwin support

+Sami (who I know once, a very long time ago, used cygwin) On Thu, Dec 14, 2023 at 10:20:46 +0100, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The DebugPeCoffExtraActionLib implemention in ArmPkg contains some cruft > that dates back to the original RVCT based ARM port, and support for >

Re: [edk2-devel] [PATCH v5 0/2] Support customized FV Migration Information

Hi Liming and Kumar Could you help review this v5 patch: MdeModulePkg: Support customized FV Migration Information: https://github.com/fanwang2intel/edk2/commit/83c55a73107bfb13df1d8b522e0ea1d18ef3d86b SecurityPkg: Support customized FV Migration Information

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

On Thu, Dec 14, 2023 at 11:41 AM Pranav Madhu wrote: > > The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB > of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level > cache. Extend the SMBIOS support for RD-V2 platform with this > configuration. > >

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] Platform/Sgi: Define RD-V2 platform id values

On Thu, Dec 14, 2023 at 11:41 AM Pranav Madhu wrote: > > Add the RD-V2 platform identification values including the part > number and configuration number. This information will be used in > populating the SMBIOS tables. > > Signed-off-by: Pranav Madhu > --- >

Re: [edk2-devel] [PATCH v3 1/1] CloudHv: Add CI for CloudHv on AArch64

Hi Laszlo, On 14/12/2023, 12:28, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote: On 12/13/23 16:13, Sami Mujawar wrote: > From: Jianyong Wu mailto:jianyong...@arm.com>> > > Add the long lost CI for CloudHv on AArch64. > As CloudHv CI works nearly the same way with other VMMs like KvmTool, >

[edk2-devel] [PATCH v5 2/2] SecurityPkg: Support customized FV Migration Information

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4533 In Tcg driver, when MigratedFvInfo hob is detected, existing code logic is assuming FV raw data is already copied, and raw data base address is also recorded. Due to the new PeiCore change, the platform can publish hob to indicate raw data

[edk2-devel] [PATCH v5 1/2] MdeModulePkg: Support customized FV Migration Information

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4533 There are use cases which not all FVs need be migrated from TempRam to permanent memory before TempRam tears down. This new guid is introduced to avoid unnecessary FV migration to improve boot performance. Platform can publish MigrationInfo

[edk2-devel] [PATCH v5 0/2] Support customized FV Migration Information

There are use cases which not all FVs need be migrated from TempRam to permanent memory before TempRam tears down. This new guid is introduced to avoid unnecessary FV migration to improve boot performance. Platform can publish MigrationInfo hob with this guid to customize FV migration info, and

Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

On 12/14/23 12:11, Wu, Jiaxin wrote: > Hi Laszlo, > > Really appreciate your comments! I checked one by one and feedback as below, > thank you & Ray again & again for patch refinement > > >> >> (1) If / when you update the documentation in patch#2, please update >> this one as well. >> >

Re: [edk2-devel] [PATCH v3 4/6] OvmfPkg: Specifies SmmCpuSyncLib instance

> > > > !if $(SOURCE_DEBUG_ENABLE) == TRUE > > All four DSC files already include "PiSmmCpuDxeSmm.inf" like this: > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { > > ... > } > > Given that this new library class is again exclusively used by > PiSmmCpuDxeSmm, can you please

Re: [edk2-devel] [PATCH V6] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

I did ask. Thank you for the considered answer. Ack. :) On Thu, 14 Dec 2023 at 13:25, Laszlo Ersek wrote: > > On 12/14/23 10:33, Mike Beaton wrote: > >> Please stop sending patches. > > > > I believe this version is a clear improvement, with motivation. > > (Certainly, it was meant as such!) > >

Re: [edk2-devel] [PATCH V6] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

On 12/14/23 10:33, Mike Beaton wrote: >> Please stop sending patches. > > I believe this version is a clear improvement, with motivation. > (Certainly, it was meant as such!) > > How am I meant to send improvements or updates in this email-based workflow? By pacing yourself. Posting two

Re: [edk2-devel] [PATCH v3 1/1] CloudHv: Add CI for CloudHv on AArch64

On 12/13/23 16:13, Sami Mujawar wrote: > From: Jianyong Wu > > Add the long lost CI for CloudHv on AArch64. > As CloudHv CI works nearly the same way with other VMMs like KvmTool, > thus we can easily create its CI configuration based on KvmTool. > > Reviewed-by: Laszlo Ersek > Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V2 1/2] Platform/Sgi: Define RD-V2 platform id values

Add the RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 5 +

[edk2-devel] [edk2-platforms][PATCH V2 0/2] Add SMBIOS support for RD-V2 platform

Changes since V1: - Rebase the patches on top of latest master branch SMBIOS provides basic hardware and firmware configuration information through table-driven data structure. This patch series adds SMBIOS support for Arm's RD-V2 platforms. The first patch in this series defines platform-id

Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

Hi Saloni, Could you help to merge the patch? Thanks, Heng > -Original Message- > From: Luo, Heng > Sent: Monday, December 11, 2023 4:13 PM > To: Clark-williams, Zachary ; Kasbekar, > Saloni ; devel@edk2.groups.io > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not

Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

Hi Laszlo, Really appreciate your comments! I checked one by one and feedback as below, thank you & Ray again & again for patch refinement > > (1) If / when you update the documentation in patch#2, please update > this one as well. > Yes, I will do the alignment. > (2) Please sort the

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/DxeIpl: Add 5 level paging support

Reviewed-by: Gua Guo From: Liu, Zhiguang Sent: Thursday, December 14, 2023 3:59:38 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Wu, Jiaxin ; Ni, Ray ; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: RE: [PATCH 1/2] MdeModulePkg/DxeIpl: Add 5 level

Re: [edk2-devel] [PATCH V5] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

On Thu, 14 Dec 2023 at 10:37, Mike Beaton wrote: > > > IOW, please don't send a v6 until the discussion comes to a conclusion. > > Apologies, I did _not_ see this before sending. > > > > - #if !defined (MDEPKG_NDEBUG) > > > + #if defined (__CC_ARM) || defined (__GNUC__) > > > > No, this is not

Re: [edk2-devel] [edk2][PATCH V1 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

Hi Himanshu, Thank you for this patch. I have a minor suggestion marked inline as [SAMI]. Otherwise this patch looks good to me. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 06/12/2023 10:11 am, Himanshu Sharma wrote: Taking reference from Table 2-1 of the Arm

Re: [edk2-devel] [edk2][PATCH V1 2/2] DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs only

Hi Himanshu, Thank you for this patch. Please see my feedback marked inline as [SAMI]. Regards, Sami Mujawar On 06/12/2023 10:11 am, Himanshu Sharma wrote: Add interrupt node to the AML description of the serial-port only if the IRQ ID from the Configuration Manager is a valid SPI (shared

Re: [edk2-devel] [PATCH V5] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

> IOW, please don't send a v6 until the discussion comes to a conclusion. Apologies, I did _not_ see this before sending. > > - #if !defined (MDEPKG_NDEBUG) > > + #if defined (__CC_ARM) || defined (__GNUC__) > > No, this is not going to be acceptable to me. You noted that only the > ARM code

Re: [edk2-devel] [PATCH V6] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

> Please stop sending patches. I believe this version is a clear improvement, with motivation. (Certainly, it was meant as such!) How am I meant to send improvements or updates in this email-based workflow? Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

[edk2-devel] [PATCH] ArmPkg/DebugPeCoffExtraActionLib: Drop RVCT and Cygwin support

From: Ard Biesheuvel The DebugPeCoffExtraActionLib implemention in ArmPkg contains some cruft that dates back to the original RVCT based ARM port, and support for RVCT was dropped a while ago. Also drop the handling of Cygwin specific paths, which is highly unlikely to be still depended upon by

Re: [edk2-devel] [PATCH V6] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

Please stop sending patches. On Thu, 14 Dec 2023 at 10:12, Mike Beaton wrote: > > Repeats V5, but with a hopefully clearer (on motivation and history) commit > message. > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112512):

Re: [edk2-devel] [PATCH V6] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

Repeats V5, but with a hopefully clearer (on motivation and history) commit message. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112511): https://edk2.groups.io/g/devel/message/112511 Mute This Topic:

[edk2-devel] [PATCH V6] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

From: Mike Beaton The variant provided when MDEPKG_NDEBUG is defined will be optimised away in RELEASE builds, but by referencing the argument list, avoids unused variable errors from valid debug code, for example when STATIC variables are used only in DEBUG statements. This issue was being

Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

On Thu, 14 Dec 2023 at 08:40, Ard Biesheuvel wrote: > > On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote: > > > > From: Mike Beaton > > > > This is no longer required since the revised DEBUG macro automatically > > compiles away unused var accesses when MDEPKG_NDEBUG is defined; > > keeping

Re: [edk2-devel] [PATCH V5] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined

(cc Michael) On Thu, 14 Dec 2023 at 08:58, Mike Beaton wrote: > > From: Mike Beaton > > The variant provided when MDEPKG_NDEBUG is defined will be optimised > away in RELEASE builds, but by referencing the argument list, avoids > unused variable errors from valid debug code, for example when