Re: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-19 Thread PierreGondois
Hello Abdul, On 12/20/23 05:33, Attar, AbdulLateef (Abdul Lateef) wrote: [Public] Hi Pierre, Regarding the below comment +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + INUINT8 NumArgs, + INAML_METHOD_PARAM *Parameters

Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

2023-12-19 Thread Ard Biesheuvel
On Wed, 20 Dec 2023 at 02:57, Ni, Ray wrote: > > It’s new to me that PCI IO (not MMIO) space is accessed through MMIO. > > PCIE spec defines different TLP types for Memory and I/O request in > Transaction Layer chapter. > > If CpuIoDxe driver issues Memory request to a IO space inside a PCIE

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

2023-12-19 Thread Ard Biesheuvel
On Wed, 20 Dec 2023 at 00:29, Jake Garver wrote: > > Ard, Pedro, > > It's all connecting for me: > > I was able to recreate this problem with a crosstool-ng built toolchain. > That confirms it's not specific to Ubuntu and is indeed related to > "--enable-fix-cortex-a53-843419". > I also

Re: [edk2-devel] [PATCH v4 22/37] OvmfPkg/RiscVVirt: Remove PciCpuIo2Dxe from RiscVVirt

2023-12-19 Thread Sunil V L
On Tue, Dec 12, 2023 at 09:13:14PM +0800, Chao Li wrote: > CpuIo2Dxe is already used by RiscVVirt, so remove it. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Sunil V L > Cc: Andrei Warkentin > Signed-off-by: Chao Li > --- Reviewed-by: Sunil V L

Re: [edk2-devel] [PATCH v4 21/37] OvmfPkg/RiscVVirt: Enable UefiCpuPkg version CpuIo2Dxe

2023-12-19 Thread Sunil V L
On Tue, Dec 12, 2023 at 09:13:08PM +0800, Chao Li wrote: > Since the UefiCpuPkg/CpuIo2Dxe already supports MMIO, it is enabled at > this thime. > > Build-tested only (with "RiscVVirtQemu.dsc"). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Sunil V L > Cc: Andrei Warkentin

[edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL

2023-12-19 Thread SuqiangX Ren
Add the description of EFI_NVDIMM_LABEL_FLAGS_LOCAL to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 13.19.4 Signed-off-by: SuqiangX Ren Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Protocol/NvdimmLabel.h | 2 ++ 1 file changed, 2 insertions(+)

[edk2-devel] [PATCH edk2-platforms] Platform, Silicon: Drop AMD Seattle support

2023-12-19 Thread Ard Biesheuvel via groups.io
From: Ard Biesheuvel AMD Seattle support in edk2-platforms is implemented using a number of closed source components delivered as binary drivers via edk2-non-osi, some of which have dependencies on internal EDK2 APIs that are not considered stable, and some of which have evolved over the years

[edk2-devel] [PATCH 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL

2023-12-19 Thread SuqiangX Ren
Add the description of EFI_NVDIMM_LABEL_FLAGS_LOCAL to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 13.9 Signed-off-by: SuqiangX Ren Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Protocol/NvdimmLabel.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-19 Thread Abdul Lateef Attar via groups.io
[Public] Hi Pierre, Regarding the below comment > +AmlCodeGenInvokeMethod ( > + IN CONST CHAR8 *MethodNameString, > + INUINT8 NumArgs, > + INAML_METHOD_PARAM *Parameters OPTIONAL, > + INAML_NODE_HANDLE ParentNode Maybe it would be

Re: [edk2-devel] Clarification on LoadFile2 Protocol Installation for Network Boot Devices

2023-12-19 Thread Saloni Kasbekar
Hi Siva, We can file a Mantis for the UEFI forum with the proposal to update the wording for #18 to include Network devices. Thanks, Saloni From: Sivaraman Nainar Sent: Monday, December 18, 2023 10:54 PM To: Kasbekar, Saloni ; devel@edk2.groups.io; Clark-williams, Zachary Cc: Natalya

Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

2023-12-19 Thread Ni, Ray
It’s new to me that PCI IO (not MMIO) space is accessed through MMIO. PCIE spec defines different TLP types for Memory and I/O request in Transaction Layer chapter. If CpuIoDxe driver issues Memory request to a IO space inside a PCIE device, how does PCIE device claim the TPL packet and

[edk2-devel] [PATCH V2 2/2] FmpDevicePkg: Add DECLARE_LENGTH opcode of dependency expression

2023-12-19 Thread Li, Yi
To avoid messy parsing of the Depex section of a Capsule, it would be a lot easier for everyone involved if we preceded the Capsule Depex Section with a length declaration. It provides simple bounds checking to avoid having to parse the op-codes, but in the case of a malformed depex being parsed,

[edk2-devel] [PATCH V2 1/2] MdePkg: Add DECLARE_LENGTH opcode of dependency expression

2023-12-19 Thread Li, Yi
To avoid messy parsing of the Depex section of a Capsule, it would be a lot easier for everyone involved if we preceded the Capsule Depex Section with a length declaration. It provides simple bounds checking to avoid having to parse the op-codes, but in the case of a malformed depex being parsed,

[edk2-devel] [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression

2023-12-19 Thread Li, Yi
To avoid messy parsing of the Depex section of a Capsule, it would be a lot easier for everyone involved if we preceded the Capsule Depex Section with a length declaration. It provides simple bounds checking to avoid having to parse the op-codes, but in the case of a malformed depex being parsed,

Re: 回复: [edk2-devel] [PATCH v4 09/37] MdePkg: Add a new library named PeiServicesTablePointerLibKs0

2023-12-19 Thread Chao Li
Hi Liming, Yes, the code branch is in my private repo, here is the link: https://github.com/kilaterlee/edk2/tree/push1102 Thanks, Chao On 2023/12/19 21:07, gaoliming wrote: Chao:  Is there a branch or pull request for this patch set? I would like to check how this new library instance be

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

2023-12-19 Thread Jake Garver via groups.io
Ard, Pedro, It's all connecting for me: * I was able to recreate this problem with a crosstool-ng built toolchain. That confirms it's not specific to Ubuntu and is indeed related to "--enable-fix-cortex-a53-843419". * I also verified that this issue is specific to our

Re: [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error

2023-12-19 Thread Nate DeSimone
Pushed as 59ef582 -Original Message- From: Huang, Li-Xia Sent: Monday, December 18, 2023 10:10 PM To: devel@edk2.groups.io Cc: Abner Chang ; Desimone, Nathaniel L Subject: [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error Fix GCC compiler error in

Re: [edk2-devel] [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error

2023-12-19 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Huang, Li-Xia Sent: Monday, December 18, 2023 10:10 PM To: devel@edk2.groups.io Cc: Abner Chang ; Desimone, Nathaniel L Subject: [PATCH v1 2/2] IpmiFeaturePkg/GenericIpmi: Fix GCC compiler error Fix GCC compiler error in

Re: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-19 Thread PierreGondois
Hello Abdul, The new function looks good, there is just one small issue with the tree layout, Regards, Pierre On 12/19/23 04:06, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type

Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-12-19 Thread Samer El-Haj-Mahmoud
Thank you all! > -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, December 19, 2023 8:59 AM > To: devel@edk2.groups.io; gaolim...@byosoft.com.cn > Cc: quic_llind...@quicinc.com; ngomp...@gmail.com; Michael Kinney > ; Laszlo Ersek ; Jeremy Linton > ; Pete Batard ; Daniel P .

Re: [edk2-devel] [PATCH v10 0/5] Cache Management Operations Support For RISC-V

2023-12-19 Thread Sunil V L
On Wed, Dec 13, 2023 at 08:29:26PM +0530, Dhaval wrote: > Implementing code to support Cache Management Operations (CMO) defined by > RISC-V CMO instructions.https://github.com/riscv/riscv-CMOs > This is a re-write of original series v5. > The patchset contains 5 patches- created based on V5

Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-12-19 Thread Ard Biesheuvel
On Tue, 19 Dec 2023 at 14:00, gaoliming via groups.io wrote: > > Yes. The latest spec has clarified this behavior. So, this change is OK. > Reviewed-by: Liming Gao > Merged as #5165 Thanks all > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > > 发送时间: 2023年12月19日 19:51 > >

回复: [edk2-devel] [PATCH v4 09/37] MdePkg: Add a new library named PeiServicesTablePointerLibKs0

2023-12-19 Thread gaoliming via groups.io
Chao: Is there a branch or pull request for this patch set? I would like to check how this new library instance be used. Thanks Liming 发件人: devel@edk2.groups.io 代表 Chao Li 发送时间: 2023年12月19日 21:01 收件人: devel@edk2.groups.io; Michael D Kinney ; Liming Gao 抄送: Zhiguang Liu ; Laszlo Ersek

回复: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard

2023-12-19 Thread gaoliming via groups.io
Foster: I have no comments for this patch. Acked-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nong, Foster > 发送时间: 2023年12月19日 18:17 > 收件人: devel@edk2.groups.io; Kinney, Michael D > ; Gao, Liming ; > Chris Li > 抄送: Ni, Ray > 主题: Re: [edk2-devel] [PATCH v1]

Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

2023-12-19 Thread Chao Li
Hi Ray, Can you please review this patch? Thank you! Thanks, Chao On 2023/12/12 21:12, Chao Li wrote: CpuIo2Dxe only supports IO to access PCI IO. Some ARCH requires MMIO to access PCI IO, add the MMIO access method in CpuIo2Dxe. The MMIO methods depend on PcdPciIoTranslationIsEnabled and

回复: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling

2023-12-19 Thread gaoliming via groups.io
The change is good. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Guo, Gua > 发送时间: 2023年12月19日 15:32 > 收件人: devel@edk2.groups.io; Chen, Christine ; > Rebecca Cran ; Gao, Liming > > 抄送: Feng, Bob C > 主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select

Re: [edk2-devel] [PATCH v4 18/37] MdePkg: Add a PCD feature flag named PcdPciIoTranslationIsEnabled

2023-12-19 Thread Chao Li
Hi Mike and Liming, Can you please review this patch? Thank you! Thanks, Chao On 2023/12/12 21:12, Chao Li wrote: Some ARCH need to use MMIO to access PCI IO, such as ARM AARCH64 RISC-V and LOONGARCH64. In some drivers, a PCD value is added to determine whether to use MMIO.

Re: [edk2-devel] [PATCH v4 09/37] MdePkg: Add a new library named PeiServicesTablePointerLibKs0

2023-12-19 Thread Chao Li
Hi Mike and Liming, Can you please review this patch? Thank you! Thanks, Chao On 2023/12/12 21:11, Chao Li wrote: Adding PeiServicesTablePointerLibKs0 for LoongArch64, which provides setting and getting the PEI service table pointer through the CSR KS0 register. The idea of this library is

回复: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-12-19 Thread gaoliming via groups.io
Yes. The latest spec has clarified this behavior. So, this change is OK. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2023年12月19日 19:51 > 收件人: devel@edk2.groups.io; a...@kernel.org > 抄送: ngomp...@gmail.com; Liming Gao (Byosoft

Re: [edk2-devel] [PATCH v4 09/37] MdePkg: Add a new library named PeiServicesTablePointerLibKs0

2023-12-19 Thread Chao Li
Hi Mike and Liming, Can you please review this patch? Thank you! Thanks, Chao On 2023/12/12 21:11, Chao Li wrote: Adding PeiServicesTablePointerLibKs0 for LoongArch64, which provides setting and getting the PEI service table pointer through the CSR KS0 register. The idea of this library is

Re: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard

2023-12-19 Thread Nong, Foster
@Gao, Liming @Chris Li @Kinney, Michael D, Don't forget reviewing the patch. Thanks! -Original Message- From: Nong, Foster Sent: Wednesday, November 29, 2023 2:57 PM To: devel@edk2.groups.io Cc: Nong, Foster ; Kinney, Michael D ; Gao, Liming ; Ni, Ray ; Chris Li Subject: [PATCH v1]

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Add debug messages

2023-12-19 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, December 19, 2023 12:33 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: Add

Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-12-19 Thread Leif Lindholm
On Mon, Dec 18, 2023 at 22:55:21 +0100, Ard Biesheuvel wrote: > Hello all, > > Same question again. Could we please make some progress on this? > > Full thread here: > https://openfw.io/edk2-devel/20231031173700.647004-1-ngo...@fedoraproject.org/ > > If nobody objects, I will assume that the

Re: [edk2-devel] [PATCH v5 4/8] UefiCpuPkg: Implements SmmCpuSyncLib library instance

2023-12-19 Thread Wu, Jiaxin
Thanks all help review this series patches, I have created one PR integrated all reviewed by tag for this series patches. https://github.com/tianocore/edk2/pull/5092 Thanks, Jiaxin > -Original Message- > From: Ni, Ray > Sent: Tuesday, December 19, 2023 5:34 PM > To: Wu, Jiaxin ;

Re: [edk2-devel] [PATCH v5 4/8] UefiCpuPkg: Implements SmmCpuSyncLib library instance

2023-12-19 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, December 19, 2023 3:19 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Dong, Eric ; Ni, > Ray ; Zeng, Star ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v5 4/8] UefiCpuPkg: Implements

Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv.

2023-12-19 Thread Ard Biesheuvel
On Mon, 18 Dec 2023 at 10:08, Xu, Wei6 wrote: > > Thanks Ray, > > The PR is updated with "Reviewed-by" added. > https://github.com/tianocore/edk2/pull/5004 > Pushed, thanks. > -Original Message- > From: Ni, Ray > Sent: Monday, December 18, 2023 1:02 PM > To: Xu, Wei6 ;

Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-19 Thread Ard Biesheuvel
On Fri, Dec 15, 2023 at 12:56 PM Mike Beaton wrote: > > > For the exception handler case, we can just drop the #Ifdefs around > > the definition of BaseName () entirely given that it will now always > > be referenced. But that does depend a lot on how other toolchains deal > > with this (VS201x