Add the description of FileName to align with UEFI spec 2.10.
REF: UEFI spec 2.10 Table 13.5.16
Signed-off-by: RenSuqiang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Yi Li
---
MdePkg/Include/Guid/FileInfo.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add status code return for BROWSER callback in EFI_FORM_BROWSER2_PROTOCOL
to align with UEFI spec 2.10.
REF: UEFI spec 2.10 Table 35.6.3
Signed-off-by: RenSuqiang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Yi Li
---
MdePkg/Include/Protocol/FormBrowser2.h | 5 -
1 file
Hi Liming,
Thank you for reviewing ~
Could you please help me create a Bugzilla account? Currently, I do not have
access to the Bugzilla.
Best Regards,
Yuting
-Original Message-
From: Zhang, Zifeng
Sent: Thursday, December 21, 2023 2:44 PM
To: Gao, Liming ; Yang, Yuting2
Cc:
[AMD Official Use Only - General]
Hi Sami,
Currently we are using the AML library and evaluating the
Dynamic Tables Framework.
Soon we will be publishing(upstreaming) the usage of AML library under the
edk2-platforms/Platform/AMD/AmdPlatformPkg.
Thanks
AbduL
From: Sami Mujawar
[AMD Official Use Only - General]
Hi Sami,
Thanks for the in-depth review and making the changes.
Regarding below comment.
[SAMI] This does not seem to be related to this patch. Were you getting any
issues when building? If so, can you submit a separate patch, please?
If you agree, I
[AMD Official Use Only - General]
Hi Sami,
Below mentioned patch looks good;
https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_method_invocatio
.
Please go ahead and merge the patch series.
Thanks
AbduL
-Original Message-
From: Sami Mujawar
Sent:
REF: UEFI SPEC 2.10 34.8.10 EFI_KEY
Add EfiKeyIntl0-9.
Signed-off-by: Yi Li
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
---
.../Include/Common/UefiInternalFormRepresentation.h | 12 +++-
BaseTools/Source/C/Include/Protocol/HiiFramework.h | 12 +++-
2
REF: UEFI SPEC 2.10 34.8.10 EFI_KEY
Add EfiKeyIntl0-9.
Signed-off-by: Yi Li
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
---
MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
REF: UEFI SPEC 2.10 34.8.10 EFI_KEY
Add EfiKeyIntl0-9.
Signed-off-by: Yi Li
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Yi Li (2):
MdePkg: Update keybaord map based on UEFI spec 2.10
BaseTools: Update keybaord map
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Desimone, Nathaniel L
> Sent: Saturday, September 30, 2023 6:12 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ni, Ray ; Kinney,
> Michael D ; Chiu, Chasel
>
> Subject: [edk2-devel]
On Tue, Dec 19, 2023 at 9:11 AM Samer El-Haj-Mahmoud
wrote:
>
> Thank you all!
>
Thank you everyone, I see that it has landed in the repository now:
https://github.com/tianocore/edk2/commit/8c1e9f9c6fa7b5137003b0cfa6d54a6bada16d8e
--
真実はいつも一つ！/ Always, there's only one truth!
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/9c9a4821e0866f219f1d03ba24a6a433ea408223
Thanks,
Chasel
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, December 20, 2023 7:42 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ;
Good to me.
Thanks,
Ray
From: Chao Li
Sent: Friday, December 22, 2023 9:15 AM
To: devel@edk2.groups.io; a...@kernel.org; Ni, Ray
Cc: Kumar, Rahul R ; Gerd Hoffmann
; Leif Lindholm ; Ard Biesheuvel
; Sami Mujawar
Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, December 20, 2023 7:42 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Kinney, Michael D
> ; Gao, Liming ; Ni,
> Ray
> Subject: [PATCH v1]
> >Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
> > - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
> > + Copyright (c) 2009 - 2023, Intel Corporation. All rights reserved.
> I know this is standard procedure, but you are extending Intel's
> copyright
Thanks,
Chao
On 2023/12/21 21:59, Ard Biesheuvel wrote:
On Thu, 21 Dec 2023 at 13:41, Chao Li wrote:
...
A given platform will either be able to use port IO, or it will need
to use MMIO translation. So a driver that can do both based on a PCD
is not very useful, it makes more sense to have
Hi Abdul,
Can you check if the patch 4/4 at
https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_method_invocation_v5
looks ok to you, please?
If you confim, I will apply the push label.
Regards,
Sami Mujawar
On 21/12/2023 01:56 pm, Sami Mujawar via groups.io wrote:
On Thu, 21 Dec 2023 at 15:39, Ard Biesheuvel wrote:
>
> On Mon, 18 Dec 2023 at 03:23, Chang, Abner wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Reviewed-by: Abner Chang
> >
>
> I've queued this up, along with the mock one - thanks.
>
Rejected by CI:
On Mon, 18 Dec 2023 at 03:23, Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang
>
I've queued this up, along with the mock one - thanks.
> > -Original Message-
> > From: Jeff Brasen
> > Sent: Monday, December 11, 2023 11:48 PM
> > To:
On Thu, 21 Dec 2023 at 13:41, Chao Li wrote:
>
...
> A given platform will either be able to use port IO, or it will need
> to use MMIO translation. So a driver that can do both based on a PCD
> is not very useful, it makes more sense to have two different drivers,
> and the platform incorporates
Hi Abdul,
Glad to see your contribution to the Dynamic Tables Framework. It would
be great to hear how you are using this package.
I have some minor comments for the last patch 4/4. If you can reply
back, I will try to get the changes merged before the end of this week.
Regards,
Sami
Hi Abdul,
I have some minor feedback maked inline as [SAMI].
I think other than the typecast change for the value returned by
StrSize(), the remainder of the patch looks ok to me (i.e. with the
minor changes I suggested).
Please let me know if you agree with my suggestions and I will make
Hi Abdul,
Thank you for this fix.
For Arm EFIAPI evaluates to nothing, hence we could not catch such issues.
Do you use the rest of the Dynamic Tables Framework? I guess we have not
included the calling convention at other places e.g.
Hi Abdul,
Thank you for this fix. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc:
Hi Abdul,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami
Thanks,
Chao
On 2023/12/21 20:31, Ard Biesheuvel wrote:
On Thu, 21 Dec 2023 at 13:11, Chao Li wrote:
Hi Ard,
Thanks,
Chao
On 2023/12/21 15:31, Ard Biesheuvel wrote:
On Thu, 21 Dec 2023 at 04:48, Chao Li wrote:
...
Ard,
PcdPciIoTranslationIsEnabled is only use for whether to trigger
On Thu, 21 Dec 2023 at 13:11, Chao Li wrote:
>
> Hi Ard,
>
>
> Thanks,
> Chao
> On 2023/12/21 15:31, Ard Biesheuvel wrote:
>
> On Thu, 21 Dec 2023 at 04:48, Chao Li wrote:
>
> ...
>
> Ard,
>
> PcdPciIoTranslationIsEnabled is only use for whether to trigger the Ffio read
> or write, it seem that
Hi Ard,
Thanks,
Chao
On 2023/12/21 15:31, Ard Biesheuvel wrote:
On Thu, 21 Dec 2023 at 04:48, Chao Li wrote:
...
Ard,
PcdPciIoTranslationIsEnabled is only use for whether to trigger the Ffio read
or write, it seem that only x86 or x64 need them, not others.
When I was submitted the patch
Hi Liming,
Sorry, I forget to CC you when I submitted the patch that modified the
DebugSupport.h, I originally planned to CC you when I submitted V5.
My answer:
Thanks,
Chao
On 2023/12/21 15:16, gaoliming wrote:
Chao:
For the changes in MdePkg, I have two comments here.
Hello Leif,
I think the following files:
- ArmPkg/Include/Chipset/AArch64.h
- ArmPkg/Include/Chipset/AArch64Mmu.h
- ArmPkg/Include/Chipset/ArmV7.h
- ArmPkg/Include/Chipset/ArmV7Mmu.h
also need to be moved to the MdePkg. Otherwise the MdePkg
would depend on the ArmPkg, cf. ArmLib.h:
#ifdef
Thanks Nate for the feedback. I've sent out patch v2 according to your
comments. Can you please review again?
Thanks,
Ted
-Original Message-
From: Desimone, Nathaniel L
Sent: Thursday, December 21, 2023 8:13 AM
To: Kuo, Ted ; devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu,
https://bugzilla.tianocore.org/show_bug.cgi?id=4623
1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64.
2.Made changes in common file to support both IA32 and X64.
3.Added the PCDs below for FSP-T UPD revisions and reset vector in FSP.
- PcdFspWrapperBfvforResetVectorInFsp
-
On Wed, 20 Dec 2023 at 22:26, Rebecca Cran wrote:
>
> Reviewed-by: Rebecca Cran
>
Merged as #5183
Thanks all
>
> On 12/20/2023 12:31 PM, Jake Garver wrote:
> > In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, we may encounter an ADR
> > instead of an ADRP when the toolchain is working around
Code review tools like gerrit might use a 'Change-id' tag to track
the evolution of patches. This tag should be removed before
submitting a patch to the mailing-list.
It has been observed that contributors sometimes forget to remove
this tag. Add a check in PatchCheck.py to automate this.
Also
34 matches
Mail list logo
