[edk2-devel] [PATCH v2] OvmfPkg: RiscVVirt: Fix network drivers not be built

2024-01-12 Thread Tuan Phan
Only need to include Network.dsc.inc to have all network drivers/components be built. Otherwise, there were missing definition that prevent them from be built for RiscVVirt platform. Signed-off-by: Tuan Phan --- v2: - Rebase OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 15 +-- 1 file chan

Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

2024-01-12 Thread Narinder Dhillon
Hi Marcin, > -Original Message- > From: Marcin Wojtas > Sent: Friday, January 12, 2024 4:19 AM > To: devel@edk2.groups.io; Narinder Dhillon > Cc: quic_llind...@quicinc.com; marcin.s.woj...@gmail.com; Szymon Balcerak > > Subject: [EXT] Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] > Si

[edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/ARM/N1Sdp: Route the Debug Serial Port to IOFPGA UART1

2024-01-12 Thread Himanshu Sharma
Update the RegisterBase and Clk for the Debug Serial Port (DBG2) to route it to the IOFPGA UART1 and make the SPCR and DBG2 Serial Ports exclusive. Signed-off-by: Himanshu Sharma --- Change-log: V2: - Reverse updating the IRQ ID for DBG2 UART. - Update the commit message. Platfor

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
> On Jan 12, 2024, at 11:04 AM, Kinney, Michael D > wrote: > > Agreed. Basically every API that takes an EF_HANDLE as input calls that API > to make sure it is a valid handle. > > The first question is if we get value from making sure the EFI_HANDLE is a > member of the active set of hand

[edk2-devel] [PATCH v3 1/3] OvmfPkg: Add CloudHv support to PlatformScanE820 utility function.

2024-01-12 Thread Thomas Barrett
From: Thomas Barrett The PlatformScanE820 utility function is not currently compatible with CloudHv since it relies on the prescence of the "etc/e820" QemuFwCfg file. Update the PlatformScanE820 to iterate through the PVH e820 entries when running on a CloudHv guest. Cc: Anatol Belski Cc: Ard B

[edk2-devel] [PATCH v3 3/3] OvmfPkg: CloudHv: Enable PcdUse1GPageTable

2024-01-12 Thread Thomas Barrett
From: Thomas Barrett Without enabling PcdUse1GPageTable, CloudHv guests are limited to a 40-bit address space, even if the hardware supports more. This limits the amount of RAM to 1TiB of CloudHv guests. Cc: Anatol Belski Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jianyong Wu Cc: Jiewen Yao C

[edk2-devel] [PATCH v3 2/3] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv

2024-01-12 Thread Thomas Barrett
From: Thomas Barrett In addition to initializing the PhysMemAddressWidth and FirstNonAddress fields in PlatformInfoHob, the PlatformAddressWidthInitialization function is responsible for initializing the PcdPciMmio64Base and PcdPciMmio64Size fields. Currently, for CloudHv guests, the PcdPciMmio6

[edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: Remove Ard as Platform/ARM reviewer

2024-01-12 Thread Ard Biesheuvel via groups.io
From: Ard Biesheuvel Remove me as reviewer for ARM development platforms: I am no longer employed by ARM and have no access to or knowledge about ARM development/reference hardware. Signed-off-by: Ard Biesheuvel --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Maintainers

[edk2-devel] [PATCH v1 1/1] Sophgo/SG2042Pkg: Override Sstc extension

2024-01-12 Thread caiyuqing_hz
From: caiyuqing379 Override Sstc extension and use SBI calls itself by default for RISC-V Sophgo SG2042 platform. Cc: dahogn Cc: meng-cz Cc: USER0FISH Cc: Sunil V L Signed-off-by: caiyuqing379 --- Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1117 ++-- 1 file changed, 559

[edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-12 Thread Thomas Barrett
This series adds support for cloud-hypervisor guests with >1TiB of RAM to Ovmf. This bug was solved for Qemu back in 2017 https://bugzilla.redhat.com/show_bug.cgi?id=1468526. The bug is still occuring for CloudHv guests because the PlatformScanE820 utility is not currently supported for CloudHv. M

[edk2-devel] [PATCH v1 0/1] Sophgo/SG2042Pkg: Disable Sstc feature

2024-01-12 Thread caiyuqing_hz
From: caiyuqing379 By default the Sstc feature is enabled and Sophgo SG2042 platform need to set the PCD to disable the feature because Sstc is not supported. Cc: dahogn Cc: meng-cz Cc: USER0FISH Cc: Sunil V L Signed-off-by: caiyuqing379 caiyuqing379 (1): Sophgo/SG2042Pkg: Override Sstc

Re: [edk2-devel] [PATCH v1 0/1] Sophgo/SG2042Pkg: Disable Sstc feature

2024-01-12 Thread caiyuqing379
Hi, everyone Sorry, there is a problem with the formatting of this series of patches and it can't be retracted, please ignore this series and the correct series will be sent again later. Thanks! Yuqing Cai At 2024-01-12 22:16:23, caiyuqing...@163.com wrote: >From: caiyuqing379 > >B

Re: [edk2-devel] [Patch V2] BaseTools: VfrCompiler Adds DefaultValueError Feature

2024-01-12 Thread Zhang, Zifeng
Hi Liming, Could you help to share the update for this patch solution? Best Regards, Zifeng -Original Message- From: Yang, Yuting2 Sent: Monday, December 25, 2023 3:10 PM To: Gao, Liming Cc: Zhang, Zifeng ; Chen, Christine ; devel@edk2.groups.io Subject: RE: [Patch V2] BaseTools: Vfr

[edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read

2024-01-12 Thread Zhiquan Li
Currently the types of casting mismatch with TD MMIO read 1, 2 and 4 bytes, that might introduce potential issues. So fix the types as conventional MmioRead[8|16|32] does. Signed-off-by: Zhiquan Li --- MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c | 6 +++--- 1 file changed, 3 insertions

[edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read

2024-01-12 Thread Zhiquan Li
Currently the types of casting mismatch with TD MMIO read 1, 2 and 4 bytes, that might introduce potential issues. So fix the types as conventional MmioRead[8|16|32] does. Signed-off-by: Zhiquan Li --- MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c | 6 +++--- 1 file changed, 3 insertions(

[edk2-devel] [PATCH 6/6] SecurityPkg: : Adding CVE 2022-36764 to SecurityFixes.yaml

2024-01-12 Thread Doug Flick via groups.io
This creates / adds a security file that tracks the security fixes found in this package and can be used to find the fixes that were applied. Cc: Jiewen Yao Signed-off-by: Doug Flick [MSFT] --- SecurityPkg/SecurityFixes.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/S

[edk2-devel] [PATCH 5/6] SecurityPkg: DxeTpmMeasureBootLib: SECURITY PATCH 4118 - CVE 2022-36764

2024-01-12 Thread Doug Flick via groups.io
This commit contains the patch files and tests for DxeTpmMeasureBootLib CVE 2022-36764. Cc: Jiewen Yao Signed-off-by: Doug Flick [MSFT] --- .../DxeTpmMeasureBootLibSanitization.h| 23 + .../DxeTpmMeasureBootLib.c| 13 ++- .../DxeTpmMeasureBootLibSanitization.c

[edk2-devel] [PATCH 4/6] SecurityPkg: DxeTpm2MeasureBootLib: SECURITY PATCH 4118 - CVE 2022-36764

2024-01-12 Thread Doug Flick via groups.io
This commit contains the patch files and tests for DxeTpm2MeasureBootLib CVE 2022-36764. Cc: Jiewen Yao Signed-off-by: Doug Flick [MSFT] --- .../DxeTpm2MeasureBootLibSanitization.h | 28 - .../DxeTpm2MeasureBootLib.c | 12 ++-- .../DxeTpm2MeasureBootLibSanitizat

[edk2-devel] [PATCH 1/6] SecurityPkg: DxeTpm2MeasureBootLib: SECURITY PATCH 4117 - CVE 2022-36763

2024-01-12 Thread Doug Flick via groups.io
This commit contains the patch files and tests for DxeTpm2MeasureBootLib CVE 2022-36763. Cc: Jiewen Yao Signed-off-by: Doug Flick [MSFT] --- SecurityPkg/Test/SecurityPkgHostTest.dsc | 1 + .../DxeTpm2MeasureBootLib.inf | 4 +- ...Tpm2MeasureBootLibSanitizationTestHost.

[edk2-devel] [PATCH 0/6] SECURITY PATCHES TCBZ4117 & TCBZ4118

2024-01-12 Thread Doug Flick via groups.io
This patch series include the combined / merged security patches (as seperate commits) for TCBZ4117 (CVE-2022-36763) and TCBZ4118 (CVE-2022-36764) for DxeTpm2MeasureBootLib and DxeTpmMeasureBootLib. These patches have already been reviewed by SecurityPkg Maintainer (Jiewen) on GHSA. This patch se

[edk2-devel] [PATCH 3/6] SecurityPkg: : Adding CVE 2022-36763 to SecurityFixes.yaml

2024-01-12 Thread Doug Flick via groups.io
This creates / adds a security file that tracks the security fixes found in this package and can be used to find the fixes that were applied. Cc: Jiewen Yao Signed-off-by: Doug Flick [MSFT] --- SecurityPkg/SecurityFixes.yaml | 22 ++ 1 file changed, 22 insertions(+) create

[edk2-devel] [PATCH 2/6] SecurityPkg: DxeTpmMeasureBootLib: SECURITY PATCH 4117 - CVE 2022-36763

2024-01-12 Thread Doug Flick via groups.io
This commit contains the patch files and tests for DxeTpmMeasureBootLib CVE 2022-36763. Cc: Jiewen Yao Signed-off-by: Doug Flick [MSFT] --- SecurityPkg/Test/SecurityPkgHostTest.dsc | 1 + .../DxeTpmMeasureBootLib.inf | 4 +- ...eTpmMeasureBootLibSanitizationTestHost.i

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Michael D Kinney
Agreed. Basically every API that takes an EF_HANDLE as input calls that API to make sure it is a valid handle. The first question is if we get value from making sure the EFI_HANDLE is a member of the active set of handles. A simple signature check in the EFI_HANDLE may be enough as long as all

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
> On Jan 12, 2024, at 8:37 AM, Michael D Kinney > wrote: > > Hi Pedro, > > Thank you for evaluating this idea change from linked list to improve > performance of the handle database. > > The concept of using integers for an EFI_HANDLE has been considered before. > One advantage over pointers

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
> On Jan 12, 2024, at 6:46 AM, Pedro Falcato wrote: > > On Fri, Jan 12, 2024 at 9:35 AM Laszlo Ersek wrote: >> >> On 1/12/24 03:10, Pedro Falcato wrote: >>> My idea was to make each handle an index - like a file descriptor - >>> AFAIK there's no reason why it *needs* to be an actual pointer.

Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv

2024-01-12 Thread Thomas Barrett
Thanks Gerd, I'll pull that change into a separate commit and resubmit. Best, Thomas On Fri, Jan 12, 2024 at 3:47 AM Gerd Hoffmann wrote: > Hi, > > > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc > b/OvmfPkg/CloudHv/CloudHvX64.dsc > > index af594959a9..b522fa1059 100644 > > --- a/OvmfPkg/Cloud

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Michael D Kinney
Hi Pedro, Thank you for evaluating this idea change from linked list to improve performance of the handle database. The concept of using integers for an EFI_HANDLE has been considered before. One advantage over pointers is that a guarantee can be made that an EFI_HANDLE value can be guaranteed to

[edk2-devel] [edk2-platforms][PATCH V2 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-01-12 Thread Prabin CA
Enable ACPI CPPC mechanism for RD-Fremont as defined by the ACPI specification. The implementation uses AMU registers accessible as Fixed-feature Hardware (FFixedHW) for monitoring the performance. Non-secure SCMI fastchannels are used to communicate with LCP to set the desired performance. RD-Frem

[edk2-devel] [edk2-platforms][PATCH V2 7/8] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-01-12 Thread Prabin CA
RD-Fremont platform supports two LPI states, LPI1 (Standby WFI) and LPI3 (Power-down). The cluster supports LPI2 (Power-down) state. The LPI implementation also supports combined power state for core and cluster. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf

[edk2-devel] [edk2-platforms][PATCH V2 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-01-12 Thread Prabin CA
Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a 16 core platform with Poseidon CPU. Each of the CPUs include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache. The platform also includes system level cache of 32MB and 8GB of RAM. Signed-off-by: Prabin CA --- Platf

[edk2-devel] [edk2-platforms][PATCH V2 5/8] Platform/Sgi: Add initial support for RD-Fremont platform

2024-01-12 Thread Prabin CA
The RD-Fremont fixed virtual platform simulates 16 CPUs and 8GB of RAM. Add initial support for this platform by adding the required platform build configuration files. This platform has considerable differences in its memory map compared to its predecessors. So add a corresponding memory map file

[edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-01-12 Thread Prabin CA
From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system and so the FVP simulates 16 clusters. In preparation for

[edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-01-12 Thread Prabin CA
Introducing a flag called PCIE_ENABLE, which can be set to TRUE or FALSE from the respective .dsc files to enable or disable the PCIe support. As not all reference design platforms have PCIe support enabled, this flag is introduced. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/SgiPlatform.de

[edk2-devel] [edk2-platforms][PATCH V2 2/8] Platform/Sgi: Refactor system memory base and size definitions

2024-01-12 Thread Prabin CA
In preparation of adding the next generation of reference design platform that have different memory map, refactor the PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the common PCD definitions file into the various platform generation specific memory map PCD definitions file. Sig

[edk2-devel] [edk2-platforms][PATCH V2 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-01-12 Thread Prabin CA
From: Vivek Gautam On RD-N2 and previous generation platforms, the base address was within 32-bit region. However, on upcoming platforms, the SMMUv3 base address is beyond 32-bit address region. So, update the datatype of SMMUv3 base PCD. Signed-off-by: Vivek Gautam Signed-off-by: Prabin CA --

[edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-12 Thread Prabin CA
Changes since V1: - Corrected memory map in the DSDT file. This patch series introduce support for RD-Fremont reference design platform. This platform includes 32 CPUs, but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system and so the FVP

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Pedro Falcato
On Fri, Jan 12, 2024 at 9:35 AM Laszlo Ersek wrote: > > On 1/12/24 03:10, Pedro Falcato wrote: > > My idea was to make each handle an index - like a file descriptor - > > AFAIK there's no reason why it *needs* to be an actual pointer. > > We'd allocate indices when creating a handle, and return th

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

2024-01-12 Thread Sami Mujawar
Hi Liming, If there are no further comments on this patch, can you let me know if I can merge this, please? Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113740): https://edk2.groups.io/g/devel/message/113740 Mu

Re: [edk2-devel] [edk2-platforms PATCH v2 0/8] Silicon/Marvell/OdysseyPkg:

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > New Marvell Odyssey SoC > > This patchset contains only the very basic elements needed to boot to > EDK2 UiApp on Marvell Odyssey SoC > - ARM BL31 firmware component cop

[edk2-devel] [edk2-platforms][PATCH v3 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-12 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the RD-

[edk2-devel] [edk2-platforms][PATCH v3 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-01-12 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 +++

[edk2-devel] [edk2-platforms][PATCH v3 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-12 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant. RD-N

[edk2-devel] [edk2-platforms][PATCH v3 3/6] Platform/Sgi: Add a PCD to specify platform variant

2024-01-12 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/SgiPlatform.d

[edk2-devel] [edk2-platforms][PATCH v3 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-12 Thread Prabin CA
From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in SgiPlatformMm.

[edk2-devel] [edk2-platforms][PATCH v3 1/6] Platform/Sgi: remove +nofp gcc option flag

2024-01-12 Thread Prabin CA
From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow ac

[edk2-devel] [edk2-platforms][PATCH v3 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-01-12 Thread Prabin CA
Changes since V2: - Removed the patch which introduce fno-stack-protector in the build flag Changes since V1: - Addressed comments from Sami This patch series introduces support for two reference design platforms- RD-N2-Cfg3 and RD-V2. The RD-N2-Cfg3 FVP platform is a variant of RD-N2 platform wi

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

2024-01-12 Thread Gerd Hoffmann
On Fri, Jan 12, 2024 at 01:16:47PM +0100, Ard Biesheuvel wrote: > On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > > > It is possible to find variable entries with State being 0xff, > > i.e. not updated since flash block erase. This indicates the > > header write was not completed (and the

Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch adds an EDK2 shell command to dump board configuration > device tree. > > Signed-off-by: Narinder Dhillon > --- > .../Drivers/Fdt/FdtPlatformDxe/FdtPlatfor

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

2024-01-12 Thread Ard Biesheuvel
On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > It is possible to find variable entries with State being 0xff, > i.e. not updated since flash block erase. This indicates the > header write was not completed (and therefore State was not set > to VAR_HEADER_VALID_ONLY). Treat this as addit

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase

2024-01-12 Thread Ard Biesheuvel
On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > Raise the limit for writes without block erase from two to four > P30_MAX_BUFFER_SIZE_IN_BYTES blocks. With this in place almost > all efi variable updates are handled without block erase. With > the old limit some variable updates (with dev

Re: [edk2-devel] [PATCH 2/4] OvmfPkg/VirtNorFlashDxe: clarify block write logic

2024-01-12 Thread Ard Biesheuvel
On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > Introduce Start and End variables to make it easier to follow the > logic and code flow. Also replace the two NorFlashWriteBuffer calls > with a loop containing one call. > > With the changes in place the code is able to handle updates larger

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads

2024-01-12 Thread Ard Biesheuvel
On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > In some cases (specifically when the flash update region is > small but crosses a multiple of P30_MAX_BUFFER_SIZE_IN_BYTES) > NorFlashWriteSingleBlock reads only one instead of two > P30_MAX_BUFFER_SIZE_IN_BYTES blocks into the shadow buffer.

Re: [edk2-devel] [edk2-platforms PATCH v2 6/8] Silicon/Marvell: Device tree driver

2024-01-12 Thread Marcin Wojtas via groups.io
pt., 12 sty 2024 o 13:00 Marcin Wojtas napisał(a): > > +marcin.s.woj...@gmail.com > > Hi Narinder, > > czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > > > From: Narinder Dhillon > > > > This patch adds a device tree driver that is used to read board > > configuration information fro

Re: [edk2-devel] [edk2-platforms PATCH v2 6/8] Silicon/Marvell: Device tree driver

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch adds a device tree driver that is used to read board > configuration information from a device tree. > > Signed-off-by: Narinder Dhillon > --- > .../Drivers

Re: [edk2-devel] [Patch V4] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-12 Thread Gerd Hoffmann
Hi, > + // > + // 4-level paging supports translating 48-bit linear addresses to 52-bit > physical addresses. > + // Since linear addresses are sign-extended, the linear-address space of > 4-level paging is: > + // [0, 2^47-1] and [0x8000_, 0x_]. > + // So only

Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv

2024-01-12 Thread Gerd Hoffmann
Hi, > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc > index af594959a9..b522fa1059 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -566,6 +566,8 @@ ># Point to the MdeModulePkg/Application/UiApp/UiApp.inf >gEfiMdeMo

Re: [edk2-devel] [edk2-platforms PATCH v2 5/8] Silicon/Marvell: RTC driver

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > Marvell Odyssey SoC does not have RTC on chip. This patch provides a > dummy RTC driver to generate architectural protocol and help boot > Odyssey SoC. > > Signed-off-by

Re: [edk2-devel] [PATCH] UefiPayloadPkg: CbParseLib: Fix integer overflow

2024-01-12 Thread Guo, Gua
Reviewed-by: Gua Guo From: Lean Sheng Tan Sent: Friday, January 12, 2024 7:33:00 PM To: Rudolph, Patrick Cc: devel@edk2.groups.io ; Rhodes, Sean ; Guo, Gua ; Lu, James ; Ni, Ray ; Dong, Guo Subject: Re: [PATCH] UefiPayloadPkg: CbParseLib: Fix integer overflow

[edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

2024-01-12 Thread Gerd Hoffmann
It is possible to find variable entries with State being 0xff, i.e. not updated since flash block erase. This indicates the header write was not completed (and therefore State was not set to VAR_HEADER_VALID_ONLY). Treat this as additional "end of variable list" condition. Signed-off-by: Gerd H

[edk2-devel] [PATCH 3/4] OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase

2024-01-12 Thread Gerd Hoffmann
Raise the limit for writes without block erase from two to four P30_MAX_BUFFER_SIZE_IN_BYTES blocks. With this in place almost all efi variable updates are handled without block erase. With the old limit some variable updates (with device paths) took the block erase code path. Signed-off-by: Ger

[edk2-devel] [PATCH 1/4] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads

2024-01-12 Thread Gerd Hoffmann
In some cases (specifically when the flash update region is small but crosses a multiple of P30_MAX_BUFFER_SIZE_IN_BYTES) NorFlashWriteSingleBlock reads only one instead of two P30_MAX_BUFFER_SIZE_IN_BYTES blocks into the shadow buffer. That leads to random crap being written to the second block,

[edk2-devel] [PATCH 2/4] OvmfPkg/VirtNorFlashDxe: clarify block write logic

2024-01-12 Thread Gerd Hoffmann
Introduce Start and End variables to make it easier to follow the logic and code flow. Also replace the two NorFlashWriteBuffer calls with a loop containing one call. With the changes in place the code is able to handle updates larger than two P30_MAX_BUFFER_SIZE_IN_BYTES blocks, even though the

[edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-12 Thread Gerd Hoffmann
This is a little series containing the flash corruption fix sent yesterday with an slightly improved commit message and some small improvements on top of this. Gerd Hoffmann (4): OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads OvmfPkg/VirtNorFlashDxe: clarify block write logic OvmfPkg/VirtNo

Re: [edk2-devel] [edk2-platforms PATCH v2 4/8] Silicon/Marvell: Odyssey watchdog driver

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch adds watchdog driver for Odyssey SoC. To make sure - isn't this watchdog IP compatible with the ARM generic watchdog (ArmPkg/Drivers/GenericWatchdogDxe/). FYI

Re: [edk2-devel] [PATCH] UefiPayloadPkg: CbParseLib: Fix integer overflow

2024-01-12 Thread Sheng Lean Tan
Hi Gua or Sean, Would you mind to help review this? Thanks! Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum

Re: [edk2-devel] [edk2-platforms PATCH v2 2/8] Silicon/Marvell: Odyssey ArmPlatformLib

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 napisał(a): > > From: Narinder Dhillon > > This patch adds ArmPlatformLib for Marvell Odyssey SoC. > > Signed-off-by: Narinder Dhillon > --- > .../AArch64/ArmPlatformHelper.S | 86 > .../Library/ArmP

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads

2024-01-12 Thread Gerd Hoffmann
On Fri, Jan 12, 2024 at 10:47:43AM +0100, Laszlo Ersek wrote: > On 1/11/24 14:36, Gerd Hoffmann wrote: > > In some cases (specifically when the flash update region is > > small but crosses a multiple of P30_MAX_BUFFER_SIZE_IN_BYTES) > > NorFlashWriteSingleBlock reads only one instead of two > > P30

Re: [edk2-devel] [edk2-platforms PATCH v2 1/8] Silicon/Marvell: New Marvell Odyssey processor

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 napisał(a): > > From: Narinder Dhillon > > This patch creates ArmPlatformPkg for Odyssey SoC by overriding some of > the files in original ArmPlatformPkg. Differences from standard > ArmPlatformPkg are marked with "--- MRVL Overr

Re: [edk2-devel] [edk2-platforms PATCH v2 3/8] Silicon/Marvell: Odyssey SmcLib

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch provides SMC call needed by Odyssey to determine available > memory size. > > Signed-off-by: Narinder Dhillon > --- > Silicon/Marvell/Library/SmcLib/SmcLib.

[edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

2024-01-12 Thread Nickle Wang via groups.io
When the value type is defined as number in Redfish schema, floating point number is allowed. RedfishCrtLib raises assert without handling this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS and handle the floating point number. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Ig

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-12 Thread Sunil V L
Hi Ray, On Fri, Jan 12, 2024 at 09:12:34AM +, Ni, Ray wrote: > Sunil, > I would like to hear your feedback regarding locations of following RiscV64 > components in UefiCpuPkg: > * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ > * UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/ > * UefiCpuP

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-12 Thread Chao Li
Hi Ray, OK, here I come. [Ray] INF is a good question. [Ray] There are two options: [Ray]    Re-use current INF file. [Ray]    Create a new INF under LoongArch64 folder. [Ray] If the INF content can be shared a lot between different archs. Single INF is better. [Ray] I am just afraid some

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads

2024-01-12 Thread Laszlo Ersek
On 1/11/24 14:36, Gerd Hoffmann wrote: > In some cases (specifically when the flash update region is > small but crosses a multiple of P30_MAX_BUFFER_SIZE_IN_BYTES) > NorFlashWriteSingleBlock reads only one instead of two > P30_MAX_BUFFER_SIZE_IN_BYTES blocks into the shadow buffer. > > That leads

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Laszlo Ersek
On 1/12/24 03:44, Andrew (EFI) Fish wrote: > Sorry need some more time to digest this…. First thoughts. > > 1) The actual performance issue we hit was the explosion > of CoreValidateHandle() calls as the number of protocols got large for > some diags. The newer handles tended to be at the end of t

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Laszlo Ersek
On 1/12/24 03:10, Pedro Falcato wrote: > On Thu, Jan 11, 2024 at 8:46 AM Laszlo Ersek wrote: >> >> On 1/10/24 22:50, Pedro Falcato wrote: >>> FWIW, can we do better than an RB tree? They're notoriously cache >>> unfriendly... >> >> Sure, if someone contributes a different data structure that is s

Re: [edk2-devel] [PATCH v7 11/37] UefiCpuPkg: Add LoongArch64 CPU Timer library

2024-01-12 Thread Ni, Ray
Chao, I just sent a mail “[edk2-devel] RFC: Folder layout change in UefiCpuPkg” asking Sunil (RiscV64) the same thing. INF is a good question. There are two options: 1. Re-use current INF file. 2. Create a new INF under LoongArch64 folder. If the INF content can be shared a lot between di

Re: [edk2-devel] [PATCH v7 11/37] UefiCpuPkg: Add LoongArch64 CPU Timer library

2024-01-12 Thread Chao Li
Hi Ray, Thanks, Chao On 2024/1/12 16:51, Ni, Ray wrote: Chao, Do you mind putting the lib content under UefiCpuPkg/Library/CpuTimerLib/LoongArch64/? It also follows the guidelines and avoid creating too many folders under Library folder. No, I don't mind, do you means put the drivers or li

[edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-12 Thread Ni, Ray
Sunil, I would like to hear your feedback regarding locations of following RiscV64 components in UefiCpuPkg: * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ * UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/ * UefiCpuPkg/CpuDxeRiscV64/ * UefiCpuPkg/CpuTimerDxeRiscV64/ I would like to move them

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-12 Thread Ni, Ray
It's strange to me that ARM's MM env still allows modifying HOBs. Thanks, Ray > -Original Message- > From: Guo, Gua > Sent: Friday, January 12, 2024 10:25 AM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Marc Beatove ; > Ard Biesheuvel ; Sami Mujawar > ; Ni, Ray ; Mathews, John > ; Gerd Hof

Re: [edk2-devel] [PATCH] UefiCpuPkg: change name of gMpInformationHobGuid2

2024-01-12 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Thursday, January 11, 2024 5:01 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [PATCH] UefiCpuPkg: change name of gMpInformationHobGuid2 > > Change na

Re: [edk2-devel] [PATCH v7 11/37] UefiCpuPkg: Add LoongArch64 CPU Timer library

2024-01-12 Thread Ni, Ray
Chao, Do you mind putting the lib content under UefiCpuPkg/Library/CpuTimerLib/LoongArch64/? It also follows the guidelines and avoid creating too many folders under Library folder. Thanks, Ray > -Original Message- > From: Chao Li > Sent: Friday, January 12, 2024 4:24 PM > To: devel@ed

Re: [edk2-devel] [PATCH v7 15/37] UefiCpuPkg: Add multiprocessor library for LoongArch64

2024-01-12 Thread Ni, Ray
Chao, Do you mind putting the lib content under UefiCpuPkg/Library/MpInitLib/LoongArch64/? It also follows the guidelines and avoid creating too many folders under Library folder. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Friday, January

Re: [edk2-devel] [Patch V4] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-12 Thread duntan
Hi Gerd, I've refined the comments and the commit message. Could you please help to review again? Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, January 12, 2024 4:32 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul R ;

Re: [edk2-devel] [PATCH v7 16/37] UefiCpuPkg: Add CpuDxe driver for LoongArch64

2024-01-12 Thread Ni, Ray
Chao, Do you mind putting the lib content under UefiCpuPkg/CpuDxe/LoongArch64/? It also follows the guidelines and avoid creating too many folders under root folder. Thanks, Ray > -Original Message- > From: Chao Li > Sent: Friday, January 12, 2024 4:25 PM > To: devel@edk2.groups.io > Cc

Re: [edk2-devel] [PATCH v7 12/37] UefiCpuPkg: Add CPU exception library for LoongArch

2024-01-12 Thread Ni, Ray
Chao, Do you mind putting the lib content under UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch64/? It also follows the guidelines and avoid creating too much folders under Library folder. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Fr

[edk2-devel] [Patch V4] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-12 Thread duntan
When creating smm page table, limit maximum supported physical addresses bits returned by CalculateMaximumSupportAddress() to 47 if 5-Level Paging is disabled. This commit is to avoid issue that more than 47-bit physical addresses are requested in smm page table when 5-level paging is disabled. 4-

[edk2-devel] [PATCH v7 37/37] OvmfPkg/LoongArchVirt: Add self introduction file

2024-01-12 Thread Chao Li
Add self introduction file for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Reviewed-by: Bibo Mao --- OvmfPkg/LoongArchVirt/Rea

[edk2-devel] [PATCH v7 36/37] OvmfPkg/LoongArchVirt: Add build file

2024-01-12 Thread Chao Li
Add infrastructure files to build edk2 for LoongArch QEMU virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-auth

[edk2-devel] [PATCH v7 35/37] OvmfPkg/LoongArchVirt: Support PEI phase

2024-01-12 Thread Chao Li
Platfrom PEI module for LoongArch platfrom initialization. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Ma

[edk2-devel] [PATCH v7 34/37] OvmfPkg/LoongArchVirt: Support SEC phase

2024-01-12 Thread Chao Li
Add SEC code for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao Reviewed-by:

[edk2-devel] [PATCH v7 33/37] OvmfPkg/LoongArchVirt: Add reset system library

2024-01-12 Thread Chao Li
This library provides interface related to restart and shudown the LoongArch64 virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by:

[edk2-devel] [PATCH v7 32/37] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-01-12 Thread Chao Li
This library for PEI phase, and obtains the QemuFwCfg base address by directly parsing the FDT, reads and writes the data in QemuFwCfg by operating on the QemuFwCfg base address. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Ger

[edk2-devel] [PATCH v7 31/37] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-01-12 Thread Chao Li
Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-b

[edk2-devel] [PATCH v7 30/37] OvmfPkg/LoongArchVirt: Add real time clock library

2024-01-12 Thread Chao Li
This library is provides real time clock for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang Co-authore

[edk2-devel] [PATCH v7 29/37] OvmfPkg/LoongArchVirt: Add the early serial port output library

2024-01-12 Thread Chao Li
Add a early serial port output library into LoongArchVirt that named EarlyFdtSerialPortLib16550, this library is referenced from MdeModulePkg. This library is used in the PEI phase. Since the serial port address can not be saved in memory of the LoongArch QEMU virtual machine in the PEI phase, the

[edk2-devel] [PATCH v7 28/37] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-01-12 Thread Chao Li
Add a serial port hook library in LoongArchVirt named Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to transfer serial port base addres from the PEI phase to the DXE phase. BZ: https://bugzilla.tianocore.or

[edk2-devel] [PATCH v7 27/37] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

2024-01-12 Thread Chao Li
This Library is used to collect APs resources, but is currently NULL for OvmfPkg, because it is not used by the LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qi

[edk2-devel] [PATCH v7 26/37] OvmfPkg/LoongArchVirt: Add stable timer driver

2024-01-12 Thread Chao Li
Add a CPU timer driver named StableTimerDxe, which proviedes EFI_TIMER_ARCH_PROTOCOL for LoongArch. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored

[edk2-devel] [PATCH v7 25/37] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg

2024-01-12 Thread Chao Li
Moved the PlatformBootManagerLib to OvmfPkg and renamed to PlatformBootManagerLibLight for easy use by other ARCH. Build-tested only (with "ArmVirtQemu.dsc"). BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: J

[edk2-devel] [PATCH v7 24/37] ArmVirtPkg: Move two PCD variables into OvmfPkg

2024-01-12 Thread Chao Li
Move the PcdTerminalTypeGuidBuffer and PcdUninstallMemAttrProtocol into OvmfPkg so other ARCH can easily use it. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: Jiewen Yao Signed-off-by: Chao Li --- ArmVirt

  1   2   >