On Fri, Feb 16, 2024 at 8:06 PM Pedro Falcato wrote:
>
> On Fri, Feb 16, 2024 at 2:46 PM pawel.karczewski via groups.io
> wrote:
> >
> > Hi,
> >
> > I'm successfully building C++20 project with edk2 under the GCC compiler.
> > Currently I'm trying to add edk2-libc to this project, but
This patch series is the second version of
MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations.
The subject line has been updated because this went from a one commit
patch with no cover letter to a multi-commit patch.
The commit messages cover the vast amount of detail here,
ISO C interfaces do not have the 'register' keyword, so this is
technically non-compliant and other consumers of C headers (such as C++)
will error out when seeing this keyword.
This should not affect anything, functionality-wise or ABI-wise.
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc:
-Wregister (C++ and Objective-C++ only)
Warn on uses of the register storage class specifier, except when it is part of
the GNU Variables in Specified Registers extension. The use of the register
keyword as storage class specifier has been deprecated in C++11 and removed in
C++17. Enabled by
Signed-off-by: Mike Maslenkin
Cc: Ray Ni
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
index
This set contains a simple fixes for UINT64 values passed to functions
producing strings.
Patch 1/2 is a real fix for NVMe drive label creation logic.
For example: Opal driver from SecurityPkg uses gEfiComponentNameProtocolGuid
family for obtaining disk name.
Signed-off-by: Mike Maslenkin
Cc:
Eui64 is a 64 bit value, so the "L" or "l" is required for
format specifier, otherwise only lower 32 bit will be converted.
Signed-off-by: Mike Maslenkin
Cc: Ray Ni
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The other option is update build to ignore -Werror=register
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Friday, February 16, 2024 12:06 PM
> To: devel@edk2.groups.io; pawel.karczew...@solidigm.com
> Subject: Re: [edk2-devel] Using
On Fri, Feb 16, 2024 at 2:46 PM pawel.karczewski via groups.io
wrote:
>
> Hi,
>
> I'm successfully building C++20 project with edk2 under the GCC compiler.
> Currently I'm trying to add edk2-libc to this project, but encountered issue
> with header.
>
> ```
>
On Fri, Feb 16, 2024 at 5:26 PM Michael D Kinney
wrote:
>
> I think adding a #define to define register to nothings makes sense.
No, the correct fix is to remove 'register' from the parameters. It
does not change the ABI, nor the API, nor are the parameters
"register"-ified in the C or C++
On 2/15/24 11:25, Gerd Hoffmann wrote:
> The EFI Shell allows to bypass secure boot, do not allow
> to include the shell in the firmware images of secure boot
> enabled builds.
>
> This prevents misconfigured downstream builds.
>
> Ref: https://bugs.launchpad.net/ubuntu/+source/edk2/+bug/2040137
>
On 2/15/24 11:25, Gerd Hoffmann wrote:
> Place the EFI shell as EFI/BOOT/BOOT{ARCH}.EFI on the virtual drive.
> This allows the "run to shell" CI test case to work even in case the
> shell is not included in the firmware image.
>
> This is needed because an followup patch will exclude the shell
On 2/15/24 11:25, Gerd Hoffmann wrote:
> Note that IntelTdxX64 is compiled without network support, so thanks to
> the network conditionals in the include files the build result (network
> shell commands excluded) should be identical before and after the patch.
>
> Signed-off-by: Gerd Hoffmann
>
On 2/15/24 11:24, Gerd Hoffmann wrote:
> Note that AmdSevX64 is compiled without network support, so thanks to
> the network conditionals in the include files the build result (network
> shell commands excluded) should be identical before and after the patch.
>
> Signed-off-by: Gerd Hoffmann
>
On 2/15/24 11:24, Gerd Hoffmann wrote:
> Add NETWORK_ENABLE conditionals for the components
> which need network support.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/Include/Dsc/ShellComponents.dsc.inc | 6 ++
> OvmfPkg/Include/Fdf/ShellDxe.fdf.inc| 2 ++
> 2 files changed, 8
On 2/15/24 11:24, Gerd Hoffmann wrote:
> Move EFI Shell libraries from OvmfPkgX64.dsc to
> the new ShellComponents.dsc.inc include file.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/Include/Dsc/ShellLibs.dsc.inc | 10 ++
> OvmfPkg/OvmfPkgX64.dsc| 4 +---
> 2 files
I think adding a #define to define register to nothings makes sense.
If this is something that is tied to a specific C++ version, then it could be
further qualified with a version value.
Mike
From: devel@edk2.groups.io On Behalf Of pawel.karczewski
via groups.io
Sent: Friday, February 16,
Hi Rebecca,
This approach makes a lot of sense. Thank you for the updated. I have
approved.
Can we open some new Issues to re-enable flake8/ruf and codecov so
those tasks are not forgotten.
Thanks,
Mike
> -Original Message-
> From: Rebecca Cran
> Sent: Thursday, February 15, 2024
Good point.
The Spec revision can run ahead of the supported INF_VERSION values
if the spec changes are only clarifications.
1.27 is the highest INF_VERSION value currently documented.
I agree moving to 1.30 for spec and INF_VERSION is correct.
Mike
> -Original Message-
> From:
On Fri, 16 Feb 2024 at 15:20, Laszlo Ersek wrote:
>
> On 2/15/24 14:45, Rebecca Cran wrote:
> > On 2/15/2024 4:28 AM, Laszlo Ersek wrote:
> >> mail-archive.com is an important secondary archive because it offers
> >> message-id-based lookup. "git am --message-id" captures patch email
> >> message
Hi,
I'm successfully building C++20 project with edk2 under the GCC compiler.
Currently I'm trying to add edk2-libc to this project, but encountered issue
with header.
```
edk2/StdLib/Include/string.h:487:19: error: ISO C++17 does not allow ‘register’
storage class specifier
On 2/15/24 14:45, Rebecca Cran wrote:
> On 2/15/2024 4:28 AM, Laszlo Ersek wrote:
>> mail-archive.com is an important secondary archive because it offers
>> message-id-based lookup. "git am --message-id" captures patch email
>> message IDs in the commit messages, and then those can be used for
>>
On 2/15/24 18:29, Kinney, Michael D wrote:
> Hi Laszlo,
>
> I was also thinking the INF Version would be best approach.
>
> I recommend we identify the EDK II Build Specification and
> EDK II INF Specification changes required to resolve this
> issue.
>
>
23 matches
Mail list logo
