On 2/22/24 02:49, Laszlo Ersek wrote:
> (commenting once more, to explain the actual reason:)
>
> On 2/21/24 11:24, Gerd Hoffmann wrote:
>> On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote:
+ MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof
(MP_HAND_OFF)) /
Thanks for addressing my comment.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Thursday, February 22, 2024 4:06 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Nickle Wang
> ; Abner Chang ; Igor Kulchytskyy
>
> Subject:
On 2/20/24 18:49, Gerd Hoffmann wrote:
> Add support for splitting Hand-Off data into multiple HOBs. This is
> required for VMs with thousands of CPUs. The actual CPU count per HOB
> is much smaller (128) for better test coverage.
(1) The mention of the count 128 now seems stale for the code.
Laszlo:
Thanks for the detailed feedback on the changes for this issue. Since we are
not sure if this change are valid / violate some purpose of SNP driver, it
mentioned as Workaround.
@Saloni Kasbekar and @Clark-williams, Zachary can add more on these changes.
As you recommended, we can have
(commenting once more, to explain the actual reason:)
On 2/21/24 11:24, Gerd Hoffmann wrote:
> On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote:
>>>
>>> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof
>>> (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF);
>>
>> Above
Reviewed-by: Chao Li
Thanks,
Chao
On 2024/2/19 10:03, xianglai wrote:
The current implementation of loongarch NorFlashQemuLib is to
parse fdt and think that the first flash address resolved to
the NVRAM space, with the evolution of qemu code, loongarch
uses the first flash to store UEFI code
On 2/21/24 11:24, Gerd Hoffmann wrote:
> On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote:
>>>
>>> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof
>>> (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF);
>>
>> Above formula assumes the maximum HOB length could be 0x.
>
>
On 2/20/24 18:49, Gerd Hoffmann wrote:
> Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
> covering all CPUs in the system.
>
> Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are
> present, using the MpHandOff pointer for that does not work because the
>
On 2/20/24 18:49, Gerd Hoffmann wrote:
> Rename the MpHandOff parameter to FirstMpHandOff. Add loops so the
> function inspects all HOBs present in the system.
>
> Signed-off-by: Gerd Hoffmann
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 35
On 2/20/24 18:49, Gerd Hoffmann wrote:
> Rename the MpHandOff parameter to FirstMpHandOff. Add a loop so the
> function inspects all HOBs present in the system.
>
> Signed-off-by: Gerd Hoffmann
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 +++
> 1 file changed, 15
On 2/20/24 18:49, Gerd Hoffmann wrote:
> Rename the MpHandOff parameter to FirstMpHandOff. Add a loop so the
> function inspects all HOBs present in the system.
>
> Signed-off-by: Gerd Hoffmann
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 +++
> 1 file changed, 15
On 2/21/24 04:35, Ni, Ray wrote:
>> -Original Message-
>> From: Gerd Hoffmann
>> Sent: Wednesday, February 21, 2024 1:50 AM
>> To: devel@edk2.groups.io
>> Cc: Oliver Steffen ; Laszlo Ersek
>> ; Kumar, Rahul R ; Ni, Ray
>> ; Gerd Hoffmann
>> Subject: [PATCH v2 1/5] UefiCpuPkg/MpInitLib:
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, February 21, 2024 3:59 PM
> To: devel@edk2.groups.io; memrist...@proton.me
> Subject: Re: [edk2-devel] Peims are not gettting Dispatched in EagleStream
> Platform
>
> On 2/21/24 07:59,
On 2/21/24 07:59, memristor2 via groups.io wrote:
> Hi,
> I am trying to build edk2-platforms for EagleStream Platform. The
> problem I am facing now is that the Peims are not getting dispatched
> when The PeiMain routine calls PeiDispatcher().
> After digging deeper into it it seems that the
On 2/21/24 18:15, Santhosh Kumar V via groups.io wrote:
> The customer has a server environment where PXE and HTTP service run in same
> Linux Server. In this environment a SUT trying to boot to SLES 15 OS via PXE
> from the Boot Menu. After PXE Boot file downloaded and grub Loaded without
>
The series has been pushed as 73ebcac~..b7b8dd4.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nathaniel
> Haller
> Sent: Friday, February 16, 2024 5:47 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/2] Intel maintainers updates
>
> Adding maintainers
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, February 21, 2024 3:29 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Desimone, Nathaniel L
> Subject: Re: [edk2-devel] Merge commit in edk2-non-osi
>
> On Wed, 21 Feb 2024 at 16:05, Michael D Kinney
> wrote:
> >
>
On Wed, 21 Feb 2024 at 23:16, Laszlo Ersek wrote:
>
> On 2/20/24 15:48, Ard Biesheuvel wrote:
> > Hello Mike,
> >
> > I understand the desire to be pedantic about cc'ing the right
> > maintainers, but I'm not convinced this is the way.
> >
> > - the presence of a cc: tag does not guarantee that
On Wed, 21 Feb 2024 at 16:05, Michael D Kinney
wrote:
>
> Hi Ard,
>
> I disagree. We have never allowed a force push to the main
> branch of TianoCore repos. This has happened before and
> was discussed and the policy is to not fix. Even the edk2
> repo has some merge commits in its history
Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as IN.
"IN" replaced with "IN OUT" in the following interfaces:
PageTableLibSetPte4K(): Pte4K
PageTableLibSetPleB(): PleB
PageTableLibSetPle(): Ple
PageTableLibSetPnle(): Pnle
Signed-off-by: Zhou Jianfeng
Cc: Ray Ni
Cc:
Hi,
I am trying to build edk2-platforms for EagleStream Platform. The problem I am
facing now is that the Peims are not getting dispatched when The PeiMain
routine calls PeiDispatcher().
After digging deeper into it it seems that the DepexSatisfied() routine is
always returning false. So I also
The customer has a server environment where PXE and HTTP service run in same
Linux Server. In this environment a SUT trying to boot to SLES 15 OS via PXE
from the Boot Menu. After PXE Boot file downloaded and grub Loaded without
continuing for installation Exit is pressed and control back to
Add volatile qualifier to page table related variable to prevent
compiler from optimizing away the variables which may lead to
unexpected result.
Signed-off-by: Zhou Jianfeng
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
Hi,
I am trying to build edk2-platforms for EagleStream Platform. The problem I am
facing now is that the Peims are not getting dispatched when The PeiMain
routine calls PeiDispatcher().
After digging deeper into it it seems that the DepexSatisfied() routine is
always returning false. So I also
On 2/20/24 15:48, Ard Biesheuvel wrote:
> Hello Mike,
>
> I understand the desire to be pedantic about cc'ing the right
> maintainers, but I'm not convinced this is the way.
>
> - the presence of a cc: tag does not guarantee that the person was
> cc'ed - only git send-email will take CC:s in the
On 2/21/24 18:15, Borzeszkowski, Alan wrote:
>> It does not make sense to have a UEFI Driver active in early DXE because it
>> will not be connected yet and has dependencies on other UEFI drivers that
>> will not be connected yet.
>
> With suggested change, we connect to this driver
On Wed, Feb 21, 2024 at 8:36 PM Laszlo Ersek wrote:
>
> On 2/21/24 02:25, Zhou Jianfeng wrote:
> > Add volatile qualifier to page table related variable to prevent
> > compiler from optimizing away the variables which may lead to
> > unexpected result.
> >
> > Signed-off-by: Zhou Jianfeng
> >
DXE env is not UEFI conformant. UEFI Drivers can not be executed
until the UEFI env is fully established which is at end of DXE
after all DXE Arch Protocols are produced and DXE Core supports the
full set of requires UEFI services. Running a UEFI Driver or UEFI
Application before all DXE Arch
On 2/21/24 02:25, Zhou Jianfeng wrote:
> Add volatile qualifier to page table related variable to prevent
> compiler from optimizing away the variables which may lead to
> unexpected result.
>
> Signed-off-by: Zhou Jianfeng
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
On 2/21/24 21:06, Laszlo Ersek wrote:
> On 2/21/24 06:46, Ni, Ray wrote:
>> Reviewed-by: Ray Ni
>
> Thank you Ray for reviewing this; I'm happy if this goes in with your
> review.
small suggestion: I think we could improve the subject line as follows:
UefiCpuPkg/CpuPageTableLib: Fix IN OUT
On 2/21/24 06:46, Ni, Ray wrote:
> Reviewed-by: Ray Ni
Thank you Ray for reviewing this; I'm happy if this goes in with your
review.
Laszlo
>
> Thanks,
> Ray
>> -Original Message-
>> From: Zhou, Jianfeng
>> Sent: Wednesday, February 21, 2024 9:25 AM
>> To: devel@edk2.groups.io
>> Cc:
This patch replaces value Private->Json with Json used as second argument
for RedfishIdentifyResource(). Currently Json argument is not used at all
and the pattern for caller side is:
Status = RedfishIdentifyResourceCommon (Private, Private->Json);
So in scope of RedfishIdentifyResourceCommon
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
Reviewed-by: Nickle Wang
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
Reviewed-by: Nickle Wang
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Use local variable for BiosUri passed to HandleResource() to avoid
problems in case of Private->Uri is overriden down the call stack.
Suggested-by: Nickle Wang
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
This set contains a trivial fix for a leak reviewed on Feb 1 [1] and a fix for
а leak discussed in [2]
PR: https://github.com/tianocore/edk2-redfish-client/pull/76
[1] https://edk2.groups.io/g/devel/message/114925
[2] https://edk2.groups.io/g/devel/message/114765
v2:
in commit message put Cc
On 2/20/24 20:48, Hsueh, Hong-Chih (Neo) wrote:
> [AMD Official Use Only - General]
>
>
> Hi Feng & Laszlo,
>
> Thank you for the feedback, I have changed the title of this email and
> the title of the commit message of this patch.
> The new patch as attached. If this patch looks good to you,
On Wed, Feb 21, 2024 at 5:34 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Wednesday, February 21, 2024 8:13 AM
> > To: devel@edk2.groups.io
> > Cc: Mike Maslenkin ; Nickle Wang
> > ; Chang, Abner ; Igor
> >
> It does not make sense to have a UEFI Driver active in early DXE because it
> will not be connected yet and has dependencies on other UEFI drivers that
> will not be connected yet.
With suggested change, we connect to this driver successfully in early DXE
using ConnectController(). We did
Thanks for the reminder. "Require Linear History" was not set
in edk2-non-osi. It is now.
Mike
> -Original Message-
> From: Marcin Juszkiewicz
> Sent: Wednesday, February 21, 2024 12:58 AM
> To: devel@edk2.groups.io; Desimone, Nathaniel L
>
> Cc: Kinney, Michael D
> Subject: Re:
[AMD Official Use Only - General]
Hi Nickle,
I have no problem with either one, maybe BiosUri is a better choice.
Thanks
Abner
From: Nickle Wang
Sent: Wednesday, February 21, 2024 3:30 PM
To: Mike Maslenkin ; devel@edk2.groups.io; Chang,
Abner
Cc: Igor Kulchytskyy
Subject: RE: [PATCH 2/4]
Hi Ard,
I disagree. We have never allowed a force push to the main
branch of TianoCore repos. This has happened before and
was discussed and the policy is to not fix. Even the edk2
repo has some merge commits in its history that were discussed
and not fixed.
We can never know how many
On Sat, 17 Feb 2024 at 02:27, Oliver Smith-Denny
wrote:
>
> This patch series is the second version of
> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations.
> The subject line has been updated because this went from a one commit
> patch with no cover letter to a multi-commit
On Tue, 20 Feb 2024 at 10:06, Gerd Hoffmann wrote:
>
> Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a
> 5-level enabled build runs in 4-level paging mode.
>
> Patch #2 - #4 update OvmfPkg ResetVector, adding support for 5-level
> paging (setup 5-level page tables in case both
W dniu 20.02.2024 o 8:33 AM, Xiong Yining pisze:
To support more memory nodes, we refer to the implement of
"OvmfPkg/Fdt/HighMemDxe" to add memory space for the high memory nodes
except the first one.
Signed-off-by: Xiong Yining
Signed-off-by: Chen Baozi
Tested-by: Marcin Juszkiewicz
EDK2
W dniu 20.02.2024 o 9:03 AM, Xiong Yining pisze:
This is beacuse UEFI only allocates the first memory node memory space
for SbsaQemu platform, i refer to implemet of "OvmfPkg/Fdt/HighMemDxe"
and add the support for other memory nodes via GCD services. Maybe you
can apply patch "support multi
On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote:
> >
> > + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof
> > (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF);
>
> Above formula assumes the maximum HOB length could be 0x.
Which is IMHO correct.
> But actually the
Current implementation makes assumptions about arch it will be built
for. Need to make it more generic to add follow up support for RISCV.
Right now it does not build for RV until relevant dsc file is available.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Dhaval
Current implementation makes assumptions about arch it will be built
for. Need to make it more generic to add follow up support for RISCV.
Right now it does not build for RV until relevant dsc file is available.
https://github.com/tianocore/edk2/pull/5395
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James
W dniu 21.02.2024 o 2:49 AM, Nate DeSimone pisze:
I would like to remind everyone that we generally don't accept
submissions via PRs yet. At the very least please click "Rebase and
merge" when closing the PR instead of "Merge pull request". Since that
merge commit is currently at the top of the
On Wed, 21 Feb 2024 at 02:49, Nate DeSimone
wrote:
>
> Hi Everyone,
>
> It appears that a merge commit was introduced to edk2-non-osi due to a PR
> merge:
>
> https://github.com/tianocore/edk2-non-osi/commit/61b65fccfe4c75bc9ecb7b542412a436e3db5de6
>
> I would like to remind everyone that we
51 matches
Mail list logo
