Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/28/24 17:27, Albecki, Mateusz wrote: > Sorry, I didn't want to make an impression that I expected solution to > be delivered, I was merely trying to explain some of the complexity we > are trying to handle on our side and why we didn't went for SerialDxe > and instead opted to make

Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Reset the one-shot bits before modifing GCMD_REG

Hi Ray, Could you help to review and merge this Vtd driver patch to edk2platforms branch? This patch is used to fix a bug about missing to mask one-shot bits when write VTD GCMD_REG register. Here is the PR of this patch. https://github.com/tianocore/edk2-platforms/pull/125 Thank you. BR Sheng

Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro

On 2/28/24 09:22, Gerd Hoffmann wrote: > On Wed, Feb 28, 2024 at 05:09:32AM +0100, Laszlo Ersek wrote: >> On 2/22/24 12:54, Gerd Hoffmann wrote: >>> Move code to clear the page tables to a nasm macro. >>> No functional change. >>> >>> Signed-off-by: Gerd Hoffmann >>> --- >>>

Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Reset the one-shot bits before modifing GCMD_REG

Reviewed-by: Jenny Huang -Original Message- From: devel@edk2.groups.io On Behalf Of Sheng, W Sent: Monday, February 19, 2024 7:37 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Reset the one-shot bits

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

[AMD Official Use Only - General] From: Igor Kulchytskyy Sent: Thursday, February 29, 2024 9:38 AM To: Chang, Abner ; Nickle Wang ; Mike Maslenkin Cc: devel@edk2.groups.io; Nick Ramirez Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Re: [edk2-devel] [PATCH v2] SecurityPkg/SecureBootConfigDxe: Update UI according to UEFI spec

Jiewen: This patch is only for UEFI spec mantis 1908 change in SecureBootConfigDxe. This spec change just ask some drivers do some modification, it does not ask the HII core to be modified, so this spec change will not cause compatibility issue. For this patch, it only touch the UI

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

-Original Message- From: Chang, Abner Sent: Wednesday, February 28, 2024 7:31 PM To: Nickle Wang ; Mike Maslenkin ; Igor Kulchytskyy Cc: devel@edk2.groups.io; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Thursday, February 29, 2024 8:11 AM > To: Mike Maslenkin > Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Chang, Abner > ; Nick Ramirez > Subject: RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

> Sure! > > Reviewed-by: Mike Maslenkin Thanks, Mike! > But I didn't see any implementation of gzip coding/encoding for edk2. > Do you know of any? I just talked to Aber about this. We are working to see if we can provide gzip implementation in edk2 or not. It seems to me that we need 3rd

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On Wed, Feb 7, 2024 at 10:15 AM Laszlo Ersek wrote: > On 2/7/24 02:29, Tuan Phan wrote: > > The GCD EFI_MEMORY_UC and EFI_MEMORY_WC attributes will be > > supported when Svpbmt extension available. > > > > Signed-off-by: Tuan Phan > > --- > > .../Library/BaseRiscVMmuLib/BaseRiscVMmuLib.c | 25

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

Reviewed-by: Mike Maslenkin Regards, Mike. On Mon, Feb 26, 2024 at 7:55 AM wrote: > > From: Abner Chang > > Clarify the HTTP method that is used to provision BIOS > managed Redfish resource. > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > ---

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

On Wed, Feb 28, 2024 at 2:47 PM Nickle Wang wrote: > > Hi @Mike Maslenkin, > > > > May I have your reviewed-by if version 3 patch set look good to you? > Sure! Reviewed-by: Mike Maslenkin BTW I'm just curious, there is a mention in patch 2 "We currently only support gzip Content-Encoding."

Re: [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension

On Tue, Feb 27, 2024 at 8:42 PM Sunil V L wrote: > Hi Tuan, > > On Mon, Feb 26, 2024 at 08:34:22PM -0800, Tuan Phan wrote: > > Hi Sunil/ Andrei, > > Any comments on this series? > > > Did I miss your response to Laszlo's feedback on PATCH 2 - [1]? Apart > from that, don't we need to handle

Re: [edk2-devel] Tagging and releases of edk2-basetools

Thanks. Since Sean commented on https://github.com/tianocore/edk2-basetools/issues/85, adding him for more context around the original request. -- Rebecca Cran On 2/28/24 04:35, Gerd Hoffmann wrote: On Wed, Feb 28, 2024 at 09:27:57AM +0100, Laszlo Ersek wrote: On 2/28/24 02:15, Rebecca

Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

+Resending with email address for maintainers. Hi Ard, Leif, This patch adds macros that can be used to validate that the SPI ranges are valid. These have been define here so that we do not duplicate it at multiple places. Can you let me know if I can merge this patch, please? Regards, Sami

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

Sorry, I didn't want to make an impression that I expected solution to be delivered, I was merely trying to explain some of the complexity we are trying to handle on our side and why we didn't went for SerialDxe and instead opted to make PciSioSerialDxe work for our use case. Anyway thanks for

Re: [edk2-devel] [PATCH v2 00/23] Provide SEV-SNP support for running under an SVSM

On 2/28/24 00:14, Yao, Jiewen wrote: Some feedback: 1) 0002-MdePkg-GHCB-APIC-ID-retrieval-support-definitions MdePkg only contains the definition in the standard. Question: Is EFI_APIC_IDS_GUID definition in some AMD/SVSM specification? The structure is documented in the GHCB specification,

Re: [edk2-devel] [PATCH v2 18/23] OvmfPkg/CcSvsmLib: Add support for the SVSM_CORE_PVALIDATE call

On 2/28/24 02:50, Gerd Hoffmann wrote: Hi, +// Clear the buffer in prep for creating all new entries +SetMem (Caa->SvsmBuffer, sizeof (Caa->SvsmBuffer), 0); Minor nit: There is a ZeroMem() for this purpose. I use SetMem() in a few places, I'll change them over to

Re: [edk2-devel] [PATCH v2 14/23] Ovmfpkg/CcSvsmLib: Create CcSvsmLib to handle SVSM related services

On 2/28/24 02:40, Gerd Hoffmann wrote: +/** + Perform a native PVALIDATE operation for the page ranges specified. + + Validate or rescind the validation of the specified pages. + + @param[in] Info Pointer to a page state change structure + +**/ +STATIC +VOID +BasePvalidate ( +

Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

Hi Ard, Leif, This patch adds macros that can be used to validate that the SPI ranges are valid. These have been define here so that we do not duplicate it at multiple places. Can you let me know if I can merge this patch, please? Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] CI: GCC13 and lcov problem

Hi, I am working on switching the Linux CI jobs over to the Fedora 39 image which comes with gcc 13. Unfortunately, some jobs fail due to some error related to lcov / geninfo, see below. Does anybody know from the top of the head what this is about / what to do? PR:

Re: [edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Adds ACPI HPET Table generator

Hi Pierre Gondois,     Thanks for review the comment, i will make the changes accordingly. Please find my response in line. Thanks AbduL On 27-02-2024 21:32, Pierre Gondois wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

Move the WaitLoopExecutionMode and StartupSignalValue fields to a separate HOB with the new struct. WaitLoopExecutionMode and StartupSignalValue are independent of processor index ranges; they are global to MpInitLib (i.e., the entire system). Therefore they shouldn't be repeated in every

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Hi @Mike Maslenkin, May I have your reviewed-by if version 3 patch set look good to you? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Tuesday, February 27, 2024 8:49 AM >

Re: [edk2-devel] Tagging and releases of edk2-basetools

On Wed, Feb 28, 2024 at 09:27:57AM +0100, Laszlo Ersek wrote: > On 2/28/24 02:15, Rebecca Cran wrote: > > edk2-basetools is finally fixed and releases can once again be published > > to PyPI. > > > > However, in moving from setup.py to pyproject.toml the process has > > changed, and Joey

Re: [edk2-devel] CodeQL Analysis in edk2

On Tue, Feb 27, 2024 at 11:04:47AM -0500, Michael Kubacki wrote: > Hi Gerd, > > A real-world example is here: > https://github.com/microsoft/mu_basecore/blob/release/202311/CodeQlFilters.yml > > That can currently operate at the file and CodeQL rule level granularity. In > this case, the null

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/27/24 18:15, Albecki, Mateusz wrote: > Is the idea to refactor PciSioSerialDxe to extract functions that access > the HW and wrap it in the SerialPortLib instance? That solution would > still save us some maintenance cost. However exploring the idea further > I see following problems: > > 1.

[edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini

When the FMMTConf.ini file has empty lines then it used to throw errors GuidTool load error!, this patch is to skip checking for empty lines in the ini file Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Chen Christine Cc: Chaganty Rangasai V Signed-off-by: Ashraf Ali ---

Re: [edk2-devel] [PATCH v2 22/23] Ovmfpkg/CcExitLib: Provide SVSM discovery support

On Thu, Feb 22, 2024 at 11:30:01AM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > The SVSM specification documents an alternative method of discovery for > the SVSM using a reserved CPUID bit and a reserved MSR. > > For the CPUID support, the #VC handler

Re: [edk2-devel] [PATCH v2 2/4] MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

Thanks Laszlo. Both are good comments. I will follow in next version Thanks Zhiguang > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, February 28, 2024 4:45 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Liming Gao ; Wu, Jiaxin > ; Ni, Ray > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH v2 20/23] OvmfPkg/CcSvsmLib: Add support for the SVSM create/delete vCPU calls

On Thu, Feb 22, 2024 at 11:29:59AM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > The RMPADJUST instruction is used to alter the VMSA attribute of a page, > but the VMSA attribute can only be changed when running at VMPL0. When > an SVSM is present, use

Re: [edk2-devel] [PATCH v2 19/23] OvmfPkg/BaseMemEncryptSevLib: Maximize Page State Change efficiency

On Thu, Feb 22, 2024 at 11:29:58AM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > Similar to the Page State Change optimization added previously, also take > into account the possiblity of using the SVSM for PVALIDATE instructions. > Conditionally adjust

Re: [edk2-devel] [PATCH v2 18/23] OvmfPkg/CcSvsmLib: Add support for the SVSM_CORE_PVALIDATE call

Hi, > +// Clear the buffer in prep for creating all new entries > +SetMem (Caa->SvsmBuffer, sizeof (Caa->SvsmBuffer), 0); Minor nit: There is a ZeroMem() for this purpose. Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH v2 16/23] OvmfPkg/BaseMemEncryptSevLib: Use CcSvsmSnpPvalidate() to validate pages

> -STATIC > -VOID > -PvalidateRange ( > - IN SNP_PAGE_STATE_CHANGE_INFO *Info > - ) > -{ Ah, here you are completing the code move started in patch #14. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116104):

Re: [edk2-devel] [PATCH v2 4/4] StandaloneMmPkg: Disallow unregister MMI handler in other MMI handler

On 2/28/24 03:27, Zhiguang Liu wrote: > In last patch, we add code support to unregister MMI handler inside > itself. However, the code doesn't support unregister MMI handler > insider other MMI handler. While this is not a must-have usage. > So add check to disallow unregister MMI handler in

Re: [edk2-devel] [PATCH v2 3/4] StandaloneMmPkg: Support to unregister MMI handler inside MMI handler

On 2/28/24 03:27, Zhiguang Liu wrote: > To support unregister MMI handler inside MMI handler itself, > get next node before MMI handler is executed, since LIST_ENTRY that > Link points to may be freed if unregister MMI handler in MMI handler > itself. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc:

Re: [edk2-devel] [PATCH v2 2/4] MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

On 2/28/24 03:27, Zhiguang Liu wrote: > In last patch, we add code support to unregister SMI handler inside > itself. However, the code doesn't support unregister SMI handler > insider other SMI handler. While this is not a must-have usage. > So add check to disallow unregister SMI handler in

Re: [edk2-devel] [PATCH v2 17/23] OvmfPkg: Create a calling area used to communicate with the SVSM

On Thu, Feb 22, 2024 at 11:29:56AM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > An SVSM requires a calling area page whose address (CAA) is used by the > SVSM to communicate and process the SVSM request. > > Add a pre-defined page area to the OvmfPkg

Re: [edk2-devel] [PATCH v2 15/23] UefiCpuPkg/MpInitLib: Use CcSvsmSnpVmsaRmpAdjust() to set/clear VMSA

On Thu, Feb 22, 2024 at 11:29:54AM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > The RMPADJUST instruction is used to change the VMSA attribute of a page, > but the VMSA attribute can only be changed when running at VMPL0. To > prepare for running at a

Re: [edk2-devel] [PATCH v2 14/23] Ovmfpkg/CcSvsmLib: Create CcSvsmLib to handle SVSM related services

> +/** > + Perform a native PVALIDATE operation for the page ranges specified. > + > + Validate or rescind the validation of the specified pages. > + > + @param[in] Info Pointer to a page state change structure > + > +**/ > +STATIC > +VOID > +BasePvalidate ( > + IN

[edk2-devel] [PATCH v4] IntelFsp2Pkg: Fsp 2.x Changes

Changes to support spec changes 1. Remove usage of Pcd. 2. Change code to validate the Temporary Ram size input. 3. Consume the input saved in YMM Register Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chiu Chasel Cc: Duggapu Chinni B Signed-off-by: Duggapu Chinni B ---

Re: [edk2-devel] [PATCH V1 3/3] OvmfPkg/TdxDxe: Clear the registers before tdcall

On Tuesday, February 27, 2024 8:26 PM Yamahata, Isaku wrote: > > +%macro tdcall_regs_preamble 2 > > +mov rax, %1 > > + > > +xor rcx, rcx > > +mov ecx, %2 > > + > > +; R10 = 0 (standard TDVMCALL) > > + > > +xor r10d, r10d > > + > > +; Zero out unused (for standard TDVMCALL)

Re: [edk2-devel] Tagging and releases of edk2-basetools

On 2/28/24 02:15, Rebecca Cran wrote: > edk2-basetools is finally fixed and releases can once again be published > to PyPI. > > However, in moving from setup.py to pyproject.toml the process has > changed, and Joey suggested the old way might have been chosen > deliberately to be different from

Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro

On Wed, Feb 28, 2024 at 05:09:32AM +0100, Laszlo Ersek wrote: > On 2/22/24 12:54, Gerd Hoffmann wrote: > > Move code to clear the page tables to a nasm macro. > > No functional change. > > > > Signed-off-by: Gerd Hoffmann > > --- > > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 35