Re: [edk2-devel] VS2019 and AARCH64 with current EDKII mainline code.

2024-03-19 Thread Adam Liu
I got the same issue and already submit a patch. https://edk2.groups.io/g/devel/topic/patch_v2_1_1/105038588?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,105038588,previd%3D1710905523338626613,nextid%3D1710847665703537227=1710905523338626613=1710847665703537227 Hope it got accepted and push to

Re: [edk2-devel] [PATCH] MdePkg: Add PciVenNameLib to get vendor name.

2024-03-19 Thread Simon Wang via groups.io
The original intention is using the string data for firmware manufacturer of SMBIOS type 45 record which associated to PCI device. Moving to ShellPkg would limit the usage for other purpose. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

[edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-19 Thread Adam Liu
Declare InternalAssertJumpBuffer as EXTERN Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Shun Cheng Liu Reviewed-by: levi.yun --- MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 1 +

[edk2-devel] [PATCH v2 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-19 Thread Adam Liu
Declare InternalAssertJumpBuffer to fix build error. Shun Cheng Liu (1): MdePkg/BaseLib: Fix AARCH64 compilation error MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 1 + MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 + 2 files changed, 2 insertions(+) -- 2.25.1

Re: [edk2-devel] reg: HTTP Proxy Support

2024-03-19 Thread Saloni Kasbekar
Still waiting for the new UEFI Specification to be released. Plan to send out the edk2 patches as soon as it is released. From: Vivian Shi (石丽) Sent: Tuesday, March 19, 2024 12:01 AM To: Kasbekar, Saloni ; Sivaraman Nainar ; devel@edk2.groups.io Cc: Dhanaraj V ; Clark-williams, Zachary ;

[edk2-devel] VS2019 and AARCH64 with current EDKII mainline code.

2024-03-19 Thread Ken Taylor
Hi all, I've been trying to build the latest 2023 release of EDKII with AARCH64 using VS2019, and I'm encountering an issue with line 51 of MdePkg\Library\BaseLib\AArch64\SetJumpLongJump.asm. Specifically, there's no EXTERN for InternalAssertJumpBuffer and the 64 bit ARM cross assembler that

[edk2-devel] [PATCH v2 3/3] ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c

2024-03-19 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c Additionally added the base support for the table with new header file ConformanceProfiles.h (Cc'd maintainers of MdePkg for this) Cc: Ray Ni Cc: Zhichao Gao Cc:

[edk2-devel] [PATCH v2 2/3] ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c

2024-03-19 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented dumping of the Image Execution Table using Dmem.c Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor --- ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 138

[edk2-devel] [PATCH v2 1/3] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c

2024-03-19 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented the dumping of the UEFI RT Properties Table using Dmem.c Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor --- ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 62

[edk2-devel] [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to Dmem.c

2024-03-19 Thread Sam Kaynor
v1->v2: - Changed how the Conformance Profile Table is iterated - Changed how the Image Execution Table is iterated Cc: Ray Ni Cc: Zhichao Gao Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sam Kaynor Sam Kaynor (3): ShellPkg: UefiShellDebug1CommandsLib: Dumping RT

[edk2-devel] Refactoring the UEFI shell

2024-03-19 Thread Benjamin Doron
Hi all, We're planning to refactor the shell into a library so that shell apps possibly used in the field for testing can be easily adapted for automation. Our plan is: - Refactor ShellInfoObject into base internals and interactive elements - Migrate functions that imply interactivity into

Re: [edk2-devel] [PATCH edk2-platforms v7 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-19 Thread Ard Biesheuvel
On Tue, 19 Mar 2024 at 14:50, Marcin Juszkiewicz wrote: > > This library provides functions to check for hardware information. > For now it covers CPU ones: > > - amount of cpu cores > - MPIDR value for cpu core > - NUMA node id for cpu core > > Values are read from TF-A using platform specific

Re: [edk2-devel] [PATCH v4 3/4] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

2024-03-19 Thread Tuan Phan
Hi Sunil, On Mon, Mar 18, 2024 at 6:00 AM Sunil V L wrote: > Hi Tuan, > > On Thu, Mar 14, 2024 at 01:19:16PM -0700, Tuan Phan wrote: > > The GCD EFI_MEMORY_UC and EFI_MEMORY_WC memory attributes will be > > supported when Svpbmt extension available. > > > > Cc: Gerd Hoffmann > > Cc: Laszlo

Re: [edk2-devel] [PATCH 1/3] CryptoPkg/BaseCryptLib: add additional RSAEP-OAEP crypto functions

2024-03-19 Thread Chris Ruffin via groups.io
Hi Yi, thanks for your email. I created a Bugzilla ticket for this, see Bugzilla ID #4732: https://bugzilla.tianocore.org/show_bug.cgi?id=4732. The Pkcs1v2Encrypt() API is maintained but the implementation is refactored. There is currently no Pkcs1v2Decrypt(), this is also a newly

[edk2-devel] [PATCH edk2-platforms v7 4/4] Platform/SbsaQemu: get the information of memory via SMC calls

2024-03-19 Thread Marcin Juszkiewicz
From: Xiong Yining Provide functions to check for memory information: - amount of memory nodes - memory address - NUMA node id for memory Values are read from TF-A using platform specific SMC calls. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v7 3/4] Platform/SbsaQemu: drop FdtHandlerLib

2024-03-19 Thread Marcin Juszkiewicz
There is no need for EDK2 to know that there is DeviceTree around. All hardware information is read using functions from SbsaQemuHardwareInfoLib library. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 -

[edk2-devel] [PATCH edk2-platforms v7 2/4] Platform/SbsaQemu: use SbsaQemuHardwareInfoLib for cpu information

2024-03-19 Thread Marcin Juszkiewicz
We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to parse DeviceTree anymore. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++ .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 5 ++---

[edk2-devel] [PATCH edk2-platforms v7 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-19 Thread Marcin Juszkiewicz
This library provides functions to check for hardware information. For now it covers CPU ones: - amount of cpu cores - MPIDR value for cpu core - NUMA node id for cpu core Values are read from TF-A using platform specific SMC calls. Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v7 0/4] get rid of DeviceTree from SbsaQemu

2024-03-19 Thread Marcin Juszkiewicz
We want to stop parsing DeviceTree to gather hardware information. Instead we ask TF-A for those details using SMC calls. On real hardware platform it could be asking on-board Embedded Controller. Hardware information (CPU, Memory) is now in SbsaQemuHardwareInfoLib together with new code for

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Qemu/Sbsa: update TF-A binaries to get needed SMC calls

2024-03-19 Thread Ard Biesheuvel
On Thu, 14 Mar 2024 at 15:21, Marcin Juszkiewicz wrote: > > W dniu 14.03.2024 o 15:17, Marcin Juszkiewicz via groups.io pisze: > > We want to stop parsing DeviceTree (in EDK2) to gather hardware information. > > > > Instead we ask TF-A for those details using SMC calls. On real hardware > >

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

2024-03-19 Thread Sivaraman Nainar via groups.io
@Saloni Kasbekar, Can you please comment on the changes? Thanks Siva -Original Message- From: Sivaraman Nainar Sent: Monday, February 26, 2024 4:01 PM To: devel@edk2.groups.io; Sivaraman Nainar ; Laszlo Ersek ; Santhosh Kumar V ; Saloni Kasbekar ; Zachary Clark-williams Cc: Raj V

Re: [edk2-devel] [PATCH edk2-platforms v6 2/7] Platform/SbsaQemu: read amount of cpus during init

2024-03-19 Thread Marcin Juszkiewicz
W dniu 19.03.2024 o 12:02, Ard Biesheuvel pisze: EDK2 starts and one of the first DXE called is SbsaQemuPlatformDxe one: How is this guaranteed? DXE are generally dispatched in the order in which they appear in the FDF, but only if all DEPEX dependencies are satisfied. DEPEXes are compiled

Re: [edk2-devel] [PATCH edk2-platforms v6 2/7] Platform/SbsaQemu: read amount of cpus during init

2024-03-19 Thread Ard Biesheuvel
On Tue, 19 Mar 2024 at 11:25, Marcin Juszkiewicz wrote: > > W dniu 15.03.2024 o 12:49, Marcin Juszkiewicz pisze: > > W dniu 14.03.2024 o 16:13, Ard Biesheuvel pisze: > > >> How is it guaranteed that other components will only see the correct > >> core count? DXE dispatch is ordered using a

Re: [edk2-devel] [PATCH edk2-platforms v6 2/7] Platform/SbsaQemu: read amount of cpus during init

2024-03-19 Thread Marcin Juszkiewicz
W dniu 15.03.2024 o 12:49, Marcin Juszkiewicz pisze: W dniu 14.03.2024 o 16:13, Ard Biesheuvel pisze: How is it guaranteed that other components will only see the correct core count? DXE dispatch is ordered using a dependency graph, so all users of this PCD should never execute before this

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-19 Thread Gerd Hoffmann
On Tue, Mar 19, 2024 at 05:10:39PM +0800, Chao Li wrote: > He Gerd, > > > Speaking of this series: maybe split it into two? The first part > > of this series with the Mde*Pkg + UefiPkg changes looks almost ready > > to merge to me, so maybe we can get that in while still sorting out > > the

Re: [edk2-devel] [PATCH v2 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2024-03-19 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/49620fa0bb9757bce13f41f604001114ea6c40de -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116888): https://edk2.groups.io/g/devel/message/116888 Mute This

Re: [edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG2 Protocol: add test infrastructure and GetCapability Test

2024-03-19 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/ff8a146ace642cadc83b58cd4382181ec2dac633 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116887): https://edk2.groups.io/g/devel/message/116887 Mute

Re: [edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2024-03-19 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/bebabc28d9471de17b9dbebf83d4dfb54624ac0c -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116886): https://edk2.groups.io/g/devel/message/116886 Mute This

Re: [edk2-devel] [PATCH v2 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2024-03-19 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/244ebf6954c43496ca173e9091de92b061e0957e -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116885): https://edk2.groups.io/g/devel/message/116885 Mute This

Re: [edk2-devel] [PATCH v2 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2024-03-19 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/7ec35ffac51d0682c1368041ca1e599189a58223 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116884): https://edk2.groups.io/g/devel/message/116884 Mute This

Re: [edk2-devel] [PATCH v2 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2024-03-19 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/ee928b21d8df70c5729a6ae470366d3c6a6fd84b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116883): https://edk2.groups.io/g/devel/message/116883 Mute This

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-19 Thread Chao Li
He Gerd, Thanks, Chao On 2024/3/19 16:03, Gerd Hoffmann wrote: Hi, I can't tell the implementation scheme of the current lib and existing lib implementation scheme which one is better, Could you give we some advice? I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as

[edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4647

2024-03-19 Thread Nayana Patel
Clear out the variable SmmCommunicateVerifyPassword which contains password before goto Exit. To avoid vulnerability. Signed-off-by: Nayana Patel --- .../UserAuthenticationDxeSmm/UserAuthenticationSmm.c| 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4645

2024-03-19 Thread Nayana Patel
Clear out the variable SmmCommunicateSetPassword which contains password before goto Exit. To avoid vulnerability. Signed-off-by: Nayana Patel --- .../UserAuthenticationDxeSmm/UserAuthenticationSmm.c| 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-19 Thread Gerd Hoffmann
Hi, > > > I can't tell the implementation scheme of the current lib and existing > > > lib implementation scheme which one is better, Could you give we some > > > advice? > > I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as > > it is not really loongarch-specific. > > >

[edk2-devel] [PATCH] CryptoPkg: BaseCryptLib: ASN1_get_object() function return value is not checked properly in CryptX509.c.

2024-03-19 Thread Sountharya N via groups.io
Added Inf variable, and the error case returned value was checked properly. --- CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c