[AMD Official Use Only - General]
Hi @Mike Maslenkin, would you like to review this patch again as I addressed
your comments in V5 patch set.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, March 26, 2024 8:14 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igo
Add support to create SRAT(System resource affinity table) for
sbsa platform at runtime.
Signed-off-by: Xiong Yining
Reviewed-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
---
.../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 27 ++
.../Include/Library/HardwareInfoLib.h | 10 ++
SbsaQemu can configure with numa-related arguments, but OS cannot
identify the numa architecture without SRAT tables. We add supporting
for generating SRAT tables at runtime to solve this issue.
the numa-related information and memory information can be obtained via
SMC calls which is provided on
Hello Aaron,
Could you describe the problem that is being solved by the ability to
use EfiAcpiMemoryNVS for ACPI tables?
On Thu, 28 Mar 2024 at 05:59, Aaron Li wrote:
>
> Hi Liming,
>
> Currently this patch does not have a related Bugzilla.
>
> According to UEFI spec, the ACPI Tables at boot ti
Hi Liming,
Currently this patch does not have a related Bugzilla.
According to UEFI spec, the ACPI Tables at boot time can be contained in memory
of type EfiACPIReclaimMemory or EfiAcpiMemoryNVS.
Current implementation in AcpiTableDxe only allocate memory with type
EfiACPIReclaimMemory by defau
Hi,
Please follow the correct upstream process to avoid Github CI errors.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contributor-workflow
You are missing your Sign-off and Cc maintainers in this patch,
And please add BZ
Aaron:
Is there a Bugzilla for this issue? What problem will be resolved with this
change?
Thanks
Liming
> -邮件原件-
> 发件人: Aaron Li
> 发送时间: 2024年3月26日 15:58
> 收件人: devel@edk2.groups.io
> 抄送: Zhiguang Liu ; Dandan Bi
> ; Liming Gao ; Liu Yun
> ; Jiewen Yao ; Ray Ni
> ; Michael D Kinney
>
Seemly, this change has no other impact. I agree this change.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chiu, Ian
> 发送时间: 2024年3月14日 21:40
> 收件人: devel@edk2.groups.io
> 抄送: Ian Chiu ; Hao A Wu ; Ray
> Ni ; More Shih
> 主题: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Increase 1
Madhan:
I have no comments for this patch set. Reviewed-by: Liming Gao
Have you create Edk2 PR to verify the changes?
Thanks
Liming
> -邮件原件-
> 发件人: Pethaiyan, Madhan
> 发送时间: 2024年3月14日 16:17
> 收件人: Kinney, Michael D ;
> devel@edk2.groups.io
> 抄送: Liming Gao ; Liu, Zhiguang
> ; Li,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Wenxing Hou
> 发送时间: 2024年3月27日 14:16
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [PATCH v3 1/2] MdePkg: Add UEFI 2.10 DeviceAuthentication
>
> According to UEFI 2.10 spec
> 32.8.2 UEFI Dev
Can you submit a Bugzilla for this problem?
Can you give one example to explain the incorrect usage?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Taylor Beebe
> 发送时间: 2024年3月23日 3:19
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
>
> 主题:
From: PhanindraX Babu Pabba
Adding missed out call to FreePool API to free the
allocated memory.
Signed-off-by: PhanindraX Babu Pabba
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++--
Platform/Intel/Mi
From: PhanindraX Babu Pabba
Adding missed out call to FreePool API to free the
allocated memory.
Signed-off-by: PhanindraX Babu Pabba
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++--
Platform/Intel/Mi
Thanks Phanindra!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Pabba, PhanindraX Babu
> Sent: Wednesday, March 27, 2024 2:27 PM
> To: devel@edk2.groups.io
> Cc: Pabba, PhanindraX Babu ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Liming Gao ;
> Dong, Eric
> Subject: [edk2-plat
From: PhanindraX Babu Pabba
Adding missed out call to FreePool API to free
the allocated memory.
Signed-off-by: PhanindraX Babu Pabba
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +-
Platform/Intel/MinPl
Greetings!
The edk2 base tools scripts seems to have some issues translating the "SPEC"
option under the "DEFINES" section of the INF file.
Currently if we follow the instruction listed out on the github page build
failure occurs.
[Defines]
SPEC Value = 1.0
Failure :
makefile(50) : fatal
Hi Mike and Ray,
I'm here to bug you again :). I have another patchset that
unfortunately Liming has not gotten to review in a month's
time frame with weekly pings. When I bugged you last time,
he reviewed the next day, so something must have worked out
there. Can you please help get this merged?
I think the patch ordering relative to 3/4 breaks bisect?
/
Leif
On Wed, Mar 27, 2024 at 14:03:05 +, Xiong Yining wrote:
> Provide functions to check for memory information:
>
> - amount of memory nodes
> - memory address
> - NUMA node id for memory
>
> Values are read from TF-A using p
On Wed, Mar 27, 2024 at 14:03:02 +, Xiong Yining wrote:
> From: Marcin Juszkiewicz
>
> This library provides functions to check for hardware information.
> For now it covers CPU ones:
>
> - amount of cpu cores
> - MPIDR value for cpu core
> - NUMA node id for cpu core
>
> Values are read fr
On Wed, Mar 27, 2024 at 13:59:34 +, Xiong Yining wrote:
> Add support to create SRAT(System resource affinity table) for
> sbsa platform at runtime.
>
> Signed-off-by: Xiong Yining
> Signed-off-by: Chen Baozi
No one can sign off patches on behalf of someone else. Please only
include your ow
We want to stop parsing DeviceTree to gather hardware information.
Instead we ask TF-A for those details using SMC calls. On real hardware
platform it could be asking on-board Embedded Controller.
Hardware information (CPU, Memory) is now in SbsaQemuHardwareInfoLib
together with new code for hand
From: Marcin Juszkiewicz
This library provides functions to check for hardware information.
For now it covers CPU ones:
- amount of cpu cores
- MPIDR value for cpu core
- NUMA node id for cpu core
Values are read from TF-A using platform specific SMC calls.
Signed-off-by: Marcin Juszkiewicz
-
From: Marcin Juszkiewicz
We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to
parse DeviceTree anymore.
Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
---
.../Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++
.../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
Provide functions to check for memory information:
- amount of memory nodes
- memory address
- NUMA node id for memory
Values are read from TF-A using platform specific SMC calls.
Signed-off-by: Xiong Yining
Signed-off-by: Chen Baozi
Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Ard Biesheuv
From: Marcin Juszkiewicz
There is no need for EDK2 to know that there is DeviceTree around.
All hardware information is read using functions from
SbsaQemuHardwareInfoLib library.
Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
---
Silicon/Qemu/SbsaQemu/SbsaQemu.dec|
When SaSbQemu platform is configured with multi memory nodes, like
numa architecture, os will ignore any memory node in the device tree
except the first one. The kernel reads UEFI memory map for memory
information when booting via UEFI.
However UEFI only allocates the first memory node memory
To support more memory nodes, we refer to the implement of
"OvmfPkg/Fdt/HighMemDxe" to add memory space for the high memory nodes
except the first one.
Signed-off-by: Xiong Yining
Signed-off-by: Chen Baozi
Tested-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
Add support to create SRAT(System resource affinity table) for
sbsa platform at runtime.
Signed-off-by: Xiong Yining
Signed-off-by: Chen Baozi
Reviewed-by: Marcin Juszkiewicz
Change-Id: I4a65084e6ade66d87ea935adfa4be15a7030d3eb
---
.../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 27 ++
...
SbsaQemu can configure with numa-related arguments, but OS cannot
identify the numa architecture without SRAT tables. We add supporting
for generating SRAT tables at runtime to solve this issue.
the numa-related information and memory information can be obtained via
SMC calls which is provided on
Hi all,
Any feedback regarding this? :P
Any thoughts?
Much appreciated!
Best Regards,
Sheng
On Tue, 19 Mar 2024 at 18:44, Benjamin Doron
wrote:
> Hi all,
> We're planning to refactor the shell into a library so that shell apps
> possibly used in the field for testing can be easily adapted for a
Hello Leif,
On 3/12/24 17:47, Leif Lindholm wrote:
On 2024-03-12 02:18, Pierre Gondois wrote:
This patch relies on [1].
Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
move the Chipset/* files to the MdePkg as the Armlib.h relies on
them.
These patches span over multiple pac
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Yang, Yuting2
> Sent: Wednesday, March 27, 2024 4:43 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Liming Gao
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [Patch V2] [edk2-staging] BaseTools: Update ReadMe in Python
> VfrCompil
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Yuting Yang
---
BaseTools/BinWrappers/PosixLike/PyVfrCompile | 22 +++---
BaseTools/Conf/build_rule.template| 2 --
BaseTools/Source/Python/VfrCompiler/README.md | 27 +
From: HoraceX Lien
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4737
update smbiosview type 4 related fileds.
Signed-off-by: HoraceX Lien
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
---
.../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4
1 file changed, 4 insertions(
Hello Sami,
On Tue, 26 Mar 2024 at 19:07, Sami Mujawar wrote:
>
> The Kvmtool guest firmware uses the dynamic HII
> PCD PcdForceNoAcpi to determine if ACPI tables
> or the DT must be used for booting an OS.
>
> This PcdForceNoAcpi is a BOOLEAN value that can
> be configured using the variable "Fo
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Yuting Yang
---
BaseTools/BinWrappers/PosixLike/PyVfrCompile | 22 +++
BaseTools/Source/Python/VfrCompiler/README.md | 27 ---
2 files changed, 28 insertions(+), 21 deletions(-)
mode chan
[AMD Official Use Only - General]
Hi Igor,
If time is allowed, please also review this patch set.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 27, 2024 3:42 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
> Subject: RE: [PATCH V2 0/6
I have tested this patch series on my system and got a lot of performance
improvements too.
Great work, Abner!
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> S
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang ; Igor Kulchytskyy
> Subject: [edk2-devel] [PATCH V2 6/6] Redfis
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang
> Subject: [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs
>
> External email: Use caution
Thanks for addressing this issue.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 4/6] RedfishPkg/RedfishPlatformCon
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add
> RefishDebugLib suppo
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG
> macro
>
Per offline discussion with Abner, this will be addressed by separated patch
since there is no function impact to performance improvements.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle Wang
> via groups.io
> Sent: Wedne
44 matches
Mail list logo
