Hi Pierre and Sami,
I'll submit separate patches for each table, which will be ready
and easy to merge after the current hard feature freeze over.
Thanks
AbduL
On 03-05-2024 13:11, Sami Mujawar wrote:
Caution: This message originated from an External Source. Use proper caution
when
Thanks for the comments.
How about change the commits order to be like:
1) S3 MTRRs operation:
2) AP page table unavailiable issue fix:
3) S3 ApHltLoopCode Operation:
> UefiCpuPkg:Abstract some DxeMpLib code to function
> UefiCpuPkg:Move some code in DxeMpLib to common place
>
Yes, let's do the cleanup for PcdCpuS3DataAddress in another new patch set.
Thanks,
Dun
-Original Message-
From: Wu, Jiaxin
Sent: Monday, May 13, 2024 11:04 AM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: RE: [PATCH 04/18] UefiCpuPkg: Save
Thanks for the comments. Agree that the order adjustment can make the patch set
clearer. Will modify the commits in next version patch set.
Thanks,
Dun
-Original Message-
From: Wu, Jiaxin
Sent: Monday, May 13, 2024 10:49 AM
To: devel@edk2.groups.io; Tan, Dun ; Ni, Ray
Subject: RE:
I think the MtrrTable is not needed in the AcpiCpuDataEx (which is from the
PcdCpuS3DataAddress).
That mean: we can cleanup unused definition in the PcdCpuS3DataAddress. Maybe
in the future patches set, not this one.
Thanks,
Jiaxin
> -Original Message-
> From: Tan, Dun
> Sent:
My comments as below:
1. I stronger recommend re-ordering the patches as below so as to combine all
related sub-patches together, then we can more easy understand what we are
target to resolving: 1) S3 MTRRs operation 2) AP page table unavailiable issue
fix. 3) S3 ApHltLoopCode Operation 3)
My comment to patch #6 suggested to keep the assignment to
SmmS3ResumeState->MpService2Ppi.
How about you keep the "SmmS3ResumeState->MpService2Ppi = 0" there and remove
that assignment and the field together in this patch?
Thanks,
Ray
From: Tan, Dun
Sent:
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 17/18] UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c
Remove
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 16/18] UefiCpuPkg:Remove code to wakeup AP and relocate ap
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting and
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 14/18] UefiCpuPkg: Remove code to set register table
Remove
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 13/18] UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE
Set
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting
Remove code
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 11/18] UefiCpuPkg: Disable PG in IA32 ApLoopCode
Disable paging
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
In
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h
b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 179f8e585b..11e0d2661f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -357,7 +357,8 @@ typedef
IN UINTNStackStart
);
-extern EFI_GUID
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 08/18] UefiCpuPkg:Abstract some DxeMpLib code to function
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin
Subject: [PATCH 05/18] UefiCpuPkg: LoadMtrrData for all cpu in S3Resume
In this commit,
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin
Subject: [PATCH 04/18] UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe
Save MTRR by lockbox
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin
Subject: [PATCH 03/18] UefiCpuPkg: Add locbox lib instance in DSC
Add locbox lib instance in
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Gerd Hoffmann ; Ni, Ray
; Wu, Jiaxin
Subject: [PATCH 02/18] OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
Save MTRR
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Liming Gao ; Wu,
Jiaxin
Subject: [PATCH 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
Add gEdkiiS3MtrrSettingGuid a new GUID for s3
MTRR
diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
index 3e85eab28f..a8e9c92a93 100644
--- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
+++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
@@ -1139,7 +1139,6 @@
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, May 13, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
24 matches
Mail list logo
