Re: [edk2-devel] [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib

2024-05-13 Thread Ni, Ray
Gerd, I agree that the logic might be duplicated in multi places. But even CPU supports 1G paging, caller can decide whether to use 1G paging or 2M paging, or 4K paging. Using a single API to encapsulate the entire logic may not seem flexible. Maybe, a lib API to detect 1G paging capability can

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-13 Thread Nhi Pham via groups.io
Thanks Nickle. I will help review and verify your patch. On 5/14/2024 8:56 AM, Nickle Wang wrote: Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle -Original Message- From: Nhi Pham

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-13 Thread Nickle Wang via groups.io
Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle > -Original Message- > From: Nhi Pham > Sent: Monday, May 13, 2024 5:02 PM > To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle

[edk2-devel] Cancelled Event: Tools, CI, Code base construction meeting series - Monday, May 13, 2024 #cal-cancelled

2024-05-13 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z

Re: [edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc

2024-05-13 Thread Nate DeSimone
Pushed as 59c6866 > -Original Message- > From: Vivian Nowka-Keane > Sent: Thursday, May 9, 2024 7:09 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc > > When building MinPlatformPkg,

Re: [edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc

2024-05-13 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Vivian Nowka-Keane > Sent: Thursday, May 9, 2024 7:09 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc > > When building

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-13 Thread Nate DeSimone
Thanks for the feedback Chasel and Sai! I have incorporated all your suggestions. > -Original Message- > From: Chaganty, Rangasai V > Sent: Thursday, May 9, 2024 6:15 PM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io > Cc: Chiu, Chasel ; Liming Gao > ; Dong, Eric ; Chuang, > Rosen

Re: [edk2-devel] [edk2-platforms] [PATCH v1 0/2] Intel/MinPlatform: Add MpInfo2HobPei

2024-05-13 Thread Nate DeSimone
The series has been pushed as c31962b~..0ba43d4 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Wednesday, May 8, 2024 5:09 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chuang, Rosen > ; Kasbekar, Saloni ; > Chiu, Chasel ; Liming Gao >

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-13 Thread Ard Biesheuvel
(cc some ARM folks) On Mon, 13 May 2024 at 11:23, Gerd Hoffmann wrote: > > On Sat, May 11, 2024 at 10:40:23AM GMT, Ard Biesheuvel wrote: > > As I pointed out before, on the ARM side there are a few intersecting > > issues with these changes. (On x86, this is mostly avoided due to the > > fact

[edk2-devel] HII Keyword utility

2024-05-13 Thread Jeff Brasen via groups.io
I have a UEFI shell application that can set/get UEFI x-UEFI HII Keyword values. edk2-nvidia/Silicon/NVIDIA/Application/HiiKeywordUtil at main · NVIDIA/edk2-nvidia (github.com) ( https://github.com/NVIDIA/edk2-nvidia/tree/main/Silicon/NVIDIA/Application/HiiKeywordUtil ) I have used this to

Re: [edk2-devel] [PATCH v2 07/13] SecurityPkg: RngDxe: Remove incorrect limitation on GetRng

2024-05-13 Thread PierreGondois
Hello, The patch looks good to me: Reviewed-by: Pierre Gondois Regards, Pierre On 5/11/24 02:24, Yao, Jiewen wrote: Thanks to confirm that. I am OK on what you have said. Since the ARM part is added by Pierre Gondois pierre.gond...@arm.com , I will let him

Re: 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

2024-05-13 Thread Praveen Sankar N via groups.io
Thanks you so much Liming. Regards, Praveen Sankar -Original Message- From: gaoliming Sent: Friday, May 10, 2024 6:16 AM To: devel@edk2.groups.io; Praveen Sankar N Cc: Srinivasan Mani ; Sundaresan S ; michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov ; Rabisha R

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-05-13 Thread Pethaiyan, Madhan
Hi all , I had created EDK2 PR, few weeks ago, thought it will be reviewed and approved . Please help to check and approve. https://github.com/tianocore/edk2/pull/5584 https://github.com/tianocore/edk2/pull/5586 https://github.com/tianocore/edk2/pull/5587 Thanks, P. Madhan -Original

Re: [edk2-devel] [PATCH v2 08/13] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-13 Thread Ard Biesheuvel
Could we please include gEfiRngAlgorithmArmRndr in the list of accepted RNG protocols? The ARM architecture reference mandates the use of a DRBG that complies with NIST SP800-90A Rev 1 to produce the random output emitted by RNDR/RNDRRS, and so it matches the requirement imposed by this change.

回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-05-13 Thread gaoliming via groups.io
These PRs are all failure. Please update them. Thanks Liming > -邮件原件- > 发件人: Pethaiyan, Madhan > 发送时间: 2024年5月13日 20:10 > 收件人: gaoliming ; Kinney, Michael D > ; devel@edk2.groups.io > 抄送: Liu, Zhiguang ; Li, Yi1 ; 'GuoX > Xu' > 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,

Re: [edk2-devel] [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib

2024-05-13 Thread Gerd Hoffmann
Hi, > + if (sizeof (UINTN) == sizeof (UINT64)) { > +// > +// Check Page5Level Support or not. > +// > +Cr4.UintN = AsmReadCr4 (); > +Page5LevelSupport = (Cr4.Bits.LA57 ? TRUE : FALSE); > + > +// > +// Check Page1G Support or not. > +// > +

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-13 Thread Gerd Hoffmann
On Sat, May 11, 2024 at 10:40:23AM GMT, Ard Biesheuvel wrote: > As I pointed out before, on the ARM side there are a few intersecting > issues with these changes. (On x86, this is mostly avoided due to the > fact that RDRAND is universally supported) Well, it's not that easy on x86 either.

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-13 Thread Nhi Pham via groups.io
On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah, I forget this patch set and seems we don't have any follow up conversation after below feedbacks from community. https://edk2.groups.io/g/devel/message/103116

Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

2024-05-13 Thread Gerd Hoffmann
On Thu, May 09, 2024 at 01:27:07PM GMT, Du Lin wrote: > Encrypted and Special Purpose resource attributes are introduced in > PI 1.8 Specification. This patch is to update VMM Hob list integrity > check to recognise these resource attributes. > > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc:

Re: [edk2-devel] [PATCH v1 0/4] Add EINJ table parser.

2024-05-13 Thread PierreGondois
Hello, For the whole patch-set: Reviewed-by: Pierre Gondois Thanks, Pierre On 5/10/24 14:22, levi.yun wrote: Add Error Injection Table (EINJ) parser for AcpiView and add some missing Error Injection Action definitions in each Acpi* headers. The changes can be seen at:

Re: [edk2-devel] [PATCH 00/19] Remove some S3 related code in CpuS3.c of smm cpu driver

2024-05-13 Thread Ni, Ray
Good suggestions, Jiaxin! Thanks, Ray From: Tan, Dun Sent: Monday, May 13, 2024 11:37 To: Wu, Jiaxin ; devel@edk2.groups.io ; Ni, Ray Subject: RE: [edk2-devel] [PATCH 00/19] Remove some S3 related code in CpuS3.c of smm cpu driver Thanks for the comments.