Zhihao:
If Fsp-T/M is not installed, are they still used in PEI boot? If they are
used, I agree they should be measured.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Li, Zhihao
> 发送时间: 2024年5月29日 11:36
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Chiu, Chasel ; Desimone,
If ASSERT trigs the exception, could call stack show each caller?
Thanks
Liming
> -邮件原件-
> 发件人: Gerd Hoffmann
> 发送时间: 2024年5月29日 21:09
> 收件人: devel@edk2.groups.io; dougfl...@microsoft.com
> 抄送: Liming Gao ; Ard Biesheuvel
>
> 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg:
Lin:
I see there is some discussion. Have you made the agreement with this
change?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Du Lin
发送时间: 2024年5月29日 21:05
收件人: devel@edk2.groups.io
抄送: Liming Gao ; Ni, Ray ;
Lin, Du
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Tan, Dun
> 发送时间: 2024年5月28日 17:44
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Wang, Jian J
> 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi
> field in SMM_S3_RESUME_STATE
>
> Liming,
>
> Sure, I think we can
Hi Ard,
Gerd has reviewed and tested this patch set, so can you give me the R-B
or should I create the PR on github?
Thanks,
Chao
On 2024/5/29 17:09, Gerd Hoffmann wrote:
On Fri, May 24, 2024 at 04:38:26PM GMT, Chao Li wrote:
Hi Ard and other maintainers,
Could you help to review this
I've updated the wiki process to clarify that maintainers need to ensure
PR reviewers are added and that a contributor cannot do so unless they
are a maintainer in this update:
Hey
It is great to see what we have moved to PR process finally.
Just tried today, and I confess I made a mistake - I forget to add PUSH label,
but just click "Rebase and Merge" button directly when I see it. And the patch
is merged successfully.
Using github native approval and merge process
Hi Pete,
https://github.com/tianocore/edk2/pull/5697 was merged and should
resolve your issue.
Please let us know if it does not.
Mike
> -Original Message-
> From: Pete Batard
> Sent: Wednesday, May 29, 2024 3:01 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Yao, Jiewen ;
Thanks Michael Kubacki,
It is merged.
> -Original Message-
> From: Michael Kubacki
> Sent: Thursday, May 30, 2024 3:57 AM
> To: Kinney, Michael D ; Pete Batard
> ; devel@edk2.groups.io; Yao, Jiewen
> Subject: Re: [edk2-devel] libspdm Breaking Builds
>
> Since we already reached
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Wednesday, May 29, 2024
5:30pm to 6:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Lin Du
Just FYI: The CI failed after I rebase.
If possible, I recommend to submit a new PR to get it resolved.
Then I can approve again.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Monday, May 27, 2024 3:13 PM
> To: gaoliming ;
Thanks Michael,
After working around some weird rate-limiting from GitHub, I was finally
able to apply your suggested workaround, and can validate that it indeed
works:
https://github.com/pbatard/UEFI-Shell/actions/runs/9293562444/job/25576978957
Still, I would assert that many people
Hi Linus,
Some comments below inline.
Thanks,
Chasel
> -Original Message-
> From: Liu, Linus
> Sent: Thursday, May 23, 2024 9:14 PM
> To: devel@edk2.groups.io
> Cc: Lin, Benny ; Guo, Gua ; Chiu,
> Chasel ; Lu, James ; Dhaval
> Sharma
> Subject: [PATCH v3 5/6] UefiPayloadPkg: Add
We could, but that would require manually syncing CODEOWNERS
with Maintainer.txt until that part of the process is automated.
We also need a way to verify that CODEOWNERS and Maintainers.txt
produce the exact same assignments.
This was on the list of future enhancements when resources are
Since we already reached agreement in libspdm to move its cmocka
submodule to the gitlab mirror in
https://github.com/DMTF/libspdm/issues/2707 and that was merged in
https://github.com/tianocore/edk2/pull/5697.
I'd like to suggest we go with option 2 as well. This is impacting our
ability to
Hi Pete,
I just tested this config command and it works when cryptomilk is down.
git config --global
url."https://github.com/tianocore/edk2-cmocka.git".insteadOf
"https://git.cryptomilk.org/projects/cmocka.git;
I updated edk2-cmocka mirror last week.
I tested this with
git clone
Mike,
I agree that automatically adding reviewers would be helpful.
Do you think we could add a CODEOWNERS file now to assist with this?
Benefits being:
1. CODEOWNERS is low overhead in that GitHub already supports it.
2. We do not need to require CODEOWNER enforcement yet. We can simply
Hi Pete,
There is another option for developers and CI agents.
Git supports a URL insteadof option to redirect git requests.
https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf
We can use this to redirect a request from cryptomilk cmocka to the
TianoCore
GitHub has notification settings. Maintainers should configure
GitHub so they are notified of all PR submissions to edk2 repo.
The Wiki for the Maintainer Process provides a link to this page with the
details:
On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
Hi Gerd,
We can clarify the Wiki. A Maintainer has to be involved in every
code review. The first action a Maintainer does is verify that the
code change should be considered at all or rejected. Then add
maintainers for the ones
Hello all,
On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
Please let us know if the preference for libspdm submodule. (Below options)
1) Keep current libspdm official 3.3.0 release, and update to next release at
the beginning of July.
2) Update libspdm immediately with the new cmocka
Hi Gerd,
We can clarify the Wiki. A Maintainer has to be involved in every
code review. The first action a Maintainer does is verify that the
code change should be considered at all or rejected. Then add
maintainers for the ones that look like good submissions.
I agree that this may add a
On Wed, May 29, 2024 at 03:00:13PM GMT, Michael D Kinney wrote:
> Hi Gerd,
>
> You are in the EDK II Reviewers team.
>
> The current settings only allow members of the EDK II Maintainers
> team to assign reviewers.
That contradicts the wiki instructions which say I should assign
reviewers
Merged as f69888ada859..35bca3ca71c0
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119355): https://edk2.groups.io/g/devel/message/119355
Mute This Topic: https://groups.io/mt/106365450/21656
Group
Other than my comments for patch 14 and 15 (the changes for which I will fix
locally before merging), this patch series looks good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Hi Gerd,
You are in the EDK II Reviewers team.
The current settings only allow members of the EDK II Maintainers
team to assign reviewers.
The maintainers of the OvmfPkg are required to add all reviewers to the PR.
I have added niruiyu,ajfish to keep this PR moving while we continue
the
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for the clarification, Mike.
Thanks
Abner
From: Kinney, Michael D
Sent: Wednesday, May 29, 2024 10:44:41 PM
To: Chang, Abner ; devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: RE: GitHub PR
Hi Abner,
Yes. The plan is to apply to all repos.
We want to use it on edk2 for a while to make sure we get the
settings and process correct, then we will expand.
Mike
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, May 29, 2024 3:41 AM
> To: devel@edk2.groups.io;
On 5/29/2024 8:18 PM, Leif Lindholm via groups.io wrote:
> +Nhi,
>
> Could you check/verify these work fine on your systems?
Yes, I can. Thanks Leif for reaching out to me.
Hi Tommy Huang - Could you please create a Pull Request (PR) or share a
branch so I can easily apply and test the AArch64
W dniu 29.05.2024 o 15:30, Leif Lindholm via groups.io pisze:
On 2024-05-29 14:29, Marcin Juszkiewicz wrote:
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
Thanks, pushed as 5fdbccd742d4206a2370a08c5420a1aa8c6ad85b
On 2024-05-29 14:29, Marcin Juszkiewicz wrote:
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
---
Platform/Qemu/Sbsa/Readme.md | 49 ---
Platform/Qemu/Sbsa/bl1.bin | Bin 23349 ->
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/Sbsa/Readme.md | 49 ---
Platform/Qemu/Sbsa/bl1.bin | Bin 23349 -> 2 bytes
Platform/Qemu/Sbsa/fip.bin | Bin 82722 -> 82722 bytes
3 files
Can you update the hashes in Readme.md as well?
/
Leif
On 2024-05-29 14:18, Marcin Juszkiewicz wrote:
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/Sbsa/bl1.bin | Bin 23349 -> 2 bytes
Platform/Qemu/Sbsa/fip.bin | Bin
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/Sbsa/bl1.bin | Bin 23349 -> 2 bytes
Platform/Qemu/Sbsa/fip.bin | Bin 82722 -> 82722 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644
+Nhi,
Could you check/verify these work fine on your systems?
Regards,
Leif
On 2024-05-28 03:08, Tommy Huang wrote:
1.Update the X64/AArch64 UEFI GOP driver into v1.13.04.
2.Update the .inf version.
3.Fix display flick on ast2600.
4.Remove 800x600@56 from mode list.
5.Add check EDID header
On Thu, May 23, 2024 at 10:44:52PM GMT, Doug Flick via groups.io wrote:
>
> REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-edk-ii-ipv6-network-stack.html
>
> This patch series patches the following CVEs:
> - CVE-2023-45236: Predictable TCP Initial Sequence Numbers
>
A pull request has been created for this patch:
https://github.com/tianocore/edk2/pull/5691.
BRs,
Lin, Du
From: Ni, Ray
Sent: Friday, May 10, 2024 10:53 AM
To: Lin, Du ; devel@edk2.groups.io
Cc: Liming Gao
Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to support
SP
Hi Sahil,
I will drop the loop before merging the changes.
Other than that this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Sahil Kaushal
Date: Wednesday 29 May 2024 at 12:51
To: Sami Mujawar , "devel@edk2.groups.io"
Cc: Ard Biesheuvel , Leif Lindholm
Hi Sami,
Thank you for reviewing the patch.
You are right. The do-while loop is redundant and hence can be removed.
Thanks,
Sahil
From: Sami Mujawar
Date: Wednesday, 29 May 2024 at 5:06 PM
To: Sahil Kaushal , devel@edk2.groups.io
Cc: Ard Biesheuvel , Leif Lindholm
, nd
Subject: Re:
Hi Sahil,
There is a typo in one of the macro names, see my comment inline marked [SAMI].
I will fix that up before merging.
Other than that, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/05/2024, 09:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>>
Hi Sahil,
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 29/05/2024, 09:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>> wrote:
From: sahil mailto:sa...@arm.com>>
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI (QSPI) controller.
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Mike,
Wondering if we also plan to apply GitHub PR process on edk2-platforms repo? Or
other repos under tianocore? I found there is another email thread "Enable
GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no
On Fri, May 24, 2024 at 04:38:26PM GMT, Chao Li wrote:
> Hi Ard and other maintainers,
>
> Could you help to review this patch set?
Looks good to me and survived a quick smoke test.
Tested-by: Gerd Hoffmann
Acked-by: Gerd Hoffmann
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
From: sahil
This driver enables Fault Tolerant Write protocol, which provides
fault tolerant write capability for block devices.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 +
2 files changed, 6 insertions(+)
diff --git
From: sahil
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 19 ++-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 ++
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git
From: sahil
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI (QSPI) controller. This QSPI controller manages
the flash chip device via QSPI bus.
This patch adds CadenceQspiNorFlashDeviceLib which is used to
manage and access the above configuration.
Signed-off-by:
From: sahil
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable
From: sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable storage.
Signed-off-by: sahil
---
From: sahil
This patch adds an optional functionality in NorFlashDxe to fetch and
print NOR Flash information from NorFlashInfoLib using its JEDEC ID.
NOR Flash libraries will implement a function "NorFlashReadID" which
will fetch and return JEDEC ID. This JEDEC ID can be then printed
along
From: sahil
This patch adds error_handler1 and error_handler2 labels in
NorFlashCreateInstance() function to handle the cleanup.
error_handler1: Frees just the Instance structure as the
ShadowBuffer is not allocated yet.
error_handler2: Frees both Instance and Instance->ShadowBuffer.
From: sahil
This variable holds the QSPI controller's base address.
It is defined in ARM.dec as well with the default value of 0x0.
In case a platform is not using it, they can just ignore this
variable and the default value of 0x0 will be propogated and
the variable will not be used.
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch adds the following major changes:
1. Adds changes in
From: sahil
This patch implements functions to interact with P30 NOR Flash.
The code is taken from Platform/ARM/Drivers/NorFlashDxe/NorFlash.c
file.
Signed-off-by: sahil
---
Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf | 35 +
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch splits NorFlash.h and moves out the function
From: sahil
This patch makes local functions not being used outside
NorFlash.c STATIC.
Also, NorFlashWriteBuffer() is specific to a particular
flash implementation and need not be implemented by
other NOR flash device IPs.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h |
From: sahil
This patch removes NorFlashReadCfiData() and NorFlashWrite()
prototypes from NorFlash.h as these are not implemented or
used anywhere in NorFlashDxe driver.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h | 17 -
1 file changed, 17 deletions(-)
From: sahil
Refactoring done in this patch has two major parts:
1. Moving out NorFlashUnlockAndEraseSingleBlock and
NorFlashWriteFullBlock functions from NorFlashDxe.c and
NorFlashStandaloneMm.c to NorFlash.c files.
2. At the same time, we are adding NorFlashLock and NorFlashUnlock
functions
From: sahil
This patch splits NorFlash.h and adds NorFlashCommon.h which
will have all the flash independent functions and macros.
Whereas all the flash specific functions will be in NorFlash.h
header file.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf |
From: sahil
Moving this function from NorFlash.c to NorFlashDxe.c as it is not
dependent on any particular flash implementation.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h| 14 +++
Platform/ARM/Drivers/NorFlashDxe/NorFlash.c| 44
From: sahil
Moving these functions from NorFlash.c to NorFlashBlockIoDxe.c as
they are not dependent on any particular flash implementation.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.c | 129
From: sahil
This patch series adds the following changes:
1. Splits the NorFlashDxe driver to introduce a NorFlashDeviceLib that
implements the specifics for the respective flash. This will allow us
to plug different libraries implementing functionality of various NOR
Flash. The flash specific
> The GitHub PR code review process is now active. Please
> use the new PR based code review process for all new
> submissions starting today.
>
> * The Wiki has been updated with the process changes.
>
>
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
65 matches
Mail list logo
