Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

On Thu, 2024-05-30 at 11:03 +0200, Gerd Hoffmann wrote: >   Hi, > > > > -    SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed, > > > 0x06); > > > +    SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed, > > > MTRR_CACHE_WRITE_BACK); > > > ZeroMem (&MtrrSettings.Variables, sizeof > >

Re: 回复: [edk2-devel] Is DEBUG output function safe for MP case?

Hi, Jeff: If AP code use base-typed debuglib, then it's mp safe? Thanks At 2024-05-31 14:33:40, "Jeff Fan via groups.io" wrote: AP cannot run any UEFI Service. Please make sure AP code use base-typed DebugLib instance (Such as BaseDebugLibSerialport.inf from MdePkg) fan

Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

Hi, > > I have a draft PR open with this fixed: > > https://github.com/tianocore/edk2/pull/5696 > > > > Can you check this works for bhyve? > > Works. Thanks! Thanks for testing, flipped PR to 'Ready'. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH v4 6/6] UefiPayloadPkg: Update UefiPayload driver for FDT support.

BuildFitLoadablesFvHob: - Fdt variable is not initialized. - It ONLY gets initialized if GuidHob is found. What if it is not found? - FdtCheckHeader still evaluating it? On Mon, Jun 3, 2024 at 7:49 AM Linus Liu wrote: > Add FDT detection and comsume FDT when needed. > Move some x86 sp

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

As a follow up, I created the following PR to specify the exact version of queries to use for a given CodeQL CLI release. Now that both are explicitly specified (the CLI and the query version), there should not be any mismatch in the future where we're using an older CodeQL CLI against the late

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

Hello, Just a ping in case this was left aside and as the patch-set (+ Leif's initial patch) are a prerequisite to enable arm64 native instruction support for the openssllib, which would also allow to use openssl's DRBG, Regards, Pierre On 3/14/24 15:51, Pierre Gondois wrote: v2: - Move files t

Re: [edk2-devel] GitHub PR Code Review process now active

On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io wrote: > > Hello, > > The GitHub PR code review process is now active. Please > use the new PR based code review process for all new > submissions starting today. > > * The Wiki has been updated with the process changes. > > > http

Re: [edk2-devel] GitHub PR Code Review process now active

CI jobs are dispatched to both GitHub Actions and Azure Pipelines. For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running. This must imply that edk2 repo allows this. Do you happen to know where this is configurable or a link to GitHub docs for configuration? Mike > -Ori

Re: [edk2-devel] ArmCallSmc() and SMCCC specification

Hi Marcin. A few high-level thoughs below. On 2024-05-31 08:14, Marcin Juszkiewicz wrote: EDK2/ArmPkg/Library/ArmSmcLib has code to do SMC calls. There are ArmCallSmc[0-3]() functions for up to 3 arguments/results and ArmCallSmc() function which can use 7 arguments and get 4 results back. T

Re: [edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 3, 2024 #cal-reminder

confirming this meeting will be held today. Topics and agenda posted: Tools and CI Meeting - Date 6/3 · tianocore/edk2 · Discussion #5723 (github.com) Add additional agenda topics to the github discussion. Thanks Sean On 6/2/2024 4:30

Re: [edk2-devel] GitHub PR Code Review process now active

Hmm, I don't see a setting for it anymore, maybe that's not a thing anymore? I seemingly recall that draft PRs didn't get CI runs, but if that's not a thing anymore, then that's fine. That said, draft PRs cannot be reviewed, so we should not be telling people to make draft PRs. On Mon, Jun 3, 2

Re: [edk2-devel] GitHub PR Code Review process now active

The reason to allow a draft PR is to allow contributors to run all the CI tests to see if they pass and resolve issues before starting a review. The CI tests include combinations of OS/compiler that not all contributors have available. Mike > -Original Message- > From: Neal Gompa > Sent

[edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB

Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module. Signed-of-by: Sebastian Witt --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c

[edk2-devel] [PATCH] CryptoPkg: Fix BaseCryptLib CrtWrapper strcpy

strcpy fails when strSource is closer than 4096 bytes after strDest. This is caused by an overlap check in AsciiStrCpyS: // // 5. Copying shall not take place between objects that overlap. // SAFE_STRING_CONSTRAINT_CHECK (InternalSafeStringNoAsciiStrOverlap (Destination, DestMax, (CHAR8

[edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path

Worked on the following protocols’ test cases as we have seen PCIe card UEFI driver related failures with these test cases: EFI_HII_CONFIG_ACCESS_PROTOCOL EFI_ADAPTER_INFORMATION_PROTOCOL EFI_SIMPLE_NETWORK_PROTOCOL EFI_PXE_BASE_CODE_PROTOCOL Output of a failed PCIe test Auto Conformance Test for

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 3, 2024 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, June 3, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f98

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, June 3, 2024 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* Monday, June 3, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-4

回复: Re: [edk2-devel] Is DEBUG output function safe for MP case?

As Andrew mentioned, DEBUG() is NOT safe for MP. Generally, kernel modules are not suggested to use DEBUG() in AP code becasue they are not the decision maker on the final DebuLib instance. If you could make sure the DebugLib instance platform selected only based on I/O or MMIO operations, you