Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] SbsaQemu: support multiple PCI Express buses

2024-06-04 Thread Marcin Juszkiewicz
W dniu 28.05.2024 o 16:31, Ard Biesheuvel pisze: I would expect each host bridge to have its own separate resource windows for config space, buses and MMIO regions. So each host bridge gets a different segment number, and each segment is associated with a different ECAM region. That also means t

Re: [edk2-devel] [PATCH] CryptoPkg: Fix BaseCryptLib CrtWrapper strcpy

2024-06-04 Thread Li, Yi
Thanks for your patch, this is a known issue: https://bugzilla.tianocore.org/show_bug.cgi?id=2817 Could you also update other wrappers in CrtWrapper.h and add BZ link to commit message? Edk2 has switched to github pr code review process, you can raise PR in https://github.com/tianocore/edk2/pu

Re: [edk2-devel] [PATCH] CryptoPkg: Fix BaseCryptLib CrtWrapper strcpy

2024-06-04 Thread Witt, Sebastian via groups.io
Ok thanks, I'll look at the other wrappers and do a PR. Regards, Sebastian On Tue, 2024-06-04 at 07:28 +, Li, Yi1 wrote: > Thanks for your patch, this is a known issue: > https://bugzilla.tianocore.org/show_bug.cgi?id=2817 > > Could you also update other wrappers in CrtWrapper.h and add BZ li

Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] SbsaQemu: support multiple PCI Express buses

2024-06-04 Thread Gerd Hoffmann
On Tue, Jun 04, 2024 at 09:23:30AM GMT, Marcin Juszkiewicz wrote: > W dniu 28.05.2024 o 16:31, Ard Biesheuvel pisze: > > I would expect each host bridge to have its own separate resource > > windows for config space, buses and MMIO regions. That isn't how qemu pxb-pcie host bridge works on x86 tho

Re: [edk2-devel] ArmCallSmc() and SMCCC specification

2024-06-04 Thread Marcin Juszkiewicz
W dniu 3.06.2024 o 18:47, Leif Lindholm via groups.io pisze: In 2020 we got version C of spec (and then D, E, F) which allows to use more registers:  > Allow R4—R7 (SMC32/HVC32) to be used as result registers.  > Allow X8—X17 to be used as parameter registers in SMC64/HVC64.  > Allow X4—X17 to

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-04 Thread Gerd Hoffmann
On Mon, Jun 03, 2024 at 02:46:30PM GMT, Neal Gompa wrote: > That said, draft PRs cannot be reviewed, so we should not be telling > people to make draft PRs. It makes sense to open draft PRs, work in the PR until CI is clean, only then flip the PR to 'ready' and bother maintainers to review. take

Re: [edk2-devel] ArmCallSmc() and SMCCC specification

2024-06-04 Thread Ard Biesheuvel
On Tue, 4 Jun 2024 at 14:37, Marcin Juszkiewicz wrote: > > W dniu 3.06.2024 o 18:47, Leif Lindholm via groups.io pisze: > > >> In 2020 we got version C of spec (and then D, E, F) which allows to > >> use more registers: > >> > >> > Allow R4—R7 (SMC32/HVC32) to be used as result registers. > >> >

Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775)

2024-06-04 Thread Hsueh, Hong-Chih (Neo) via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] Hi Liming, Sorry for the late response. I already created a pull request for it. https://github.com/tianocore/edk2/pull/5737 Regards, Neo From: gaoliming Sent: Wednesday, May 15, 2024 8:08 PM To: devel@edk

[edk2-devel] Steps in using RamDiskDxe?

2024-06-04 Thread Lonnie Cumberland via groups.io
Hello All, I am new to working with EDK2 and have just been able to compile it up on my Ubuntu 22.04 (x64) system. Some of my initial interest is in that I am wanting to learn all about using EDK2 as well as am seeming a UEFI Ramdisk in which I was able to build up the edk2 RamDiskDxe.efi an

Re: [edk2-devel] [PATCH v4 6/6] UefiPayloadPkg: Update UefiPayload driver for FDT support.

2024-06-04 Thread Dhaval Sharma
I also believe this code needs to go through crustify etc to ensure it follows all edk2 standards? On Mon, Jun 3, 2024 at 4:57 PM Dhaval Sharma wrote: > BuildFitLoadablesFvHob: > >- Fdt variable is not initialized. >- It ONLY gets initialized if GuidHob is found. What if it is not >f

Re: [edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path

2024-06-04 Thread Prachotan Bathi
Here's the PR for your convenience: https://github.com/tianocore/edk2-test/pull/96 From: devel@edk2.groups.io on behalf of Prachotan Bathi via groups.io Sent: Monday, June 3, 2024 1:27 PM To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Barton Gao ; Carolyn Gj

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, June 5, 2024 #cal-reminder

2024-06-04 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Wednesday, June 5, 2024 5:30pm to 6:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4e

[edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

2024-06-04 Thread Nhi Pham via groups.io
This allows to initialize secure boot with the default factory keys embedded in firmware flash image. For example, to incorporate PK, KEK, and DB default keys, specify the corresponding key files in the Jade.dsc as follows: DEFINE DEFAULT_KEYS= TRUE DEFINE PK_DEFAULT_FILE = path/to/PK

[edk2-devel] [PATCH ovmf v4 0/5] Enable AMD SEV-ES DebugVirtualization

2024-06-04 Thread Alexey Kardashevskiy via groups.io
This is to prevent #DB interception on SEV-ES VM with enabled DebugVirtualization feature. The previous conversation is here: https://edk2.groups.io/g/devel/topic/patch_ovmf_v3_0_5_enable/105863808 This is based on sha1 7772e339bdbb Chao Li "ArmVirtPkg: Enable the non-hardcode version FdtNorFlas

[edk2-devel] [PATCH ovmf v4 1/5] MdePkg/Register/Amd: Define all bits from MSR_SEV_STATUS_REGISTER

2024-06-04 Thread Alexey Kardashevskiy via groups.io
For now we need DebugSwap but others are likely to be needed too. Cc: Tom Lendacky Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Alexey Kardashevskiy --- Changes: v4: * added more from April/2024 APM --- MdePkg/Include/Register/Amd/Fam17Msr.h | 95 +++-

[edk2-devel] [PATCH ovmf v4 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr

2024-06-04 Thread Alexey Kardashevskiy via groups.io
PcdConfidentialComputingGuestAttr so far only contained an SEV mode bit but there are more other features which do not translate to levels such as DebugVirtualization or SecureTsc. Add the feature mask and the DebugVirtualization feature bit to the PCD. Cc: Liming Gao Cc: Michael D Kinney Cc: Z

[edk2-devel] [PATCH ovmf v4 3/5] OvmfPkg: Add AMD SEV-ES DebugVirtualization feature support

2024-06-04 Thread Alexey Kardashevskiy via groups.io
The SEV-ES DebugVirtualization feature enables type B swapping of debug registers on #VMEXIT and makes #DB and DR7 intercepts unnecessary and unwanted. When DebugVirtualization is enabled, this stops booting if #VC for #DB or DB7 read/write occurs as this signals unwanted interaction from the HV.

[edk2-devel] [PATCH ovmf v4 4/5] UefiCpuPkg: Add AMD SEV-ES features support

2024-06-04 Thread Alexey Kardashevskiy via groups.io
CONFIDENTIAL_COMPUTING_GUEST_ATTR is not a simple SEV level anymore and includes a feature mask since the previous commit. Fix AmdMemEncryptionAttrCheck to check the level and feature correctly and add DebugVirtualization support. Since the actual feature flag is not set yet, this should cause no

[edk2-devel] [PATCH ovmf v4 5/5] OvmfPkf: Enable AMD SEV-ES DebugVirtualization

2024-06-04 Thread Alexey Kardashevskiy via groups.io
Write the feature bit into PcdConfidentialComputingGuestAttr and enable DebugVirtualization in PEI, SEC, DXE. Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Michael Roth Cc: Min Xu Cc: Tom Lendacky Signed-off-by: Alexey Kardashevskiy --- Changes: v4: * s/DebugSwap/

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

2024-06-04 Thread Rebecca Cran via groups.io
Reviewed-by: Rebecca Cran -- Rebecca Cran On 6/4/2024 6:57 PM, Nhi Pham wrote: This allows to initialize secure boot with the default factory keys embedded in firmware flash image. For example, to incorporate PK, KEK, and DB default keys, specify the corresponding key files in the Jade.dsc as

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, June 5, 2024 #cal-cancelled

2024-06-04 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_Ang

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

2024-06-04 Thread Nhi Pham via groups.io
Could you help push my patch to Tianocore/edk2-platforms once approved, while I don't have write permission? Thanks, Nhi On 6/5/2024 11:10 AM, Rebecca Cran wrote: Reviewed-by: Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onl

[edk2-devel] Call for TianoCore Community Meeting topics

2024-06-04 Thread Michael D Kinney
Hi, Are there any topics for the TianoCore community meeting this month? Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119468): https://edk2.groups.io/g/devel/message/119468 Mute This Topic: https://groups.io/mt/106498468