[edk2-devel] [PATCH v1 9/9] ShellPkg: Add validator help string

2021-12-15 Thread Chris Jones
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773) Amend the help string to explain the use of the validator option. Signed-off-by: Chris Jones --- ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni | 18 +- ShellPkg/Library

[edk2-devel] [PATCH v1 8/9] ShellPkg: Rewrite SBBR validation

2021-12-15 Thread Chris Jones
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773) Rewrite SBBR validation into the validator framework. This decouples the SBBR validations from the internal workings of the Acpiview application. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm

[edk2-devel] [PATCH v1 7/9] ShellPkg: Add installed tables to parser collection

2021-12-15 Thread Chris Jones
cification. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | 21 ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/AcpiDataStore.h | 5 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH v1 6/9] ShellPkg: Add processor ID cross table validation

2021-12-15 Thread Chris Jones
found in the MADT as specified in ACPI 6.4 Table 5.138 - ACPI Processor ID. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/AcpiStandard/AcpiStandardValidator.c | 161 +++- 1 file changed, 159 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH v1 5/9] ShellPkg: Store MADT and PPTT processor data

2021-12-15 Thread Chris Jones
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773) Store processor data from the MADT and PPTT ACPI tables so that it can be used for processor ID validation. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 23

[edk2-devel] [PATCH v1 4/9] ShellPkg: Add ACPI data store

2021-12-15 Thread Chris Jones
dynamically as nodes in a linked list that is accessed by META_DATA_TYPE. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 6 + ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 + ShellPkg/Library

[edk2-devel] [PATCH v1 3/9] ShellPkg: Add post parsing validation framework

2021-12-15 Thread Chris Jones
in this validator however it will be called from the main AcpiView.c application. Also make AcpiViewConfig use the new VALIDATOR_ID enum when setting and getting ValidatorId. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c

[edk2-devel] [PATCH v1 2/9] ShellPkg: Replace SBBR validation option with generic one

2021-12-15 Thread Chris Jones
if trying to run a validator. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | 7 --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c| 27 +++--- ShellPkg/Library/UefiShellAcpiViewCommandLib

[edk2-devel] [PATCH v1 1/9] ShellPkg: Add AcpiView validators readme

2021-12-15 Thread Chris Jones
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773) Add readme to explain the function and use of the new AcpiView validator framework. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/Readme.md | 113 1 file changed

Re: [edk2-devel] SbsaQemu: "acpiview -s pptt" crashes after printing "Flags : 0x5F"

2021-12-14 Thread Chris Jones
Hi Rebecca, Thank you for reporting this. After further investigation I believe the issue is in the PPTT parser when it tries to report an error with the cache flags it performs an incorrect dereference of the FlagName parameter. I have filed this in bugzilla

[edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

2021-12-14 Thread Chris Jones
to ensure the message is printed cleanly. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b

Re: [edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-09 Thread Chris Jones
On 08/12/2021 04:06 PM, Chris Jones wrote: > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) > > Update the PPTT generator with the CacheId field as defined in table > 5.140 of the ACPI 6.4 specification. > > Also add validations to ensure that the cache id g

[edk2-devel] [PATCH v3 2/7] MdePkg: Remove PPTT ID type structure

2021-12-08 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) The ACPI 6.3A specification deprecated the PPTT ID type structure (type 2) therefore remove it from Acpi64.h. Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072) Signed-off-by: Chris Jones Reviewed-by: Liming

[edk2-devel] [PATCH v3 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-12-08 Thread Chris Jones
) Signed-off-by: Chris Jones Reviewed-by: Zhichao Gao --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 61 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 2 +- 2 files changed, 12 insertions(+), 51 deletions

[edk2-devel] [PATCH v3 6/7] DynamicTablesPkg: Update PPTT generator to ACPI 6.4

2021-12-08 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator to use Acpi64.h. Signed-off-by: Chris Jones --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[edk2-devel] [PATCH v3 0/7] Support ACPI 6.4 PPTT changes

2021-12-08 Thread Chris Jones
n be seen at: https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v3 Chris Jones (7): MdePkg: Add missing Cache ID (in)valid define MdePkg: Remove PPTT ID type structure ShellPkg: Update Acpiview PPTT parser to ACPI 6.4 ShellPkg: Add Cache ID to PPTT parser DynamicTablesPkg: Remo

[edk2-devel] [PATCH v3 5/7] DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator

2021-12-08 Thread Chris Jones
/mantis/view.php?id=2072) Signed-off-by: Chris Jones --- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 23 +-- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 154 +--- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 4

[edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-08 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table 5.140 of the ACPI 6.4 specification. Also add validations to ensure that the cache id generated is unique. Signed-off-by: Chris Jones --- DynamicTablesPkg

[edk2-devel] [PATCH v3 4/7] ShellPkg: Add Cache ID to PPTT parser

2021-12-08 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser with the Cache ID field and relevant validations as defined in tables 5.140 and 5.141 of the ACPI 6.4 specification. Signed-off-by: Chris Jones Reviewed-by: Zhichao Gao --- ShellPkg/Library

[edk2-devel] [PATCH v3 1/7] MdePkg: Add missing Cache ID (in)valid define

2021-12-08 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Add Cache ID valid/invalid defines to Acpi64.h which were not initially added when the CacheIdValid field was added to EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS. Signed-off-by: Chris Jones Reviewed-by: Liming Gao Reviewed

Re: [edk2-devel] [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors

2021-11-24 Thread Chris Jones
This patch series looks good to me. Reviewed-by: Chris Jones Thanks, Chris -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84056): https://edk2.groups.io/g/devel/message/84056 Mute This Topic: https://groups.io/mt/87284484/21656 Group

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory aggregator/device type mismatch

2021-11-08 Thread Chris Jones
> > Akanksha Jain ; Matteo Carlini > > ; nd > > Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory > > aggregator/device type mismatch > > > > Jones: > > Do you know what impact will be introduced by this change? > > > > Thanks > > L

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

2021-11-08 Thread Chris Jones
: Sami Mujawar > > Regards, > > Sami Mujawar > > On 20/10/2021, 11:47, "Chris Jones" wrote: > > Add a comment to clarify that in Acpiview the ItemPtr is not set until > after the FieldValidator has been called. > > Signed-off-by: Chr

Re: [edk2-devel] [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-11-03 Thread Chris Jones
: Update Acpiview PPTT parser to ACPI 6.4 Hi, On 10/18/21 10:10 AM, Chris Jones via groups.io wrote: > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) > > Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, > remove support for parsing PP

Re: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes

2021-11-03 Thread Chris Jones
: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes For the changes in MdePkg, Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chris Jones > 发送时间: 2021年10月18日 23:11 > 收件人: devel@edk2.groups.io > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com

[edk2-devel] [PATCH v2 6/7] DynamicTablesPkg: Update PPTT generator to ACPI 6.4

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator to use Acpi64.h. Signed-off-by: Chris Jones --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[edk2-devel] [PATCH v2 5/7] DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) ACPI 6.3A deprecated PPTT ID (type 2) structure which was subsequently removed in ACPI 6.4. Therefore remove support for generating PPTT ID structures. Signed-off-by: Chris Jones --- DynamicTablesPkg/Include

[edk2-devel] [PATCH v2 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table 5.140 of the ACPI 6.4 specification. Also add validations to ensure that the cache id generated is unique. Signed-off-by: Chris Jones --- Notes: v2

[edk2-devel] [PATCH v2 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, remove support for parsing PPTT type 2 ID structure. Signed-off-by: Chris Jones --- Notes: v2: - Changed PPTT ID error message to say "re

[edk2-devel] [PATCH v2 4/7] ShellPkg: Add Cache ID to PPTT parser

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser with the Cache ID field and relevant validations as defined in tables 5.140 and 5.141 of the ACPI 6.4 specification. Signed-off-by: Chris Jones --- Notes: v2: - Fixed a bug where

[edk2-devel] [PATCH v2 2/7] MdePkg: Remove PPTT ID type structure

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) The ACPI 6.3A specification deprecated the PPTT ID type structure (type 2) therefore remove it from Acpi64.h. Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH v2 0/7] Support ACPI 6.4 PPTT changes

2021-11-03 Thread Chris Jones
nstead of EFI_STATUS. - Added a missing space to the definition of 'IsCacheIdUnique'. The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v2 Chris Jones (7): MdePkg: Add missing Cache ID (in)valid define MdePkg: Remove PPTT ID type structur

[edk2-devel] [PATCH v2 1/7] MdePkg: Add missing Cache ID (in)valid define

2021-11-03 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Add Cache ID valid/invalid defines to Acpi64.h which were not initially added when the CacheIdValid field was added to EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard

Re: [edk2-devel] [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure

2021-10-29 Thread Chris Jones
Pkg: Remove PPTT ID type structure > > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) > > The ACPI 6.3A specification deprecated the PPTT ID type structure (type > 2) therefore remove it from Acpi64.h. > > Mantis ID: 2072 (https://mantis.uefi.org/mantis/vie

[edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

2021-10-20 Thread Chris Jones
Add a comment to clarify that in Acpiview the ItemPtr is not set until after the FieldValidator has been called. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library

[edk2-devel] [PATCH v1 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table 5.140 of the ACPI 6.4 specification. Also add validations to ensure that the cache id generated is unique. Signed-off-by: Chris Jones --- DynamicTablesPkg

[edk2-devel] [PATCH v1 6/7] DynamicTablesPkg: Update PPTT generator to ACPI 6.4

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator to use Acpi64.h. Signed-off-by: Chris Jones --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[edk2-devel] [PATCH v1 5/7] DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) ACPI 6.3A deprecated PPTT ID (type 2) structure which was subsequently removed in ACPI 6.4. Therefore remove support for generating PPTT ID structures. Signed-off-by: Chris Jones --- DynamicTablesPkg/Include

[edk2-devel] [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, remove support for parsing PPTT type 2 ID structure. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt

[edk2-devel] [PATCH v1 4/7] ShellPkg: Add Cache ID to PPTT parser

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser with the Cache ID field and relevant validations as defined in tables 5.140 and 5.141 of the ACPI 6.4 specification. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib

[edk2-devel] [PATCH v1 1/7] MdePkg: Add missing Cache ID (in)valid define

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Add Cache ID valid/invalid defines to Acpi64.h which were not initially added when the CacheIdValid field was added to EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard

[edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes

2021-10-18 Thread Chris Jones
) structure. In addition add two 'Cache ID' defines and remove the type 2 PPTT structure from Acpi64.h as these changes were missing when Acpi64.h was introduced. The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v1 Chris Jones (7): MdePkg: Add missing

[edk2-devel] [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) The ACPI 6.3A specification deprecated the PPTT ID type structure (type 2) therefore remove it from Acpi64.h. Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory aggregator/device type mismatch

2021-10-06 Thread Chris Jones
to match the specification. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi50.h | 6 +++--- MdePkg/Include/IndustryStandard/Acpi51.h | 6 +++--- MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++--- MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++--- MdePkg/Include/IndustryStandard

Re: [edk2-devel] [PATCH v1 0/4] Set default Makefile name

2021-09-23 Thread Chris Jones
For this patch series: Reviewed-by: Chris Jones Regards, Chris From: devel@edk2.groups.io on behalf of PierreGondois via groups.io Sent: Thursday, September 23, 2021 9:58 AM To: devel@edk2.groups.io ; Bob Feng ; Liming Gao ; Sami Mujawar Subject: [edk2

Re: [edk2-devel] [PATCH v1] ShellPkg: Update Acpiview HMAT parser to ACPI spec version 6.4

2021-09-08 Thread Chris Jones
, Sami Mujawar On 18/08/2021, 11:09, "Chris Jones" wrote: Bugzilla: 3570 (https://bugzilla.tianocore.org/show_bug.cgi?id=3570) Add parser support for the new "MinTransferSize" field of the System Locality, Latency and Bandwidth structure, introduced by the AC

Re: [edk2-devel] [PATCH v1 0/2] Support ACPI 6.4 in Acpiview PCCT parser

2021-09-08 Thread Chris Jones
, "Chris Jones" wrote: Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563) This patch series adds support for ACPI 6.4 to the Acpiview PCCT parser by using Acpi64.h and adding parsing, validation and printing support for the new 'Type 5' subspace

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

2021-09-08 Thread Chris Jones
Mujawar On 16/08/2021, 15:52, "Chris Jones" wrote: Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565) This patch series updates the Acpiview GTDT parser and DynamicTables GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h whic

[edk2-devel] [PATCH v1] ShellPkg: Update Acpiview HMAT parser to ACPI spec version 6.4

2021-08-18 Thread Chris Jones
ersion 6.4 definitions. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hmat/HmatParser.c | 19 ++- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 2 +- 2 files changed, 11 insertions(+), 10 deletions(-)

[edk2-devel] [PATCH v1] DynamicTablesPkg: Update FADT generator to ACPI 6.4

2021-08-17 Thread Chris Jones
-by: Chris Jones --- DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 104 ++-- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm

[edk2-devel] [PATCH v1 2/2] ShellPkg: Update Acpiview GTDT parser to ACPI 6.4

2021-08-16 Thread Chris Jones
Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565) Update the Acpiview GTDT parser to use Acpi64.h and as such rename all occurences of "SBSA Generic Watchdog" to "Arm Generic Watchdog". Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCom

[edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Rename SBSA generic watchdog

2021-08-16 Thread Chris Jones
nce of "SBSA Generic Watchdog" to "Arm Generic Watchdog". Signed-off-by: Chris Jones --- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 8 +-- DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 60 ++-- 2 files changed,

[edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

2021-08-16 Thread Chris Jones
uot;Arm Generic Watchdog" strucutre. The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1822_64_acpi_generic_watchdog_v1 Chris Jones (2): DynamicTablesPkg: Rename SBSA generic watchdog ShellPkg: Update Acpiview GTDT parser to ACPI 6.4 .../Include/ArmNameSpaceObject

[edk2-devel] [PATCH v1 1/2] ShellPkg: Update Acpiview PCCT parser to ACPI 6.4

2021-08-13 Thread Chris Jones
Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563) Update the Acpiview PCCT parser to use Acpi64.h. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c | 46 ++-- ShellPkg/Library

[edk2-devel] [PATCH v1 0/2] Support ACPI 6.4 in Acpiview PCCT parser

2021-08-13 Thread Chris Jones
://github.com/chris-jones-arm/edk2/tree/1825_64_acpi_pcct_update_v1 Chris Jones (2): ShellPkg: Update Acpiview PCCT parser to ACPI 6.4 ShellPkg: Add Type 5 PCC Subspace Structure parser .../Parsers/Pcct/PcctParser.c | 104 +- .../UefiShellAcpiViewCommandLib.c

[edk2-devel] [PATCH v1 2/2] ShellPkg: Add Type 5 PCC Subspace Structure parser

2021-08-13 Thread Chris Jones
Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563) Update the Acpiview PCCT parser with the HW Registers based Communications Subspace Structure (Type 5) as defined in Section 14.1.7 of the ACPI 6.4 specification. Signed-off-by: Chris Jones --- ShellPkg/Library

[edk2-devel] [PATCH v2 13/13] MdePkg: Fix broken coding style in Acpi64.h

2021-08-05 Thread Chris Jones
rs present prior to ACPI 64. Signed-off-by: Chris Jones --- Notes: v2: - Remove EFI_ACPI_6_4_GIC_STRUCTURE field name changes. [Liming] - Add Acpi64.h to IgnoreFiles list in MdePkg.ci.yaml. [Liming] MdePkg/Include/IndustryStandard/Acpi64.h | 27 +++- MdePkg/MdeP

[edk2-devel] [PATCH v2 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator

2021-08-05 Thread Chris Jones
-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index b8be65c5e1c861b2a85b81f585ffdb40a178

[edk2-devel] [PATCH v2 12/13] MdePkg: Add Cache ID to PPTT

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141 - Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138) Signed-off-by: Chris Jones

[edk2-devel] [PATCH v2 11/13] MdePkg: Add Secure Access Components in the SDEV table

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.26.1.1 - Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111) Signed-off-by: Chris Jones --- MdePkg

[edk2-devel] [PATCH v2 09/13] MdePkg: Add Multiprocessor Wakeup structure

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19 - Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087) Signed-off-by: Chris Jones

[edk2-devel] [PATCH v2 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog

2021-08-05 Thread Chris Jones
-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index 5a0e5b29c7e41cfa03ebc28e306719762b72

[edk2-devel] [PATCH v2 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT)

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5, Section 5.2.30 - Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094) Signed-off-by: Chris Jones

[edk2-devel] [PATCH v2 01/13] MdePkg: Add ACPI 6.4 header file

2021-08-05 Thread Chris Jones
nitions were named "PMMT" when it should be "PMTT". 6. Fix a typo: "PPTT Platform Communication Channel" should be "PDTT Platform Communication Channel". Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi.h |4 +- MdePkg/Include/

[edk2-devel] [PATCH v2 08/13] MdePkg: Add 'Type 5' PCC structure

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 14.1.7, Section 14.4 - Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010) Signed-off-by: Chris Jones

[edk2-devel] [PATCH v2 04/13] MdePkg: Update PMTT to ACPI 6.4

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.21.12 - Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975) Signed-off-by: Chris Jones --- MdePkg

[edk2-devel] [PATCH v2 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure

2021-08-05 Thread Chris Jones
/view.php?id=1988) Also added a blank line between #defines and structure definitions to improve readability. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include

[edk2-devel] [PATCH v2 02/13] MdePkg: Increment FADT version

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5-9 - Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH v2 06/13] MdePkg: Remove DPPT table

2021-08-05 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5 - Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH v2 00/13] Add ACPI 6.4 header file

2021-08-05 Thread Chris Jones
the previous ACPI header files. Changes since v1: 1. Patch 13/13 - Remove EFI_ACPI_6_4_GIC_STRUCTURE field name changes. [Liming] - Add Acpi64.h to IgnoreFiles list in MdePkg.ci.yaml. [Liming] The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v2

[edk2-devel] [PATCH RESEND v1 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT)

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5, Section 5.2.30 - Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094) Signed-off-by: Chris Jones

[edk2-devel] [PATCH RESEND v1 12/13] MdePkg: Add Cache ID to PPTT

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141 - Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138) Signed-off-by: Chris Jones

[edk2-devel] [PATCH RESEND v1 11/13] MdePkg: Add Secure Access Components in the SDEV table

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.26.1.1 - Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111) Signed-off-by: Chris Jones --- MdePkg

[edk2-devel] [PATCH RESEND v1 13/13] MdePkg: Fix broken coding style in Acpi64.h

2021-07-30 Thread Chris Jones
[EFI_ACPI_6_4_GIC_STRUCTURE_.GICH]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR]. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++- 1 file changed, 21 insertions(+), 18 deletions

[edk2-devel] [PATCH RESEND v1 06/13] MdePkg: Remove DPPT table

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5 - Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH RESEND v1 09/13] MdePkg: Add Multiprocessor Wakeup structure

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19 - Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087) Signed-off-by: Chris Jones

[edk2-devel] [PATCH RESEND v1 08/13] MdePkg: Add 'Type 5' PCC structure

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 14.1.7, Section 14.4 - Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010) Signed-off-by: Chris Jones

[edk2-devel] [PATCH RESEND v1 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure

2021-07-30 Thread Chris Jones
/view.php?id=1988) Also added a blank line between #defines and structure definitions to improve readability. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include

[edk2-devel] [PATCH RESEND v1 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog

2021-07-30 Thread Chris Jones
-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index 5a0e5b29c7e41cfa03ebc28e306719762b72

[edk2-devel] [PATCH RESEND v1 01/13] MdePkg: Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
nitions were named "PMMT" when it should be "PMTT". 6. Fix a typo: "PPTT Platform Communication Channel" should be "PDTT Platform Communication Channel". Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi.h |4 +- MdePkg/Include/

[edk2-devel] [PATCH RESEND v1 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator

2021-07-30 Thread Chris Jones
-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index b8be65c5e1c861b2a85b81f585ffdb40a178

[edk2-devel] [PATCH RESEND v1 02/13] MdePkg: Increment FADT version

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5-9 - Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH RESEND v1 04/13] MdePkg: Update PMTT to ACPI 6.4

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.21.12 - Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975) Signed-off-by: Chris Jones --- MdePkg

[edk2-devel] [PATCH RESEND v1 00/13] Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
the previous ACPI header files. The patches have been resent to include the bugzilla id, no code has been changed. The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v1 Chris Jones (13): MdePkg: Add ACPI 6.4 header file MdePkg: Increment FADT version

[edk2-devel] [PATCH v1 13/13] MdePkg: Fix broken coding style in Acpi64.h

2021-07-30 Thread Chris Jones
contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR]. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg

[edk2-devel] [PATCH v1 11/13] MdePkg: Add Secure Access Components in the SDEV table

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.26.1.1 - Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 84 ++-- 1 file changed

[edk2-devel] [PATCH v1 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT)

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5, Section 5.2.30 - Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 79 1 file

[edk2-devel] [PATCH v1 12/13] MdePkg: Add Cache ID to PPTT

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141 - Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 6 -- 1 file

[edk2-devel] [PATCH v1 01/13] MdePkg: Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
. Fix a typo: "PPTT Platform Communication Channel" should be "PDTT Platform Communication Channel". Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi.h |4 +- MdePkg/Include/IndustryStandard/Acpi64.h | 2967 2 files ch

[edk2-devel] [PATCH v1 08/13] MdePkg: Add 'Type 5' PCC structure

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 14.1.7, Section 14.4 - Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 29 1

[edk2-devel] [PATCH v1 09/13] MdePkg: Add Multiprocessor Wakeup structure

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19 - Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 29 +++- 1

[edk2-devel] [PATCH v1 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.59, Section 5.2.27.1 & Section 5.2.27.4 - Mantis ID 1991 (https://mantis.uefi.org/mantis/view.php?id=1991) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h

[edk2-devel] [PATCH v1 02/13] MdePkg: Increment FADT version

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5-9 - Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[edk2-devel] [PATCH v1 06/13] MdePkg: Remove DPPT table

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5 - Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 - 1 file changed, 5 deletions(-) diff

[edk2-devel] [PATCH v1 04/13] MdePkg: Update PMTT to ACPI 6.4

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.21.12 - Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 89 +++- 1 file changed

[edk2-devel] [PATCH v1 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.24, Table 5.100 & Section 5.2.24.2 - Mantis ID 2126 (https://mantis.uefi.org/mantis/view.php?id=2126) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h

[edk2-devel] [PATCH v1 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure

2021-07-30 Thread Chris Jones
definitions to improve readability. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index e66e1b5a7ab25daf690ef4b21d665fb88d15e8ab

[edk2-devel] [PATCH v1 00/13] Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v1 Chris Jones (13): MdePkg: Add ACPI 6.4 header file MdePkg: Increment FADT version MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog MdePkg: Update PMTT to ACPI 6.4 MdePkg: Add SPA Location Cookie field to SPA Range

[edk2-devel] [PATCH 00/13] Add ACPI 6.4 header file

2021-07-29 Thread Chris Jones
://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v1 Chris Jones (13): MdePkg: Add ACPI 6.4 header file MdePkg: Increment FADT version MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog MdePkg: Update PMTT to ACPI 6.4 MdePkg: Add SPA Location Cookie field to SPA Range