Pkg: Remove PPTT ID type structure
>
> Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
>
> The ACPI 6.3A specification deprecated the PPTT ID type structure (type
> 2) therefore remove it from Acpi64.h.
>
> Mantis ID: 2072 (https://mantis.uefi.org/mantis/vie
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Add Cache ID valid/invalid defines to Acpi64.h which were not initially
added when the CacheIdValid field was added to
EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS.
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard
Pkg:
- Make IsCacheIdUnique() return BOOLEAN instead of EFI_STATUS.
- Added a missing space to the definition of 'IsCacheIdUnique'.
The changes can be seen at:
https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v2
Chris Jones (7):
MdePkg: Add missing Cach
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
The ACPI 6.3A specification deprecated the PPTT ID type structure (type
2) therefore remove it from Acpi64.h.
Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072)
Signed-off-by: Chris Jones
---
MdePkg/Include
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the Acpiview PPTT parser with the Cache ID field and relevant
validations as defined in tables 5.140 and 5.141 of the ACPI 6.4
specification.
Signed-off-by: Chris Jones
---
Notes:
v2:
- Fixed a bug where
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes,
remove support for parsing PPTT type 2 ID structure.
Signed-off-by: Chris Jones
---
Notes:
v2:
- Changed PPTT ID error message to say "re
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator with the CacheId field as defined in table
5.140 of the ACPI 6.4 specification.
Also add validations to ensure that the cache id generated is unique.
Signed-off-by: Chris Jones
---
Notes:
v2
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
ACPI 6.3A deprecated PPTT ID (type 2) structure which was subsequently
removed in ACPI 6.4. Therefore remove support for generating PPTT ID
structures.
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Include
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator to use Acpi64.h.
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44
++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff
: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes
For the changes in MdePkg, Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chris Jones
> 发送时间: 2021年10月18日 23:11
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com
: Update Acpiview PPTT parser
to ACPI 6.4
Hi,
On 10/18/21 10:10 AM, Chris Jones via groups.io wrote:
> Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
>
> Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes,
> remove support for parsing PP
: Sami Mujawar
>
> Regards,
>
> Sami Mujawar
>
> On 20/10/2021, 11:47, "Chris Jones" wrote:
>
> Add a comment to clarify that in Acpiview the ItemPtr is not set until
> after the FieldValidator has been called.
>
> Signed-off-by: Chr
> > Akanksha Jain ; Matteo Carlini
> > ; nd
> > Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory
> > aggregator/device type mismatch
> >
> > Jones:
> > Do you know what impact will be introduced by this change?
> >
> > Thanks
> > L
This patch series looks good to me.
Reviewed-by: Chris Jones
Thanks,
Chris
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84056): https://edk2.groups.io/g/devel/message/84056
Mute This Topic: https://groups.io/mt/87284484/21656
Group
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Add Cache ID valid/invalid defines to Acpi64.h which were not initially
added when the CacheIdValid field was added to
EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS.
Signed-off-by: Chris Jones
Reviewed-by: Liming Gao
Reviewed-by
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the Acpiview PPTT parser with the Cache ID field and relevant
validations as defined in tables 5.140 and 5.141 of the ACPI 6.4
specification.
Signed-off-by: Chris Jones
Reviewed-by: Zhichao Gao
---
ShellPkg/Library
/mantis/view.php?id=2072)
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 23 +--
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 154
+---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 4
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator with the CacheId field as defined in table
5.140 of the ACPI 6.4 specification.
Also add validations to ensure that the cache id generated is unique.
Signed-off-by: Chris Jones
---
DynamicTablesPkg
e definition of 'IsCacheIdUnique'.
The changes can be seen at:
https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v3
Chris Jones (7):
MdePkg: Add missing Cache ID (in)valid define
MdePkg: Remove PPTT ID type structure
ShellPkg: Update Acpiview PPTT parser to ACPI 6.4
Sh
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator to use Acpi64.h.
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44
++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff
)
Signed-off-by: Chris Jones
Reviewed-by: Zhichao Gao
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c |
61
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c |
2 +-
2 files changed, 12 insertions(+), 51 deletions
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
The ACPI 6.3A specification deprecated the PPTT ID type structure (type
2) therefore remove it from Acpi64.h.
Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072)
Signed-off-by: Chris Jones
Reviewed-by: Liming
08/12/2021 04:06 PM, Chris Jones wrote:
> Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
>
> Update the PPTT generator with the CacheId field as defined in table
> 5.140 of the ACPI 6.4 specification.
>
> Also add validations to ensure that the cache id g
ensure the message is
printed cleanly.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6
+++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
b
Hi Rebecca,
Thank you for reporting this. After further investigation I believe the issue
is in the PPTT parser when it tries to report an error with the cache flags it
performs an incorrect dereference of the FlagName parameter. I have filed this
in bugzilla (https://bugzilla.tianocore.org/sho
Mujawar
On 16/08/2021, 15:52, "Chris Jones" wrote:
Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)
This patch series updates the Acpiview GTDT parser and DynamicTables
GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h
which re
, "Chris Jones" wrote:
Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563)
This patch series adds support for ACPI 6.4 to the Acpiview PCCT parser
by using Acpi64.h and adding parsing, validation and printing support
for the new 'Type 5' subspace
,
Sami Mujawar
On 18/08/2021, 11:09, "Chris Jones" wrote:
Bugzilla: 3570 (https://bugzilla.tianocore.org/show_bug.cgi?id=3570)
Add parser support for the new "MinTransferSize" field of the System
Locality, Latency and Bandwidth structure, introduced by the AC
For this patch series:
Reviewed-by: Chris Jones
Regards,
Chris
From: devel@edk2.groups.io on behalf of PierreGondois
via groups.io
Sent: Thursday, September 23, 2021 9:58 AM
To: devel@edk2.groups.io ; Bob Feng
; Liming Gao ; Sami Mujawar
Subject: [edk2
match the specification.
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi50.h | 6 +++---
MdePkg/Include/IndustryStandard/Acpi51.h | 6 +++---
MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++---
MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++---
MdePkg/Include/IndustryStandard
ID (type 2) structure.
In addition add two 'Cache ID' defines and remove the type 2 PPTT
structure from Acpi64.h as these changes were missing when Acpi64.h was
introduced.
The changes can be seen at:
https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v1
Chris Jones (7):
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
The ACPI 6.3A specification deprecated the PPTT ID type structure (type
2) therefore remove it from Acpi64.h.
Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072)
Signed-off-by: Chris Jones
---
MdePkg/Include
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Add Cache ID valid/invalid defines to Acpi64.h which were not initially
added when the CacheIdValid field was added to
EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS.
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the Acpiview PPTT parser with the Cache ID field and relevant
validations as defined in tables 5.140 and 5.141 of the ACPI 6.4
specification.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes,
remove support for parsing PPTT type 2 ID structure.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
ACPI 6.3A deprecated PPTT ID (type 2) structure which was subsequently
removed in ACPI 6.4. Therefore remove support for generating PPTT ID
structures.
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Include
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator to use Acpi64.h.
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44
++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator with the CacheId field as defined in table
5.140 of the ACPI 6.4 specification.
Also add validations to ensure that the cache id generated is unique.
Signed-off-by: Chris Jones
---
DynamicTablesPkg
Add a comment to clarify that in Acpiview the ItemPtr is not set until
after the FieldValidator has been called.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Add readme to explain the function and use of the new AcpiView validator
framework.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/Readme.md | 113
1 file changed
trying to run a validator.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c |
7 ---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
27 +++---
ShellPkg/Library/UefiShellAcpiViewCommandLib
this validator however it will be called from the main
AcpiView.c application.
Also make AcpiViewConfig use the new VALIDATOR_ID enum when setting and
getting ValidatorId.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
dynamically as nodes in a linked list that is
accessed by META_DATA_TYPE.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c |
6 +
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |
2 +
ShellPkg/Library
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Store processor data from the MADT and PPTT ACPI tables so that it can
be used for processor ID validation.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 23
also found in the MADT as specified in ACPI 6.4 Table
5.138 - ACPI Processor ID.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/AcpiStandard/AcpiStandardValidator.c
| 161 +++-
1 file changed, 159 insertions(+), 2 deletions(-)
diff --g
cification.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | 21
ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/AcpiDataStore.h | 5
+++--
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Rewrite SBBR validation into the validator framework. This decouples the
SBBR validations from the internal workings of the Acpiview application.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Amend the help string to explain the use of the validator option.
Signed-off-by: Chris Jones
---
ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni |
18 +-
ShellPkg/Library
://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v1
Chris Jones (13):
MdePkg: Add ACPI 6.4 header file
MdePkg: Increment FADT version
MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog
MdePkg: Update PMTT to ACPI 6.4
MdePkg: Add SPA Location Cookie field to SPA Range
definitions to
improve readability.
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include/IndustryStandard/Acpi64.h
index
e66e1b5a7ab25daf690ef4b21d665fb88d15e8ab
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.24, Table 5.100 & Section 5.2.24.2
- Mantis ID 2126 (https://mantis.uefi.org/mantis/view.php?id=2126)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5
- Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 5 -
1 file changed, 5 deletions(-)
diff
://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v1
Chris Jones (13):
MdePkg: Add ACPI 6.4 header file
MdePkg: Increment FADT version
MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog
MdePkg: Update PMTT to ACPI 6.4
MdePkg: Add SPA Location Cookie field to SPA Range
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5-9
- Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.21.12
- Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 89 +++-
1 file changed
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.59, Section 5.2.27.1 & Section 5.2.27.4
- Mantis ID 1991 (https://mantis.uefi.org/mantis/view.php?id=1991)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 14.1.7, Section 14.4
- Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 29
1
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19
- Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 29 +++-
1
. Fix a typo: "PPTT Platform Communication Channel" should be "PDTT
Platform Communication Channel".
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi.h |4 +-
MdePkg/Include/IndustryStandard/Acpi64.h | 2967
2 files ch
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141
- Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 6 --
1 file
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5, Section 5.2.30
- Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 79
1 file
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.26.1.1
- Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111)
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 84 ++--
1 file changed
contain lower case characters,
Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR].
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++-
1 file changed, 21 insertions(+), 18 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg
previous ACPI header files.
The patches have been resent to include the bugzilla id, no code has
been changed.
The changes can be seen at:
https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v1
Chris Jones (13):
MdePkg: Add ACPI 6.4 header file
MdePkg: Increment FADT version
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.21.12
- Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975)
Signed-off-by: Chris Jones
---
MdePkg
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5-9
- Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105)
Signed-off-by: Chris Jones
---
MdePkg/Include
f-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include/IndustryStandard/Acpi64.h
index
b8be65c5e1c861b2a85b81f585ffdb40a178
/view.php?id=1988)
Also added a blank line between #defines and structure definitions to
improve readability.
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include
f-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include/IndustryStandard/Acpi64.h
index
5a0e5b29c7e41cfa03ebc28e306719762b72
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5
- Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133)
Signed-off-by: Chris Jones
---
MdePkg/Include
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19
- Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087)
Signed-off-by: Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141
- Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138)
Signed-off-by: Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.26.1.1
- Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111)
Signed-off-by: Chris Jones
---
MdePkg
ions were named "PMMT" when it should
be "PMTT".
6. Fix a typo: "PPTT Platform Communication Channel" should be "PDTT
Platform Communication Channel".
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi.h |4 +-
MdePkg/Include/
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5, Section 5.2.30
- Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094)
Signed-off-by: Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 14.1.7, Section 14.4
- Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010)
Signed-off-by: Chris Jones
[EFI_ACPI_6_4_GIC_STRUCTURE_.GICH].
- Error code: 8005 - Variable name must contain lower case characters,
Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR].
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++-
1 file changed, 21 insertions(+), 18 deletions
previous ACPI header files.
Changes since v1:
1. Patch 13/13
- Remove EFI_ACPI_6_4_GIC_STRUCTURE field name changes. [Liming]
- Add Acpi64.h to IgnoreFiles list in MdePkg.ci.yaml. [Liming]
The changes can be seen at:
https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v2
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5-9
- Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105)
Signed-off-by: Chris Jones
---
MdePkg/Include
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5
- Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133)
Signed-off-by: Chris Jones
---
MdePkg/Include
/view.php?id=1988)
Also added a blank line between #defines and structure definitions to
improve readability.
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.21.12
- Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975)
Signed-off-by: Chris Jones
---
MdePkg
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 14.1.7, Section 14.4
- Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010)
Signed-off-by: Chris Jones
ions were named "PMMT" when it should
be "PMTT".
6. Fix a typo: "PPTT Platform Communication Channel" should be "PDTT
Platform Communication Channel".
Signed-off-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi.h |4 +-
MdePkg/Include/
f-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include/IndustryStandard/Acpi64.h
index
5a0e5b29c7e41cfa03ebc28e306719762b72
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5, Section 5.2.30
- Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094)
Signed-off-by: Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19
- Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087)
Signed-off-by: Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.26.1.1
- Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111)
Signed-off-by: Chris Jones
---
MdePkg
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141
- Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138)
Signed-off-by: Chris Jones
f-by: Chris Jones
---
MdePkg/Include/IndustryStandard/Acpi64.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
b/MdePkg/Include/IndustryStandard/Acpi64.h
index
b8be65c5e1c861b2a85b81f585ffdb40a178
rs present prior to ACPI 64.
Signed-off-by: Chris Jones
---
Notes:
v2:
- Remove EFI_ACPI_6_4_GIC_STRUCTURE field name changes. [Liming]
- Add Acpi64.h to IgnoreFiles list in MdePkg.ci.yaml. [Liming]
MdePkg/Include/IndustryStandard/Acpi64.h | 27 +++-
MdePkg/MdeP
at:
https://github.com/chris-jones-arm/edk2/tree/1825_64_acpi_pcct_update_v1
Chris Jones (2):
ShellPkg: Update Acpiview PCCT parser to ACPI 6.4
ShellPkg: Add Type 5 PCC Subspace Structure parser
.../Parsers/Pcct/PcctParser.c | 104 +-
.../UefiShellAcpiViewCo
Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563)
Update the Acpiview PCCT parser with the HW Registers based
Communications Subspace Structure (Type 5) as defined in Section 14.1.7
of the ACPI 6.4 specification.
Signed-off-by: Chris Jones
---
ShellPkg/Library
Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563)
Update the Acpiview PCCT parser to use Acpi64.h.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c |
46 ++--
ShellPkg/Library
uot;Arm Generic Watchdog" strucutre.
The changes can be seen at:
https://github.com/chris-jones-arm/edk2/tree/1822_64_acpi_generic_watchdog_v1
Chris Jones (2):
DynamicTablesPkg: Rename SBSA generic watchdog
ShellPkg: Update Acpiview GTDT parser to ACPI 6.4
.../Include/ArmNameSpaceObject
nce of "SBSA Generic Watchdog" to "Arm Generic Watchdog".
Signed-off-by: Chris Jones
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 8 +--
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 60
++--
2 files changed,
Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)
Update the Acpiview GTDT parser to use Acpi64.h and as such rename all
occurences of "SBSA Generic Watchdog" to "Arm Generic Watchdog".
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCom
: Chris Jones
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 104
++--
1 file changed, 52 insertions(+), 52 deletions(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm
ersion 6.4
definitions.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hmat/HmatParser.c |
19 ++-
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c |
2 +-
2 files changed, 11 insertions(+), 10 deletions(-)
dif
99 matches
Mail list logo