; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric ; Kuo,
Donald ; Kumar, Chandana C
Subject: Re: [edk2-devel] [edk2-platforms: PATCH] BIOS needs to present cores
in order of relative performance in MADT
On Thu, Nov 17, 2022 at 6:01 AM JackX Lin
mailto:jackx@intel.com>> wrote
BIOS should keep MADT ordering by big core first then small core
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
then add all the other in any order? I
see that only CORE and ATOM are defined at this time. Does this imply that
this logic will need to be updated if additional core types are added?
Best regards,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of JackX
BIOS should keep MADT ordering by big core first then small core
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 94
JackX
> Lin
> Sent: Tuesday, November 15, 2022 6:53 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX ; Lin, JackX
> ; Chiu, Chasel ; Desimone,
> Nathaniel L ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Kuo, Donald ;
> Kumar, Chandana C
> Subject: [edk2-devel] [
BIOS should keep MADT ordering by big core first then small core
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
BIOS should keep MADT ordering by big core first then small core
Signed-off-by: JackX Lin
Cc: Dong Guo
Cc: Ray Ni
Cc: Donald Kuo
Cc: Jiewen Yao
Cc: Rangasai V Chaganty
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 149
BIOS should keep MADT ordering by big core first then small core
Cc: Ray Ni
Cc: Donald Kuo
Cc: Jiewen Yao
Cc: Rangasai V Chaganty
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 149
,
Ray
> -Original Message-
> From: Lin, JackX
> Sent: Monday, August 8, 2022 4:21 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX ; Lin, JackX
> ; Chiu, Chasel ; Dong,
> Eric ; Yao, Jiewen ; Ni,
> Ray ; Chaganty, Rangasai V
> ; Kuo, Donald ;
> Kumar, Chandana
BIOS should not reordering cpu processor_uid
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: Palakshareddy, Lavanya C
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables
reads.
Do you see an issue that we remove the thread sorting logic?
Thanks,
Ray
> -Original Message-
> From: Lin, JackX
> Sent: Monday, August 8, 2022 4:21 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX ; Lin, JackX
> ; Chiu, Chasel ; Dong,
> Eric ; Yao, Jiew
BIOS should not reordering cpu processor_uid
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: Palakshareddy, Lavanya C
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables
uot;
can be changed to a local variable?
Thanks,
Ray
> -Original Message-
> From: Lin, JackX
> Sent: Thursday, July 28, 2022 3:25 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX ; Lin, JackX
> ; Chiu, Chasel ; Dong,
> Eric ; Yao, Jiewen ; Ni,
> Ray ; C
BIOS should not reordering cpu processor_uid
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: Palakshareddy, Lavanya C
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables
BIOS should not reordering cpu processor_uid
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 14
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
System will occur a CPU exception error when sorting CPU
APIC map, because of a pointer point to an wrong space.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
Check MAX_SOCKET exists before its creation.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
Correct coding style
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
Hi Ray,
Thanks for recommendations.
For item5, after referencing the log from server platform.
I think it is fine to keep original coding.
For item1 to item4, all of them are optimized.
I will re-sent the code patch.
Thank you.
Jack
-Original Message-
From: Ni, Ray
Sent: Thursday, A
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc
30 matches
Mail list logo
