I have a UEFI shell application that can set/get UEFI x-UEFI HII Keyword
values. edk2-nvidia/Silicon/NVIDIA/Application/HiiKeywordUtil at main ·
NVIDIA/edk2-nvidia (github.com) (
https://github.com/NVIDIA/edk2-nvidia/tree/main/Silicon/NVIDIA/Application/HiiKeywordUtil
)
I have used this to
Add Google Mock Library for FdtLib
Signed-off-by: Jeff Brasen
---
MdePkg/Test/MdePkgHostTest.dsc| 1 +
.../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++
.../Include/GoogleTest/Library/MockFdtLib.h | 164 ++
.../GoogleTest/MockFdtLib/MockFdtLib.cpp
Oops not sure how that happened will fix and push a v3.
-Jeff
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, January 23, 2024 4:52 PM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ;
> Kinney, Michael D
> Subject: RE: [PATCH v2
Rename the standard functions in the LibFdtSupport to remove conflicts
with other libraries that define them.
Signed-off-by: Jeff Brasen
---
MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 7 +--
MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++-
2 files changed, 7
Add Google Mock Library for FdtLib
Signed-off-by: Jeff Brasen
---
.../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++
.../Include/GoogleTest/Library/MockFdtLib.h | 164 ++
.../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34
3 files changed, 226 insertions(+)
create
Any comments on this patch?
Thanks,
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, December 11, 2023 8:43 AM
> To: devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com;
> zhiguang@intel.com; Jeff Brasen
> Subject: [PATCH] MdePkg: Add
> Sent: Monday, December 11, 2023 9:00 AM
> > To: devel@edk2.groups.io; Jeff Brasen
> > Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard
> > functions
> >
> > External email: Use caution opening links or attachments
> >
> >
> >
Add Google Mock Library for DtPlatformLoaderDtbLib
Signed-off-by: Jeff Brasen
---
EmbeddedPkg/EmbeddedPkg.dec | 1 +
.../MockDtPlatformDtbLoaderLib.inf| 29 +
.../Library/MockDtPlatformDtbLoaderLib.h | 31 +++
Add implementation of ReallocatePool which is defined in the
MemoryAllocationLib header file to allow components to not
need special handling for PrePi module types.
Signed-off-by: Jeff Brasen
---
.../MemoryAllocationLib.c | 57 +++
1 file changed, 57
Add UnitTestFrameworkPkg to AcceptableDependencies-HOST_APPLICATION list
Signed-off-by: Jeff Brasen
---
EmbeddedPkg/EmbeddedPkg.ci.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.ci.yaml b/EmbeddedPkg/EmbeddedPkg.ci.yaml
index
Adding Mock support for DtPlatformLoaderLib and changing ci.yaml to support this
Adding ReallocatePool support to PrePi Library.
Passing CI in https://github.com/tianocore/edk2/pull/5197
Change log
v2 -
Fix uncrustify errors
Fix ci allowed packages entries
Fix cast on 32-bit systems
Jeff
Looks like I missed an UINTN cast will fix and push a v2.
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, December 21, 2023 7:54 AM
> To: Chang, Abner
> Cc: Jeff Brasen ; devel@edk2.groups.io;
> ardb+tianoc...@kernel.org; quic_llind...@quicinc.com
> Subject: Re: [PATCH]
Rename standard
> functions
>
> External email: Use caution opening links or attachments
>
>
> On Mon, Dec 11, 2023 at 3:40 PM Jeff Brasen via groups.io
> wrote:
> >
>
> Jeff,
>
> You're missing CC's on this patch. Also, you should probably send the
>
Add implementation of ReallocatePool which is defined in the
MemoryAllocationLib header file to allow components to not
need special handling for PrePi module types.
Signed-off-by: Jeff Brasen
---
.../MemoryAllocationLib.c | 57 +++
1 file changed, 57
Add Google Mock Library for DtPlatformLoaderDtbLib
Signed-off-by: Jeff Brasen
---
EmbeddedPkg/EmbeddedPkg.dec | 1 +
.../Library/MockDtPlatformDtbLoaderLib.h | 31 +++
.../MockDtPlatformDtbLoaderLib.cpp| 13
Add Google Mock Library for FdtLib
Signed-off-by: Jeff Brasen
---
.../Include/GoogleTest/Library/MockFdtLib.h | 165 ++
.../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34
.../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++
3 files changed, 227 insertions(+)
create
Rename the standard functions in the LibFdtSupport to remove conflicts
with other libraries that define them.
Signed-off-by: Jeff Brasen
---
MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 16 +++
MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++-
2 files changed,
Anything else needed to get this merged as the November stable release is
coming up.
Thanks,
Jeff
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, October 16, 2023 8:39 PM
> To: Jeff Brasen ; Gao, Liming
> ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Bi, Dandan
>
> Subject:
Anything else needed to get this merged would as the November stable release is
coming up.
Thanks,
Jeff
> -Original Message-
> From: gaoliming
> Sent: Friday, October 6, 2023 11:23 PM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; dandan...@intel.com; Ashish
Anyone have any thoughts on this patch?
Thanks,
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, September 11, 2023 2:14 PM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn;
> dandan...@intel.com; Ashish Singhal
> Subject: RE: [PATCH]
.com
> Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add
> EFI_NOT_READY return
>
> External email: Use caution opening links or attachments
>
>
> On Thu, 29 Jun 2023 at 22:47, Jeff Brasen via groups.io
> wrote:
> >
> > Add EFI_NOT_READY return if the
Anything else needed on this to get it merged?
Thanks,
Jeff
> -Original Message-
> From: gaoliming
> Sent: Tuesday, September 12, 2023 6:59 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; dandan...@intel.com; zhichao@intel.com
> Subject: 回复: [PATCH v2 0/2]
Reviewed-by: Jeff Brasen
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Friday, September 22, 2023 8:18 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; Leif Lindholm
> ; Jeff Brasen
> Subject: [PATCH 1/1] DynamicTablesPkg/AmlLib: Define an enum for
> IsaRanges
>
>
I see you swapped the order of the functions, that looks good and avoids
special handling for that case. That looks good to me.
Thanks,
Jeff
From: Sami Mujawar
Sent: Thursday, September 21, 2023 2:07 PM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: Pierre Gondois ; Swatisri Kantamsetti
; Ashish
From: Vidya Sagar
Add helper functions to generate AML Resource Data describing I/O
ranges of four words long. API AmlCodeGenRdQWordIo () is exposed.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 67 ++
.../AmlLib/CodeGen/AmlResourceDataCodeGen.c
From: Vidya Sagar
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses
can be used to generate I/O packets over the PCIe bus.
Signed-off-by: Jeff Brasen
---
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit
addresses can be used to generate I/O packets over the PCIe bus.
Changes:
v2 - Rebased and set transferEncoding = 8bit
Vidya Sagar (2):
DynamicTablesPkg: AML
Only thing I see is if AmlCodeGenInteger fails we don’t delete DataNode right?
From: Sami Mujawar
Sent: Thursday, September 21, 2023 10:49 AM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: pierre.gond...@arm.com; Swatisri Kantamsetti ; Ashish
Singhal ; n...@arm.com
Subject: Re: [PATCH v4 2/4]
Hi Sami,
That sounds good.
Thanks,
Jeff
> -Original Message-
> From: Sami Mujawar
> Sent: Thursday, September 21, 2023 10:50 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: pierre.gond...@arm.com; Swatisri Kantamsetti ;
> Ashish Singhal ; n...@arm.com
> Subject: Re: [PATCH v4 3/4]
Add API to generate a Name that contains a Unicode string buffer.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 31 +++
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 86 +++
2 files changed, 117 insertions(+)
diff --git
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 17
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 88 +++
2 files changed, 105 insertions(+)
diff --git
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 54
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 244 ++
2 files changed, 298
Add APIs needed to create thermal zones dynamically.
Does not add a generator for this as creating the TMP method generically may
be difficult.
Change log:
v4 - Fixed an additional error handling path
v3 - Fixed a couple error handling paths
v2 - renamed NameString function and added goto dones
Add API to generate a ThermalZone object to AmlLib.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 28 +
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++
2 files changed, 144 insertions(+)
diff --git
Regarding the signed-off-by I wasn't sure the right way to handle this. Vidya
was the author of this patch and applied the signed off on our internal repo
during development. I was upstreaming it on his behalf. I was unsure if I
should just replace his as I assumed just leaving his from this
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses
can be used to generate I/O packets over the PCIe bus.
Vidya Sagar (2):
DynamicTablesPkg: AML Code generation for I/O ranges
DynamicTablesPkg:
From: Vidya Sagar
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses
can be used to generate I/O packets over the PCIe bus.
Reviewed-by: Shanker Donthineni
Signed-off-by: Vidya Sagar
Signed-off-by: Jeff
From: Vidya Sagar
Add helper functions to generate AML Resource Data describing I/O
ranges of four words long. API AmlCodeGenRdQWordIo () is exposed.
Reviewed-by: Shanker Donthineni
Signed-off-by: Vidya Sagar
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 67
Add API to generate a ThermalZone object to AmlLib.
Bug 4063340
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 28 +
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 116
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Bug 4063340
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 54
Add API to add a String to a package created with NamedPackage API.
Bug 4063340
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 17
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 88
Add API to generate a Name that contains a Unicode string buffer.
Bug 4063340
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 31 +++
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 86
Add APIs needed to create thermal zones dynamically.
Does not add a generator for this as creating the TMP method generically may
be difficult.
Change log:
v3 - Fixed a couple error handling paths
v2 - renamed NameString function and added goto dones in a couple error cases
Jeff Brasen (4):
Any additional thoughts/feedback on this patch series?
Thanks,
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Friday, June 30, 2023 11:30 AM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; dandan...@intel.com;
> zhichao@intel.com; Jeff
Any thoughts/feedback on this patch?
Thanks,
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, May 15, 2023 5:49 PM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; dandan...@intel.com;
> Jeff Brasen ; Ashish Singhal
>
> Subject: [PATCH]
Ray,
Would you prefer this sort of use would be done by an extra dispatch after
the wait for everything being completed and the connect controller call in BDS
as opposed to the driver binding approach? Basically using a depex on the
library as we are currently doing.
-Jeff
>
Add API to generate a Name that contains a Unicode string buffer.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 31 +++
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 86 +++
2
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 17
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 82 +++
2
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 54 +
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 224 ++
Add APIs needed to create thermal zones dynamically.
Does not add a generator for this as creating the TMP method generically may
be difficult.
Change log:
v2 - renamed NameString function and added goto dones in a couple error cases
Jeff Brasen (4):
DynamicTablesPkg: Add ThermalZone CodeGen
Add API to generate a ThermalZone object to AmlLib.
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 28 +
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++
2 files changed, 144 insertions(+)
diff
If the system does not have ACPI setup use the configuration table
to get the performance info.
Signed-off-by: Jeff Brasen
---
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf| 1 +
.../DpDynamicCommand/DpDynamicCommand.inf | 1 +
Install the performance table into the UEFI configuration table.
This will allow the shell application to get this if the system
is not using ACPI.
Signed-off-by: Jeff Brasen
---
.../Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Systems that do not boot with ACPI (system that use device tree for example)
can not use the shell dp command. This patch adds this to the configuration
table so that dp command can get this without the FPDT table.
I am open to other ways for this to be passed if desired (Installed protocol,
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, June 29, 2023 9:59 PM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A
> Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Add support for driver
> binding
>
> External email: Use caution
Not sure why the patch failed to apply I'll see if there is something wrong
with my gitconfig tomorrow. The path you suggested below is exactly what our
current implementation does. However, I am trying to make our pcie controller
driver do async initialization so that using a depex is less
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 17
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 82
Add API to generate a Name that contains a Unicode string buffer.
Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 31 +++
.../Common/AmlLib/CodeGen/AmlCodeGen.c
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 54 +
Add APIs needed to create thermal zones dynamically.
Does not add a generator for this as creating the TMP method generically may
be difficult.
Jeff Brasen (4):
DynamicTablesPkg: Add ThermalZone CodeGen function
DynamicTablesPkg: Add support for simple method invocation.
DynamicTablesPkg:
Add API to generate a ThermalZone object to AmlLib.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 28 +
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++
2 files
Systems that do not boot with ACPI (system that use device tree for example)
can not use the shell dp command. This patch adds this to the configuration
table so that dp command can get this without the FPDT table.
I am open to other ways for this to be passed if desired (Installed protocol,
Install the performance table into the UEFI configuration table.
This will allow the shell application to get this if the system
is not using ACPI.
Signed-off-by: Jeff Brasen
---
.../Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
If the system does not have ACPI setup use the configuration table
to get the performance info.
Signed-off-by: Jeff Brasen
---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 11 ---
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf| 1 +
If the platform does not support any PCIe devices using the library
method allow devices to connect to host bridge via driver binding.
Signed-off-by: Jeff Brasen
---
.../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 649 ++
.../Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf | 1
Add EFI_NOT_READY return if the CPU can not be enabled if the
processor is already on.
This can occur in normal use if the CPU is still being turned off from
a previous call when this is called again.
Signed-off-by: Jeff Brasen
---
ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 4
Add PCD to control if modules with start addresses in PE/COFF > 0x10
attempt to load at specified address.
If a module has an address in this range and there is untested memory
DxeCore will attempt to promote all memory to tested which bypasses any
memory testing that would occur later in
Nothing to do here for virtio 1.0 devices
Signed-off-by: Jeff Brasen
---
.../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
Reviewed-by: Jeff Brasen
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Thursday, March 9, 2023 8:33 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; Alexei Fedorov
> ; Jeff Brasen
> Subject: [PATCH 1/1] DynamicTablesPkg/SsdtCpuTopology: Allow multi-
> packages
The changes on your branch seem pretty good to me
> -Original Message-
> From: Pierre Gondois
> Sent: Monday, February 6, 2023 2:28 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: sami.muja...@arm.com; alexei.fedo...@arm.com;
> quic_llind...@quicinc.com; ardb+tianoc...@kernel.org
>
on UEFI Spec, would you consider those option roms to be non-
> conformant?
>
> Mike
>
> > -Original Message-----
> > From: devel@edk2.groups.io On Behalf Of Jeff
> > Brasen via groups.io
> > Sent: Friday, February 10, 2023 12:43 PM
> > To: Kinney,
t; External email: Use caution opening links or attachments
>
>
> Did your original approach work for all your use cases?
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Jeff
> > Brasen via groups.io
> > Sent: Frid
>
> Thanks,
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Jeff
> > Brasen via groups.io
> > Sent: Thursday, February 9, 2023 2:03 PM
> > To: Demeter, Miki
> > Cc: devel@edk2.groups.io
> > Subject:
Here is a patch that has been pending for a bit
Thanks,
Jeff
-Original Message-
From: Jeff Brasen
Sent: Wednesday, February 1, 2023 9:21 AM
To: devel@edk2.groups.io
Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; guomin.ji...@intel.com
Subject: RE: [PATCH v2]
In SSDT CPU topology generator allow for multiple top level physical
nodes as would be seen with a multi-socket system. This will create a
top level processor container for all systems.
Signed-off-by: Jeff Brasen
---
.../SsdtCpuTopologyGenerator.c| 43 ++-
To solve that problem I had added support for allowing the UID/Name to come
from the node
https://github.com/tianocore/edk2/commit/5fb3f5723a1ea9d9a93e317181e1c11468a9eb45
> -Original Message-
> From: Pierre Gondois
> Sent: Friday, February 3, 2023 9:28 AM
> To: Jeff Brasen ;
I'll on an updated patch this morning that only does the new behavior. We can't
reset the procindex as it is used for the _UID as well and we would end up with
the same value in two nodes.
-Jeff
> -Original Message-
> From: Pierre Gondois
> Sent: Friday, February 3, 2023 6:11 AM
>
There are some cases (for example the _PSL list in thermal zones) where we need
to have a reference to the node and we have been doing that via an Extern and a
reference to the node path. I am push a patch where the effectively the PCD I
added was fixed true but was unsure if that would have
Just to clarify you are suggesting that all CPU nodes generated via this with
have an outer processor container? I am fine with that but was concerned with a
change in behavior to other platforms in case they are expecting the CPUs to
just be under \SB.C00x instead of \SB.C000.C00x
-Jeff
>
In SSDT CPU topology generator allow for multiple top level physical
nodes as would be seen with a multi-socket system. This will be auto
detected if there are more then one physical device and there is a
new PCD to enable forcing of a top level processor container to allow
for consistency for
Any updates on this would be great to get this in for the next stable release
if possible.
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, December 12, 2022 12:27 PM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn;
> guomin.ji...@intel.com; Jeff
Skip error check if HardwareInstance is 0 as this either means that
FmpVersion < 3 and not supported or,
"A zero means the FMP provider is not able to determine a
unique hardware instance number or a hardware instance number
is not needed." per UEFI specification.
As the FmpInstances are merged
Skip error check if HardwareInstance is 0 as this either means that
FmpVersion < 3 and not supported or,
"A zero means the FMP provider is not able to determine a
unique hardware instance number or a hardware instance number
is not needed." per UEFI specification.
As the FmpInstances are merged
_LPI Revision should be 0 per the ACPI 6.5 specification.
"The revision number of the _LPI object. Current revision is 0."
Signed-off-by: Jeff Brasen
---
.../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This was the simplest approach that I had to solve this issue, but not sure if
it would be better to do something smarter. A couple other ideas I had where:
- Specify the affinity level that CPUs use and use the levels above that for
the containers.
- Have a new object that has the container
Allow object to specify the name of processor and processor container
nodes and the UID of processor containers.
This allows these to be more accurately referenced from other tables.
For example for the _PSL method or the UID in the APMT table.
The UID and Name for processor container may
This adds #defines and struct typedefs for the various node types in
the ACPI Arm Performance Monitoring Unit (APMT) table.
Signed-off-by: Jeff Brasen
---
MdePkg/Include/IndustryStandard/Acpi64.h | 5 ++
.../ArmPerformanceMonitoringUnitTable.h | 69 +++
2
Add a new parser for the Arm Performance Monitoring Unit Table.
The APMT table describes the properties of PMU support
implemented by components in an Arm-based system.
Signed-off-by: Jeff Brasen
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 21
.../Parsers/Apmt/ApmtParser.c
This adds #defines and struct typedefs for the various node types in
the ACPI Arm Performance Monitoring Unit (APMT) table.
Signed-off-by: Jeff Brasen
---
MdePkg/Include/IndustryStandard/Acpi64.h | 5 ++
.../ArmPerformanceMonitoringUnitTable.h | 69 +++
2
Add a new parser for the Arm Performance Monitoring Unit Table.
The APMT table describes the properties of PMU support
implemented by components in an Arm-based system.
Signed-off-by: Jeff Brasen
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 21
.../Parsers/Apmt/ApmtParser.c
Add support for getting disk info from UFS devices.
Signed-off-by: Jeff Brasen
---
MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 4 +++-
.../Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git
; >
> > External email: Use caution opening links or attachments
> >
> >
> > Jeff:
> > I want to confirm why UFS apply the same rule to SCSI. Does UFS
> > follows SCSI spec?
> >
> > Thanks
> > Liming
> > > -邮件原件-
> >
rnel.org
> Subject: Re: [edk2-devel] [PATCH v2]
> MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer
>
> External email: Use caution opening links or attachments
>
>
> On Wed, 21 Sept 2022 at 18:27, Jeff Brasen via groups.io
> wrote:
>
Those changes look good to me.
Thanks,
Jeff
> -Original Message-
> From: Sami Mujawar
> Sent: Friday, September 23, 2022 10:55 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: ardb+tianoc...@kernel.org; alexei.fedo...@arm.com;
> pierre.gond...@arm.com; n...@arm.com
> Subject: Re:
Update check for enough space to occur prior to alignment offset.
This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom.
Signed-off-by: Jeff Brasen
---
.../MemoryAllocationLib.c | 48 ---
1 file changed, 21 insertions(+), 27 deletions(-)
Update check for enough space to occur prior to alignment offset.
This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom.
Change-Id: I58c5d378523c881a4afc655e7ace4c009130c781
---
.../MemoryAllocationLib.c | 48 ---
1 file changed, 21
_CPC entries can describe CPU performance information.
The object is described in ACPI 6.4 s8.4.7.1.
"_CPC (Continuous Performance Control)".
Add AmlCreateCpcNode() helper function to add _CPC entries to an
existing CPU object.
Signed-off-by: Jeff Brasen
---
Add code to use a token attached to GICC to generate _CPC object on cpus.
Signed-off-by: Jeff Brasen
---
.../SsdtCpuTopologyGenerator.c| 133 +-
1 file changed, 127 insertions(+), 6 deletions(-)
diff --git
Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects.
This allows to describe CPC information, as described in ACPI 6.4,
s8.4.7.1 "_CPC (Continuous Performance Control)".
Signed-off-by: Jeff Brasen
---
.../Include/ArmNameSpaceObjects.h | 60 ++---
Add generator for creating the _CPC object for CPU nodes.
If viewing this review by a pull request is helpful one exists here:
https://github.com/NVIDIA/edk2/pull/12
Change Log:
v1 - Initial Revision
v2 - Added revision to object, improved error handling, changed to ACPI 6.4
structures.
v3 -
1 - 100 of 211 matches
Mail list logo
