From: Ni, Ray
Sent: Sunday, August 11, 2024 10:50 PM
To: Kun Qin ; devel@edk2.groups.io
Cc: Wu, Jiaxin ; Tan, Dun ; Xu, Wei6
; Zhang, Hongbin1 ; Kinney,
Michael D ; Zimmer, Vincent
Subject: [EXTERNAL] Re: Proposing v3 of MM communicate buffer
Kun,
This PR (Mm infra by
(32 or 64
bit, Intel or AMD) and communicate under the new definition of data structure
and PPI.
Please let me know your thoughts. Your feedback is really appreciated!
Regards,
Kun
From: Ni, Ray
Sent: Thursday, August 8, 2024 8:48 PM
To: Kun Qin ; devel@edk2.groups.io
Cc: Wu, Jiaxin ; Tan, Du
ain/MmSupervisorPkg/Drivers/MmPeiLaunchers/MmIplX64Relay.inf>.
We can upstream it to edk2 if folks think it will help.
From: Ni, Ray
Sent: Thursday, August 8, 2024 1:15 AM
To: devel@edk2.groups.io; Kun Qin
Cc: Wu, Jiaxin ; Tan, Dun ; Xu, Wei6
; Zhang, Hongbin1 ; Ni, Ray
; Kinney, Michael D
S
Adding stakeholders.
Regards,
Kun
From: Kun Qin
Sent: Wednesday, August 7, 2024 11:15 AM
To: devel@edk2.groups.io
Subject: Proposing v3 of MM communicate buffer
Hi all,
I am trying to propose a change into PI spec and would like to gather some
feedback in this forum.
Essentially, the current
Hi all,
I am trying to propose a change into PI spec and would like to gather some
feedback in this forum.
Essentially, the current communicate header contains a UINTN field in place,
which is causing programing
errors when trying to communicate the message between different operation mode
(i.
but does this routine
still run properly if variable PEIM is loaded much later than memory discovered?
Regards,
Kun
From: Ni, Ray
Sent: Friday, May 17, 2024 5:10 AM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Liming Gao ; Kun Qin ;
Sean Brogan
Subject: [EXTERNAL] Re: [PATCH 7/9] MdeMod
: Dandan Bi
Cc: Debkumar De
Cc: Catharine West
Co-authored-by: John Schock
Signed-off-by: Kun Qin
---
Notes:
v2:
- Fix up author
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Pei/Dispatcher
delayed dispatch callbacks.
Cc: Jian J Wang
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Catharine West
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
Notes:
v2:
- Fixed function documentation [Liming]
- Removed GUID declaration internal to PEI core [Liming
spec.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
Notes:
v2:
- Fixed PI spec version number to v1.8 [Liming]
MdePkg/Include/Ppi/DelayedDispatch.h | 26 ++--
1 file changed, 24 insertions(+), 2 deletions
type.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
Notes:
v2:
- No review, no change.
MdePkg/Include/Ppi/DelayedDispatch.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/MdePkg
- Removed max entry PCD declaration and use macro instead
Patch branch: https://github.com/kuqin12/edk2/tree/Delayed_Dispatch_v3
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jian J Wang
Cc: Dandan Bi
Cc: Debkumar De
Cc: Catharine West
Kun Qin (4):
MdePkg: DelayedDispatch
e:
On Wed, 26 Jul 2023 at 20:45, Kun Qin wrote:
Hi Ard,
Our current use case is around AP core suspension and wake-ups.
The program can suspend the secondary cores through PSCI interfaces
(after powering
them on). BSP can then wake up the suspended cores through SGI on
demand.
The
after your input
on those.
Thanks,
Kun
On 7/24/2023 7:17 PM, gaoliming via groups.io wrote:
Kun:
I add my comments below.
-邮件原件-
发件人: Kun Qin
发送时间: 2023年7月21日 5:07
收件人:devel@edk2.groups.io
抄送: Jian J Wang; Dandan Bi
; Liming Gao;
Debkumar De; Catharine West
; Mike Turner
主题: [PATCH
Biesheuvel wrote:
On Mon, 24 Jul 2023 at 22:15, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466
This patch series introduce a few improvements related to interrupt
handling for ArmGic driver and library.
1. The current implementation of the `ArmGicSendSgiTo` is based on GIC v2
: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Kun Qin
---
ArmPkg/Drivers/ArmGic/ArmGicLib.c | 162
ArmPkg/ArmPkg.ci.yaml | 2 +
ArmPkg/Include/Library/ArmGicLib.h | 49 ++
3 files changed, 213 insertions(+)
diff --git a/ArmPkg/Drivers
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466
This change extended the existing function `ArmGicSendSgiTo` of ArmGicLib
to format the incoming parameters to comply with GICv3 and GICv4 spec,
and signal software generated interrupts to non secure group 1 at EL1.
Cc
/kuqin12/edk2/tree/improve_gic_v1
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Kun Qin (3):
ArmPkg: ArmGic: Added support to send SGI to NS G1 EL1
ArmPkg: ArmGicLib: Added GIC v3 and v4 support to ArmGicSendSgiTo
ArmPkg: ArmGic: Added functionalities to manipulate pending interrupts
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466
This change extended the functionality of ArmGic to support sending
software generated interrupts to non-secure group 1 at EL1.
The change made here follows the ARM documentation `ICC_SGI1R_EL1,
Interrupt Controller
delayed dispatch callbacks.
Cc: Jian J Wang
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Catharine West
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 353
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 3
: Dandan Bi
Cc: Debkumar De
Cc: Catharine West
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
b/MdeModulePkg/Core/Pei
type.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
MdePkg/Include/Ppi/DelayedDispatch.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/MdePkg/Include/Ppi/DelayedDispatch.h
b/MdePkg/Include
spec.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Co-authored-by: Mike Turner
Signed-off-by: Kun Qin
---
MdePkg/Include/Ppi/DelayedDispatch.h | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Ppi/DelayedDispatch.h
b/MdePkg
: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jian J Wang
Cc: Dandan Bi
Cc: Debkumar De
Cc: Catharine West
Kun Qin (4):
MdePkg: DelayedDispatch: Correct PPI descriptions
MdePkg: DelayedDispatch: Added WaitOnEvent interface
MdeModulePkg: PeiMain: Introduce implementation of
Hi Pierre,
Thanks for sending this update. I tested the v5 patch series and
verified it booted
to Windows.
Tested-by: Kun Qin
Regards,
Kun
On 7/18/2023 4:51 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v5:
- Let an implementation of BaseRngLibTimer in MdePkg to give some
*From:* Kun Qin
*Sent:* 11 July 2023 20:22
*To:* devel@edk2.groups.io ; Nishant Sharma
*Cc:* Ard Biesheuvel ; Sami Mujawar
; Thomas Abraham ;
Sayanta Pattanayak ; Achin Gupta
; Aditya Angadi
*Subject:* Re: [edk2-devel] [edk2-platforms][PATCH V1 19/20]
ArmPkg
Hi Nishant,
Thank you for sending out the patch. Can you please evaluate how much
effort it would be
to support the same for MmCommunicatePei? I think it would provide
better coverage for
the FFA support if we can have that change.
Thanks,
Kun
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
Fro
e the changes made in response to
his v1 request so we'll need to get that before merging the patch.
Thanks,
Michael
On 6/30/2023 2:14 PM, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467
Current implementation of UnitTestFrameworkPkg for shell-based unit test
will sav
Hi Sami, Jiewen & Jian,
Just a gentle ping on this.
Could you please provide further feedback on this patch and/or merge the
patch?
Thanks in advance!
Regards,
Kun
On 7/3/2023 1:09 PM, Kun Qin via groups.io wrote:
Hi Sami,
Would you prefer to have input from Jiewen or Jian to review
Hi Pierre,
Thanks for sending the update. I tested on QEMU with this change (no
TRNG from TFA), it works for me.
Tested-by: Kun Qin
Please note that the change below is still needed to avoid data abortion
exception. It will be helpful if one
of the maintainers can help merging it.
[PATCH
Hi Sami,
Would you prefer to have input from Jiewen or Jian to review this patch
as well?
Otherwise, would you mind helping me to merge the change?
Thanks in advance!
Regards,
Kun
On 6/29/2023 4:59 PM, Kun Qin via groups.io wrote:
From: Kun Qin
REF: https://bugzilla.tianocore.org
` shell argument to allow
even more flexibility.
This change was tested on proprietary physical hardware platforms and
QEMU based virtual platform.
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
Signed-off-by: Kun Qin
---
Notes:
v2:
- Adding input argument [Mike Kinney
updated changes are verified on QEMU based Q35 virtual platform as
well as proprietary physical platforms.
Patch v3 branch: https://github.com/kuqin12/edk2/tree/unit_test_fv_v3
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Sean Brogan
Kun Qin (1):
UnitTestFrameworkPkg: UnitTestPersistenceLib: Save
touching 2 packages in
one commit?
Thanks,
Kun
On 6/30/2023 7:30 AM, Pierre Gondois wrote:
Hello Kun,
On 6/29/23 22:36, Kun Qin wrote:
This patch seems to have some discrepancy between the title and
content :)
I'm not sure I see the discrepancy between the title/content,
should I
/message/104347
- Added reviewed-by tag
This change is verified on QEMU based ARM SBSA system.
Patch v2 branch: https://github.com/kuqin12/edk2/tree/fix_rng_edk2_v2
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Sami Mujawar
Cc: Pierre Gondois
Kun Qin (1):
SecurityPkg: RngDxe: Fixing mAvailableAlgoArray
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491
mAvailableAlgoArray is currently allocated for "RNG_AVAILABLE_ALGO_MAX"
number of bytes, whereas it was dereferenced as "EFI_RNG_ALGORITHM".
This change fixed the buffer allocation logic by allocat
Hi Sami,
Your suggestion in https://edk2.groups.io/g/devel/message/106511 works
properly during my test.
But I think we still need to keep the `+ &RngGuid, ` change below
as a bug fix?
Thanks,
Kun
On 6/29/2023 3:28 AM, Sami Mujawar wrote:
Hi Pierre,
I think this patch would not be r
This patch seems to have some discrepancy between the title and content :)
Can you please break this patch into 2, so that MdePkg change and
SecurityPkg can be their
own commit?
Thanks,
Kun
On 5/9/2023 12:40 AM, PierreGondois wrote:
From: Pierre Gondois
In order to use PcdCpuRngSupportedAl
Hi Pierre,
Do we really need this removal of ASSERT? I tried to use the real
ArmTrngLib with this patch
and it seems to work fine with a TFA that does not support TRNG interfaces.
I think it would be valuable to keep the ASSERT to indicate there might
be an integration error?
Please let me
:
Hello Kun,
Thanks for the patch-set, there is another patch-set that also aims to
fix the logic at:
https://edk2.groups.io/g/devel/message/104341
but I haven't got feedback so far. Would it be possible to try it out
to see if
it also solves your issue ?
Regards,
Pierre
On 6/28/23 22:33, Ku
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491
mAvailableAlgoArray is currently allocated for "RNG_AVAILABLE_ALGO_MAX"
number of bytes, whereas it was dereferenced as "EFI_RNG_ALGORITHM".
This change fixed the buffer allocation logic by allocat
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491
The existing logic of initializing `mAvailableAlgoArrayCount` will treat
the zero GUID in `PcdCpuRngSupportedAlgorithm` as a legit case and
increment `mAvailableAlgoArrayCount`, causing the RNG protocol be
published
ge is verified on QEMU
virtual platform and proprietary physical platform.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/fix_rng_edk2_v1
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Sami Mujawar
Cc: Pierre Gondois
Kun Qin (2):
SecurityPkg: RngDxe: Unify handling of zero guid
Thank you so much for the quick turnaround!
Regards,
Kun
On 6/28/2023 11:44 AM, Ard Biesheuvel wrote:
On Wed, 28 Jun 2023 at 01:14, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This patch series is a follow-up of previous submission:
https://edk2.groups.io/g/devel
pi". This was because the "Ppi"
field inside
"EFI_PEI_PPI_DESCRIPTOR" was defined as "VOID*" and not doing so will
cause the build
failure.
Please let me know if you have further feedback. Thanks in advance.
Regards,
Kun
On 6/27/2023 7:36 AM, Ard Biesheuvel wrot
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the Standalone MM based variable read capability
in PEI phase for applicable platforms (such as ARM platforms).
Similar to the x86 counterpart, MM communicate PPI is used to request
variable
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the MM communicate support in PEI phase for ARM
based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is
used as communicate buffer and SMC will be invoked to communicate to
TrustZone when
: Sami Mujawar
Kun Qin (2):
ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI
MdeModulePkg: Variable: Introduce MM based variable read service in
PEI
ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 221
MdeModulePkg/Universal/Variable/MmVariablePei
Liming
-邮件原件-
发件人: devel@edk2.groups.io 代表 Kun Qin
发送时间: 2023年6月9日 4:45
收件人: devel@edk2.groups.io
抄送: Hao A Wu ; Liming Gao
; Jian J Wang ; Ronny
Hansen ; Shriram Masanamuthu
Chinnathurai ; Preshit Harlikar
主题: [edk2-devel] [PATCH v1 2/2] MdeModulePkg: Variable: Introduce MM
based
response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/06/2023 09:44 pm, Kun Qin wrote:
From: Kun Qin
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the MM communicate support in PEI phase for ARM
based platforms. Similar to the DXE counterpart, `PcdMmBufferBase
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the Standalone MM based variable read capability
in PEI phase for applicable platforms (such as ARM platforms).
Similar to the x86 counterpart, MM communicate PPI is used to request
variable
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the MM communicate support in PEI phase for ARM
based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is
used as communicate buffer and SMC will be invoked to communicate to
TrustZone when
ndholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Kun Qin (2):
ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI
MdeModulePkg: Variable: Introduce MM based variable read service in
PEI
ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 212
+++
MdeModulePkg
Thanks a lot, Sami!
On 6/22/2023 12:06 AM, Sami Mujawar wrote:
Hi Kun,
Apologies for the delay in reviewing.
I will take a look at this series shortly and get back.
Regards,
Sami Mujawar
On 22/06/2023, 06:07, "Kun Qin" mailto:kuqi...@gmail.com>>
wrote:
Hi Arm and M
Also, a gentle ping on this topic. Could any maintainer help reviewing
this change?
Any feedback is appreciated.
Regards,
Kun
On 6/6/2023 6:07 PM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467
This is a follow-up of a previously submitted patch series
/16/2023 4:38 PM, Kun Qin via groups.io wrote:
Hi Mike,
Thank you for the rb tag. Could you please help merging the change if
you have a chance?
If it is preferable to send a v3 with your extra tag, please let me
know as well.
Thanks,
Kun
On 6/14/2023 3:31 PM, Michael D Kinney wrote
Hi Arm and MdeModule package maintainers,
This patch series has been sent out for almost 2 weeks without any reviews.
Could you please provide feedback on the change when you have a chance?
Any input is appreciated.
Regards,
Kun
On 6/8/2023 1:44 PM, Kun Qin via groups.io wrote:
REF: https
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kun Qin
Sent: Thursday, June 8, 2023 11:25 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Wang, Jian J
; Zhang, Qi1 ; Kumar, Rahul R
; Kinney, Michael D ;
Gao, Liming ; Liu, Zhiguang
Subject: [edk2-devel] [PATCH v2 0/3] Adding Status Code
Hi EDK2 maintainers,
This patch series was reviewed the week before and was not merged. Could
you please help merging this when you have a chance?
Thanks in advance.
Regards,
Kun
On 6/8/2023 11:25 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794
REF
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the Standalone MM based variable read capability
in PEI phase for applicable platforms (such as ARM platforms).
Similar to the x86 counterpart, MM communicate PPI is used to request
variable
code, thus will be ideally added to MdeModulePkg.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/arm_var_pei_v1
Cc: Hao A Wu
Cc: Liming Gao
Cc: Jian J Wang
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Kun Qin (2):
ArmPkg: MmCommunicationPei: Introduce MM communic
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464
This change introduced the MM communicate support in PEI phase for ARM
based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is
used as communicate buffer and SMC will be invoked to communicate to
TrustZone when
-by: Kun Qin
Reviewed-by: Jiewen Yao
Reviewed-by: Liming Gao
---
Notes:
v2:
- Added reviewed-by tag [Jiewen]
- Added reviewed-by tag [Liming]
SecurityPkg/SecurityPkg.dec | 6 +++---
SecurityPkg/SecurityPkg.uni | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
to another.
These error codes could provide helpful datapoints to OEMs to investigate
and prevent system failures in general.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Kun Qin
Reviewed-by: Liming Gao
---
Notes:
v2:
- Added reviewed-by tag [Liming]
MdePkg
provide helpful datapoints to OEMs to analyze
system security state and healthiness, as well as avoid definition
collision with other existing peripheral subclass definitions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Kun Qin
Reviewed-by: Liming Gao
---
Notes:
v2
and no other changes.
Patch v2 branch: https://github.com/kuqin12/edk2/tree/pi_v1p8_v2
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Kun Qin (3):
MdePkg: PiStatusCode: Add new Host Software class Error Code to MdePkg
Forgot to add applicable maintainers earlier..
It would be great if StandaloneMmPkg maintainers could shed some light here.
Thanks,
Kun
On 6/6/2023 5:57 PM, Kun Qin via groups.io wrote:
Hi all,
We found an issue a while back on ARM systems, where the Standalone MM
drivers with Depex
.
Thanks,
Kun
On 6/1/2023 6:18 PM, gaoliming via groups.io wrote:
Reviewed-by: Liming Gao
-邮件原件-
发件人: Kun Qin
发送时间: 2023年6月2日 2:30
收件人: devel@edk2.groups.io
抄送: Jiewen Yao ; Jian J Wang
; Qi Zhang ; Rahul Kumar
; Michael D Kinney ;
Liming Gao ; Zhiguang Liu
主题: [PATCH v1 0/3] Adding Statuc
function can look for UEFI Shell arguments and if args specify
alternate path
for unit test cache then save some state for that path.
Mike
-Original Message-
From: Kun Qin
Sent: Thursday, June 1, 2023 8:50 AM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Sean Brogan ; Michael
` shell argument to allow
even more flexibility.
This change was tested on proprietary physical hardware platforms and
QEMU based virtual platform.
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
Signed-off-by: Kun Qin
---
Notes:
v2:
- Adding input argument [Mike Kinney
.
The updated changes are verified on QEMU based Q35 virtual platform as
well as proprietary physical platforms.
Patch v2 branch: https://github.com/kuqin12/edk2/tree/unit_test_fv_v2
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Sean Brogan
Kun Qin (1):
UnitTestFrameworkPkg
Hi all,
We found an issue a while back on ARM systems, where the Standalone MM
drivers with Depex specified will run into a hang when TFA hands off to
Standalone MM core. (https://bugzilla.tianocore.org/show_bug.cgi?id=3883)
After some debugging, the logic in the ticket still seems to be true
un
provide helpful datapoints to OEMs to analyze
system security state and healthiness, as well as avoid definition
collision with other existing peripheral subclass definitions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Kun Qin
---
MdePkg/Include/Pi/PiStatusCode.h | 1 +
1
to another.
These error codes could provide helpful datapoints to OEMs to investigate
and prevent system failures in general.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Kun Qin
---
MdePkg/Include/Pi/PiStatusCode.h | 41 ++--
1 file changed, 21
-by: Kun Qin
---
SecurityPkg/SecurityPkg.dec | 6 +++---
SecurityPkg/SecurityPkg.uni | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 0a8042d63fe1..53aa7ec43557 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b
Cc: Zhiguang Liu
Kun Qin (3):
MdePkg: PiStatusCode: Add new Host Software class Error Code to MdePkg
MdePkg: PiStatusCode: Add TPM subclass definition to MdePkg
SecurityPkg: SubClassTpm: Updated default value
MdePkg/Include/Pi/PiStatusCode.h | 42 ++--
SecurityPkg
-Original Message-
From: Kun Qin
Sent: Thursday, June 1, 2023 8:50 AM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Sean Brogan ; Michael Kubacki
Subject: Re: [PATCH v1 1/1] UnitTestFrameworkPkg: UnitTestPersistenceLib:
Save Unit Test Cache to Drive
Hi Mike,
Yes, that would indeed serve the
?
Mike
-Original Message-
From: Kun Qin
Sent: Wednesday, May 31, 2023 12:14 PM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Michael Kubacki
; Kinney, Michael D
Subject: [PATCH v1 1/1] UnitTestFrameworkPkg: UnitTestPersistenceLib: Save
Unit Test Cache to Drive
From: kuqin12 <42554914+k
rdware platforms and
QEMU based virtual platform.
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
Signed-off-by: Kun Qin
---
UnitTestFrameworkPkg/Library/UnitTestPersistenceLibSimpleFileSystem/UnitTestPersistenceLibSimpleFileSystem.c
| 81 +++-
1 file changed, 43 inse
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467
Current implementation of UnitTestFrameworkPkg for shell-based unit test
will save the unit test cache to the same file system as the test
application itself. This works as long as the test application is on a
writable volume, such as USB or
wrote:
Hi Kun,
I've updated my answers in your original mail.
Thanks,
Dun
-Original Message-
From: Kun Qin
Sent: Saturday, May 20, 2023 10:00 AM
To: devel@edk2.groups.io; Tan, Dun
Cc: Dong, Eric ; Ni, Ray ; Kumar,
Rahul R ; Gerd Hoffmann
Subject: Re: [edk2-devel] [Patch V4
validation process.
Thanks,
Kun
On 5/23/2023 2:14 AM, duntan wrote:
Hi Kun,
I've updated my answers in your original mail.
Thanks,
Dun
-Original Message-
From: Kun Qin
Sent: Saturday, May 20, 2023 10:00 AM
To: devel@edk2.groups.io; Tan, Dun
Cc: Dong, Eric ; Ni, Ray ; Kumar, Ra
Hi Dun,
Thanks for the notice on the other thread (v4 04/15).
I have a few more questions on this specific patch (and a few associated
commits related to it):
Why would we allow page table manipulation after `mIsReadOnlyPageTable`
is evaluated to TRUE?
As far as I can tell, `mIsReadOnlyPag
Hi Dun,
I might have missed the context, but could you please explain why we
need to clear "EFI_MEMORY_XP"?
It is understandable that you would like to clear RO. But would it make
more sense to clear XP only when needed (i.e. code page allocation)?
Thanks,
Kun
On 5/16/2023 2:59 AM, duntan
From: Sean Brogan
Create SECURITY.md security policy for tianocore edk2 leveraging CVD and
the Github Private Vulnerability Reporting process.
Co-authored-by: Sean Brogan
Signed-off-by: Kun Qin
---
SECURITY.md | 33
1 file changed, 33 insertions(+)
diff --git a
This change added a markdown file as a policy guideline for Tianocore EDK2
community to handle security sensitive reports.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/patch-1
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Miki Demeter
Cc: Sean Brogan
Sean Brogan (1):
Thanks for sharing the updated patches. I tested the patches on both
QEMU and FVP, they work
for all my use cases.
Although my vote probably does not mean much, thanks again for sharing
this update:
Tested-by: Kun Qin
On 1/16/2023 8:57 PM, Rebecca Cran wrote:
Implement
added some comments under [KQ-3].
Please let me know if any thoughts about them. Sorry again for the
fragmented email.
Regards,
Kun
On 1/6/2023 2:16 PM, Kun Qin wrote:
Sorry, hit the send button too soon... One more comment under [KQ-2].
Thanks,
Kun
On 1/6/2023 2:11 PM, Kun Qin via
Hi Rebecca,
Thanks for sharing this patch. I found a few minor issues when running
this test app. Please see comments with [KQ] below.
Regards,
Kun
On 1/4/2023 7:37 AM, Rebecca Cran wrote:
The MpServicesTest application exercises the EFI_MP_SERVICES_PROTOCOL.
usage:
MpServicesTest -A [-O
Sorry, hit the send button too soon... One more comment under [KQ-2].
Thanks,
Kun
On 1/6/2023 2:11 PM, Kun Qin via groups.io wrote:
Hi Rebecca,
I have tried to use this for a few different scenarios and below is a
few minor issues I have found and potential
changes (marked with [KQ]). Please
Hi Rebecca,
I have tried to use this for a few different scenarios and below is a
few minor issues I have found and potential
changes (marked with [KQ]). Please let me know if I have any
misunderstanding on the protocol itself.
Thanks,
Kun
On 1/4/2023 7:37 AM, Rebecca Cran wrote:
Add suppor
Hi Rebecca,
Thanks for the information. Somehow these patches (i.e.
https://edk2.groups.io/g/devel/message/98106) just landed on groups.io
last night.
I will test the latest version of your patches and reply back here.
Regards,
Kun
On 1/6/2023 10:42 AM, Rebecca Cran wrote:
The patches aren'
Hi Ard/Rebecca,
Thanks for bringing this to the mailing list. But somehow I cannot find
the patches sent along with this
v4 cover letter. Could you please point me to them?
I have been running the previous version of this patch and noticed a
minor issue when the wait event is
specified but th
Thanks for the update, Rebecca. I will also keep an eye on the cache
issue when I have a chance to run this on FVP models.
Regards,
Kun
On 11/28/2022 4:04 PM, Rebecca Cran wrote:
On 11/28/22 15:59, Kun Qin wrote:
Hi Rebecca/Ard,
I was trying to reach out regarding the original patches
let me
know if you have other concerns:
https://github.com/kuqin12/mu_silicon_arm_tiano/commit/c76072b37018276f2fec2582d0c540be5b40d0f2
Lastly, do you plan to merge these patches in the near future? This will
be a great add-on for ARM platforms.
Thanks,
Kun
On 9/29/2022 11:45 AM, Kun Qi
Hi Rebecca,
Thanks for sending this patch. I have a few questions inline "[KQ]".
Could you please help me to
understand the patch better? Thanks in advance.
Regards,
Kun
On 8/29/2022 8:59 AM, Rebecca Cran wrote:
Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under
AArch64.
PS
d like me to send a v2 patch?
Regards,
Kun
On 09/22/2022 04:26, Bob Feng wrote:
Create PR https://github.com/tianocore/edk2/pull/3378 for merge.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Thursday, September 22, 2022 7:11 PM
To: Kun Qin ; devel@edk2.gro
Currently the BaseTool build step is failing and caused the pipeline to
malfunciton.
The issue is due to the environment path too long during the build
process and adding VC toolchain path to the environment variable will
fail due to Windows varaible length limit.
Patch v1 branch: https://github.
to
replace the existing path, which is desirable in the specific use case.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Co-authored-by: Sean Brogan
Signed-off-by: Kun Qin
---
BaseTools/Edk2ToolsBuild.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools
M, Ard Biesheuvel wrote:
On Mon, 13 Dec 2021 at 19:23, Kun Qin wrote:
Hi ArmPkg and MdeModulePkg maintainers,
Now that the hard freeze is lifted, could you please provide some
feedback on these patches when you have a chance?
My apologies for not responding to these changes.
If these patches are
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/08/2022 11:28 pm, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
This patch series is a follow-up of
1 - 100 of 514 matches
Mail list logo
