Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

On 10/27/23 18:27, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580 > > This BZ has been created to provide the sample python scripts > to demonstrate the socket client capabilities using http library > on UEFI shell with the help of Python UEFI interpreter. > The h

[edk2-devel] EDK II Release Planning: update content for edk2-stable202311

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#edk2-stable202311-tag-planning I've scanned the edk2 git commit range edk2-stable202308..f945b72331d7, and collected (and when necessary, closed/updated) TianoCore BZs. When TianoCore BZs were not available, I tried capt

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 17:21, Ard Biesheuvel wrote: > On Thu, 26 Oct 2023 at 17:19, Laszlo Ersek wrote: >> >> On 10/26/23 16:21, Peter Maydell wrote: >>> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>>> On 10/10/23 09:43, Ard Biesheuvel wrote: >>>&g

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

On 10/26/23 15:41, Laszlo Ersek wrote: > On 10/25/23 13:42, Yuanhao Xie wrote: >> Aim: >> - To solve the assertion that checks if CpuMpData->FinishedCount >> equals (CpuMpData->CpuCount - 1). The assertion arises from a timing >> discrepancy between the BSP'

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

On 10/26/23 18:19, Laszlo Ersek wrote: > On 10/26/23 15:53, Neal Gompa wrote: >> From: Neal Gompa >> >> Currently, the ReadyToBoot event is only signaled when a formal Boot >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). >> >> Howe

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

On 10/26/23 14:37, jacopo.r0...@gmail.com wrote: > Hi there, > > I was trying to HTTPs boot a virtual machine with the following scenario: > > 1) I have a self signed root CA /root.crt /and then I use it to sign > another self signed certificate /myip.crt /for the IP address X.X.X.X > 2) I have a

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

On 10/26/23 15:53, Neal Gompa wrote: > From: Neal Gompa > > Currently, the ReadyToBoot event is only signaled when a formal Boot > Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). > > However, the introduction of Platform Recovery in UEFI 2.5 makes it > necessary to signal Read

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

dLib/realpath.c > @@ -34,7 +34,7 @@ > **/ > char * > realpath( > - char *file_name, > + const char *file_name, >char *resolved_name >) > { Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply On

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 16:55, Ard Biesheuvel wrote: > On Thu, 26 Oct 2023 at 16:46, Julien Grall wrote: >> >> Hi, >> >> On 26/10/2023 15:21, Peter Maydell wrote: >>> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>>> On 10/10/23 09:43, Ard Biesheuv

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 16:46, Julien Grall wrote: > Hi, > > On 26/10/2023 15:21, Peter Maydell wrote: >> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>> On 10/10/23 09:43, Ard Biesheuvel wrote: >>>> Thanks for looking into this - a cleanup was overdue here. >>

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 16:21, Peter Maydell wrote: > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >> On 10/10/23 09:43, Ard Biesheuvel wrote: >>> Thanks for looking into this - a cleanup was overdue here. >>> >>> I will take a look in more detail later, but on

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

On 10/25/23 13:42, Yuanhao Xie wrote: > Aim: > - To solve the assertion that checks if CpuMpData->FinishedCount > equals (CpuMpData->CpuCount - 1). The assertion arises from a timing > discrepancy between the BSP's completion of startup signal checks and > the APs' incrementation of the FinishedCou

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

ff); > - ASSERT (CpuMpData->FinishedCount == (CpuMpData->CpuCount - 1)); > + // > + // Wait for all APs finished initialization > + // > + while (CpuMpData->FinishedCount < (CpuMpData->CpuCount - 1)) { > +CpuPause (); > + } > >// &

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

e: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove >> Isaac Oram's email address >> >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> On Wed,

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Uncrustify on C source files

, >"%a: RequestDataSize == 0, however RequestData is not NULL for PLDM > type: 0x%x, Command: 0x%x.\n", > @@ -85,7 +85,7 @@ PldmSubmitCommand ( > return EFI_INVALID_PARAMETER; >} > > - if (ResponseData == NULL && *ResponseDataSize != 0) { &

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

On 10/26/23 10:33, Gerd Hoffmann wrote: > On Thu, Oct 26, 2023 at 10:36:35AM +0800, Yoshinoya wrote: > >> CXL Host Bridge / Root Port / Switch / Device enumeration / HDM Config, >> maybe could be integrated into pci drivers stack. > > Point being? Can or should the firmware do anything useful w

Re: [edk2-devel] [PATCH] UefiCpuPkg: Remove ASSERT checking if FinishedCount equal to CpuCount-1

On 10/25/23 12:07, Yuanhao Xie wrote: > The purpose is to fix an assertion with applying the following patch > series: > > UefiCpuPkg: Refactor the logic for placing APs in HltLoop. > UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. > UefiCpuPkg: Create MpHandOff. > UefiCpuPkg: ApW

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

On 10/19/23 07:43, Chang, Abner via groups.io wrote: > From: Abner Chang > > - Add two entries of MdePkg and MdeModulePkg for > manageability modules and files. > - Add one entry of UefiCpuPkg AMD related files. > > Signed-off-by: Abner Chang > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Mich

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues

On 10/23/23 11:05, sunceping wrote: > From: Ceping Sun > > v1 -> v2 Changed list: > 1:Since both commits are intended to fix coverity issues, they are merged > into one > 2: Changed the debug info level to debug error when "DsdtTable == NULL" > 3:Add the Cc member as below > Erdem Aktas erd

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

On 10/17/23 13:28, Gerd Hoffmann wrote: > Checking the max cpuid leaf is not enough to figure whenever > CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says: > >Software must detect the presence of CPUID leaf 1FH by verifying >(a) the highest leaf index supported by CPUID is >= 1FH, a

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

can't rebase a public branch), and the code is alright per review, so a revert won't help much here. Laszlo > > Yuanhao > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 25, 2023 4:00 PM > To: devel@edk2.groups.io; Xie, Yuanhao > Cc:

[edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

Ray Ni Cc: Sai Chaganty Cc: Theo Jehl Signed-off-by: Laszlo Ersek --- Maintainers.txt | 11 --- 1 file changed, 11 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 3e72f53afa0d..affb2632e0db 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -148,7 +148,6 @@ R: Marvin Hä

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

mmCpuFeaturesLib/*Amd*.* > +M: Abdul Lateef Attar [abdattar] > +R: Abner Chang [changab] > + > UefiPayloadPkg > F: UefiPayloadPkg/ > W: https://github.com/tianocore/tianocore.github.io/wiki/UefiPayloadPkg For the UefiCpuPkg part: Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

Yuanhao, On 10/19/23 05:20, Yuanhao Xie wrote: > With the fact that CSM is not supported, > the request is to remove the cache setting for memory under 1MB. > This can be treated as the missing part of legacy CSM deprecation. > > This patch only set the 0 to 9 and C to F as Write

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL031RealTimeClockLib: remove superfluous instance init steps

On 10/20/23 14:27, Ard Biesheuvel wrote: > On Fri, 20 Oct 2023 at 14:17, Laszlo Ersek wrote: >> >> RealTimeClockLib instances are consumed by edk2's >> EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function >> InitializeRealTimeCloc

Re: [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances

On 10/20/23 14:18, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=4565 > > RealTimeClockLib instances should neither set gRT fields nor install > EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize(); > EmbeddedPkg/RealTimeClockRuntimeDxe already perform

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/24/23 14:29, Laszlo Ersek wrote: > On 10/24/23 04:18, Gao, Zhichao wrote: >> The patch looks good to me. >> Reviewed-by: Zhichao Gao >> >> The comments of this patch and proposal would be taken care in another >> patch. Better to have a Bugzilla record

Re: [edk2-devel] [PATCH v6 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On 10/21/23 19:33, Dhaval Sharma wrote: > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Lasz

Re: [edk2-devel] [PATCH v6 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

usage should be avoided. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Laszlo Ersek > > Signed-off-by: Dhaval Sharma > --- > > Notes: > v2: > - Modify

Re: [edk2-devel] [PATCH v6 3/5] MdePkg: Implement RISC-V Cache Management Operations

. Not able to verify actual instruction in HW as Qemu ignores >any actual cache operations. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Laszlo Ersek > > Signed-off-by: Dhaval Sharma > ---

Re: [edk2-devel] [PATCH v6 2/5] MdePkg: Rename Cache Management Function To Clarify Fence Based Op

ed in future > patches. Current method is fence instruction based, rename the > function accordingly to add that clarity. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Laszlo Ersek > > Signed-off-

Re: [edk2-devel] [PATCH v6 1/5] MdePkg: Move RISC-V Cache Management Declarations Into BaseLib

t; #include > > -/** > - RISC-V invalidate instruction cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateInstCacheAsm ( > - VOID > - ); > - > -/** > - RISC-V invalidate data cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateDataCach

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

Eric, Ray, Rahul -- can you ACK this patch please? I intend to merge it in one or two days. Thanks Laszlo On 10/17/23 13:42, Laszlo Ersek wrote: > On 10/17/23 13:28, Gerd Hoffmann wrote: >> Checking the max cpuid leaf is not enough to figure whenever >> CPUID_V2_EXTENDED_TOPOLO

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/24/23 04:18, Gao, Zhichao wrote: > The patch looks good to me. > Reviewed-by: Zhichao Gao > > The comments of this patch and proposal would be taken care in another patch. > Better to have a Bugzilla record for the planned change. I've submitted

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV.

On 10/24/23 07:53, Xu, Wei6 wrote: > The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. > When an inner FV is uncompressed, StandaloneMmCore will miss the FV and > all the MM drivers in the FV will not be dispatched. > Add checks for uncompressed inner FV to fix this issue. > >

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 10/20/23 14:25, Ard Biesheuvel wrote: > On Fri, 20 Oct 2023 at 11:49, Laszlo Ersek wrote: >> >> On 10/18/23 10:57, Ard Biesheuvel wrote: >>> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew >>> wrote: >>>> >>>> Dear Maintainers, >>>

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 10/20/23 14:25, Laszlo Ersek wrote: > On 10/20/23 13:30, John Chew wrote: >> Hi Heinrich, Laszlo, >> >> Thank you very much for your support! Really appreciate it =D >> >> My account just approved few days ago, so original patch (submit few weeks >> bac

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

szlo > > Regards, > John > > -Original Message- > From: Heinrich Schuchardt > Sent: Friday, October 20, 2023 6:44 PM > To: Laszlo Ersek > Cc: Sunil V L ; Li Yong ; Leif > Lindholm ; Ard Biesheuvel > ; Abner Chang ; Daniel > Schaefer ; devel@edk2.

[edk2-devel] [edk2-platforms PATCH 6/7] FT2000-4Pkg/RealTimeClockLib: remove superfluous instance init steps

ocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 13 - 1 file changed, 13 deletions(-) diff --git a/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c b/Silicon/Phytium/FT2000

[edk2-devel] [edk2-platforms PATCH 4/7] Hisilicon/RX8900RealTimeClockLib: remove superfluous instance init steps

8900 RTC, so upstream the RX8900RealTimeClockLib", so I guess there might be out-of-tree / proprietary consumers. Quite unfortunate. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/

[edk2-devel] [edk2-platforms PATCH 7/7] Omap35xxPkg/RealTimeClockLib: remove superfluous instance init steps

ready does not list UefiRuntimeServicesTableLib and gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with "BeagleBoardPkg.dsc"). Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/TexasInstrume

[edk2-devel] [edk2-platforms PATCH 2/7] LoongArchQemuPkg/LsRealTimeClockLib: remove superfluous instance init steps

file already does not list UefiRuntimeServicesTableLib.) Build-tested only (with "Loongson.dsc"). Cc: Bibo Mao Cc: Chao Li Cc: Xianglai li Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Notes: context:-W Platform/Loongson/LoongArch

[edk2-devel] [edk2-platforms PATCH 5/7] Silicon/Marvell/RealTimeClockLib: remove superfluous instance init steps

or step (3); it does not try to set "gRT" fields). (Note that the lib instance INF file already does not list gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with "Armada70x0Db.dsc"). Cc: Leif Lindholm Cc: Marcin Wojtas Ref: https://bugzilla.tianocore.org/show_bug.cgi

[edk2-devel] [edk2-platforms PATCH 3/7] Hisilicon/M41T83RealTimeClockLib: remove superfluous instance init steps

nocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c b/Silicon/Hisilic

[edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances

: Leif Lindholm Cc: Ling Jia Cc: Marcin Wojtas Cc: Peng Xie Cc: Wenyi Xie Cc: Xianglai li Cc: Yiqi Shu Thanks Laszlo Laszlo Ersek (7): Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init steps LoongArchQemuPkg/LsRealTimeClockLib: remove superfluous instance init

[edk2-devel] [edk2-platforms PATCH 1/7] Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init steps

ready does not list UefiBootServicesTableLib, UefiRuntimeServicesTableLib, and gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with the D03 and D05 platforms). Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: L

[edk2-devel] [PATCH] ArmPlatformPkg/PL031RealTimeClockLib: remove superfluous instance init steps

undant for step (3); it does not try to set "gRT" fields). (Note that the lib instance INF file already does not list gEfiRealTimeClockArchProtocolGuid.) Tested with ArmVirtQemu. Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 10/18/23 10:57, Ard Biesheuvel wrote: > On Wed, 18 Oct 2023 at 10:49, YuinYee Chew > wrote: >> >> Dear Maintainers, >> >> Just a friendly reminder to ask if you could take a look at my patch. I'd >> really appreciate your feedback and help. >> > > Thanks for the reminder. I don't have time to

Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features

for this. (And even if CI has gcc-12, I'd still ask for the macros, because RHEL9 / EPEL9 don't seem to have a new enough binutils.) Thanks Laszlo > > On Thu, Oct 19, 2023 at 5:47 PM Laszlo Ersek <mailto:ler...@redhat.com>> wrote: > > On 10/19/23 11:2

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioFsDxe: tolerate opening an abs. pathname rel. to a reg. file

On 10/19/23 15:50, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 6:24 PM Laszlo Ersek wrote: >> >> Referring to a file relative to a regular file makes no sense (or at least >> it cannot be implemented consistently with how a file is referred to >&

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Add maintainers for Sophgo platform

;Maintainers.txt" file. > > Cc: dahogn > Cc: meng-cz > Cc: USER0FISH > Cc: Sunil V L > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Laszlo Ersek > Signed-off-by: caiyuqing379 > --- > Maintainers.txt| 9 ++ > Platform/Sophgo/Mainta

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioFsDxe: tolerate opening an abs. pathname rel. to a reg. file

On 10/19/23 08:28, Gerd Hoffmann wrote: > On Wed, Oct 18, 2023 at 07:24:34PM +0200, Laszlo Ersek wrote: >> Referring to a file relative to a regular file makes no sense (or at least >> it cannot be implemented consistently with how a file is referred to >> re

Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features

On 10/19/23 11:22, Laszlo Ersek wrote: > On 10/19/23 08:48, Dhaval Sharma wrote: >> (11) I agree that we should use symbolic names rather than >> magic constants, but raw encodings of machine instructions don't belong >> into a >>      C header file. [Dhaval] This

Re: [edk2-devel] Question about OvmfPackage cxl emulation support

On 10/19/23 03:51, Yoshinoya wrote: > Hi, > I findd qemu supports cxl emulation, but it uses seabios as virtual > machine firmware. > > Does UEFI OvmfPackage have a plan to support CXL device enumeration and > declaration? I expect MdeModulePkg would have to add some generic CXL device driver, wh

Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features

ne* > (25-26) The *API* renames belong to v6 patch#2. & The new APIs, plus the > *file* rename, belong to v6 patch#3. *Done* > (27) Please use the assembler macros from point (11). Please see (11) > (28-29-30-31) Please do not abbreviate RISC-V as "RV". It's incredi

[edk2-devel] [PATCH] OvmfPkg/VirtioFsDxe: tolerate opening an abs. pathname rel. to a reg. file

euvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Laszlo Ersek --- Notes: context:-U4 OvmfPkg/VirtioFsDxe/SimpleFsOpen.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/VirtioFsDxe/SimpleFsOpen.c b/OvmfPkg/VirtioFsDxe

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

On 10/18/23 15:44, Ard Biesheuvel wrote: > On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek wrote: >> >> On 10/12/23 11:10, Laszlo Ersek wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >>> >>> The RealTimeClockLib class header in edk2's

Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

On 10/18/23 17:15, Sami Mujawar wrote: > Hi Laszlo, > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 18/10/2023, 14:42, "Laszlo Ersek" <mailto:ler...@redhat.com>> wrote: > > > Hi Sami, >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 15:13, Gerd Hoffmann wrote: > Hi, > >>> - if (!VirtioFsFile->IsDirectory) { >>> + if (!VirtioFsFile->IsDirectory && FileName[0] != '\\') { > >> It's nice to see this topic pop up on edk2-devel; apparently you started >> testing shim on top of virtio-fs. :) > > Indeed. For starte

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 15:08, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 1:20 PM Laszlo Ersek wrote: >> >> On 10/18/23 13:33, Pedro Falcato wrote: >>> On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: >>>> >>>> On 10/18/23 12:33, Gerd Hoffmann wrot

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

On 10/18/23 14:21, Sunil V L wrote: > On Wed, Oct 18, 2023 at 02:11:17PM +0200, Laszlo Ersek wrote: >> On 10/18/23 13:21, 蔡雨晴 wrote: >>> Hi Laszlo, >>> >>> Thank you for your comments. I will commit a new patch to add the >>> maintainers to the "

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

On 10/12/23 11:10, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > declares a function called LibRtcVirtualNotifyEvent(). No component ever > calls this function across mo

Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

t;devel@edk2.groups.io <mailto:devel@edk2.groups.io> on > behalf of Laszlo Ersek via groups.io" <mailto:devel@edk2.groups.io> on behalf of lersek=redhat@groups.io > <mailto:redhat@groups.io>> wrote: > > > PcatRealTimeClockRuntimeDxe seems to have c

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

On 10/18/23 13:28, Marcin Juszkiewicz wrote: > W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: >> On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz >> wrote: >>> >>> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: Acked-by: Nhi Pham Nit: I think you want to run uncrustify for Patch 3

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

On 10/18/23 13:55, Yuanhao Xie wrote: > With the fact that CSM is not supported, > the request is to remove the cache setting for memory under 1MB. > This can be treated as the missing part of legacy CSM deprecation. > > This patch only set the 0 to 9 and C to F as Write Back. > A0

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 13:33, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: >> >> On 10/18/23 12:33, Gerd Hoffmann wrote: >>> VirtiofsDxe throws an error in case the caller tries to open a file or >>> directory using an handle with is not a

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

tility creates a git-format-patch alias called "fp" that includes these options. BTW I could help Ard out by pushing this patch set (well, v4, with the Maintainers.txt fix), I'm just not clear when a patch set counts as "sufficiently reviewed" for edk2-platforms. Laszlo

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

; FileName=\"%s\": " It's nice to see this topic pop up on edk2-devel; apparently you started testing shim on top of virtio-fs. :) I have had the following patch in my local repo, on a separate branch, since April this year: > commit cb4a6d1664ea6cabd14d2af0e5d9abb114973

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

On 10/13/23 05:03, caiyuqing...@163.com wrote: > diff --git a/Platform/Sophgo/Maintainers.md b/Platform/Sophgo/Maintainers.md > new file mode 100644 > index ..4cb32c359a31 > --- /dev/null > +++ b/Platform/Sophgo/Maintainers.md > @@ -0,0 +1,105 @@ > +##Project Name: EDK2 Sophgo SG2042 >

Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features

On 10/17/23 14:17, Dhaval Sharma wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be a

Re: [edk2-devel] [PATCH v5 1/2] MdePkg:Implement RISCV CMO

On 10/17/23 16:22, Laszlo Ersek wrote: > On 10/17/23 14:17, Dhaval Sharma wrote: >> Implementing code to support Cache Management Operations >> (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs (28) Please do not abbreviate RISC-V as "RV". It's incredibly

Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features

On 10/17/23 14:17, Dhaval Sharma wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be a

Re: [edk2-devel] [PATCH v5 1/2] MdePkg:Implement RISCV CMO

On 10/17/23 14:17, Dhaval Sharma wrote: > Implementing code to support Cache Management Operations > (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs > > Notes: > 1. CMO only supports block based Operations. Meaning complete >cache flush/invd/clean Operations are not available. In t

Re: [edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

On 10/17/23 13:38, Nhi Pham via groups.io wrote: > Thanks, Laszlo for this patch. > > Reviewed-by: Nhi Pham > > Regards, > Nhi Thank you both for reviewing; commit 7f3e7fc0b4ed. Laszlo > > On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote:

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

0; > + } else { > +AsmCpuidEx (CPUID_V2_EXTENDED_TOPOLOGY, 0, NULL, > &ExtendedTopologyEbx.Uint32, NULL, NULL); > + } > + > + if (ExtendedTopologyEbx.Bits.LogicalProcessors == 0) { > if (Die != NULL) { >*Die = 0; > } Reviewed-by: Laszlo Erse

[edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

: Nhi Pham Cc: Rebecca Cran Suggested-by: Nhi Pham Signed-off-by: Laszlo Ersek --- Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraP

Re: [edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped

On 10/13/23 12:12, Ard Biesheuvel wrote: > On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote: >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >> >> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly >> declares a function called Li

Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

n't want to do it without asking. Thansk Laszlo > > Thanks, > Nhi > > On 10/13/2023 9:20 AM, Nhi Pham wrote: >> Thanks for fixing it. >> >> Reviewed-by: Nhi Pham >> >> Regards, >> Nhi >> >> On 10/12/2023 4:09 PM, Laszlo Ersek wrot

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

On 10/11/23 12:06, Gerd Hoffmann wrote: > Checking the max cpuid leaf is not enough to figure whenever > CPUID_V2_EXTENDED_TOPOLOGY is supported. Quoting a comment for > CPUID_EXTENDED_TOPOLOGY in GetProcessorLocationByApicId(): > > // If CPUID.(EAX=0BH, ECX=0H):EBX returns zero and maximum input

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/11/23 19:36, Aaron Young wrote: > >  Thanks for the comments, Laszlo. > >  I could look into optimizing SetBootOrderFromQemu()->Match() by using >  EfiBootManagerGetNextLoadOptionDevicePath() instead of > EfiBootManagerGetLoadOptionBuffer(). >  Makes sense to me and at first glance seems li

[edk2-devel] [PATCH 5/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

dPkg.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 --- 1 file changed, 15 deletions(-) diff --git a

[edk2-devel] [PATCH 4/5] EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent

Build-tested only (with "RiscVVirtQemu.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTime

[edk2-devel] [PATCH 3/5] EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent

Build-tested only (with "EmbeddedPkg.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24

[edk2-devel] [PATCH 2/5] ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent

: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c

[edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Cc: Ray Ni Thanks Laszlo Laszlo Ersek (5): PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent EmbeddedPkg/TemplateRe

[edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

e, - in EmbeddedPkg, the RealTimeClockLib class API LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API). Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(), and make it static. Tested with booting OVMF. Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi

[edk2-devel] [edk2-non-osi PATCH 1/1] Hisilicon: rename OemMiscLib class dependencies to HisiOemMiscLib

iesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Hi1610/Library/Hi1610Serdes/Hi1610SerdesLib.inf | 2 +- Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrl

[edk2-devel] [edk2-non-osi PATCH 0/1] Hisilicon: rename OemMiscLib class dependencies to HisiOemMiscLib

https://bugzilla.tianocore.org/show_bug.cgi?id=4564 This patch accompanies "[edk2-platforms PATCH 04/19] Hisilicon: rename OemMiscLib class to HisiOemMiscLib". Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Thanks Laszlo Laszlo Ersek (1): Hisilicon: rename OemMis

[edk2-devel] [edk2-platforms PATCH 08/19] Hisilicon: drop unused DS3231RealTimeClockLib instance

("Hisilicon/D02: Remove D02 platform", 2018-08-08). Remove the unused library instance. (There's no reference in edk2-non-osi either.) Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Si

[edk2-devel] [edk2-platforms PATCH 16/19] Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

core.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib

[edk2-devel] [edk2-platforms PATCH 18/19] FT2000-4Pkg/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

Cc: Peng Xie Cc: Yiqi Shu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Silicon/Phytium/FT2000-4P

[edk2-devel] [edk2-platforms PATCH 13/19] JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent

m Cc: Nhi Pham Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/Ampe

[edk2-devel] [edk2-platforms PATCH 19/19] Omap35xxPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent

ction. Build-tested only (with "BeagleBoardPkg.dsc"). Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.c | 18 -- 1 f

[edk2-devel] [edk2-platforms PATCH 17/19] NXP/Pcf8563RealTimeClockLib: hide LibRtcVirtualNotifyEvent

f Lindholm Cc: Masami Hiramatsu Cc: Meenakshi Aggarwal Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Silicon/N

[edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

ianglai li Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/Loongson/LoongArchQemuP

[edk2-devel] [edk2-platforms PATCH 15/19] Styx/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

"OverdriveBoard.dsc", "CelloBoard.dsc", "Overdrive1000Board.dsc"). Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.c | 55 +-

[edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

e.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraPkg/Library/A

[edk2-devel] [edk2-platforms PATCH 10/19] Hisilicon/DS3231RealTimeClockLib: drop LibRtcVirtualNotifyEvent

Build-tested only (with the Hisilicon platforms). Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.c | 25 1

[edk2-devel] [edk2-platforms PATCH 11/19] Hisilicon/RX8900RealTimeClockLib: drop LibRtcVirtualNotifyEvent

unate. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClockLib.c | 11 --- 1 file changed, 11 deletions(-) diff --gi

[edk2-devel] [edk2-platforms PATCH 03/19] Hisilicon.dsc.inc: resolve VariableFlashInfoLib

ib instance. Do that now. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Hisilicon.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Si

<    2   3   4   5   6   7   8   9   10   11   >