[edk2-devel] [edk2-platforms PATCH 09/19] Hisilicon: drop unused VirtualRealTimeClockLib instance

n D02,D03,D05 and HiKey", 2017-08-03) Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Library/VirtualRealTimeClockLib/RealTimeClockLib.inf | 41 -- Silicon/Hisilic

[edk2-devel] [edk2-platforms PATCH 04/19] Hisilicon: rename OemMiscLib class to HisiOemMiscLib

1-02-08) [3] d03f71dd8be6 ("ArmPkg: Add missing library headers to ArmPkg.dec", 2021-04-28) Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by

[edk2-devel] [edk2-platforms PATCH 02/19] Hisilicon/FlashFvbDxe: fix PcdNorFlashCheckBlockLocked token space GUID

silicon/D05/D05.dsc - Platform/Hisilicon/D06/D06.fdf Update the token space GUID reference. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf

[edk2-devel] [edk2-platforms PATCH 06/19] Hisilicon/Hi1620AcpiTables: fix up ASL

ot;; it's necessary for building the Hisilicon platform DSCs. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 60 ++-- 1

[edk2-devel] [edk2-platforms PATCH 05/19] Hisilicon: add missing include file to Pptt components

Some more random bitrot in Hisilicon; must be fixed for building the Hisilicon DSCs. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Hi1616/Pptt/Pptt.h | 1 + Silicon/Hisilicon

[edk2-devel] [edk2-platforms PATCH 07/19] Hisilicon/ProcessorSubClassDxe: drop conflicting PROCESSOR_STATUS_DATA type

Remove it. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h | 13 - 1 file changed, 13 deletions(-) diff --git

[edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped

altogether. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Chuong Tran Cc: Leif Lindholm Cc: Ling Jia Cc: Marcin Wojtas Cc: Masami Hiramatsu Cc: Meenakshi Aggarwal Cc: Nhi Pham Cc: Peng Xie Cc: Rebecca Cran Cc: Wenyi Xie Cc: Xianglai li Cc: Yiqi Shu Thanks Laszlo Laszlo Ersek (19): His

[edk2-devel] [edk2-platforms PATCH 01/19] Hisilicon: enable NOOPT builds

: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Platform/Hisilicon/D03/D03.dsc | 2 +- Platform/Hisilicon/D05/D05.dsc | 2 +- Platform/Hisilicon/D06/D06.dsc | 2 +- Platform/Hisilicon/HiKey/HiKey.dsc | 2 +- Platform/Hisilicon

[edk2-devel] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

https://bugzilla.tianocore.org/show_bug.cgi?id=4564 I'm only posting this message as a common root for three upcoming patch series that belong together (one series for each of edk2-platforms, edk2-non-osi, and edk2). Please see the cover letter in each of those series. Thanks Laszlo

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/10/23 17:06, Aaron Young wrote: > Reference: https://github.com/tianocore/edk2/pull/4892 > > BmExpandPartitionDevicePath is called to expand "short-form" device paths > which are commonly used with OS boot options. To expand a device path, it > calls EfiBootManagerConnectAll to connect all

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/10/23 09:43, Ard Biesheuvel wrote: > On Sun, 8 Oct 2023 at 17:39, Laszlo Ersek wrote: >> >> This ArmVirtPkg series can be fetched from: >> >> repo: https://pagure.io/lersek/edk2.git >> branch: armvirt-dual-serial @ 65ee08413595 &g

Re: [edk2-devel] [PATCH v2 3/4] MdeModulePkg: PeiMain: Introduce implementation of delayed dispatch

On 10/10/23 02:18, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 > > This change adds the implementation that fits the needs and description > of PI spec defined Delayed Dispatch PPI in Pei Core. > > The PPI would allow minimal delay for registered callbacks. As well as

Re: [edk2-devel] [PATCH v2 2/4] MdePkg: DelayedDispatch: Added WaitOnEvent interface

On 10/10/23 02:18, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 > > This change adds a new interface for the delayed dispatch PPI. This > new addition allows functional components relying on delayed dispatch > callbacks to be managed/dispatched with definitive order.

Re: [edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

// 4-byte data, adjust size > @@ -109,6 +113,8 @@ GetNextHidItem ( > StartPos += 4; >return StartPos; > } > + > +break; > } >} > Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

EV_SIGNATURE; With this (good) fix, it's better to remove the ASSERT() altogether, in my opinion! The assert was a cop-out, and now you are replacing it with proper error checking (and cleanup, too), so there's no need for the ASSERT(). It's not an "invariant" that AllocateZeroPo

Re: [edk2-devel] [PATCH v5 28/28] MdeModulePkg: Delete Memory Protection PCDs

On 10/9/23 02:07, Taylor Beebe wrote: > Now that the transition to use SetMemoryProtectionsLib and > GetMemoryProtectionsLib is complete, delete the memory protection PCDs > to avoid confusing the interface. All memory protection settings > will now be set and consumed via the libraries. > >

Re: [edk2-devel] [PATCH v5 27/28] ArmVirtPkg: Delete Memory Protection PCDs

On 10/9/23 02:07, Taylor Beebe wrote: > Now that the transition to use SetMemoryProtectionsLib and > GetMemoryProtectionsLib is complete, delete the memory protection PCDs > to avoid confusing the interface. All memory protection settings > will now be set and consumed via the libraries. > >

Re: [edk2-devel] [PATCH v5 26/28] OvmfPkg: Delete Memory Protection PCDs

amdisk support > diff --git a/OvmfPkg/TdxDxe/TdxDxe.inf b/OvmfPkg/TdxDxe/TdxDxe.inf > index 9793562884c7..42317228c1aa 100644 > --- a/OvmfPkg/TdxDxe/TdxDxe.inf > +++ b/OvmfPkg/TdxDxe/TdxDxe.inf > @@ -68,6 +68,5 @@ [Pcd] >gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFdBaseAddress >

Re: [edk2-devel] [PATCH v5 24/28] ArmVirtPkg: Apply Memory Protections via SetMemoryProtectionsLib

On 10/9/23 02:07, Taylor Beebe wrote: > Set the memory protections on Arm virtual platforms. Because > the QemuFg parser is not currently available in ArmVirtPkg, use > the GrubCompat profile by default. > > Signed-off-by: Taylor Beebe > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami

Re: [edk2-devel] [PATCH v5 23/28] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg

On 10/9/23 02:07, Taylor Beebe wrote: > Now that the EDK2 tree uses GetMemoryProtectionsLib to query > the platform memory protection settings, OvmfPkg can be updated > to use QemuCfg to set the entire memory protection profile instead > of just SetNxForStack. both the commit message and the

Re: [edk2-devel] [PATCH v5 22/28] OvmfPkg: Add MemoryProtectionConfigLib

On 10/9/23 02:07, Taylor Beebe wrote: > MemoryProtectionConfigLib enables parsing the fw_cfg for the > memory protection profile. > > Signed-off-by: Taylor Beebe > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > --- >

Re: [edk2-devel] [PATCH v5 22/28] OvmfPkg: Add MemoryProtectionConfigLib

On 10/9/23 11:17, Laszlo Ersek wrote: > On 10/9/23 02:07, Taylor Beebe wrote: >> MemoryProtectionConfigLib enables parsing the fw_cfg for the >> memory protection profile. >> >> Signed-off-by: Taylor Beebe >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >

Re: [edk2-devel] [PATCH v5 22/28] OvmfPkg: Add MemoryProtectionConfigLib

On 10/9/23 02:07, Taylor Beebe wrote: > MemoryProtectionConfigLib enables parsing the fw_cfg for the > memory protection profile. > > Signed-off-by: Taylor Beebe > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > --- >

Re: [edk2-devel] [PATCH v5 21/28] OvmfPkg: Add QemuFwCfgParseString to QemuFwCfgSimpleParserLib

On 10/9/23 02:07, Taylor Beebe wrote: > QemuFwCfgParseString allows reading strings from the fw_cfg file. > This function is needed for parsing the memory protection profile > name. > > Signed-off-by: Taylor Beebe > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann

Re: [edk2-devel] [PATCH v5 17/28] OvmfPkg: Use GetMemoryProtectionsLib instead of Memory Protection PCDs

On 10/9/23 02:07, Taylor Beebe wrote: > Replace references to the memory protection PCDs to instead > check the platform protections via GetMemoryProtectionsLib. > > Because the protection profile is equivalent to the PCD settings, > this updated does not cause a torn state. > > Signed-off-by:

Re: [edk2-devel] [PATCH v5 11/28] OvmfPkg: Apply Memory Protections via SetMemoryProtectionsLib

On 10/9/23 02:07, Taylor Beebe wrote: > Use SetMemoryProtectionsLib to set the memory protections for > the platform in both normal and PEI-less boot. The protections > set are equivalent to the PCD settings and the ability to set > NxForStack via QemuCfg is preserved. Once the transition to use >

Re: [edk2-devel] [PATCH v5 02/28] MdeModulePkg: Define SetMemoryProtectionsLib and GetMemoryProtectionsLib

On 10/9/23 02:07, Taylor Beebe wrote: > SetMemoryProtectionsLib is a PEIM which allows platforms to > apply memory protection settings to the current boot. > > GetMemoryProtectionsLib has DXE and MM implementations to allow > platforms to query the current memory protection settings via a >

Re: [edk2-devel] [PATCH v5 10/28] OvmfPkg: Add Memory Protection Library Definitions to Platforms

On 10/9/23 02:07, Taylor Beebe wrote: > Add library classes for SetMemoryProtectionsLib and > GetMemoryProtectionsLib to OvmfPkg platfomrs. > > Signed-off-by: Taylor Beebe > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Peter Grehan >

Re: [edk2-devel] [PATCH v5 09/28] ArmVirtPkg: Add Memory Protection Library Definitions to Platforms

ArmVirtPkg". Looks OK to me otherwise: Acked-by: Laszlo Ersek > > Signed-off-by: Taylor Beebe > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Julien Grall > --- > ArmVirtPkg/ArmVirt.dsc.inc | 6 ++ > 1 file changed

Re: [edk2-devel] [PATCH v5 08/28] UefiCpuPkg: Always Set Stack Guard in MpPei Init

On 10/9/23 02:07, Taylor Beebe wrote: > Memory protection is not set in PEI and ingested during and > after DXE handoff. This paradigm means that the platform cannot > reliably query the stack guard setting during MpInit. Because the > execution path of PEI consistent and no third party > code is

Re: [edk2-devel] [PATCH v5 07/28] MdeModulePkg: Check Print Level Before Dumping GCD Memory Map

On 10/9/23 02:07, Taylor Beebe wrote: > When page/pool protections are active, the GCD sync process takes > quite a bit longer than normal. This behavior is primarily due to > a function which dumps the GCD memory map to the console. This > dump function runs only on DEBUG builds but will iterate

Re: [edk2-devel] [PATCH v5 06/28] MdeModulePkg: Apply Protections to the HOB List

components are allowed to make additions or changes to HOBs. Once the HOB list is passed into the HOB consumer phase, it is effectively read only. The ramification of a read-only HOB list is that handoff information, such as boot mode, must be handled i

Re: [edk2-devel] [PATCH v5 05/28] MdeModulePkg: Copy PEI PCD Database Into New Buffer

On 10/9/23 02:07, Taylor Beebe wrote: > HOB memory should not be written to in DXE phase. This patch > copies the PCD database from PEI into a new buffer so updates > to dynamic PCDs don't write to HOB memory. > > Signed-off-by: Taylor Beebe > Cc: Jian J Wang > Cc: Liming Gao > Cc: Dandan Bi >

[edk2-devel] [PATCH 2/9] ArmVirtPkg/Fdt16550SerialPortHookLib: rebase to FdtSerialPortAddressLib

This is only a refactoring; the patch is not supposed to cause any observable change. Build-tested only (with "ArmVirtKvmTool.dsc"). Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/Fdt16550SerialP

[edk2-devel] [PATCH 7/9] ArmVirtPkg: introduce DebugLibFdtPL011Uart RAM instance

th viewing with "git show --find-copies-harder". Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/DebugLibFdtPL011Uart/{DebugLibFdtPL011UartFlash.inf => DebugLibFdtPL011UartRam.inf} | 20 +

[edk2-devel] [PATCH 8/9] ArmVirtPkg: introduce DebugLibFdtPL011Uart DXE Runtime instance

a separate patch. This patch is worth viewing with "git show --find-copies-harder". Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/DebugLibFdtPL011Uart/{DebugLibFdtPL011UartRam.inf => DxeRuntimeDebugLi

[edk2-devel] [PATCH 9/9] ArmVirtPkg: steer DebugLib output away from SerialPortLib+console traffic

;ArmVirtKvmTool.dsc" and "ArmVirtXen.dsc" by building them for both DEBUG and RELEASE, both before the patch and after, and comparing the edk2 build report files (focusing on lib class resolutions). There are no changes. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Julien Grall Cc: L

[edk2-devel] [PATCH 4/9] ArmVirtPkg: adhere to the serial port selected by /chosen "stdout-path"

makes no difference, but if there are multiple ports, the output is written to the port identified by /chosen "stdout-path". In this patch, DebugLib output is not separated yet from the UEFI console. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by:

[edk2-devel] [PATCH 6/9] ArmVirtPkg: introduce DebugLibFdtPL011Uart Flash instance

-copies-harder". Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/DebugLibFdtPL011Uart/DebugLibFdtPL011UartFlash.inf | 54 ++ ArmVirtPkg/Librar

[edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

(b) leaves the patches applicable from the list. The base commit is noted at the end of this message. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Julien Grall Cc: Leif Lindholm Cc: Peter Maydell Cc: Sami Mujawar (I've not Cc'd Peter on the patches themselves, but I'm Cc'i

[edk2-devel] [PATCH 3/9] ArmVirtPkg: adjust whitespace in block scope declarations

rustify is (of course) unhappy with this patch, but that's fine -- this patch is in the middle of a series, and by the end of the series (which is where uncrustify is run in CI) the whitespace is going to be tight. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawa

[edk2-devel] [PATCH 5/9] ArmVirtPkg: store separate console and debug PL011 addresses in GUID HOB

ffmann Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Include/Guid/EarlyPL011BaseAddress.h | 15 - ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf | 1 + ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.c | 4 +-

[edk2-devel] [PATCH 1/9] ArmVirtPkg: introduce FdtSerialPortAddressLib

t. - Code is duplicated (of course) between SerialPortGetBaseAddress() and PlatformPeim(), but more surprisingly, all three functions embed the same code for verifying the "status" property of the serial port node, and for checking and reading its "reg" property. Cc: Ard Bi

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg/TlsLib: fix tls cipher configuration

On 10/7/23 16:32, Li, Yi wrote: > Sorry for delayed response due to PRC holiday. > This is a pretty good solution, I also ran some basic HTTPSBOOT and EAP-TLS > test cases, and all passed. > > Reviewed-by: Yi Li Merged as commit 4ddd8ac3a29d via .

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly

On 10/6/23 19:08, Ard Biesheuvel wrote: > On Mon, 2 Oct 2023 at 16:47, Laszlo Ersek wrote: >> >> On 9/30/23 23:23, Laszlo Ersek wrote: >>> FdtPL011SerialPortLib claims that it's usable from the DXE_CORE. That's >>> not correct: the DXE_CORE calls DEB

Re: [edk2-devel] another broken PR

On 10/7/23 13:33, Ard Biesheuvel wrote: > On Sat, 7 Oct 2023 at 02:26, Michael Kubacki > wrote: >> >> On 10/6/2023 8:18 PM, Michael Kubacki wrote: >>> On 10/6/2023 7:17 PM, Michael Kubacki wrote: https://edk2.groups.io/g/devel/message/109370 >>> I am planning to quickly merge that

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

On 10/5/23 12:23, Gerd Hoffmann wrote: > Hi, > An Arm compatible PEIM instance of QemuFwCfgLib will need to be created. I'm happy to look into it, but I don't want to hang up this patch series on that addition. Instead, I'll set the protection policy for ArmVirtPkg to the

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL

On 10/5/23 08:31, Nhi Pham via groups.io wrote: > Hi Ard, Oliver, > > I'm investigating the crash on grub2/shim loader due to the added > EFI_MEMORY_ATTRIBUTE_PROTOCOL when rebasing. I found this interesting > patch and went through on the discussion, I am still not sure the > conclusion on this

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

On 10/4/23 18:31, Taylor Beebe wrote: > > On 10/4/23 1:46 AM, Gerd Hoffmann wrote: >> On Fri, Sep 29, 2023 at 12:52:35PM -0700, Taylor Beebe wrote: >>> I can also update ArmVirtPkg to disable execution protection >>> for EfiLoaderData by default until fw_cfg parsing >>> support is added to

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg/TlsLib: fix tls cipher configuration

AsciiStrLen (SSL_CIPHER_get_name (OpensslCipher)), > > ); > if (EFI_ERROR (Status)) { > @@ -368,7 +274,7 @@ TlsSetCipherList ( > // > // Record the mapping. > // > -MappedCipher[MappedCipherCount++] = Mappi

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

On 10/3/23 01:05, Laszlo Ersek wrote: > On 10/2/23 03:51, Laszlo Ersek wrote: >> On 9/21/23 12:50, peter.maydell at linaro.org (Peter Maydell) wrote: >> >>> If you want to play around with this, I have some WIP patches at >>> https://git.linaro.org/peop

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

On 10/2/23 03:51, Laszlo Ersek wrote: > On 9/21/23 12:50, peter.maydell at linaro.org (Peter Maydell) wrote: > >> If you want to play around with this, I have some WIP patches at >> https://git.linaro.org/people/pmaydell/qemu-arm.git uart-edk-investigation >> (content

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly

On 9/30/23 23:23, Laszlo Ersek wrote: > FdtPL011SerialPortLib claims that it's usable from the DXE_CORE. That's > not correct: the DXE_CORE calls DEBUG() and ASSERT() before it calls > ProcessLibraryConstructorList(). Via the BaseDebugLibSerialPort instance, > those DEBUG() and AS

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

On 9/21/23 12:50, peter.maydell at linaro.org (Peter Maydell) wrote: > If you want to play around with this, I have some WIP patches at > https://git.linaro.org/people/pmaydell/qemu-arm.git uart-edk-investigation > (content wise they should be fine, but I haven't cleaned them up into > a coherent

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

On 9/28/23 13:50, Laszlo Ersek wrote: > On 9/28/23 13:24, Peter Maydell wrote: >> On Thu, 28 Sept 2023 at 08:54, Laszlo Ersek wrote: >>> >>> On 9/21/23 14:02, ardb at kernel.org (Ard Biesheuvel) wrote: >>>> EDK2's DEBUG output is extremely noisy, so

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/TlsLib: fix tls cipher configuration

On 9/29/23 15:23, Gerd Hoffmann wrote: > Trying to configure the TLS ciphers can lead to TLS handshake failures > because TlsCipherMappingTable is not in line with the ciphers actually > supported by OpensslLib. > > Fix that by removing TlsCipherMappingTable altogether. Use > SSL_get_ciphers()

[edk2-devel] [PATCH 1/1] ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly

Cc: Oliver Smith-Denny Cc: Oliver Steffen Cc: Sami Mujawar Cc: Sean Brogan Reported-by: Oliver Smith-Denny Signed-off-by: Laszlo Ersek --- Notes: In my opinion this is the wrong approach to fix the bug, but the right approach would require so much work all over edk2 (and outside of

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Enable Early Serial For DxeCore

On 9/30/23 16:43, Laszlo Ersek wrote: > On 9/8/23 01:58, Sean Brogan wrote: >> >> On 9/7/2023 1:54 PM, Laszlo Ersek wrote: >>> On 9/7/23 19:50, Sean Brogan wrote: >>>> I would argue that by declaring that your library class supports type >>>> DXE_CO

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Enable Early Serial For DxeCore

On 9/8/23 01:58, Sean Brogan wrote: > > On 9/7/2023 1:54 PM, Laszlo Ersek wrote: >> On 9/7/23 19:50, Sean Brogan wrote: >>> I would argue that by declaring that your library class supports type >>> DXE_CORE (or any core type) that you have declared you

Re: [edk2-devel] setting TLS ciphers is broken (openssl 3?)

On 9/28/23 16:25, Gerd Hoffmann wrote: >> The OpenSSL3 update may have restricted set (3), causing the grand >> intersection to be empty. > > That seems to be the case. Maybe (2) needs an update to enable newer > ciphers, when logging the mappings I see there are quite a few IDs which > don't

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

On 9/28/23 13:24, Peter Maydell wrote: > On Thu, 28 Sept 2023 at 08:54, Laszlo Ersek wrote: >> >> On 9/21/23 14:02, ardb at kernel.org (Ard Biesheuvel) wrote: >>> EDK2's DEBUG output is extremely noisy, so being able to redirect this >>> output to a di

Re: [edk2-devel] setting TLS ciphers is broken (openssl 3?)

On 9/27/23 10:38, kraxel at redhat.com (Gerd Hoffmann) wrote: > Hi, > > I've noticed that setting chipers for TLS stopped working in ovmf, > most likely due to the openssl 3.0 update. > > Test case: try http boot from https server, set ciphers on the qemu > command line using: > -object

Re: [edk2-devel] efi and ext4 and case sensitive file names

On 9/27/23 14:09, kraxel at redhat.com (Gerd Hoffmann) wrote: > Hi, > > I've noticed that the edk2 ext4 driver does case-insensitive filename > matching. I know the fat filesystem is case-insensitive, and the uefi > spec describing the fat filesystem also explicitly says it is >

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

On 9/21/23 14:02, ardb at kernel.org (Ard Biesheuvel) wrote: > On Thu, 21 Sept 2023 at 10:50, Peter Maydell > wrote: >> >> Hi; I've been looking again at a very long standing missing feature in >> the QEMU virt board, which is that we only have one UART. One of the >> things that has stalled

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

On 9/13/23 12:55, Laszlo Ersek wrote: > The shortlog below provides a good summary :) > > Cc: Andrei Warkentin > Cc: Andrew Jones > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Sunil V L > > Thanks > Laszlo > &g

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

it the MR with the "push" label set. Thanks! Laszlo > > Thanks, > Sunil > On Wed, Sep 13, 2023 at 12:55:48PM +0200, Laszlo Ersek wrote: >> The shortlog below provides a good summary :) >> >> Cc: Andrei Warkentin >> Cc: Andrew Jones >> Cc: Ard Bies

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

On 9/13/23 18:28, Andrew Jones wrote: > On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: >> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such >> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. >> >> Cc:

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

On 9/13/23 13:02, Ard Biesheuvel wrote: > On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek wrote: >> >> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain >> it. Original explanation by Drew Jones. >> > > Out of curiosity: how is th

[edk2-devel] [PATCH 3/3] OvmfPkg/RiscVVirt/README: document direct kernel boot

mplemented differently between OVMF and ArmVirtQemu. Thanks: Drew, Sunil. Cc: Andrei Warkentin Cc: Andrew Jones Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Sunil V L Signed-off-by: Laszlo Ersek --- OvmfPkg/RiscVVirt/README.md | 33 +++- 1 fi

[edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

"acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain it. Original explanation by Drew Jones. Cc: Andrei Warkentin Cc: Andrew Jones Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Sunil V L Signed-off-by: Laszlo Ersek --- OvmfPkg

[edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. Cc: Andrei Warkentin Cc: Andrew Jones Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Sunil V L Signed-off-

[edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

The shortlog below provides a good summary :) Cc: Andrei Warkentin Cc: Andrew Jones Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Sunil V L Thanks Laszlo Laszlo Ersek (3): OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

Re: [edk2-devel] [PATCH] OvmfPkg: raise DXEFV size to 14.5 MB in the traditional platform FDFs

COMPACT. I think it would allow for an absolutely huge (uncompressed) DXEFV if we wanted to grow the compressed FVMAIN_COMPACT to the QEMU-permitted hard limit, that is, nearly 16 MiB. Laszlo > > Thank you > Yao, Jiewen > >> -Original Message- >> From: Ard Biesheuvel >&g

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

On 9/12/23 16:17, Laszlo Ersek wrote: > "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro > VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already > use it (such as ArmVirtPkg/PlatformBootManagerLib, > OvmfPkg/VirtioSerialDxe). We shou

[edk2-devel] [PATCH] OvmfPkg: raise DXEFV size to 14.5 MB in the traditional platform FDFs

- 0x807000 Success > UefiMemory protection: 0x808000 - 0x81 Success > -UefiMemory protection: 0x181 - 0x7AF88000 Success > +UefiMemory protection: 0x1A1 - 0x7AF88000 Success > UefiMemory protection: 0x7AF8B000 - 0x7EB3D000 Success > UefiMemory protection: 0x7EDBD000

[edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

the naked constant 3. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Julien Grall Cc: Marc-André Lureau Cc: Stefan Berger Beautifies: 163083fd80d5 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- 1 fi

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

On 9/12/23 08:23, Sunil V L wrote: > On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote: >> Explain how users can compose their pre-OS environment purely from >> binaries they've built themselves. >> >> Cc: Andrei Warkentin >> Cc: Ard Biesheuvel >&g

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

On 9/11/23 12:15, Sunil V L wrote: > On Mon, Sep 11, 2023 at 09:07:46AM +0200, Laszlo Ersek wrote: >> On 9/11/23 08:22, Sunil V L wrote: >>> On Mon, Sep 11, 2023 at 08:15:26AM +0200, Laszlo Ersek wrote: >>>> On 9/11/23 07:32, Laszlo Ersek wrote: >>>>>

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

On 9/11/23 08:22, Sunil V L wrote: > On Mon, Sep 11, 2023 at 08:15:26AM +0200, Laszlo Ersek wrote: >> On 9/11/23 07:32, Laszlo Ersek wrote: >>> On 9/8/23 08:13, Sunil V L wrote: >>>> Hi Laszlo, >>>> >>>> On Thu, Sep 07, 2023 at 04:58:25PM

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

On 9/11/23 07:32, Laszlo Ersek wrote: > On 9/8/23 08:13, Sunil V L wrote: >> Hi Laszlo, >> >> On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote: >>> Explain how users can compose their pre-OS environment purely from >>> binaries they've built t

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

On 9/8/23 08:13, Sunil V L wrote: > Hi Laszlo, > > On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote: >> Explain how users can compose their pre-OS environment purely from >> binaries they've built themselves. >> >> Cc: Andrei Warkentin >> C

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Enable Early Serial For DxeCore

On 9/8/23 01:58, Sean Brogan wrote: > > On 9/7/2023 1:54 PM, Laszlo Ersek wrote: >> On 9/7/23 19:50, Sean Brogan wrote: >>> I would argue that by declaring that your library class supports type >>> DXE_CORE (or any core type) that you have declared you

Re: [edk2-discuss][edk2-devel] UEFI variables not getting stored in nvram disk

On 9/7/23 22:24, Het Gala wrote: > > > > Forwarded Message > Subject: [edk2-discuss] UEFI variables not getting stored in nvram disk > Date: Mon, 17 Jul 2023 23:24:45 +0530 > From: Het Gala > To: disc...@edk2.groups.io > CC: Kallol Biswas [C] > > >

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Enable Early Serial For DxeCore

e DXE_CORE to call its APIs in any order; whereas SerialPortLib requires SerialPortInitialize() to be called first, also at the *class* level). Laszlo > On 9/7/2023 8:24 AM, Oliver Smith-Denny wrote: >> On 9/7/2023 6:10 AM, Laszlo Ersek wrote: >>> (replying on the web

Re: [edk2-devel] [edk2][RFC] OvmfPkg/AcpiPlatformDxe: patch FADT PSCI bits if FDT advertises it

On 9/7/23 17:17, Ard Biesheuvel wrote: > On Thu, 7 Sept 2023 at 16:51, Laszlo Ersek wrote: >> >> On 9/7/23 16:27, Ard Biesheuvel wrote: >>> On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev >>> wrote: >>>> >>>> EL3 firmware may implement PSC

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

On 9/7/23 16:58, Laszlo Ersek wrote: > Explain how users can compose their pre-OS environment purely from > binaries they've built themselves. > > Cc: Andrei Warkentin > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Sunil V L &g

[edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI

Explain how users can compose their pre-OS environment purely from binaries they've built themselves. Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Sunil V L Signed-off-by: Laszlo Ersek --- Notes: rendered version: https

Re: [edk2-devel] [edk2][RFC] OvmfPkg/AcpiPlatformDxe: patch FADT PSCI bits if FDT advertises it

On 9/7/23 16:27, Ard Biesheuvel wrote: > On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev > wrote: >> >> EL3 firmware may implement PSCI interface on aarch64 platforms, >> including qemu-tcg-aarch64. However, EL3 firmware does not usually own >> pulling and deploying ACPI tables from qemu fw_cfg.

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Enable Early Serial For DxeCore

(replying on the webui... sorry!) The problem is actually embedded in MdePkg and MdeModulePkg. - In DxeMain() (and in functions called by DxeMain()), we call DebugLib APIs *before* reaching ProcessLibraryConstructorList(). - In ArmVirtQemu, we resolve the DXE Core's DebugLib dependency to

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ExceptionSupport: Support backtrace through an exception

On 8/30/23 15:00, Ard Biesheuvel wrote: > On Tue, 29 Aug 2023 at 16:37, Laszlo Ersek wrote: >> >> On 8/29/23 15:29, Ard Biesheuvel wrote: >>> Laszlo reports that the efi_gdb.py script fails to produce a full >>> backtrace when attaching it to an A

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ExceptionSupport: Support backtrace through an exception

On 8/29/23 15:29, Ard Biesheuvel wrote: > Laszlo reports that the efi_gdb.py script fails to produce a full > backtrace when attaching it to an ARM firmware build that has halted on > an unhandled exception. > > The reason is that the asm code that processes the exception was not > implemented

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

icrosoft.com >>> Cc: ostef...@redhat.com; Feng, Bob C ; Gerd >>> Hoffmann ; Yao, Jiewen ; >>> Justen, Jordan L ; Gao, Liming >>> ; Kinney, Michael D >>> ; Rebecca Cran ; Sean >>> Brogan ; Chen, Christine >>> ; Laszlo Ersek >>> Su

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

omorrow. > > (I'd put the CI patch first, though) Yes, that makes sense. Thank you Oliver for writing this series. With the patch ordering suggested by Ard: Reviewed-by: Laszlo Ersek Thanks! Laszlo > > >> >> Gerd Hoffmann (1): >> OvmfPkg/PlatformCI: Boot OVMF in SM

Re: [edk2-devel] [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console

On 7/6/23 14:30, Gerd Hoffmann wrote: > Be consistent with pl011-based serial console setup. > > Suggested-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > --- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 d

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification()

- 6acf72901a2e ("UefiCpuPkg: Supporting S3 in 64bit PEI") > See also https://bugzilla.tianocore.org/show_bug.cgi?id=4195 > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek > Reviewed-by: Ray Ni > --- > OvmfPkg/Bhyve/Pla

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformPei: drop S3Verification()

with \"OvmfPkgIa32X64.dsc\".\n", > - __func__ > - )); > -ASSERT (FALSE); > -CpuDeadLoop (); > - } > - > - #endif > -} > - > STATIC > VOID > Q35BoardVerification ( > @@ -354,7 +324,6 @@ InitializePlatform ( >

Re: [edk2-devel] managing memory attributes in PEI

On 5/23/23 07:39, Ni, Ray wrote: > > >> -Original Message----- >> From: Laszlo Ersek >> Sent: Tuesday, May 23, 2023 1:31 PM >> To: Ard Biesheuvel ; edk2-devel-groups-io >> ; Ni, Ray ; Yao, Jiewen >> ; Gerd Hoffmann ; Taylor Beebe >> ; Oli

Re: [edk2-devel] managing memory attributes in PEI

On 5/23/23 06:49, Gerd Hoffmann wrote: > On Mon, May 22, 2023 at 11:20:16PM +, Ni, Ray wrote: >> Gerd, >> The S3 path has been 64bit ready. >> Can you check if OVMF pei64 image can do s3? >> >> At least internally in some real platform we tested s3 flow with 64bit PEI. > > Tested on OVMF,

Re: [edk2-devel] managing memory attributes in PEI

On 5/22/23 14:06, Gerd Hoffmann wrote: >> So my questions are: >> - do we need to retain mixed IA32 / X64 support, and if so, why? (I >> think it is related to SMM emulation but I need someone to confirm >> this) > > Yes, it's SMM related. S3 suspend in SMM-enabled builds requires > 32bit PEI. >

Re: [edk2-devel] managing memory attributes in PEI

On 5/22/23 13:31, Ard Biesheuvel wrote: > Hello all, > > (OVMF specific questions below - please keep reading) > > As a follow-up to the discussion we had last week regarding DXE core, > I'd like to raise the issue of managing memory permissions in PEI, > including the mapping attributes of the

<    3   4   5   6   7   8   9   10   11   12   >