Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting.

2021-12-01 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/e9149e2 -Original Message- From: devel@edk2.groups.io On Behalf Of Tan, Ming Sent: Tuesday, October 26, 2021 11:57 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting.

Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting.

2021-12-01 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Tan, Ming Sent: Tuesday, October 26, 2021 11:57 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. REF: https://bugzilla.tianocore.org

Re: [edk2-devel] [PATCH v1 0/3] IntelSiliconPkg: Remove v1 PCH SPI PPI and Protocol

2021-12-01 Thread Nate DeSimone
to IntelSiliconPkg. This change removes the v1 definitions. V2 is intended to better support multiple silicon generations which aligns with the goals of IntelSiliconPkg. Minor changes are also made in board packages that have stale references to the SPI PPI and Protocol. Cc: Chasel Chiu Cc: Nate DeSimone Cc

Re: [edk2-devel] [PATCH v1] Maintainers.txt: Change SimicsOpenBoardPkg Maintainer

2021-12-01 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/9ab8913 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, November 2, 2021 3:07 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Leif Lindholm ; Kinney, Michael D Subject: [edk2-devel

[edk2-devel] [edk2-platforms] [PATCH v1] UserAuthFeaturePkg: VerifyPassword() allows one extra password attempt

2021-12-01 Thread Nate DeSimone
of attempts again, after checking if the password is correct. Cc: Dandan Bi Cc: Liming Gao Cc: Jadhav Manoj D Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../UserAuthenticationSmm.c| 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

Re: [edk2-devel] [PATCH v1 0/3] IntelSiliconPkg: Remove v1 PCH SPI PPI and Protocol

2021-11-03 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, November 3, 2021 7:45 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Ranga

Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances

2021-11-02 Thread Nate DeSimone
spectful of contributors time and efforts and review in a timely manner. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Deepika Kethi Reddy Cc: Eric Dong Cc: Heng Luo Cc: Jeremy Soller Cc: Kathappan Esakkithevar Cc: Liming Gao Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Benjamin Doron Signed-off

Re: [edk2-devel] [PATCH v6 52/52] WhiskeylakeOpenBoardPkg: Update for SPI2 PPI

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v6 52/52] WhiskeylakeOpenBoardPkg: Update for SPI2 PPI From: Michael Kubacki REF:https

Re: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Luo, Heng Subject: [edk2-devel] [PATCH v6 51/52

Re: [edk2-devel] [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol From: Michael

Re: [edk2-devel] [PATCH v6 48/52] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 48/52] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

Re: [edk2-devel] [PATCH v6 47/52] KabylakeOpenBoardPkg/KabylakeRvp3: Add PeiSerialPortlibSpiFlash to build

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Benjamin Doron Subject: [PATCH v6 47/52] KabylakeOpenBoardPkg/KabylakeRvp3: Add

Re: [edk2-devel] [PATCH v6 46/52] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Benjamin Doron Subject: [PATCH v6 46/52] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update

Re: [edk2-devel] [PATCH v6 45/52] KabylakeSiliconPkg: Update for SPI2 PPI and Protocol

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 45/52

Re: [edk2-devel] [PATCH v6 44/52] KabylakeSiliconPkg: Identify flash regions by GUID

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 44/52

Re: [edk2-devel] [PATCH v6 43/52] CometlakeOpenBoardPkg: Remove unnecessary gPchSpiPpiGuid reference

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan

Re: [edk2-devel] [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI

Re: [edk2-devel] [PATCH v6 41/52] CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 41/52

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone I will correct the commit message during the upstreaming process. Thanks, Nate -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel

Re: [edk2-devel] [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg

Re: [edk2-devel] [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm From

[edk2-devel] [PATCH v1] Maintainers.txt: Change SimicsOpenBoardPkg Maintainer

2021-11-02 Thread Nate DeSimone
-off-by: Nate DeSimone --- Maintainers.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index c839c71b22..8d9d454347 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -235,7 +235,7 @@ M: Chasel Chiu Platform/Intel

Re: [edk2-devel] [edk2-[PATCH v1 0/2] APIC table updates

2021-11-02 Thread Nate DeSimone
1 file changed, 22 insertions(+), 15 deletions(-) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83179): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [PATCH v6 06/52] IntelSiliconPkg: Add PCH SPI PPI

2021-10-29 Thread Nate DeSimone
: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 This SPI PPI definition is intended to serve as the single definition for Intel platform and silicon packages. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed

Re: [edk2-devel] [PATCH v6 07/52] IntelSiliconPkg: Add PCH SPI Protocol

2021-10-29 Thread Nate DeSimone
. gPchSmmSpiProtocolGuid Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h | 301 Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec| 5 + 2 files changed, 306 insertions(+) diff --git

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatformPkg: Update APIC Table based on mode

2021-10-29 Thread Nate DeSimone
Hi Abdul, Excellent! I checked with the Windows kernel team as well and they don't believe there should be any issues. Therefore, I am approving your patch series as it is. Thanks, Nate Reviewed-by: Nate DeSimone -Original Message- From: Attar, AbdulLateef (Abdul Lateef) Sent

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatformPkg: Update APIC Table based on mode

2021-10-27 Thread Nate DeSimone
e. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Abdul Lateef Attar --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 35 1 file changed, 21 insertions(+), 14 deletions(-) diff --git

Re: [edk2-devel] [PATCH] IntelFsp2Pkg SplitFspBin.py: Correct file name in file header

2021-10-27 Thread Nate DeSimone
Reviewed-by: Nate DeSimone On 10/27/21, 5:00 AM, "Zeng, Star" wrote: Cc: Maurice Ma Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Star Zeng --- IntelFsp2Pkg/Tools/SplitFspBin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [edk2-devel] [edk2-platforms] [PATCH v1 2/2] MinPlatformPkg: AcpiProcessorUid for multi-socket

2021-10-27 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Abdul Lateef Attar via groups.io Sent: Friday, October 22, 2021 7:48 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatformPkg: Update APIC Table based on mode

2021-10-27 Thread Nate DeSimone
: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Abdul Lateef Attar --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 35 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c

Re: [edk2-devel] [edk2-[PATCH v1 0/2] APIC table updates

2021-10-27 Thread Nate DeSimone
/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 37 1 file changed, 22 insertions(+), 15 deletions(-) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification.

2021-10-27 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, October 26, 2021 1:06 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification. REF

Re: [edk2-devel][edk2-platforms][PATCH V1 09/11] MinPlatformPkg/SpifvbService: Publish FV based on board request

2021-10-22 Thread Nate DeSimone
his removed > the hardcoded table of FV to publish. > Also removed the unused "default" table. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Isaac Oram > --- > > Platform/Intel/MinPlatformPkg/Flash/SpiF

Re: [edk2-devel][edk2-platforms][PATCH V1 08/11] SimicsOpenBoardPkg/ReportFvLib: Update ReportFvLib

2021-10-22 Thread Nate DeSimone
Hi Isaac, Unlike the other platforms, you don't have a SMM and a PEI implementation in the same directory here. Therefore, why take the "Pei" prefix off the directory name here? Since this is a PEI specific implementation of a generic LibraryClass, it is convention to keep the "Pei" prefix.

Re: [edk2-devel][edk2-platforms][PATCH V1 06/11] WhitleyOpenBoardPkg/ReportFvLib: Add board support for custom MM FV

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:25 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-devel][edk2-platforms][PATCH V1 06/11] > WhitleyOpenBoardPk

Re: [edk2-devel][edk2-platforms][PATCH V1 07/11] PurleyOpenBoardPkg/ReportFvLib: Update ReportFvLib

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:26 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel][edk2-platforms][PATCH V1 07/11] > PurleyOpenBoar

Re: [edk2-devel][edk2-platforms][PATCH V1 11/11] MinPlatformPkg/ReportFvLib: Remove obsolete PeiReportFvLib instance

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:26 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel][edk2-platforms][PATCH V1

Re: [edk2-devel][edk2-platforms][PATCH V1 10/11] MinPlatformPkg/SpiFvbService: Reduce duplicate code

2021-10-22 Thread Nate DeSimone
edk2-platforms][PATCH V1 10/11] > MinPlatformPkg/SpiFvbService: Reduce duplicate code > > Consolidate all the entry point functions into SpiFvbServiceMm.c This > reduces the number of files and makes the code easier to understand. > > Cc: Chasel Chiu > Cc: Nate DeSimone &g

Re: [edk2-devel][edk2-platforms][PATCH V1 05/11] WhiskeyLakeOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:25 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel][edk2-platforms][PATCH V1 05/11] > WhiskeyLakeOpenBoar

Re: [edk2-devel][edk2-platforms][PATCH V1 04/11] TigerLakeOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:25 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > > Subject: [edk2-devel][edk2-platforms][PATCH V1 04/11]

Re: [edk2-devel][edk2-platforms][PATCH V1 03/11] KabyOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:25 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Benjamin Doron > ; Jeremy Soller > Subject: [edk2-devel][edk2-p

Re: [edk2-devel][edk2-platforms][PATCH V1 02/11] CometlakeOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-22 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:25 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan &

Re: [edk2-devel][edk2-platforms][PATCH V1 01/11] MinPlatformPkg/ReportFvLib: Add ReportMmFv to API

2021-10-22 Thread Nate DeSimone
kg library instances to the CorePeiLib.dsc and > CoreDxeLib.dsc as the default library instances. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Isaac Oram > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

Re: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/Build: Remove MultiPchPei PEIM binary use

2021-10-21 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Tuesday, October 19, 2021 8:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/Build: Remove

Re: [edk2-devel][edk2-platforms][PATCH V1 1/2] WhitleySiliconPkg/MultiPchPei: Open Source PEIM

2021-10-21 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Tuesday, October 19, 2021 8:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 1/2] WhitleySiliconPkg/MultiPchPei: Open Source

Re: [edk2-devel] [edk2-platforms][PATCH v5 00/46] Consolidate SpiFlashCommonLib instances

2021-10-21 Thread Nate DeSimone
tributors time and efforts and review in a timely manner. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Deepika Kethi Reddy Cc: Eric Dong Cc: Heng Luo Cc: Jeremy Soller Cc: Kathappan Esakkithevar Cc: Liming Gao Cc: Nate DeSimone Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Michael Ku

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

2021-10-14 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, September 22, 2021 2:35 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardP

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

2021-10-14 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/86916cb > -Original Message- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone,

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

2021-10-14 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; fel...

Re: [edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

2021-10-14 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 14, 2021 2:16 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Luo, Heng ; > Jeremy Soller ; Ben

Re: [edk2-devel] [PATCH] SpcrFeaturePkg: Close the event after first callback.

2021-10-11 Thread Nate DeSimone
> > Subject: [PATCH] SpcrFeaturePkg: Close the event after first callback. > > Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to > avoid multiple installation of SPCR table. > > Cc: Isaac Oram > Cc: Nate DeSimone > Cc:

Re: [edk2-devel] [PATCH] SpcrFeaturePkg: Close the event after first callback.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, July 26, 2021 12:30 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Liming Gao > > Subject: [PATCH] SpcrFeatur

Re: [edk2-devel] [edk2-platforms: PATCH v3 9/9] WhitleySiliconPkg: Use same variable name for FspNvsHob.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Oram, Isaac W > ; Desimone, Nathaniel L > > Subject: [edk2-platforms: PATCH v3 9/9] WhitleySilicon

Re: [edk2-devel] [edk2-platforms: PATCH v3 8/9] WhitleyOpenBoardPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Oram, Isaac W > ; Desimone, Nathaniel L > > Subject: [edk2-platforms: PATCH v3 8/9] WhitleyOpenBoa

Re: [edk2-devel] [edk2-platforms: PATCH v3 7/9] WhiskeylakeOpenBoardPkg: Use same variable name for FspNvsHob.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms: PATCH v3 7/9] WhiskeylakeOpenBoardPkg: Use

Re: [edk2-devel] [edk2-platforms: PATCH v3 6/9] TigerlakeOpenBoardPkg: Use same variable name for FspNvsHob.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [edk2-platforms: PATCH v3 6/

Re: [edk2-devel] [edk2-platforms: PATCH v3 5/9] KabylakeOpenBoardPkg/KabylakeRvp3: Use same variable name for FspNvsHob.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms: PATCH v3 5/9] > KabylakeOpenBoardPkg/KabylakeRvp3

Re: [edk2-devel] [edk2-platforms: PATCH v3 4/9] KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-platforms: PATCH v3 4/9] > KabylakeOpenBoard

Re: [edk2-devel] [edk2-platforms: PATCH v3 1/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

2021-10-11 Thread Nate DeSimone
former one is > not found. > > Also added PeiGetLargeVariable () to support the scenarios where the > variable data size is bigger than a single variable size limit. > > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Chasel Chiu > --- > Platform/In

Re: [edk2-devel] [edk2-platforms: PATCH v3 3/9] KabylakeOpenBoardPkg/AspireVn7Dash572G:Use same variable name for FspNvsHob

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Benjamin Doron > > Subject: [edk2-platforms: PATCH v3 3/9

Re: [edk2-devel] [edk2-platforms: PATCH v3 2/9] CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Katha

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

2021-10-11 Thread Nate DeSimone
lla.tianocore.org/show_bug.cgi?id=3678 > > Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly > and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is > not found. > > Also added PeiGetLargeVariable () to support the scenarios where the > variable data size is bigge

Re: [edk2-devel][edk2-platforms][PATCH V2 0/5] WhitleyOpenBoardPkg: Enable VT-D support

2021-10-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Tuesday, October 5, 2021 4:26 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: [edk2-devel][edk2

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/AcpiTables: Update structures for ACPI 6.3

2021-10-01 Thread Nate DeSimone
n MinPlatformPkg for ACPI 6.3. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Cc: Daniel Maddy > Co-authored-by: Michael Kubacki > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- > Platform/Intel/MinPlatf

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/AcpiTables: Update structures for ACPI 6.3

2021-10-01 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, September 24, 2021 11:23 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric ; Maddy, > Daniel ; Michael Kub

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Adopt FSP 2.3 specification.

2021-10-01 Thread Nate DeSimone
Hi Chasel, My only feedback is let's not add the EDK1 style GUID definition to FspNonVolatileStorageHob2.h. It is redundant with the EDK2 style definition. Please see inline. With that change... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sen

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/be67e47 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, September 28, 2021 6:03 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Benjamin Doron Subject: [edk2-devel] [edk2-platforms] [PATCH

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build

2021-09-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/437dd50 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, September 28, 2021 6:03 PM To: devel@edk2.groups.io Cc: Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Nate DeSimone
cast in cases where integer truncation is possible. Cc: Chasel Chiu Cc: Benjamin Doron Signed-off-by: Nate DeSimone --- .../AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c| 9 + .../Library/BoardInitLib/DxeBoardInitLib.c | 3 ++- .../Library/BoardInitLib

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build

2021-09-28 Thread Nate DeSimone
Commit d281e9e broke the build for KabylakeOpenBoardPkg due to DxeMultiBoardAcpiSupportLib having a dependency on BoardAcpiTableLib that was never declared. This change adds a correct declaration of the library dependency and fixes the build. Cc: Chasel Chiu Signed-off-by: Nate DeSimone

[edk2-devel] Intel® FSP External Architecture Specification v2.3 Has Been Released

2021-09-23 Thread Nate DeSimone
Hi Everyone, We are pleased to announce that the FSP External Architecture Specification v2.3 has been posted to https://www.intel.com/fsp! Highlights * FSP_NON_VOLATILE_STORAGE_HOB2 – A new architectural HOB has been added for storage of MRC training data. While this HOB serves the

Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Whitley SEC support

2021-09-16 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Wednesday, September 15, 2021 12:05 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Whitley SEC support This series

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Build: Reduce debug output for default boot.

2021-09-16 Thread Nate DeSimone
/Build: Reduce debug output for default boot. Replace Info with Load, so we still get component loading details Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-16 Thread Nate DeSimone
designed for all phase use. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- Platform/Intel/MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.c | 75 Platform/Intel/MinPlatformPkg/Library

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Wednesday, September 8, 2021 3:30 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel][edk2-platforms][PATCH V1 1

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/AcpiTables: Update structures for ACPI 6.3

2021-09-14 Thread Nate DeSimone
Updates ACPI table structures in MinPlatformPkg for ACPI 6.3. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Daniel Maddy Co-authored-by: Michael Kubacki Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 203

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

2021-09-14 Thread Nate DeSimone
and improvements to AcpiPlatform. Note that the following patch from a different series that is on the mailing list is currently required for MinPlatformPkg to build: https://edk2.groups.io/g/devel/message/78711 Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

2021-09-14 Thread Nate DeSimone
For the series.. Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, August 5, 2021 9:38 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/4

Re: [edk2-devel] [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build

2021-09-14 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/2bb0314 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 4:40 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Kinney, Michael D Subject: [edk2-devel] [edk2-platforms

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/6e68849 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Wednesday, August 25, 2021 8:56 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Michael Kubacki ; Benjamin Doron Subject: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-non-osi] [PATCH V1] WhitleyOpenBoardBinPkg: Add Readme.md for IFWI Ingredients

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-non-osi/commit/eba85cf -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 12:55 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel Subject: [edk2-devel] [edk2-non-osi] [PATCH V1

Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Fix Purley and Whitley builds

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/98e8ab0 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 3:29 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Oram, Isaac W ; Liming Gao ; Dong, Eric ; Ni, Ray ; Lin, JackX

[edk2-devel] [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build

2021-08-31 Thread Nate DeSimone
Cc: Agyeman Prince Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc b/Platform/Intel

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/5f67c57 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 10:27 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1

[edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Fix Purley and Whitley builds

2021-08-31 Thread Nate DeSimone
Commit f4e12 causes a re-definition warning for the MAX_SOCKETS macro on PurleyOpenBoardPkg and WhitleyOpenBoardPkg. Cc: Chasel Chiu Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Cc: Jack Lin Signed-off-by: Nate DeSimone --- .../Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c

[edk2-devel] [edk2-non-osi] [PATCH V1] WhitleyOpenBoardBinPkg: Add Readme.md for IFWI Ingredients

2021-08-31 Thread Nate DeSimone
Cc: Isaac Oram Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../WhitleyOpenBoardBinPkg/Ifwi/README.md | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Platform/Intel/WhitleyOpenBoardBinPkg/Ifwi/README.md diff --git a/Platform/Intel/WhitleyOpenBoardBinPkg

[edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Nate DeSimone
Adds support for stitching the IFWI (Integrated Firmware Image) for Wilson City and Copper City Cc: Isaac Oram Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../WhitleyOpenBoardPkg/CooperCityRvp/build_board.py | 11 +++ .../CooperCityRvp/build_config.cfg| 2

Re: [edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/77bbf33 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Saturday, August 28, 2021 6:19 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Luo, Heng Subject: [edk2-devel] [edk2-platforms

[edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Nate DeSimone
Adds support for stitching the IFWI (Integrated Firmware Image) for Wilson City and Copper City Cc: Isaac Oram Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../WhitleyOpenBoardPkg/CooperCityRvp/build_board.py | 11 +++ .../CooperCityRvp/build_config.cfg| 2

[edk2-devel] [edk2-non-osi] [PATCH V1 4/4] Maintainers.txt: Add maintainers for WhitleyOpenBoardBinPkg

2021-08-31 Thread Nate DeSimone
Cc: Isaac Oram Cc: Chasel Chiu Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index b8a4140..6ac132c 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -45,6 +45,11 @@ Platform

[edk2-devel] [edk2-non-osi] [PATCH V1 0/4] Add IFWI Ingredients for Ice Lake-SP and Cooper Lake Boards

2021-08-31 Thread Nate DeSimone
This patch series adds IFWI ingredients for Ice Lake-SP and Cooper Lake boards. This allows the MinPlatform build to produce a full IFWI (Integrated Firmware Image) instead of just the BIOS region. Cc: Isaac Oram Cc: Chasel Chiu Cc: Michael D Kinney Nate DeSimone (4): WhitleyOpenBoardBinPkg

Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check

2021-08-28 Thread Nate DeSimone
is not present. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib

Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check

2021-08-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Saturday, August 28, 2021 12:42 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg

[edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment

2021-08-28 Thread Nate DeSimone
A comment in OpenBoardPkgPcd.dsc states that FSP dispatch mode is not supported, which is inaccurate. Cc: Sai Chaganty Cc: Heng Luo Signed-off-by: Nate DeSimone --- .../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/2] BoardModulePkg/BoardBdsHookLib: Simplify hotkey registration

2021-08-26 Thread Nate DeSimone
rather than creating an additional boot option. Tested, both F7 hotkey still opens the list of boot options. Cc: Eric Dong mailto:eric.d...@intel.com>> Cc: Liming Gao mailto:gaolim...@byosoft.com.cn>> Cc: Nate DeSimone mailto:nathaniel.l.desim...@intel.com>> Signed-off

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

2021-08-26 Thread Nate DeSimone
Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 2 +- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | 29 +++- 2 files changed, 11 insertions(+), 20

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

2021-08-26 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Friday, August 13, 2021 5:43 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v2 1/2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/2] BoardModulePkg/BoardBdsHookLib: Simplify hotkey registration

2021-08-26 Thread Nate DeSimone
registration Retrieve BootOption of BootManagerMenu for registering F7 hotkey, rather than creating an additional boot option. Tested, both F7 hotkey still opens the list of boot options. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters

2021-08-26 Thread Nate DeSimone
HI Caden, You accidentally added a bunch of trailing white space on line 371, but that should be fixable during the check-in process. Reviewed-by: Nate DeSimone -Original Message- From: Caden Kline Sent: Sunday, August 22, 2021 7:44 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Wu

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G

2021-08-26 Thread Nate DeSimone
Hi Benjamin, Sounds good. I have pushed your patch. Thanks, Nate From: Benjamin Doron Sent: Wednesday, August 25, 2021 9:09 PM To: Desimone, Nathaniel L Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Hi Nate,

<    1   2   3   4   5   6   7   8   9   10   >