Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-05-13 Thread Pethaiyan, Madhan
Message- From: gaoliming Sent: Thursday, March 28, 2024 6:41 AM To: Pethaiyan, Madhan ; Kinney, Michael D ; devel@edk2.groups.io Cc: Liu, Zhiguang ; Li, Yi1 ; 'GuoX Xu' Subject: 回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details Madhan: I have no comments

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-26 Thread Pethaiyan, Madhan
Hi All , Remider , request to review and provide feedback , Thanks, P. Madhan -Original Message- From: Pethaiyan, Madhan Sent: Thursday, March 14, 2024 1:47 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Liming Gao ; Liu, Zhiguang ; Li, Yi1 ; GuoX Xu Subject: RE: [edk2-devel

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-18 Thread Pethaiyan, Madhan
Hi Mike , I had raised new code review addressing the coding standard errors and those were not part of my change any way .. Thanks, P. Madhan -Original Message- From: Kinney, Michael D Sent: Sunday, March 10, 2024 1:47 AM To: devel@edk2.groups.io; Pethaiyan, Madhan Cc: Liming Gao

[edk2-devel] [PATCH V1 1/3] FmpDevicePkg: GetImageInfo Add missing conditions

2024-03-18 Thread Pethaiyan Madhan
d=4660 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li Cc: GuoX Xu Signed-off-by: Pethaiyan Madhan --- FmpDevicePkg/FmpDxe/FmpDxe.c | 52 +--- FmpDevicePkg/FmpDxe/FmpDxe.h | 15 --- 2 files changed, 43 insertions(+), 24 deletions(-) di

[edk2-devel] [PATCH V1 3/3] SignedCapsulePkg: Update GetImage and GetImageInfo description details

2024-03-18 Thread Pethaiyan Madhan
d=4660 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li Cc: GuoX Xu Signed-off-by: Pethaiyan Madhan --- .../SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 13 +++-- .../SystemFirmwareUpdate/SystemFirmwareDxe.h| 13 +++-- 2 files changed, 22 i

[edk2-devel] [PATCH V1 2/3] MdePkg: Update GetImage , GetImageInfo description details

2024-03-18 Thread Pethaiyan Madhan
d=4660 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li Cc: GuoX Xu Signed-off-by: Pethaiyan Madhan --- MdePkg/Include/Protocol/FirmwareManagement.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/FirmwareManagem

[edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-08 Thread Pethaiyan Madhan
d=4660 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li Cc: GuoX Xu Signed-off-by: Pethaiyan Madhan --- MdePkg/Include/Protocol/FirmwareManagement.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/FirmwareManagem

[edk2-devel] [PATCH V1] SignedCapsulePkg: Update GetImage and GetImageInfo description details

2024-03-08 Thread Pethaiyan Madhan
d=4660 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li Cc: GuoX Xu Signed-off-by: Pethaiyan Madhan --- .../SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 13 +++-- .../SystemFirmwareUpdate/SystemFirmwareDxe.h| 13 +++-- 2 files changed, 22 i

[edk2-devel] [PATCH V5] FmpDevicePkg: GetImageInfo Add missing conditions

2024-03-08 Thread Pethaiyan Madhan
d=4660 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li Cc: GuoX Xu Signed-off-by: Pethaiyan Madhan --- FmpDevicePkg/FmpDxe/FmpDxe.c | 20 +++- FmpDevicePkg/FmpDxe/FmpDxe.h | 15 --- 2 files changed, 27 insertions(+), 8 deletions(-) diff --g

[edk2-devel] [PATCH] MdePkg: Update GetImage , GetImageInfo description details

2024-02-27 Thread Pethaiyan Madhan
er needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageInfoSize is not too small and Image is NULL." and add new descriptions for "EFI_INVALID_PARAMETER" return code. REF: UEFI spec v2.10 23.1.2 Cc: Michael D Kinney Cc: Liming Gao Cc:

[edk2-devel] [PATCH V4] FmpDevicePkg: GetImageInfo Add missing conditions

2024-02-27 Thread Pethaiyan Madhan
er needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageInfoSize is not too small and Image is NULL." and add new descriptions for "EFI_INVALID_PARAMETER" return code. REF: UEFI spec v2.10 23.1.2 Cc: Michael D Kinney Cc: Liming Gao Cc:

[edk2-devel] [PATCH] SignedCapsulePkg: Update GetImage and GetImageInfo description details

2024-02-27 Thread Pethaiyan Madhan
er needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageInfoSize is not too small and Image is NULL." and add new descriptions for "EFI_INVALID_PARAMETER" return code. REF: UEFI spec v2.10 23.1.2 Cc: Michael D Kinney Cc: Liming Gao Cc:

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-19 Thread Pethaiyan, Madhan
Hi All, I had corrected the description, added the UEFI spec version and section details . Please check and approve it Thanks, P. Madhan -Original Message- From: Pethaiyan, Madhan Sent: Monday, January 8, 2024 12:13 PM To: devel@edk2.groups.io Cc: Pethaiyan, Madhan ; Gao, Liming

[edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-09 Thread Pethaiyan Madhan
From: "Pethaiyan, Madhan" UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney C

[edk2-devel] [PATCH] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-09 Thread Pethaiyan Madhan
From: "Pethaiyan, Madhan" 23.1 Firmware Management Protocol , Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu --- FmpDevice

[edk2-devel] [PATCH] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-04 Thread Pethaiyan Madhan
From: "Pethaiyan, Madhan" Mantis 1899 : Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2