Hi,
Any chance you could review this change? It's fairly simple.
Cheers,
Tom
On 03/01/2023 17:02, Tomas Pilar (tpilar) wrote:
From: Tomas Pilar
Create PcdShellDefaultDelay to configure the default
delay the shell provides for the user at the start time
if the user wishes to cancel
From: Tomas Pilar
Create PcdShellDefaultDelay to configure the default
delay the shell provides for the user at the start time
if the user wishes to cancel the execution of a potential
startup script.
The shell application already allows the user to override
the delay default value by
From: Tomas Pilar
Create PcdShellDefaultDelay to configure the default
delay the shell provides for the user at the start time
if the user wishes to cancel the execution of a potential
startup script.
The shell application already allows the user to override
the delay default value by
From: Tomas Pilar
Create PcdShellDefaultDelay to configure the default
delay the shell provides for the user at the start time
if the user wishes to cancel the execution of a potential
startup script.
The shell application already allows the user to override
the delay default value by
Move the logic that stores starting PCI attributes and sets the
EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to
DriverBindingStart() before the memory that backs the
DMA engine is allocated.
This ensures that the DMA-backing memory is not forcibly allocated
below 4G in system address map.
Move the logic that stores starting PCI attributes and sets the
EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to
DriverBindingStart() before the memory that backs the
DMA engine is allocated.
This ensures that the DMA-backing memory is not forcibly allocated
below 4G in system address map.
Move the logic that stores starting PCI attributes and sets the
EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to
DriverBindingStart() before the memory that backs the
DMA engine is allocated.
This ensures that the DMA-backing memory is not forcibly allocated
below 4G in system address map.
On 24/02/2022 13:19, Tomas Pilar (tpilar) wrote:
On 24/02/2022 13:14, Tomas Pilar (tpilar) wrote:
On 24/02/2022 13:13, Ard Biesheuvel wrote:
On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar)
wrote:
Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci
attribute
On 24/02/2022 13:14, Tomas Pilar (tpilar) wrote:
On 24/02/2022 13:13, Ard Biesheuvel wrote:
On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar)
wrote:
Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci
attribute to DriverBindingStart() before the memory that backs
On 24/02/2022 13:13, Ard Biesheuvel wrote:
On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar)
wrote:
Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci
attribute to DriverBindingStart() before the memory that backs the
DMA engine is allocated.
This ensures
Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci
attribute to DriverBindingStart() before the memory that backs the
DMA engine is allocated.
This ensures that the DMA-backing memory is not forcibly allocated
below 4G in system address map. Otherwise the allocation fails
On 24/02/2022 12:09, Ard Biesheuvel wrote:
On Thu, 24 Feb 2022 at 12:58, Ard Biesheuvel wrote:
On Thu, 24 Feb 2022 at 12:48, Tomas Pilar wrote:
Delay and move the allocation and mapping of memory that backs the DMA
engine in NvmExpress devices to NvmeInit() to ensure that
the allocation
Hi Sami,
Could you possibly have a look at my dynamic tables patches I submitted
last week?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63775): https://edk2.groups.io/g/devel/message/63775
Mute This Topic:
The Configuration Manager Protocol is updated to include
a FreeObject function that must be used by the callers to
GetObject to clean up any dynamic allocations and other resources
reserved by the Configuration Manager in the process of fulfilling the
request in GetObject.
A NULL inline static
Add user friendly strings for CmObjectIds to TableHelperLib
and add debug print invocations to common helper methods.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas Pilar
---
.../ConfigurationManagerDumpApp.c | 13 +--
.../ConfigurationManagerDumpApp.h | 8
Simplify the methods to use the other object getter methods.
The methods no longer need CfgMgr context parameter, the getter
helpers retrieve the singleton platform protocol.
The CfgMgrGetInfo always allocates the memory that is passed to the caller.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Add functions abstracting adding and removing of objects using
the ConfigurationManagerProtocol to TableHelperLib. Also add
helpers for writing component library constructors for component
libraries populating a ConfigurationManager.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas
In GCC10 the __stack_chk_guard global variable no longer exists,
the stack checking is done a different way. This patch includes the
BaseStackCheckLib as a NULL library which provides the global variable
explicitly. This fixes compilation with GCC10.
Cc: Sami Mujawar
Cc: Alexei Fedorov
This patch series updates the configuration manager protocol
API to allow for configuration managers that dynamically allocate
memory when servicing calls from the Dynamic Tables framework.
Helper methods are provided in TableHelperLib to ensure
backwards compatibility with configuration managers
Simple application to dump the contents of the configuration
manager loaded in the platform to the screen.
There is no provision in the ConfigurationManagerProtocol for
informing consumers of the contents of the database, so the app
scans through the known namespaces using the GetObject method.
The enums for CmObjectIds defined in Dynamic Tables Framework
that are used to identify types of configuration manager objects
already include their namespaces in the symbols for enum values.
Namespace enum values are shifted up by NAMESPACE_BIT_SHIFT and
the enums tables for CmObjectIds are
(change of email)
Hi Zhichao,
I've amended the patches and respun a v3 version. Any chance you could have a
look to see if I've fixed the issues correctly?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63443):
The tests for checking specific constraints and checking
for buffer overflows have been simplified to use a standard
set of templates defined in the logging facility.
This regularises some of the error handling and makes
it easier to write more tests like this in the future.
Cc: Ray Ni
Cc:
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5 +-
.../UefiShellAcpiViewCommandLib/AcpiViewLog.c |
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 225 --
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 6 +-
Remove superfluous accessor methods for error and warning
counters.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 4 ++
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 30 ---
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
Remove accessor method bloat by creating a configuration
struct that is linked using an extern symbol in the config header
file. Directly reference the config struct for all read
and write accesses in the entire module.
Rationalise the remaining methods in the config header and source.
Cc: Ray
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212 ---
.../UefiShellAcpiViewCommandLib/AcpiParser.h |
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Change-Id: I98b2c49b155e8c8b91aaf9bbd2ab21ebad5b36f0
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 225 --
Remove accessor method bloat by creating a configuration
struct that is linked using an extern symbol in the config header
file. Directly reference the config struct for all read
and write accesses in the entire module.
Rationalise the remaining methods in the config header and source.
The tests for checking specific constraints and checking
for buffer overflows have been simplified to use a standard
set of templates defined in the logging facility.
This regularises some of the error handling and makes
it easier to write more tests like this in the future.
Change-Id:
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Change-Id: I46bba2afc6fe8d7bc0c92ec7054f2af2d2254441
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Change-Id: I9c43c9ce1e9809813949b4f45b1b19b6265e18c4
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Change-Id: I02c30939f2c5ad98da7174303ae241839d2c8eba
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Change-Id: I8f074178154e13db06a67f2158448fc625ee4216
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1
Remove superfluous accessor methods for error and warning
counters.
Change-Id: I23df0aa10cfc757f37d83dee7ecce8a188a3ad1c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
Hi Ray, Zhichao,
Did you have any opinions on my acpiview error handling patches?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#62097): https://edk2.groups.io/g/devel/message/62097
Mute This Topic:
It looks like GCC5_X64_CC_FLAGS pick up GCC48_ALL_CC_FLAGS as the lowest level
flag list, so this change will not apply to compilations on the X64
architecture.
That said, I suspect that X64 architecture will likely have the biggest issues
with disallowing void* arithmetic, so we either:
1.
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212 ---
.../UefiShellAcpiViewCommandLib/AcpiParser.h |
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 30
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 224 --
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 6 +-
The tests for checking specific constraints and checking
for buffer overflows have been simplified to use a standard
set of templates defined in the logging facility.
This regularises some of the error handling and makes
it easier to write more tests like this in the future.
Cc: Ray Ni
Cc:
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5 +-
.../UefiShellAcpiViewCommandLib/AcpiViewLog.c |
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
Remove accessor method bloat by creating a configuration
struct that is linked using an extern symbol in the config header
file. Directly reference the config struct for all read
and write accesses in the entire module.
Rationalise the remaining methods in the config header and source.
Cc: Ray
Remove superfluous accessor methods for error and warning
counters.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 4 ++
Oh, it looks like any pull requests created by non-maintainers get auto-closed
by mergify. Nevermind then.
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 29 June 2020 15:11
To: devel@edk2.groups.io
Cc: Ray Ni ; Zhichao Gao ; Sami
Mujawar
Subject: [edk2-devel
Hi Ray, Zhichao,
I've created a pull request with the standalone acpiview patches for your
convenience. Could you please merge it once it passes the CI checks?
Cheers,
Tom
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are
The UefiShellAcpiViewCommandLib is converted from NULL library to a
named library so that it may be used in modules other than shell.
The library interface exposes the main method for to AcpiView
functionality as well as a helper method to dump a buffer to a file.
The Shell module is still
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 205
Method is refactored into two parts. A new method is
created that dumps arbitrary buffers into a newly created
file. This method is called from core code after the core code
determined the appropriate filename to be used.
This improves the modular design.
Cc: Ray Ni
Cc: Zhichao Gao
A new file and header (AcpiViewConfig.[ch]) is created
that houses the user configuration. This declutters the
core code and improves modularity of the design.
The module level symbols for verbosity, table selection, and
highlighting are refactored into the new file.
Cc: Ray Ni
Cc:
This patchset adds a new application module to the
ShellPkg with the functionality of the 'acpiview' command.
The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.
The
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4
Simple application wrapper that invokes the shell
command wrapper for 'acpiview'.
This allows the AcpiView functionality to be used
on platforms with older specifications of the UEFI
shell or where the 'acpiview' command is not built in
due to platform build configuration.
Furthermore,
Hi Ray, Zhichao,
Do you have any opinions on the respun patches?
Cheers,
Tom
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 15 June 2020 15:04
To: devel@edk2.groups.io
Cc: nd ; Ray Ni ; Zhichao Gao
Subject: [edk2-devel] [PATCH v3
A new file and header (AcpiViewConfig.[ch]) is created
that houses the user configuration. This declutters the
core code and improves modularity of the design.
The module level symbols for verbosity, table selection, and
highlighting are refactored into the new file.
Cc: Ray Ni
Cc: Zhichao Gao
Method is refactored into two parts. A new method is
created that dumps arbitrary buffers into a newly created
file. This method is called from core code after the core code
determined the appropriate filename to be used.
This improves the modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 205
Simple application wrapper that invokes the shell
command wrapper for 'acpiview'.
This allows the AcpiView functionality to be used
on platforms with older specifications of the UEFI
shell or where the 'acpiview' command is not built in
due to platform build configuration.
Furthermore, this app
The UefiShellAcpiViewCommandLib is converted from NULL library to a
named library so that it may be used in modules other than shell.
The library interface exposes the main method for to AcpiView
functionality as well as a helper method to dump a buffer to a file.
The Shell module is still built
This patchset adds a new application module to the
ShellPkg with the functionality of the 'acpiview' command.
The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.
The
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4
Message-
> From: devel@edk2.groups.io On Behalf Of Tomas
> Pilar
> (tpilar)
> Sent: Friday, May 22, 2020 2:44 AM
> To: devel@edk2.groups.io
> Cc: n...@arm.com; Ni, Ray ; Gao, Zhichao
>
> Subject: [edk2-devel] [PATCH v2 6/6] ShellPkg/AcpiView: Add
> application wrapp
Krzysztof has moved on to other pastures, I'll respin the patches accordingly.
Cheers,
Tom
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
groups.io
Sent: 11 June 2020 08:43
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: Ni, Ray ; Sami Mujawar ;
Hi Kumar,
The UEFI drivers follow a two stage loading mechanism. When the driver is
loaded/executed, it loads itself into memory and installs a
DRIVER_BINDING_PROTOCOL on its own handle. That protocol provides API for the
platform to ask the driver whether it supports a particular device and
Hi,
By no means a complete answer but some important points below.
There are two important concepts in UEFI that you absolutely need to get
comfortable with. These two are Handles and Protocols.
You can think of a protocol as an implementation of a well defined API that
allows you to do
Hi Zhichao,
Thank you very much, I am just trying to make sure things don't slip through
the cracks.
Cheers,
Tom
From: Gao, Zhichao
Sent: 29 May 2020 01:31
To: Tomas Pilar ; devel@edk2.groups.io; Ni, Ray
Cc: nd
Subject: RE: AcpiView Patches
Sorry, Pilar. I am busy at other things. Plan to
Hi,
Any chance you had time to look at my AcpiView patches?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#60396): https://edk2.groups.io/g/devel/message/60396
Mute This Topic: https://groups.io/mt/74519195/21656
Group
This will probably be down to the [send-email] section of git config, do you
have smtpEncryption enabled by any chance?
You could also try updating the required package:
perl -MCPAN -e 'install "IO::Socket::SSL"'
From: devel@edk2.groups.io On Behalf Of Bret Barkelew
via groups.io
Sent: 27 May
Based on the output, am I correct in assuming that the generated
ABCPPSupportLib makefile does not have a rule for making ABCPPSupportLib.obj?
Tom
From: devel@edk2.groups.io On Behalf Of David F. via
groups.io
Sent: 25 May 2020 08:56
To: devel@edk2.groups.io
Subject: [edk2-devel] Updating to
I actually agree with you, when we migrated from reviewboard to github pull
requests, I was sorely disappointed with the PR functionality and ergonomics.
Tomas Pilar
-Original Message-
From: r...@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: 14 May 2020 22:47
To:
Simple application wrapper that invokes the shell
command wrapper for acpiview.
This allows the AcpiView functionality to be used
on platforms with older specifications of the UEFI
shell or where the 'acpiview' command is not built in
due to platform build configuration.
Furthermore, this app
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
205
Method is refactored into two parts. A new method is
created that dumps arbitrary buffers into a newly created
file. This method is called from core code after the core code
determined the appropriate filename to be used.
This improves the modular design.
Cc: Ray Ni
Cc: Zhichao Gao
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5 insertions(+), 3
A new file and header (AcpiViewConfig.[ch]) is created
that houses the user configuration. This declutters the
core code and improves modularity of the design.
The module level symbols for verbosity, table selection, and
highlighting are refactored into the new file.
Cc: Ray Ni
Cc: Zhichao Gao
This patchset adds a new application module to the
ShellPkg with the functionality of the 'acpiview' command.
The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.
The
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Well, it looks like the settings for send-email don't Just Work (tm), I'll
clean up the series and resubmit. Apologies for spamming the list.
Tom
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 21 May 2020 19:16
To: devel@edk2
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
205
A new file and header (AcpiViewConfig.[ch]) is created
that houses the user configuration. This declutters the
core code and improves modularity of the design.
The module level symbols for verbosity, table selection, and
highlighting are refactored into the new file.
Cc: Ray Ni
Cc:
This patchset adds a new application module to the
ShellPkg with the functionality of the 'acpiview' command.
The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.
The
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5 insertions(+), 3
Simple application wrapper that invokes the shell
command wrapper for acpiview.
This allows the AcpiView functionality to be used
on platforms with older specifications of the UEFI
shell or where the 'acpiview' command is not built in
due to platform build configuration.
Furthermore,
Method is refactored into two parts. A new method is
created that dumps arbitrary buffers into a newly created
file. This method is called from core code after the core code
determined the appropriate filename to be used.
This improves the modular design.
Cc: Ray Ni
Cc: Zhichao Gao
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
​Sorry Guys, I did not see the previous email. I don't claim my clang-format is
perfect, you might need to tweak it a little.
---
BasedOnStyle: LLVM
AlignAfterOpenBracket: Align
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
Oh but I am using clang-format to get vscode to format things according to
proper code style.
From: Tomas Pilar
Sent: 24 December 2019 12:36
To: Devel EDK2 ; 'ray...@intel.com'
Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code?
I don't know about clangd but I am
I don't know about clangd but I am successfully using the vscode intellisense
with EDKII including the multiple workspaces.
It took some time to configure things with paths and includes to make it work
correctly but the only problem I have at the moment is to get it to use the
correct
Hi Vikash,
If I remember correctly, those BIOSes have a binary CMS choice for CSM with
regards to options ROMs. Either you permit legacy option ROMs or you permit
UEFI option ROMs and there is not way to permit both at the same time. Make
sure that these settings are configured correctly.
I would like to add a new package to support Solarflare Communications
adapters. This package will eventually host drivers and utilities for
a number of products, most of them network adapters.
Ideally, I would like this to start with a devel-sfc branch. Leif
helpfully offered to do git lifting
This package is for Solarflare Communications drivers and utilities.
Signed-off-by: Tomas Pilar
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Drivers/SfcPkg/Readme.md | 11 +++
Maintainers.txt | 4
Readme.md| 7 +++
3 files changed, 22 insertions(+)
1 - 100 of 119 matches
Mail list logo
