Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

2021-02-22 Thread Wang, Sunny (HPS SW)
and emails. Reviewed-by: Sunny Wang -Original Message- From: Li, Walon Sent: Friday, February 19, 2021 5:40 PM To: devel@edk2.groups.io Cc: Li, Walon ; Wang, Sunny (HPS SW) ; ler...@redhat.com; ray...@intel.com; hao.a...@intel.com; gaolim...@byosoft.com.cn Subject: [PATCH v2] MdeModulePkg

Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2021-02-22 Thread Wang, Sunny (HPS SW)
Samer El-Haj-Mahmoud ; Andrei Warkentin (awarken...@vmware.com) ; Wang, Sunny (HPS SW) ; zhichao@intel.com; ray...@intel.com; Ard Biesheuvel ; Andrew Fish ; Michael D Kinney ; Jian J Wang ; Hao A Wu Subject: Re: [EXTERNAL] Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Sig

Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe

2021-02-08 Thread Wang, Sunny (HPS SW)
also think it's fine to have this change. Reviewed-by: Sunny Wang < sunnyw...@hpe.com> Regards, Sunny Wang -Original Message- From: Dong, Guo Sent: Saturday, February 6, 2021 7:16 AM To: Patrick Rudolph ; Wang, Sunny (HPS SW) Cc: devel@edk2.groups.io; Park, Aiden ; You, Be

Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe

2021-02-03 Thread Wang, Sunny (HPS SW)
Hi Patrick, I'm not familiar with UefiPayloadPkg. However, since we may want to enable the trusted console as earlier as possible, you may still need to keep the PlatformConsoleInit() call at the beginning of PlatformBootManagerBeforeConsole() to support the platform that has trusted/on-board

Re: [edk2-devel] Open Design Meeting to discuss storage/configuration purge design

2020-09-17 Thread Wang, Sunny (HPS SW)
Thanks, Ray. Hi All, If you're working on option cards' UEFI driver (especially storage card UEFI driver), welcome to join the meeting and provide your valuable thoughts. Regards, Sunny Wang From: Ni, Ray Sent: Thursday, September 17, 2020 5:25 PM To: devel@edk2.groups.io Cc: Wang, Sunny (HPS

Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

2020-06-22 Thread Wang, Sunny (HPS SW)
Looks good to me. Not sure if there was a reason to call BmDestroyRamDisk before ReportStatusCode. By the way, it is an interesting case that there is a custom boot option or application that needs the memory that was occupied by the RAM disk. It looks to me like the custom boot option or

Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2020-06-17 Thread Wang, Sunny (HPS SW)
hink that would be an easier solution. Regards, Sunny Wang -Original Message- From: Pete Batard [mailto:p...@akeo.ie] Sent: Wednesday, June 17, 2020 6:59 PM To: Wang, Sunny (HPS SW) ; devel@edk2.groups.io Cc: zhichao@intel.com; ray...@intel.com; ard.biesheu...@arm.com; l...@nuvia

Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2020-06-17 Thread Wang, Sunny (HPS SW)
Hi Pete. Since the EfiBootManagerProcessLoadOption is called by ProcessLoadOptions as well, your change would also cause some unexpected behavior like: 1. Signal one more ReadyToBoot for the PlatformRecovery option which is an application that calls EfiBootManagerBoot() to launch its recovered

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-05 Thread Wang, Sunny (HPS SW)
and show the message to users. Regards, Sunny Wang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang, Sunny (HPS SW) Sent: Wednesday, March 4, 2020 3:53 PM To: devel@edk2.groups.io; ray...@intel.com; Sean Brogan ; Kinney, Michael D Cc: Wei, Kent

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-03 Thread Wang, Sunny (HPS SW)
Sure! Regards, Sunny Wang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray Sent: Wednesday, March 4, 2020 3:26 PM To: devel@edk2.groups.io; Wang, Sunny (HPS SW) ; Sean Brogan ; Kinney, Michael D Cc: Wei, Kent (HPS SW) ; Spottswood, Jason

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-03 Thread Wang, Sunny (HPS SW)
at our offline discussion, Ray. :) Regards, Sunny Wang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray Sent: Wednesday, March 4, 2020 11:46 AM To: Sean Brogan ; Kinney, Michael D ; Wang, Sunny (HPS SW) Cc: Ni, Ray ; devel@edk2.groups.io

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2020-02-06 Thread Wang, Sunny (HPS SW)
look workable to me. I will give them a try. Thanks! Regards, Sunny Wang -Original Message- From: Ashish Singhal [mailto:ashishsin...@nvidia.com] Sent: Tuesday, December 24, 2019 12:48 PM To: Wang, Sunny (HPS SW) ; Ni, Ray ; devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A ; Gao

Re: [edk2-devel] [PATCH v7] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2019-12-23 Thread Wang, Sunny (HPS SW)
Looks good enough to me. Thanks for addressing my comments, Ashish. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ashish Singhal Sent: Tuesday, December 24, 2019 10:58 AM To: devel@edk2.groups.io; ray...@intel.com;

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2019-12-23 Thread Wang, Sunny (HPS SW)
Message- From: Ni, Ray [mailto:ray...@intel.com] Sent: Tuesday, December 24, 2019 10:40 AM To: Wang, Sunny (HPS SW) ; devel@edk2.groups.io; ashishsin...@nvidia.com; Wang, Jian J ; Wu, Hao A ; Gao, Zhichao ; Kinney, Michael D ; 'Andrew Fish (af...@apple.com)' Cc: Spottswood, Jason Subject: RE

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2019-12-20 Thread Wang, Sunny (HPS SW)
in EfiBootManagerRefreshAllBootOption), the original function name "RefreshAllBootOptions" may cause some confusion. Regards, Sunny Wang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ashish Singhal Sent: Friday, December 20, 2019 12:38 AM To: Wang, Sunny (HPS S

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2019-12-19 Thread Wang, Sunny (HPS SW)
1. Is it a proper solution to the problem? Yes, it already solved my concern discussed in the other email. 2. Is the new protocol/function name proper? Yes, but I'm not good at naming. We may need others' feedback. :) 3. Are the parameters in the function proper? How about we only

Re: [edk2-discuss] [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-12-17 Thread Wang, Sunny (HPS SW)
Sorry for the delay. Somehow I didn't catch the follow-up email. Thanks for checking my comments, Ray and Ashish. Yeah, agree. 2.b is better. I will review the code change. Regards, Sunny Wang -Original Message- From: disc...@edk2.groups.io [mailto:disc...@edk2.groups.io] On Behalf Of

Re: [edk2-discuss] [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-12-11 Thread Wang, Sunny (HPS SW)
Hi all, Since I can't attend the design meeting (EMEA), I would like to add some use cases and a suggestion for your guys' reference before this topic being discussed: We had similar needs (use cases) as Ashish like the following, so making this code change would be definitely good for

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/BdsDxe: Set RuntimeServicesSupported variable

2019-11-22 Thread Wang, Sunny (HPS SW)
Thanks for the clarification, Ray. Regards, Sunny Wang -Original Message- From: Ni, Ray [mailto:ray...@intel.com] Sent: Thursday, November 21, 2019 7:51 PM To: devel@edk2.groups.io; Wang, Sunny (HPS SW) ; Gao, Zhichao ; Jeff Brasen ; edk2-de...@lists.01.org Cc: Gao, Liming ; Kinney

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/BdsDxe: Set RuntimeServicesSupported variable

2019-11-21 Thread Wang, Sunny (HPS SW)
Hi Ray, May I know why we need to put this PCD to [PcdsFixedAtBuild, PcdsPatchableInModule] section only? If the reason is the security concern, Locking the variable (value of PCD) at the EndOfDxe should be secure enough. For the platforms that want to make it more secure (don't want the PCD

Re: [edk2-devel] Use a pcd to control PlatformRecovery

2019-10-21 Thread Wang, Sunny (HPS SW)
ks on the task below, there will be no OS or OS tool supporting it. :) - https://github.com/rhboot/efibootmgr/issues/41 Regards, Sunny Wang -Original Message- From: Ni, Ray [mailto:ray...@intel.com] Sent: Wednesday, October 16, 2019 4:43 PM To: Wang, Sunny (HPS SW) ; devel@edk2.groups.io; Gao, Zhich

Re: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make PlatformRecovery work regardless of OsIndications

2019-10-16 Thread Wang, Sunny (HPS SW)
: Gao, Zhichao [mailto:zhichao@intel.com] Sent: Wednesday, October 16, 2019 4:36 PM To: devel@edk2.groups.io; ler...@redhat.com; Wang, Sunny (HPS SW) Cc: Ni, Ray ; Li, Walon Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make PlatformRecovery work regardless of OsIndications

Re: [edk2-devel] Use a pcd to control PlatformRecovery

2019-10-16 Thread Wang, Sunny (HPS SW)
.groups.io] On Behalf Of Gao, Zhichao Sent: Wednesday, October 16, 2019 1:57 PM To: Wang, Sunny (HPS SW) ; devel@edk2.groups.io; Ni, Ray Cc: Wang, Jian J ; Wu, Hao A ; Zeng, Star ; Gao, Liming ; Sean Brogan ; Michael Turner ; Bret Barkelew ; Li, Walon ; Wei, Kent (HPS SW) Subject: Re: [edk2-

[edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make PlatformRecovery work regardless of OsIndications

2019-10-16 Thread Wang, Sunny (HPS SW)
According to the UEFI specification section 3.4.1 and 3.4.2, the OsRecovery and PlatformRecovery options should still be processed regardless of the value of OsIndications variable if processing of BootOrder does not result in success. Therefore, update the code to check

[edk2-devel] Use a pcd to control PlatformRecovery

2019-10-15 Thread Wang, Sunny (HPS SW)
Hi Zhichao and Ray, I have some questions about this code change. Sorry for being late to bring my questions here. For now, the code block for iterating the PlatformRecovery variables is controlled by OsIndications variable. However, it looks to me like that the PlatformRecovery