On 2019-04-24 13:17, Laszlo Ersek wrote:
>
> And, again, that's exactly how the sender is displayed to me by
> Thunderbird, in my list folder only:
>
> From: Rebecca via Groups.Io
>
> Again, in email that I get directly from Rebecca, the From field looks
> ju
On 2019-04-26 07:56, Andrew Fish via Groups.Io wrote:
> That one seemed to work!
Great! Though it looks like you're going to have a problem: I see "From:
Andrew Fish via Groups.Io "
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
On 2019-04-26 14:19, Laszlo Ersek wrote:
>
> This one looks good -- the From address has changed from
>
> rebecca via Groups.Io
>
> to
>
> rebe...@bluestop.org
Oh, it's in their FAQ! :D
https://groups.io/static/help#dmarc
Why Are Emails From Some People
On 2019-04-12 01:54, Laszlo Ersek wrote:
>
> obviously the "machine hardware name" is non-portable either, when we
> consider FreeBSD.
>
> Either way I've obsessed enough about this.
>
> Reviewed-by: Laszlo Ersek
Could someone com
named/reorganized/integrated)?
It seems such a useful addition for debugging UEFI code running under
OVMF that it would be nice to have it somewhere it has less chance of
bitrotting.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply O
2/tree/bhyve/edk2-stable201903) but
it didn't work and I didn't have time to look into why. It might just be
because Bhyve's gdb server is fairly basic at the moment.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
the TCP stack reports in the debug output that it's sent
a SYN packet, but I don't see it in Wireshark, and the connection
attempt eventually times out. I'm only able to reconnect if I call
tcp4sb->CreateChild() to get a new instance.
-- Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
t
> variable settings, etc. This provides easy methods for common repos
> to share build tools/steps.
>
Is there not an existing framework that could be used instead of
creating something new?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
t submits a "smoke" job to Jenkins and
collects the results for pre-commit testing, while the same instance
also checks for new changesets in the main repo and runs CI builds
against them.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this grou
work, not the client, that does things like packaging
etc., and this proposal will include server-side code too.
Also, I don't think there is anything that'll be as nicely integrated as
this, so I'm happy with it.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive a
to ask about it since it's in
the MarvellEmbeddedProcessors project and not TianoCore, but - I was
wondering where the place would be to add support libraries needed to
enable HTTP and TLS support? Would it be in
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc, or in
NetworkPkg/Network.dsc.inc i
I noticed that OpenSSL 1.1.1d was released on September 10th. I was
wondering if there are plans in progress to upgrade EDK2 to use it?
For me, it'll fix a problem building on FreeBSD.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
I was wondering if there were any plans to update the code for the UP
Squared that's on the devel-IntelAtomProcessorE3900 branch of
edk2-platforms?
I guess with mention of support for the UP Xtreme, the UP Squared isn't
going to have any more work done on it?
--
Rebecca Cran
On 2019-1
_ with anything older
than VS2012. From "edksetup.bat -h"
...
ForceRebuild Force a full rebuild of BaseTools binaries.
VS2012 Set the env for VS2012 build.
VS2013 Set the env for VS2013 build.
VS2015 Set the env for VS2015 build.
VS2017 S
The parameter to select which version of Visual Studio to use when
building BaseTools only goes back to VS2012. Add support for VS2008 and
VS2010 and fix the code to avoid selecting a newer version if the user
has requested a specific version.
Signed-off-by: Rebecca Cran
---
BaseTools
ne
> the edk2 instructions a bit more obvious.
I think we came to the conclusion that "--recursive" isn't needed. But
I've found that there are cases where "--force" is required to make sure
git checks out a submodule correctly.
--
Rebecca Cran
-=-=-=-=-=-=-=
On 2019-08-29 14:22, Michael D Kinney wrote:
> This is based on work from a number of EDK II community
> members that have provide valuable input and evaluations.
>
> * Rebecca Cran Jenkins evaluation
> * Laszlo Ersek GitLab evaluation
> * Philippe Mathieu-Daudé GitLab e
"rbt land") which automates the checks and pushes the changeset.
I understand that with Azure Pipelines and how it integrates with
Github, along with the fact that this project doesn't use pull requests
or any other review automation, means things are probably going to be
pre
test, not trying to build it locally?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47337): https://edk2.groups.io/g/devel/message/47337
Mute This Topic: https://groups.io/mt/33072637/21656
Group Owner: devel+ow...@edk2
bles.md).
What's the relevance of "stuart"?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50242): https://edk2.groups.io/g/devel/message/50242
Mute This Topic: https://groups.io/mt/44874101/21656
G
m not used to
using them.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50313): https://edk2.groups.io/g/devel/message/50313
Mute This Topic: https://groups.io/mt/44980130/21656
Group Owner: devel+ow...@edk2.groups.io
s/edk2toolext/environment/extdeptypes/nuget_dependency.py",
line 95, in _fetch_from_cache
if not os.path.isdir(NugetDependency.global_cache_path):
File "/usr/lib/python3.7/genericpath.py", line 42, in isdir
st = os.stat(s)
TypeError: stat: path should be string, bytes,
I noticed the edk2-docs are hosted on the *legacy* gitbook.com site, at
https://legacy.gitbook.com/@edk2-docs .
Are there any plans to migrate to the new version
(https://docs.gitbook.com/getting-started/migrating-from-the-previous-version)?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
[replying to devel@]
On 2019-06-10 12:47, Stephano Cetola wrote:
>
> Documentation
> -----
> Rebecca is hosting the Doxygen docs from packages on her server, and
> it is probably better if we use a cloud service to host these, or
> better yet, our current gitbooks syst
This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined
since dso_openssl.c only compiles the function if DSO_NONE is defined.
Signed-off-by: Rebecca Cran
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +-
2
On 2019-06-13 17:32, Rebecca Cran wrote:
> This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined
> since dso_openssl.c only compiles the function if DSO_NONE is defined.
Sorry, I just realized this isn't applicable to the OpenSSL we currently
pull in: I was test
is not possible. (For example, running under an OS
where an OS process hosts the UEFI emulation environment.)"
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42446): https://edk2.groups.io/g/devel/message/42446
Mu
#x27;ve created the following Bugzilla to track progress on
debugging/fixing it: https://bugzilla.tianocore.org/show_bug.cgi?id=1917
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42449): https://edk2.groups.io/g/deve
On 2019-06-17 04:54, Fan, ZhijuX wrote:
> GenBiosId is a tool to generate the BIOS ID binary file which uses
> the data from the configuration file.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1846
pylama (https://github.com/klen/pylama) reports the following issues:
bcran@photon:~/workspa
e format: need a config section"
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42515): https://edk2.groups.io/g/devel/message/42515
Mute This Topic: https://groups.io/mt/32093449/21656
Group Owner: devel+ow...@edk2.groups.io
U
te Tls Child Handle
Http->Request failed: 7
Error: Could not retrieve NBP file size from HTTP server.
Error: Network device error.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42516): https://edk2.groups.i
On 2019-06-17 16:14, rebe...@bluestop.org wrote:
> I'm having problems using HTTPS boot in OVMF: Http->Request can't find
> the EFI_TLS_SERVICE_BINDING_PROTOCOL.
>
It appears the OpenSSL update broke it. Revision b739678918 works, but
f03859ea6c doesn
l. So it seems the breakage is limited to running
OVMF built on FreeBSD, which I'll work on myself to fix.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42552): https://edk2.groups.io/g/devel/message/42552
Mute
On 2019-06-18 07:26, Liming Gao wrote:
> Rebecca:
> Thanks for your report. Now, pylama is not the requirement for BaseTools
> python script. Patch contributor can base on the report to fix the critical
> issue.
I know it's not a required tool, but many of these are co
d on Linux the NOOPT build also doesn't work, while RELEASE
does. And on FreeBSD the RELEASE and DEBUG builds work, but just NOOPT
doesn't.
Could you check if the NOOPT OVMF build works with HTTPS on your system,
please?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Lin
On 2019-06-19 01:22, Xiaoyu Lu wrote:
> This problem was found by Rebecca Cran .
> REF: https://edk2.groups.io/g/devel/topic/32100684
>
> OpenSSL will automatically load a system config file which configures
> default ssl options. In UEFI, It will cause TlsInitialize f
penSSL commit (25eb9299) first introduced in OpenSSL_1_1_1b change
> openssl_config_int
> function will cause this problem.
>
> And I made a patch for it. You can find it at
> https://edk2.groups.io/g/devel/message/42577
Thanks! That fixed the problem.
--
Rebecca Cran
-=-=-=
, I think this should be CC'd to r...@edk2.groups.io
(https://edk2.groups.io/g/rfc)?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42662): https://edk2.groups.io/g/devel/message/42662
Mute This Topic: https://g
I noticed the BroxtonPlatformPkg, needed for Intel Atom E3900 support,
isn't in edk2-platforms master but only in the
devel-IntelAtomProcessorE3900 branch. Was that deliberate, or an oversight?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
n
> export PYTHON_COMMAND=$python
>fi
I think using the "-lt" operator might be better (more standard). e.g.:
if [ "$origin_version" -lt "$python_version" ]; then
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all me
ot; < "$b" ]]*
*if [ "$a" \< "$b" ]*
Note that the "<" needs to be escaped
<http://tldp.org/LDP/abs/html/escapingsection.html#ESCP> within a *[
]* construct.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: Yo
m going to change it to
>
> if [[ "$origin_version" < "$python_version" ]]; then
>
That's fine for now, hopefully it'll keep working as long as it needs to.
But once you're comparing for example 3.7 and 3.12:
[bcran@photon ~
Signed-off-by: Rebecca Cran
---
edksetup.sh | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index c7b2e1e201..61e988035f 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -108,27 +108,27 @@ function SetupEnv
-w" confirms there are no functionality changes.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42930): https://edk2.groups.io/g/devel/message/42930
Mute This Topic: https://groups.io/mt/32217032/21656
Group Ow
=TRUE set.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43026): https://edk2.groups.io/g/devel/message/43026
Mute This Topic: https://groups.io/mt/32217032/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
ople's inboxes.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43097): https://edk2.groups.io/g/devel/message/43097
Mute This Topic: https://groups.io/mt/32267733/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubsc
On 2019-07-10 13:04, Michael D Kinney wrote:
> +set -e
> +
Reviewed-by: Rebecca Cran
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43635): https://edk2.groups.io/g/devel/message/43635
Mute This Topic:
oks like these changes are for getting ready to move the code into
master.
I've just started working on porting the BroxtonPlatformPkg over to
master too, and just wanted to check if you know if anyone's already
working on it? If so, I'll stop my work to avoid the dupl
Reviewed-by: Rebecca Cran
On 7/10/19 1:05 PM, Michael D Kinney wrote:
From: Gary Lin
When setting NETWORK_TLS_ENABLE to TRUE, we need TlsLib.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 3
bld_vlv.sh should probably have "set -e" at the top, like the change to
Build_IFWI.sh
See https://bugzilla.tianocore.org/show_bug.cgi?id=1599 ("bld_vlv.sh
isn't `set -e` and doesn't check if commands completed successfully").
--
Rebecca Cran
On 7/10/19 1
On 2019-07-10 15:17, Rebecca Cran wrote:
> o Use '$SCRIPTNAME' consistently instead of 'edksetup.sh'
>
> o Use the bash environment variable $PWD instead of executing the pwd
> command.
>
> o Add quotes around variables to ensure they're evaluated c
On 2019-07-12 10:23, Michael D Kinney wrote:
> Hi Rebecca,
>
> Vlv2 is already in edk2-platforms/master. This patch series is fixing some
> Linux/GCC build issues.
>
> I have a few more queued up after this to make it even better by
> removing the use of the FCE tool in t
ll reports "Core Version: UEFI 2.3.1".
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43670): https://edk2.groups.io/g/devel/message/43670
Mute This Topic: https://groups.io/mt/32445906/21656
Group Owner: devel+
ld' as
the GUID string.
Signed-off-by: Rebecca Cran
---
.../Feature/Capsule/GenerateCapsule/GenCapsuleAll.sh | 10 ++
.../Capsule/GenerateCapsule/GenCapsuleMinnowMax.sh | 2 ++
.../GenerateCapsule/GenCapsuleMinnowMaxRelease.sh | 2 ++
.../Capsule/GenerateCapsule/GenC
e list are to single lines.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43723): https://edk2.groups.io/g/devel/message/43723
Mute This Topic: https://groups.io/mt/32421563/21656
Group Owner: devel+ow...@edk2.groups.io
slip through review. (And we've had issues with
> this in the past in edksetup.sh.)
Thanks, I understand now. I'll resubmit the changes as a series.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43726
Signed-off-by: Rebecca Cran
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 12a3e26a67..ab58fe4a6e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -71,7 +71,7 @@ function SetWorkspace()
#
# Set $WORKSPACE
#
- export
Signed-off-by: Rebecca Cran
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 752e47e7cb..76c8d7916e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -199,7 +199,7 @@ do
break
;;
esac
- I=$(($I - 1))
+ I=$((I - 1
Signed-off-by: Rebecca Cran
---
edksetup.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index e2f116f8bc..ba055d5d5a 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -118,7 +118,7 @@ function SetupPython3()
function SetupPython()
{
- if
Signed-off-by: Rebecca Cran
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 76c8d7916e..06d2f041e6 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -194,7 +194,7 @@ do
RECONFIG=TRUE
shift
;;
--?|-h|--help
Signed-off-by: Rebecca Cran
---
edksetup.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index ab58fe4a6e..752e47e7cb 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -49,11 +49,11 @@ function SetWorkspace()
return 0
fi
- if
On Linux, "whereis" matches python3, python3.7, as well as
man pages, libs etc. While on macOS it only matches the specified
name, and so misses python3.7. Improve this by looping over
potential version numbers and seeing if such a binary exists and
can be executed.
Signed-off-by: Re
different goals: *one* goal, of simplifying the script :)
Anyway, I've resubmitted the changes as a series. Now back to my day job.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43749): https://edk2.groups.io/g/dev
nt
> default behavior". Is that the reason?
No, it's mainly as a (very minor) optimization: `pwd` runs the command
(even as a built-in), whereas $PWD simply evaluates the value of the
variable.
Also, modern scripts as I understand it should generally use $(...) to
ru
low-up patch to fix the
others and further reduce the number of shellcheck warnings.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43765): https://edk2.groups.io/g/devel/message/43765
Mute This Topic: https://groups.i
7;command -v' instead.".
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43766): https://edk2.groups.io/g/devel/message/43766
Mute This Topic: https://groups.io/mt/32483827/21656
Group Owner: devel+ow...@edk2.groups.io
Unsu
On Linux, "whereis" matches python3, python3.7, as well as
man pages, libs etc. While on macOS it only matches the specified
name, and so misses python3.7. Improve this by looping over
potential version numbers and seeing if such a binary exists and
can be executed.
Signed-off-by: Re
inaries to use.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43791): https://edk2.groups.io/g/devel/message/43791
Mute This Topic: https://groups.io/mt/32485955/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe
creating a symlink in BaseTools/Bin/FreeBSD-amd64, which is what I've
been doing.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43797): https://edk2.groups.io/g/devel/message/43797
Mute This Topic: https://gro
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
---
edksetup.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index ab58fe4a6e..752e47e7cb 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -49,11 +49,11 @@ function SetWorkspace()
return
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 752e47e7cb..76c8d7916e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -199,7 +199,7 @@ do
break
;;
esac
- I
This is a (very minor) optimization: `pwd` runs the command (even as a
built-in), whereas $PWD simply evaluates the value of the variable.
ALso, modern scripts should generally use $(...) to run commands,
instead of `...`.
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
---
edksetup.sh
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 76c8d7916e..06d2f041e6 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -194,7 +194,7 @@ do
RECONFIG=TRUE
shift
There are unquoted variables that remain: only the ones considered most
important to fix (in terms of potential bugs) were changed in this
commit.
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif Lindholm
---
edksetup.sh | 4 ++--
1 file changed, 2 insertions(+), 2
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif Lindholm
---
edksetup.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index ab58fe4a6e..752e47e7cb 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -49,11 +49,11
On Linux, "whereis" matches python3, python3.7, as well as
man pages, libs etc. While on macOS it only matches the specified
name, and so misses python3.7. Improve this by looping over
potential version numbers and seeing if such a binary exists and
can be executed.
Signed-off-by: Re
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif Lindholm
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 76c8d7916e..06d2f041e6 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -194,7 +194,7 @@ do
This is a (very minor) optimization: `pwd` runs the command (even as a
built-in), whereas $PWD simply evaluates the value of the variable.
ALso, modern scripts should generally use $(...) to run commands,
instead of `...`.
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif Lindholm
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 752e47e7cb..76c8d7916e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -199,7 +199,7 @@ do
ry oldest of
non-POSIX-compatible bourne-shells. There are several reasons to always
prefer the $(...) syntax..."
And https://wiki.bash-hackers.org/scripting/obsolete
"Both the |`COMMANDS`| and |$(COMMANDS)| syntaxes are specified by
POSIX, but the latter is _greatly_ preferred, though
88bf27fecf9fb4
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1980
> Reported-by: Zhichao Gao
> Signed-off-by: Laszlo Ersek
Reviewed-by: Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43824): https://edk2.groups.io/g
: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 4fcbdd2bc9..5d3a672bd2 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -40,7 +40,7 @@ ARCH_X64=no
BUILDTARGET=DEBUG
BUILD_OPTIONS=
PLATFORMFILE
quired to build decreases from 3 minutes to 1 minute.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..5d3a672bd2 100755
> --- a
On 2019-07-22 16:16, Laszlo Ersek wrote:
>
> should we push patches #1 through #4 from this series?
>
> They are independent of python detection (which is still being discussed).
I think that's a good idea.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You rec
Thanks, I'll send a v2 patch in a while.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44179): https://edk2.groups.io/g/devel/message/44179
Mute This Topic: https://groups.io/mt/32553200/21656
Group Own
if we should add a "-j" parameter if we
build BaseTools for users (e.g. "make -j4 -C BaseTools")? I've found
that it can be pretty slow without it: on my system adding -j4 reduces
build time from 55 seconds to 15. Going higher doesn't seem to produce
much more benefit: -
Enable multithreaded builds by default when building OvmfPkg
using build.sh.
This can drastically reduce build times. For example, on a
modern ThreadRipper system the time required to build decreases
from 3 minutes to 1 minute.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index e94aa2a37e..1c28e65404 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -174,11 +174,11 @@ case $PROCESSOR in
Running qemu before building the firmware image doesn't make much sense.
Move things so qemu is run after building OvmfPkg.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
Specify the firmware to use via the newer '-drive if=pflash' syntax
which allows specifying the raw format and readonly parameters. This
avoids warnings with newer version of QEMU.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The $BUILD_ROOT_ARCH directory has too many files to
work as a fat filesystem. QEMU fails with the message:
Too many entries in root directory
Use the $QEMU_FIRMWARE_DIR as the root directory instead.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1
I tested with QEMU 1.6.2 and it works.
I’ll update the patch to make it read-write.
—
Rebecca Cran
> On Jul 23, 2019, at 8:54 PM, Jordan Justen wrote:
>
>> On 2019-07-23 18:51:00, wrote:
>> Specify the firmware to use via the newer '-drive if=pflash' syntax
&g
n ]];
> Why add $() ?
They're needed when used in a test ([...] or [[...]]) statement. $()
replaces the older `` syntax.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44314): https://edk2.groups.io/g/devel/
wly -
for example RHEL and Debian. But even Debian Jessie has QEMU 2.1
(https://packages.debian.org/jessie/qemu-system).
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44331): https://edk2.groups.io/g/devel/message/4433
ware without a drive, then maybe maybe
> we can just dump ADD_QEMU_HDA.
That sounds good! I did wonder why we were adding it. I'll update the patch.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44332): ht
latile variables across multiple qemu boots.
Oh! I thought the use case for having qemu in build.sh was to run it
against the newly-built firmware. Since that's not the case, just ignore
this patch.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to th
Specify the firmware to use via the newer '-drive if=pflash' syntax
which allows specifying the raw format parameter. This
avoids warnings with newer version of QEMU.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index e94aa2a37e..1c28e65404 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -174,11 +174,11 @@ case $PROCESSOR in
$ADD_QEMU_HDA was added because QEMU used to refuse to run without a
disk. Since newer versions run without any disks, remove it.
Signed-off-by: Rebecca Cran
---
OvmfPkg/build.sh | 14 --
1 file changed, 14 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index
patch, in the v2 series of
OvmfPkg/build.sh changes.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44339): https://edk2.groups.io/g/devel/message/44339
Mute This Topic: https://groups.io/mt/32579615/21656
Group Owner: de
1 - 100 of 1123 matches
Mail list logo