-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Tuesday, January 17, 2023 4:24 PM
To: Feng, Bob C
Cc: devel@edk2.groups.io; Jake Garver ; Gao, Liming
; Chen, Christine
Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build
Thanks
: Tuesday, January 17, 2023 1:05 PM
> To: Jake Garver ; Konstantin Aladyshev
> ; devel@edk2.groups.io
> Cc: Gao, Liming ; Chen, Christine
>
> Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM
> build
>
>
>
> Reviewed-by: Bob Feng
>
devel@edk2.groups.io
Cc: Gao, Liming ; Chen, Christine
Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build
Reviewed-by: Bob Feng mailto:bob.c.f...@intel.com>>
From: Jake Garver mailto:j...@nvidia.com>>
Sent: Wednesday, December 14, 2022 2:48 AM
To
Reviewed-by: Bob Feng
From: Jake Garver
Sent: Wednesday, December 14, 2022 2:48 AM
To: Konstantin Aladyshev ; devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build
Thanks, Konstantin,
I approve this version.
Hello!
Sorry to bother everyone.
It's been over a month. Can we merge this?
Best regards,
Konstantin Aladyshev
On Tue, Dec 13, 2022 at 9:47 PM Jake Garver wrote:
>
> Thanks, Konstantin,
>
> I approve this version.
>
> Thanks,
> Jake
>
> From: Konstantin Aladyshe
Thanks, Konstantin,
I approve this version.
Thanks,
Jake
From: Konstantin Aladyshev
Sent: Tuesday, December 13, 2022 11:22 AM
To: devel@edk2.groups.io
Cc: bob.c.f...@intel.com ; gaolim...@byosoft.com.cn
; yuwei.c...@intel.com ; Jake
Garver ; Konstantin Aladysh
EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
...
PCI_VENDOR_ID = <...>
PCI_DEVICE_ID = <...>
PCI_CLASS_CODE = <...>
PCI_REVISION = <...>
``
