Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-31 Thread Igor Kulchytskyy via groups.io
Hi Abner, See my comments below. From: Chang, Abner Sent: Sunday, October 30, 2022 10:24 PM To: Igor Kulchytskyy ; Nickle Wang ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation [AMD Official

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-30 Thread Chang, Abner via groups.io
s.io>> Cc: Nick Ramirez mailto:nrami...@nvidia.com>> Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation [AMD Official Use Only - General] Does "/redfish/v1" require authentication? I think this solution is ok if

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-30 Thread Igor Kulchytskyy via groups.io
tober 30, 2022 11:33:26 AM To: Nickle Wang ; Igor Kulchytskyy ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation [AMD Official Use Only - General] Does "/redfish/v1” require authenticati

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-30 Thread Chang, Abner via groups.io
Saturday, October 29, 2022 7:29 AM To: Igor Kulchytskyy ; Chang, Abner ; devel@edk2.groups.io Cc: Nick Ramirez Subject: Re: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation Caution: This message originated from an External Source. Use proper c

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-28 Thread Nickle Wang via groups.io
CredentailDxe driver so driver will know if it needs to call credential lib or not. Thanks, Nickle -Original Message- From: Igor Kulchytskyy Sent: Friday, October 28, 2022 9:54 PM To: Chang, Abner ; devel@edk2.groups.io; Nickle Wang Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-28 Thread Igor Kulchytskyy via groups.io
From: Nickle Wang Sent: Friday, October 28, 2022 10:53 AM To: Igor Kulchytskyy ; Chang, Abner ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation Hi Igor, Abner, Thanks for your comments. A quick su

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-28 Thread Nickle Wang via groups.io
lib or not. Thanks, Nickle -Original Message- From: Igor Kulchytskyy Sent: Friday, October 28, 2022 9:54 PM To: Chang, Abner ; devel@edk2.groups.io; Nickle Wang Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI impleme

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-28 Thread Igor Kulchytskyy via groups.io
. Thank you, Igor -Original Message- From: Chang, Abner Sent: Friday, October 28, 2022 3:48 AM To: devel@edk2.groups.io; Igor Kulchytskyy ; nick...@nvidia.com Cc: Nick Ramirez Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation **CAUTION

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-28 Thread Chang, Abner via groups.io
since there is no need to send IPMI > command. > > Thank you, > Igor > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle > Wang via groups.io > Sent: Thursday, October 27, 2022 9:26 AM > To: devel@edk2.groups.io; Igor Kulchytskyy ; >

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-27 Thread Igor Kulchytskyy via groups.io
devel@edk2.groups.io; Igor Kulchytskyy ; abner.ch...@amd.com Cc: Nick Ramirez Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clic

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-27 Thread Nickle Wang via groups.io
2 11:26 PM To: Nickle Wang ; devel@edk2.groups.io; abner.ch...@amd.com Cc: Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation External email: Use caution opening links or attachments Hi Nickle, I would like to discuss that DisableBootstrap

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-26 Thread Igor Kulchytskyy via groups.io
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Thanks for your review comments, Abner

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-25 Thread Nickle Wang via groups.io
interface specification. Regards, Nickle -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Saturday, October 22, 2022 3:01 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Nick Ramirez ; Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH] R

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, please add Igor as reviewer too. My comments is in below, > -Original Message- > From: Nickle Wang > Sent: Thursday, October 20, 2022 10:55 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nick Ramirez > > Subject: [PATCH]

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

2022-10-19 Thread Nickle Wang via groups.io
This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Cc: Abner Chang Cc: Nick Ramirez