Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-23 Thread Ni, Ray
uesday, February 23, 2021 1:44 PM To: devel@edk2.groups.io; Ni, Ray ; Ma, Maurice ; Patrick Rudolph ; Dong, Guo ; Dong, Eric Cc: You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA Ray, BSP's GDT table is setup in CpuDxe and then MpInitLib re-uses

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-23 Thread Ma, Maurice
, Eric Cc: You, Benjamin Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA Maurice, It’s doable  I prefer to accept today’s below 4G limitation to maintain simple implementation. Thanks, Ray From: Ma, Maurice mailto:maurice...@intel.com>> Sent: T

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-23 Thread Ni, Ray
, Benjamin Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA Could we decouple BSP and AP GDT in early waking up stage ? For example, AP uses temporary GDT (below 4GB) just for mode switching. Once AP is in the final stage, AP can reload GDT to match BSP

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Ma, Maurice
Sent: Monday, February 22, 2021 21:22 To: devel@edk2.groups.io; fanjianf...@byosoft.com.cn; Ma, Maurice ; Patrick Rudolph ; Dong, Guo ; Dong, Eric Cc: You, Benjamin Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA “But we could allocate room under 4G

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Jeff Fan
c CC: You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA “But we could allocate room under 4G for GDT table directly in CpuDxe.” The GDT pre-allocated is re-used by AP. Why do you suggest CpuDxe allocate GDT? Thanks, Ray From: devel@edk2.

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Ni, Ray
, Maurice ; Patrick Rudolph ; Dong, Guo ; Dong, Eric Cc: devel@edk2.groups.io; You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA Ray, Yes. You are right. Acutally, x64 IDT table cannot work correctly on protected mode. :-) But for GDT

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Jeff Fan
Date: 2021-02-23 10:52 To: fanjianf...@byosoft.com.cn; devel; Ma, Maurice; Patrick Rudolph; Dong, Guo; Dong, Eric CC: devel@edk2.groups.io; You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA Jeff, You are right that BSP’s GDT and IDT tables

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Ni, Ray
.groups.io; You, Benjamin Subject: Re: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA we will save the current BSP's GDT and IDT for APs at first time APs are waken by BSP as below. APs will start from real mode to protected mode and then to long mode. During

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread fanjianf...@byosoft.com.cn
021-02-23 00:49 To: Patrick Rudolph; Dong, Guo; Dong, Eric; Ni, Ray CC: devel@edk2.groups.io; You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA Hi, Ray and Eric, Is there any reason why the GDT base was typecast to UINT32 in CpuDxe driver ?

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Guo Dong
Ma, Maurice ; Dong, Eric ; > Ni, Ray ; devel@edk2.groups.io; You, Benjamin > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > 4GB memory WA > > Hi Guo, > I tested it and it works fine with your patch. The crash is gone. > > BTW: Are there are ot

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Patrick Rudolph
g, Eric ; Ni, Ray > > > > Cc: devel@edk2.groups.io; You, Benjamin > > Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > > 4GB memory WA > > > > Hi, Ray and Eric, > > > > Is there any reason why the GDT base was typecast to UIN

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Guo Dong
gt; To: Dong, Guo > > Cc: devel@edk2.groups.io; Ma, Maurice ; You, > > Benjamin > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: > > Remove 4GB memory WA > > > > Hi Guo, > > I tested on 078400ee15e7b250e4dfafd840c2e0c19835e16b and run

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Ma, Maurice
; Thanks Maurice > -Original Message- > From: Patrick Rudolph > Sent: Monday, February 22, 2021 7:43 > To: Dong, Guo > Cc: devel@edk2.groups.io; Ma, Maurice ; You, > Benjamin > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: > Remove 4GB memory WA

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Patrick Rudolph
Ma, Maurice > > Cc: Dong, Guo ; You, Benjamin > > > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > > 4GB memory WA > > > > This patch breaks booting on master. > > In CpuDxe.efi / InitGlobalDescriptorTable as the GDT poi

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Guo Dong
jamin > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > 4GB memory WA > > This patch breaks booting on master. > In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is casted > to 32bits. > > Regards, > Patrick > &

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Patrick Rudolph
> > From: Dong, Guo > > Sent: Sunday, February 14, 2021 21:13 > > To: devel@edk2.groups.io > > Cc: Ma, Maurice ; You, Benjamin > > > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > > 4GB memory WA > > > > Previous i

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Dong, Guo > Sent: Sunday, February 14, 2021 21:13 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > 4GB

[edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-14 Thread Guo Dong
Previous it would hang in CpuDxe if DXE drivers are dispatched above 4GB. Now remove the work around since the fixed in CpuDxe are merged. Signed-off-by: Guo Dong --- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 5 - 1 file changed, 5 deletions(-) diff --git