Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-06 Thread Rebecca Cran
On 9/6/22 11:53, Ard Biesheuvel wrote: On Tue, 6 Sept 2022 at 19:01, Rebecca Cran wrote: My only concern is about the call in MpServicesTest: WriteBackDataCacheRange ((VOID *)&ApFunction, 32); Obviously the '32' is a magic number and should be something based on the size of ApFunction. But I

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-06 Thread Ard Biesheuvel
On Tue, 6 Sept 2022 at 19:01, Rebecca Cran wrote: > > On 9/5/22 09:55, Ard Biesheuvel wrote: > > I think you've got things covered: I suggested RPi4 because it uses > > A72, and I seem to remember the issues I observed were either on A57 > > or A72 (which are quite similar). But between Juno and H

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-06 Thread Rebecca Cran
On 9/5/22 09:55, Ard Biesheuvel wrote: I think you've got things covered: I suggested RPi4 because it uses A72, and I seem to remember the issues I observed were either on A57 or A72 (which are quite similar). But between Juno and HoneyComb, I don't think the RPi4 data point is that useful. My

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-06 Thread Ard Biesheuvel
On Mon, 5 Sept 2022 at 17:55, Ard Biesheuvel wrote: > > On Mon, 5 Sept 2022 at 17:52, Rebecca Cran wrote: > > > > On 9/5/22 04:57, Ard Biesheuvel wrote: > > > > > > IIRC, there were some issues with this code on bare metal. Which > > > hardware did you use to test it? Any chance you could try it

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-05 Thread Ard Biesheuvel
On Mon, 5 Sept 2022 at 17:52, Rebecca Cran wrote: > > On 9/5/22 04:57, Ard Biesheuvel wrote: > > > > IIRC, there were some issues with this code on bare metal. Which > > hardware did you use to test it? Any chance you could try it on a > > RPi4? > > Yes, there were. I've run this code on an Arm Ju

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-05 Thread Rebecca Cran
On 9/5/22 04:57, Ard Biesheuvel wrote: IIRC, there were some issues with this code on bare metal. Which hardware did you use to test it? Any chance you could try it on a RPi4? Yes, there were. I've run this code on an Arm Juno R2, Synquacer Developer Box and SolidRun HoneyComb. I do have an R

Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-09-05 Thread Ard Biesheuvel
On Mon, 29 Aug 2022 at 18:00, Rebecca Cran wrote: > > This is the rework of the patches I sent out in late 2021, > building on fixes done by Ard at > https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor. > > The most significant changes are the addition of code to enable > the

[edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2022-08-29 Thread Rebecca Cran
This is the rework of the patches I sent out in late 2021, building on fixes done by Ard at https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor. The most significant changes are the addition of code to enable the MMU and caches on the APs, and changing MpServicesTest to use co